Mir

Code review comment for lp:~raof/mir/privatise-all-the-things

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Interesting approach. Not a complete review but:

1607 +#include <iostream>

Not needed

~~~~

3961 -#ifdef ANDROID
3962 #include "mir_test_doubles/mock_android_hw.h"
3963 -#include "src/client/android/client_platform_factory.h"

Causes FTBFS for me on desktop:

include/test/mir_test_doubles/mock_android_alloc_device.h:26:30: fatal error: hardware/gralloc.h: No such file or directory
 #include <hardware/gralloc.h>
                              ^
compilation terminated.

review: Needs Fixing

« Back to merge proposal