Looks good.
Nits:
35 +public: 36 + PlatformProbeReport() = default; 37 + virtual ~PlatformProbeReport() = default; 38 + 39 + PlatformProbeReport(PlatformProbeReport const&) = delete; 40 + PlatformProbeReport& operator=(PlatformProbeReport const&) = delete;
For abstract base classes, we usually make the constructor and and deleted CopyAssign ops protected (not that it matters functionally).
371 + 452 + 530 + 531 +
Unnecessary blank lines.
« Back to merge proposal
Looks good.
Nits:
35 +public: port() = default; eport() = default; port(PlatformPr obeReport const&) = delete; port& operator= (PlatformProbeR eport const&) = delete;
36 + PlatformProbeRe
37 + virtual ~PlatformProbeR
38 +
39 + PlatformProbeRe
40 + PlatformProbeRe
For abstract base classes, we usually make the constructor and and deleted CopyAssign ops protected (not that it matters functionally).
371 +
452 +
530 +
531 +
Unnecessary blank lines.