Mir

Code review comment for lp:~raof/mir/pkgconfig-harder

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> 9 +Requires.private: protobuf >= 2.4.1
>
> If users need access to protobuf headers should this be ".private"?

On closer examination I think this is actually unwanted. The "public" headers that "#include <google/protobuf/...>" are part of "PrivateProtobuf" - which we are not committing to supporting in the future. The headers are:

1. mir/frontend/message_processor.h
2. mir/frontend/protobuf_message_sender.h
3. mir/frontend/template_protobuf_message_processor.h

"PrivateProtobuf" was exposed as a *temporary* convenience for the Canonical downstreams to prototype adding IPC functions before proposing them to Mir proper (avoiding the need for them to put WIP code upstream). These downstream experiments will depend on protobuf directly.

The headers won't be removed for RTM but it should happen in the foreseeable future.

« Back to merge proposal