Mir

Code review comment for lp:~raof/mir/pkgconfig-harder

  1. pkgconfig-harder
  2. Merge into development-branch
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

10 +Libs: -L@LIBDIR@ -lmirserver

Users also need -lmirplatform -lmircommon - as mentioned in your comments above.

~~~~

9 +Requires.private: protobuf >= 2.4.1

If users need access to protobuf headers should this be ".private"?

~~~~

I'm prepared to accept your views on the rpath - but do check downstream projects before landing it (as they tend to have broken dependency incantations on Mir).

review: Needs Fixing

« Back to merge proposal