Merge lp:~raof/mir/i-hate-using-explicitly-forbidden-names into lp:mir
- i-hate-using-explicitly-forbidden-names
- Merge into development-branch
Status: | Rejected |
---|---|
Rejected by: | Chris Halse Rogers |
Proposed branch: | lp:~raof/mir/i-hate-using-explicitly-forbidden-names |
Merge into: | lp:mir |
Diff against target: |
14680 lines (+1598/-1598) 254 files modified
tests/acceptance-tests/server_configuration_options.cpp (+7/-7) tests/acceptance-tests/server_configuration_wrapping.cpp (+6/-6) tests/acceptance-tests/server_signal_handling.cpp (+4/-4) tests/acceptance-tests/test_client_authorization.cpp (+2/-2) tests/acceptance-tests/test_client_cursor_api.cpp (+5/-5) tests/acceptance-tests/test_client_focus_notification.cpp (+2/-2) tests/acceptance-tests/test_client_header_version.cpp (+2/-2) tests/acceptance-tests/test_client_input.cpp (+11/-11) tests/acceptance-tests/test_client_library.cpp (+15/-15) tests/acceptance-tests/test_client_library_drm.cpp (+1/-1) tests/acceptance-tests/test_client_library_errors.cpp (+9/-9) tests/acceptance-tests/test_client_library_old.cpp (+2/-2) tests/acceptance-tests/test_client_screencast.cpp (+7/-7) tests/acceptance-tests/test_client_surface_events.cpp (+3/-3) tests/acceptance-tests/test_client_surface_swap_buffers.cpp (+1/-1) tests/acceptance-tests/test_client_surface_visibility.cpp (+4/-4) tests/acceptance-tests/test_client_surfaces.cpp (+3/-3) tests/acceptance-tests/test_command_line_handling.cpp (+4/-4) tests/acceptance-tests/test_custom_input_dispatcher.cpp (+3/-3) tests/acceptance-tests/test_debug_api.cpp (+2/-2) tests/acceptance-tests/test_display_configuration.cpp (+7/-7) tests/acceptance-tests/test_focus_selection.cpp (+2/-2) tests/acceptance-tests/test_large_messages.cpp (+1/-1) tests/acceptance-tests/test_nested_mir.cpp (+4/-4) tests/acceptance-tests/test_prompt_session_client_api.cpp (+11/-11) tests/acceptance-tests/test_server_disconnect.cpp (+3/-3) tests/acceptance-tests/test_server_shutdown.cpp (+7/-7) tests/acceptance-tests/test_server_startup.cpp (+2/-2) tests/acceptance-tests/test_server_without_active_outputs.cpp (+1/-1) tests/acceptance-tests/test_shell_control_of_surface_configuration.cpp (+2/-2) tests/acceptance-tests/test_surfaces_with_output_id.cpp (+2/-2) tests/acceptance-tests/test_symbols_required_by_mesa.cpp (+2/-2) tests/acceptance-tests/test_touchspot_visualization.cpp (+2/-2) tests/acceptance-tests/test_unresponsive_client.cpp (+1/-1) tests/integration-tests/client/test_screencast.cpp (+2/-2) tests/integration-tests/compositor/test_buffer_stream.cpp (+8/-8) tests/integration-tests/compositor/test_swapping_swappers.cpp (+2/-2) tests/integration-tests/compositor/test_synchronizer.cpp (+2/-2) tests/integration-tests/frontend/test_session_mediator_report.cpp (+8/-8) tests/integration-tests/graphics/android/test_buffer_integration.cpp (+3/-3) tests/integration-tests/graphics/android/test_client_render.cpp (+4/-4) tests/integration-tests/graphics/android/test_display_integration.cpp (+2/-2) tests/integration-tests/graphics/android/test_internal_client.cpp (+1/-1) tests/integration-tests/graphics/mesa/test_buffer_integration.cpp (+3/-3) tests/integration-tests/input/android/test_android_cursor_listener.cpp (+1/-1) tests/integration-tests/input/android/test_android_input_manager.cpp (+6/-6) tests/integration-tests/input/test_configuring_input_manager.cpp (+1/-1) tests/integration-tests/input/test_nested_input.cpp (+1/-1) tests/integration-tests/session_management.cpp (+2/-2) tests/integration-tests/shell/test_session_lifecycle_event.cpp (+1/-1) tests/integration-tests/surface_composition.cpp (+1/-1) tests/integration-tests/test_client_surface_swap_buffers.cpp (+1/-1) tests/integration-tests/test_display_info.cpp (+1/-1) tests/integration-tests/test_display_server_main_loop_events.cpp (+8/-8) tests/integration-tests/test_drm_auth_magic.cpp (+2/-2) tests/integration-tests/test_error_reporting.cpp (+2/-2) tests/integration-tests/test_exchange_buffer.cpp (+2/-2) tests/integration-tests/test_macros.cpp (+1/-1) tests/integration-tests/test_protobuf.cpp (+4/-4) tests/integration-tests/test_server_client_types.cpp (+1/-1) tests/integration-tests/test_server_shutdown.cpp (+2/-2) tests/integration-tests/test_session.cpp (+1/-1) tests/integration-tests/test_session_manager.cpp (+2/-2) tests/integration-tests/test_stale_frames.cpp (+2/-2) tests/integration-tests/test_surface_first_frame_sync.cpp (+1/-1) tests/integration-tests/test_surface_stack_with_compositor.cpp (+9/-9) tests/integration-tests/test_surfaceloop.cpp (+2/-2) tests/integration-tests/test_swapinterval.cpp (+1/-1) tests/integration-tests/test_test_framework.cpp (+4/-4) tests/performance-tests/test_glmark2-es2-mir.cpp (+1/-1) tests/unit-tests/android_input/input_reader.cpp (+1/-1) tests/unit-tests/android_input/int_set.cpp (+8/-8) tests/unit-tests/android_input/property_map.cpp (+10/-10) tests/unit-tests/android_input/sha1.cpp (+1/-1) tests/unit-tests/android_input/sorted_vector.cpp (+13/-13) tests/unit-tests/android_input/string8.cpp (+2/-2) tests/unit-tests/client/android/test_android_client_platform.cpp (+2/-2) tests/unit-tests/client/android/test_android_native_window.cpp (+25/-25) tests/unit-tests/client/android/test_buffer.cpp (+4/-4) tests/unit-tests/client/android/test_client_surface_interpreter.cpp (+12/-12) tests/unit-tests/client/android/test_gralloc_registrar.cpp (+10/-10) tests/unit-tests/client/input/test_android_input_receiver.cpp (+7/-7) tests/unit-tests/client/input/test_android_input_receiver_thread.cpp (+3/-3) tests/unit-tests/client/input/test_xkb_mapper.cpp (+3/-3) tests/unit-tests/client/mesa/test_client_buffer.cpp (+9/-9) tests/unit-tests/client/mesa/test_client_platform.cpp (+1/-1) tests/unit-tests/client/mesa/test_mesa_native_display_container.cpp (+2/-2) tests/unit-tests/client/mesa/test_native_surface.cpp (+8/-8) tests/unit-tests/client/test_aging_buffer.cpp (+4/-4) tests/unit-tests/client/test_android_client_buffer_factory.cpp (+1/-1) tests/unit-tests/client/test_client.cpp (+2/-2) tests/unit-tests/client/test_client_buffer_depository.cpp (+14/-14) tests/unit-tests/client/test_client_display_conf.cpp (+1/-1) tests/unit-tests/client/test_client_mir_surface.cpp (+16/-16) tests/unit-tests/client/test_client_platform.cpp (+4/-4) tests/unit-tests/client/test_event_distributor.cpp (+4/-4) tests/unit-tests/client/test_mir_connection.cpp (+11/-11) tests/unit-tests/client/test_mir_prompt_session.cpp (+5/-5) tests/unit-tests/client/test_mir_screencast.cpp (+13/-13) tests/unit-tests/client/test_periodic_perf_report.cpp (+3/-3) tests/unit-tests/client/test_wait_handle.cpp (+5/-5) tests/unit-tests/compositor/test_buffer_queue.cpp (+48/-48) tests/unit-tests/compositor/test_buffer_stream.cpp (+37/-37) tests/unit-tests/compositor/test_compositing_screencast.cpp (+8/-8) tests/unit-tests/compositor/test_default_display_buffer_compositor.cpp (+9/-9) tests/unit-tests/compositor/test_gl_renderer.cpp (+5/-5) tests/unit-tests/compositor/test_gl_texture_cache.cpp (+3/-3) tests/unit-tests/compositor/test_multi_threaded_compositor.cpp (+11/-11) tests/unit-tests/compositor/test_occlusion.cpp (+11/-11) tests/unit-tests/compositor/test_screencast_display_buffer.cpp (+7/-7) tests/unit-tests/compositor/test_temporary_buffers.cpp (+8/-8) tests/unit-tests/compositor/test_timeout_frame_dropping_policy.cpp (+7/-7) tests/unit-tests/examples/test_demo_compositor.cpp (+1/-1) tests/unit-tests/examples/test_demo_renderer.cpp (+1/-1) tests/unit-tests/frontend/stress_protobuf_communicator.cpp (+1/-1) tests/unit-tests/frontend/test_basic_connector.cpp (+1/-1) tests/unit-tests/frontend/test_client_buffer_tracker.cpp (+34/-34) tests/unit-tests/frontend/test_event_sender.cpp (+3/-3) tests/unit-tests/frontend/test_protobuf_buffer_packer.cpp (+3/-3) tests/unit-tests/frontend/test_protobuf_message_processor.cpp (+1/-1) tests/unit-tests/frontend/test_protobuf_reports_errors.cpp (+2/-2) tests/unit-tests/frontend/test_protobuf_surface_apis.cpp (+2/-2) tests/unit-tests/frontend/test_published_socket_connector.cpp (+9/-9) tests/unit-tests/frontend/test_resource_cache.cpp (+3/-3) tests/unit-tests/frontend/test_session_mediator.cpp (+24/-24) tests/unit-tests/frontend/test_socket_connection.cpp (+6/-6) tests/unit-tests/frontend/test_unauthorized_display_changer.cpp (+2/-2) tests/unit-tests/geometry/test-dimensions.cpp (+6/-6) tests/unit-tests/geometry/test-displacement.cpp (+3/-3) tests/unit-tests/geometry/test-length.cpp (+6/-6) tests/unit-tests/geometry/test-point.cpp (+2/-2) tests/unit-tests/geometry/test-rectangle.cpp (+8/-8) tests/unit-tests/geometry/test-rectangles.cpp (+7/-7) tests/unit-tests/geometry/test-size.cpp (+1/-1) tests/unit-tests/graphics/android/test_android_alloc_adaptor.cpp (+18/-18) tests/unit-tests/graphics/android/test_android_buffer_allocator.cpp (+4/-4) tests/unit-tests/graphics/android/test_buffer.cpp (+4/-4) tests/unit-tests/graphics/android/test_buffer_tex_bind.cpp (+41/-41) tests/unit-tests/graphics/android/test_device_detection.cpp (+4/-4) tests/unit-tests/graphics/android/test_display.cpp (+8/-8) tests/unit-tests/graphics/android/test_display_buffer.cpp (+19/-19) tests/unit-tests/graphics/android/test_fb_device.cpp (+6/-6) tests/unit-tests/graphics/android/test_fb_simple_swapper.cpp (+10/-10) tests/unit-tests/graphics/android/test_hwc_common_device.cpp (+11/-11) tests/unit-tests/graphics/android/test_hwc_device.cpp (+18/-18) tests/unit-tests/graphics/android/test_hwc_fallback_gl_renderer.cpp (+6/-6) tests/unit-tests/graphics/android/test_hwc_fb_device.cpp (+3/-3) tests/unit-tests/graphics/android/test_hwc_layerlist.cpp (+3/-3) tests/unit-tests/graphics/android/test_hwc_layers.cpp (+8/-8) tests/unit-tests/graphics/android/test_hwc_logger.cpp (+8/-8) tests/unit-tests/graphics/android/test_hwc_wrapper.cpp (+9/-9) tests/unit-tests/graphics/android/test_internal_client.cpp (+2/-2) tests/unit-tests/graphics/android/test_internal_client_interpreter.cpp (+4/-4) tests/unit-tests/graphics/android/test_interpreter_buffer_cache.cpp (+5/-5) tests/unit-tests/graphics/android/test_ipc_operations.cpp (+1/-1) tests/unit-tests/graphics/android/test_native_buffer.cpp (+8/-8) tests/unit-tests/graphics/android/test_output_builder.cpp (+6/-6) tests/unit-tests/graphics/android/test_pixel_format.cpp (+2/-2) tests/unit-tests/graphics/android/test_platform.cpp (+6/-6) tests/unit-tests/graphics/android/test_resource_factory.cpp (+4/-4) tests/unit-tests/graphics/android/test_server_interpreter.cpp (+9/-9) tests/unit-tests/graphics/android/test_sync_fence.cpp (+4/-4) tests/unit-tests/graphics/egl_mock/egl_mock_test.cpp (+2/-2) tests/unit-tests/graphics/mesa/test_anonymous_shm_file.cpp (+3/-3) tests/unit-tests/graphics/mesa/test_buffer_allocator.cpp (+16/-16) tests/unit-tests/graphics/mesa/test_bypass.cpp (+20/-20) tests/unit-tests/graphics/mesa/test_cursor.cpp (+17/-17) tests/unit-tests/graphics/mesa/test_display.cpp (+22/-22) tests/unit-tests/graphics/mesa/test_display_buffer.cpp (+13/-13) tests/unit-tests/graphics/mesa/test_display_configuration.cpp (+5/-5) tests/unit-tests/graphics/mesa/test_display_multi_monitor.cpp (+6/-6) tests/unit-tests/graphics/mesa/test_drm_helper.cpp (+1/-1) tests/unit-tests/graphics/mesa/test_gbm_buffer.cpp (+8/-8) tests/unit-tests/graphics/mesa/test_internal_client.cpp (+2/-2) tests/unit-tests/graphics/mesa/test_internal_native_display.cpp (+1/-1) tests/unit-tests/graphics/mesa/test_internal_native_surface.cpp (+2/-2) tests/unit-tests/graphics/mesa/test_kms_page_flipper.cpp (+9/-9) tests/unit-tests/graphics/mesa/test_linux_virtual_terminal.cpp (+15/-15) tests/unit-tests/graphics/mesa/test_native_platform.cpp (+2/-2) tests/unit-tests/graphics/mesa/test_platform.cpp (+11/-11) tests/unit-tests/graphics/mesa/test_real_kms_output.cpp (+7/-7) tests/unit-tests/graphics/mesa/test_shm_buffer.cpp (+4/-4) tests/unit-tests/graphics/nested/test_nested_display.cpp (+3/-3) tests/unit-tests/graphics/nested/test_nested_display_buffer.cpp (+2/-2) tests/unit-tests/graphics/nested/test_nested_display_configuration.cpp (+7/-7) tests/unit-tests/graphics/nested/test_nested_platform.cpp (+1/-1) tests/unit-tests/graphics/offscreen/test_offscreen_display.cpp (+4/-4) tests/unit-tests/graphics/test_buffer_id.cpp (+1/-1) tests/unit-tests/graphics/test_buffer_properties.cpp (+4/-4) tests/unit-tests/graphics/test_default_display_configuration_policy.cpp (+7/-7) tests/unit-tests/graphics/test_display.cpp (+4/-4) tests/unit-tests/graphics/test_display_configuration.cpp (+19/-19) tests/unit-tests/graphics/test_egl_extensions.cpp (+3/-3) tests/unit-tests/graphics/test_graphics_platform.cpp (+3/-3) tests/unit-tests/graphics/test_overlapping_output_grouping.cpp (+9/-9) tests/unit-tests/graphics/test_pixel_format_utils.cpp (+6/-6) tests/unit-tests/graphics/test_program_factory.cpp (+4/-4) tests/unit-tests/input/android/test_android_communication_package.cpp (+1/-1) tests/unit-tests/input/android/test_android_input_application_handle.cpp (+1/-1) tests/unit-tests/input/android/test_android_input_dispatcher.cpp (+4/-4) tests/unit-tests/input/android/test_android_input_lexicon.cpp (+3/-3) tests/unit-tests/input/android/test_android_input_manager.cpp (+3/-3) tests/unit-tests/input/android/test_android_input_reader_policy.cpp (+1/-1) tests/unit-tests/input/android/test_android_input_registrar.cpp (+3/-3) tests/unit-tests/input/android/test_android_input_sender.cpp (+16/-16) tests/unit-tests/input/android/test_android_input_target_enumerator.cpp (+1/-1) tests/unit-tests/input/android/test_android_input_targeter.cpp (+3/-3) tests/unit-tests/input/android/test_android_input_window_handle.cpp (+1/-1) tests/unit-tests/input/android/test_android_pointer_controller.cpp (+4/-4) tests/unit-tests/input/android/test_event_filter_input_dispatcher_policy.cpp (+2/-2) tests/unit-tests/input/android/test_input_translator.cpp (+13/-13) tests/unit-tests/input/test_cursor_controller.cpp (+8/-8) tests/unit-tests/input/test_display_input_region.cpp (+2/-2) tests/unit-tests/input/test_event_filter_chain.cpp (+4/-4) tests/unit-tests/input/test_touchspot_controller.cpp (+7/-7) tests/unit-tests/input/test_xcursor_loader.cpp (+4/-4) tests/unit-tests/logging/message_processor_report.cpp (+8/-8) tests/unit-tests/logging/test_compositor_report.cpp (+3/-3) tests/unit-tests/logging/test_display_report.cpp (+1/-1) tests/unit-tests/logging/test_legacy_input_report.cpp (+6/-6) tests/unit-tests/options/test_program_option.cpp (+10/-10) tests/unit-tests/scene/test_application_session.cpp (+14/-14) tests/unit-tests/scene/test_basic_surface.cpp (+28/-28) tests/unit-tests/scene/test_broadcasting_session_event_sink.cpp (+3/-3) tests/unit-tests/scene/test_gl_pixel_buffer.cpp (+3/-3) tests/unit-tests/scene/test_global_event_sender.cpp (+1/-1) tests/unit-tests/scene/test_legacy_scene_change_notification.cpp (+6/-6) tests/unit-tests/scene/test_mediating_display_changer.cpp (+14/-14) tests/unit-tests/scene/test_prompt_session_container.cpp (+7/-7) tests/unit-tests/scene/test_prompt_session_manager.cpp (+10/-10) tests/unit-tests/scene/test_rendering_tracker.cpp (+7/-7) tests/unit-tests/scene/test_session_manager.cpp (+5/-5) tests/unit-tests/scene/test_surface.cpp (+22/-22) tests/unit-tests/scene/test_surface_controller.cpp (+4/-4) tests/unit-tests/scene/test_surface_impl.cpp (+11/-11) tests/unit-tests/scene/test_surface_stack.cpp (+27/-27) tests/unit-tests/scene/test_the_session_container_implementation.cpp (+3/-3) tests/unit-tests/scene/test_threaded_snapshot_strategy.cpp (+2/-2) tests/unit-tests/shared_library_test.cpp (+8/-8) tests/unit-tests/shell/test_default_focus_mechanism.cpp (+3/-3) tests/unit-tests/shell/test_default_placement_strategy.cpp (+1/-1) tests/unit-tests/shell/test_graphics_display_layout.cpp (+4/-4) tests/unit-tests/test_asio_main_loop.cpp (+25/-25) tests/unit-tests/test_default_emergency_cleanup.cpp (+3/-3) tests/unit-tests/test_fatal.cpp (+3/-3) tests/unit-tests/test_fd.cpp (+3/-3) tests/unit-tests/test_glib_main_loop.cpp (+34/-34) tests/unit-tests/test_gmock_fixes.cpp (+1/-1) tests/unit-tests/test_raii.cpp (+10/-10) tests/unit-tests/test_recursive_read_write_mutex.cpp (+17/-17) tests/unit-tests/test_thread_name.cpp (+2/-2) tests/unit-tests/test_thread_safe_list.cpp (+4/-4) tests/unit-tests/test_variable_length_array.cpp (+6/-6) tests/unit-tests/thread/test_basic_thread_pool.cpp (+5/-5) |
To merge this branch: | bzr merge lp:~raof/mir/i-hate-using-explicitly-forbidden-names |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Cemil Azizoglu (community) | Abstain | ||
Alan Griffiths | Disapprove | ||
Alexandros Frantzis (community) | Disapprove | ||
Daniel van Vugt | Needs Fixing | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email: mp+242606@code.launchpad.net |
Commit message
Conform to Google Test naming requirements (LP: #1149157)
The Google Test docs explicitly say that you should not name_tests_
sed -i -r '/^TEST(_F)?/ s/_([a-z]+)/\u\1/g
/TEST/ s/, ([a-z]+)/, \u\1/g' ../tests/**/*.cpp
Description of the change
Conform to Google Test naming requirements
The Google Test docs explicitly say that you should not name_tests_
Generated by sed, + manual fixup of EGL_MOCK tests + fixup of DISABLED_
sed -i -r '/^TEST(_F)?/ s/_([a-z]+)/\u\1/g
/^TEST/ s/, ([a-z]+)/, \u\1/g' tests/**/*.cpp
PS Jenkins bot (ps-jenkins) wrote : | # |
Daniel van Vugt (vanvugt) wrote : | # |
Yeah I raised this 1.5 years ago (LP: #1149157) but I think there was some resistance to changing anything in discussions at the time.
Daniel van Vugt (vanvugt) wrote : | # |
I think I approve of the idea, but we might want to time this so as to minimize conflicts. So wait until there are less active reviews...?
Daniel van Vugt (vanvugt) : | # |
- 2095. By Chris Halse Rogers
-
The great un-should-
not-ening. The Google Test docs explicitly say that you should not name_tests_
like_this.
Which, for some reason unknown to me, is our style.For some reason this annoys me everytime I propose a new test.
Change all the snake_case_named tests to CamelCaseNamed tests
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:2095
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
Daniel van Vugt (vanvugt) wrote : | # |
Your script(?) isn't quite catching everything for some reason:
1891 -//TEST_
1892 +//TEST_
Daniel van Vugt (vanvugt) wrote : | # |
Ah, because of the // :)
Alexandros Frantzis (afrantzis) wrote : | # |
We have been aware of these naming rules for some time now, but have chosen to do nothing about it because:
1. names_like_this match our current codebase better
2. [subjective] easier_
3. they don't really cause a problem, read below
The FAQ at [1] offers a strong rationale for not using underscores and at the beginning and end of the test case and test names (may lead to invalid or reserved compiler names), but a much weaker for not using it in the middle (two tests may clash). Since we never use an an underscore in the TestCase name, such clashes are not a concern for us.
There is also some concern that an implementation change may cause problems for our naming scheme, but the chance is low, and we can deal with it when/if it happens. The process can be automated fairly easily (as this branch exhibits), so we are not creating any more work for us if we keep with the current style and need to change in the future.
Alan Griffiths (alan-griffiths) wrote : | # |
It ain't broke - no need to fix
Cemil Azizoglu (cemil-azizoglu) wrote : | # |
Being proactive is good, IMO. But I see the counter argument too.
Chris Halse Rogers (raof) wrote : | # |
Ok, that sounds like a majority. I'll just continue to be annoyed when writing tests :)
Unmerged revisions
- 2095. By Chris Halse Rogers
-
The great un-should-
not-ening. The Google Test docs explicitly say that you should not name_tests_
like_this.
Which, for some reason unknown to me, is our style.For some reason this annoys me everytime I propose a new test.
Change all the snake_case_named tests to CamelCaseNamed tests
Preview Diff
1 | === modified file 'tests/acceptance-tests/server_configuration_options.cpp' |
2 | --- tests/acceptance-tests/server_configuration_options.cpp 2014-11-06 13:26:52 +0000 |
3 | +++ tests/acceptance-tests/server_configuration_options.cpp 2014-11-24 02:31:01 +0000 |
4 | @@ -102,7 +102,7 @@ |
5 | } |
6 | }; |
7 | |
8 | -TEST_F(ServerConfigurationOptions, unknown_command_line_options_are_passed_to_handler) |
9 | +TEST_F(ServerConfigurationOptions, UnknownCommandLineOptionsArePassedToHandler) |
10 | { |
11 | const int argc = 10; |
12 | char const* argv[argc] = { |
13 | @@ -123,7 +123,7 @@ |
14 | server.apply_settings(); |
15 | } |
16 | |
17 | -TEST_F(ServerConfigurationOptions, are_read_from_xdg_config_home) |
18 | +TEST_F(ServerConfigurationOptions, AreReadFromXdgConfigHome) |
19 | { |
20 | create_config_file_in(fake_xdg_config_home); |
21 | |
22 | @@ -135,7 +135,7 @@ |
23 | EXPECT_THAT(options->get(test_config_key, not_found), StrEq(fake_xdg_config_home)); |
24 | } |
25 | |
26 | -TEST_F(ServerConfigurationOptions, are_read_from_home_config_file) |
27 | +TEST_F(ServerConfigurationOptions, AreReadFromHomeConfigFile) |
28 | { |
29 | mkdir(fake_home, 0700); |
30 | create_config_file_in(fake_home_config); |
31 | @@ -151,7 +151,7 @@ |
32 | EXPECT_THAT(options->get(test_config_key, not_found), StrEq(fake_home_config)); |
33 | } |
34 | |
35 | -TEST_F(ServerConfigurationOptions, are_read_from_xdg_config_dir0_config_file) |
36 | +TEST_F(ServerConfigurationOptions, AreReadFromXdgConfigDir0ConfigFile) |
37 | { |
38 | create_config_file_in(fake_xdg_config_dir0); |
39 | |
40 | @@ -163,7 +163,7 @@ |
41 | EXPECT_THAT(options->get(test_config_key, not_found), StrEq(fake_xdg_config_dir0)); |
42 | } |
43 | |
44 | -TEST_F(ServerConfigurationOptions, are_read_from_xdg_config_dir1_config_file) |
45 | +TEST_F(ServerConfigurationOptions, AreReadFromXdgConfigDir1ConfigFile) |
46 | { |
47 | create_config_file_in(fake_xdg_config_dir1); |
48 | |
49 | @@ -175,7 +175,7 @@ |
50 | EXPECT_THAT(options->get(test_config_key, not_found), StrEq(fake_xdg_config_dir1)); |
51 | } |
52 | |
53 | -TEST_F(ServerConfigurationOptions, are_read_from_xdg_config_dir0_before_xdg_config_dir1) |
54 | +TEST_F(ServerConfigurationOptions, AreReadFromXdgConfigDir0BeforeXdgConfigDir1) |
55 | { |
56 | create_config_file_in(fake_xdg_config_dir0); |
57 | create_config_file_in(fake_xdg_config_dir1); |
58 | @@ -188,7 +188,7 @@ |
59 | EXPECT_THAT(options->get(test_config_key, not_found), StrEq(fake_xdg_config_dir0)); |
60 | } |
61 | |
62 | -TEST_F(ServerConfigurationOptions, are_read_from_xdg_config_home_before_xdg_config_dirs) |
63 | +TEST_F(ServerConfigurationOptions, AreReadFromXdgConfigHomeBeforeXdgConfigDirs) |
64 | { |
65 | create_config_file_in(fake_xdg_config_home); |
66 | create_config_file_in(fake_xdg_config_dir0); |
67 | |
68 | === modified file 'tests/acceptance-tests/server_configuration_wrapping.cpp' |
69 | --- tests/acceptance-tests/server_configuration_wrapping.cpp 2014-11-06 03:56:24 +0000 |
70 | +++ tests/acceptance-tests/server_configuration_wrapping.cpp 2014-11-24 02:31:01 +0000 |
71 | @@ -71,14 +71,14 @@ |
72 | }; |
73 | } |
74 | |
75 | -TEST_F(ServerConfigurationWrapping, surface_coordinator_is_of_wrapper_type) |
76 | +TEST_F(ServerConfigurationWrapping, SurfaceCoordinatorIsOfWrapperType) |
77 | { |
78 | auto const my_surface_coordinator = std::dynamic_pointer_cast<MySurfaceCoordinator>(surface_coordinator); |
79 | |
80 | EXPECT_THAT(my_surface_coordinator, Ne(nullptr)); |
81 | } |
82 | |
83 | -TEST_F(ServerConfigurationWrapping, can_override_surface_coordinator_methods) |
84 | +TEST_F(ServerConfigurationWrapping, CanOverrideSurfaceCoordinatorMethods) |
85 | { |
86 | auto const my_surface_coordinator = std::dynamic_pointer_cast<MySurfaceCoordinator>(surface_coordinator); |
87 | |
88 | @@ -86,19 +86,19 @@ |
89 | surface_coordinator->raise({}); |
90 | } |
91 | |
92 | -TEST_F(ServerConfigurationWrapping, returns_same_surface_coordinator_from_cache) |
93 | +TEST_F(ServerConfigurationWrapping, ReturnsSameSurfaceCoordinatorFromCache) |
94 | { |
95 | ASSERT_THAT(server.the_surface_coordinator(), Eq(surface_coordinator)); |
96 | } |
97 | |
98 | -TEST_F(ServerConfigurationWrapping, session_coordinator_is_of_wrapper_type) |
99 | +TEST_F(ServerConfigurationWrapping, SessionCoordinatorIsOfWrapperType) |
100 | { |
101 | auto const my_session_coordinator = std::dynamic_pointer_cast<MySessionCoordinator>(session_coordinator); |
102 | |
103 | EXPECT_THAT(my_session_coordinator, Ne(nullptr)); |
104 | } |
105 | |
106 | -TEST_F(ServerConfigurationWrapping, can_override_session_coordinator_methods) |
107 | +TEST_F(ServerConfigurationWrapping, CanOverrideSessionCoordinatorMethods) |
108 | { |
109 | auto const my_session_coordinator = std::dynamic_pointer_cast<MySessionCoordinator>(session_coordinator); |
110 | |
111 | @@ -106,7 +106,7 @@ |
112 | session_coordinator->focus_next(); |
113 | } |
114 | |
115 | -TEST_F(ServerConfigurationWrapping, returns_same_session_coordinator_from_cache) |
116 | +TEST_F(ServerConfigurationWrapping, ReturnsSameSessionCoordinatorFromCache) |
117 | { |
118 | ASSERT_THAT(server.the_session_coordinator(), Eq(session_coordinator)); |
119 | } |
120 | |
121 | === modified file 'tests/acceptance-tests/server_signal_handling.cpp' |
122 | --- tests/acceptance-tests/server_signal_handling.cpp 2014-11-14 02:41:05 +0000 |
123 | +++ tests/acceptance-tests/server_signal_handling.cpp 2014-11-24 02:31:01 +0000 |
124 | @@ -55,7 +55,7 @@ |
125 | }; |
126 | } |
127 | |
128 | -TEST_F(ServerSignal, terminate_handler_is_called_for_SIGTERM) |
129 | +TEST_F(ServerSignal, TerminateHandlerIsCalledFor_SIGTERM) |
130 | { |
131 | run_in_server([&] |
132 | { |
133 | @@ -65,7 +65,7 @@ |
134 | }); |
135 | } |
136 | |
137 | -TEST_F(ServerSignal, terminate_handler_is_called_for_SIGINT) |
138 | +TEST_F(ServerSignal, TerminateHandlerIsCalledFor_SIGINT) |
139 | { |
140 | run_in_server([&] |
141 | { |
142 | @@ -77,7 +77,7 @@ |
143 | |
144 | struct Abort : ServerSignal, ::testing::WithParamInterface<int> {}; |
145 | |
146 | -TEST_P(Abort, cleanup_handler_is_called_for) |
147 | +TEST_P(Abort, CleanupHandlerIsCalledFor) |
148 | { |
149 | expect_server_signalled(GetParam()); |
150 | |
151 | @@ -89,7 +89,7 @@ |
152 | INSTANTIATE_TEST_CASE_P(ServerSignal, Abort, |
153 | ::testing::Values(SIGQUIT, SIGABRT, SIGFPE, SIGSEGV, SIGBUS)); |
154 | |
155 | -TEST_F(ServerSignal, multiple_cleanup_handlers_are_called) |
156 | +TEST_F(ServerSignal, MultipleCleanupHandlersAreCalled) |
157 | { |
158 | const int multiple = 5; |
159 | expect_server_signalled(SIGABRT); |
160 | |
161 | === modified file 'tests/acceptance-tests/test_client_authorization.cpp' |
162 | --- tests/acceptance-tests/test_client_authorization.cpp 2014-11-03 02:35:50 +0000 |
163 | +++ tests/acceptance-tests/test_client_authorization.cpp 2014-11-24 02:31:01 +0000 |
164 | @@ -96,7 +96,7 @@ |
165 | }; |
166 | } |
167 | |
168 | -TEST_F(ClientCredsTestFixture, session_authorizer_receives_pid_of_connecting_clients) |
169 | +TEST_F(ClientCredsTestFixture, SessionAuthorizerReceivesPidOfConnectingClients) |
170 | { |
171 | auto const matches_creds = [&](mf::SessionCredentials const& creds) |
172 | { |
173 | @@ -143,7 +143,7 @@ |
174 | } |
175 | |
176 | // This test is also a regression test for https://bugs.launchpad.net/mir/+bug/1358191 |
177 | -TEST_F(ClientCredsTestFixture, authorizer_may_prevent_connection_of_clients) |
178 | +TEST_F(ClientCredsTestFixture, AuthorizerMayPreventConnectionOfClients) |
179 | { |
180 | init_server([&] |
181 | { |
182 | |
183 | === modified file 'tests/acceptance-tests/test_client_cursor_api.cpp' |
184 | --- tests/acceptance-tests/test_client_cursor_api.cpp 2014-10-29 06:21:10 +0000 |
185 | +++ tests/acceptance-tests/test_client_cursor_api.cpp 2014-11-24 02:31:01 +0000 |
186 | @@ -272,7 +272,7 @@ |
187 | // In this set we create a 1x1 client surface at the point (1,0). The client requests to disable the cursor |
188 | // over this surface. Since the cursor starts at (0,0) we when we move the cursor by (1,0) thus causing it |
189 | // to enter the bounds of the first surface, we should observe it being disabled. |
190 | -TEST_F(TestClientCursorAPI, client_may_disable_cursor_over_surface) |
191 | +TEST_F(TestClientCursorAPI, ClientMayDisableCursorOverSurface) |
192 | { |
193 | using namespace ::testing; |
194 | |
195 | @@ -292,7 +292,7 @@ |
196 | client_shutdown_expectations(); |
197 | } |
198 | |
199 | -TEST_F(TestClientCursorAPI, cursor_restored_when_leaving_surface) |
200 | +TEST_F(TestClientCursorAPI, CursorRestoredWhenLeavingSurface) |
201 | { |
202 | using namespace ::testing; |
203 | |
204 | @@ -315,7 +315,7 @@ |
205 | client_shutdown_expectations(); |
206 | } |
207 | |
208 | -TEST_F(TestClientCursorAPI, cursor_changed_when_crossing_surface_boundaries) |
209 | +TEST_F(TestClientCursorAPI, CursorChangedWhenCrossingSurfaceBoundaries) |
210 | { |
211 | using namespace ::testing; |
212 | |
213 | @@ -342,7 +342,7 @@ |
214 | client_shutdown_expectations(); |
215 | } |
216 | |
217 | -TEST_F(TestClientCursorAPI, cursor_request_taken_from_top_surface) |
218 | +TEST_F(TestClientCursorAPI, CursorRequestTakenFromTopSurface) |
219 | { |
220 | using namespace ::testing; |
221 | |
222 | @@ -366,7 +366,7 @@ |
223 | client_shutdown_expectations(); |
224 | } |
225 | |
226 | -TEST_F(TestClientCursorAPI, cursor_request_applied_without_cursor_motion) |
227 | +TEST_F(TestClientCursorAPI, CursorRequestAppliedWithoutCursorMotion) |
228 | { |
229 | using namespace ::testing; |
230 | |
231 | |
232 | === modified file 'tests/acceptance-tests/test_client_focus_notification.cpp' |
233 | --- tests/acceptance-tests/test_client_focus_notification.cpp 2014-03-06 06:05:17 +0000 |
234 | +++ tests/acceptance-tests/test_client_focus_notification.cpp 2014-11-24 02:31:01 +0000 |
235 | @@ -107,7 +107,7 @@ |
236 | |
237 | } |
238 | |
239 | -TEST_F(BespokeDisplayServerTestFixture, a_surface_is_notified_of_receiving_focus) |
240 | +TEST_F(BespokeDisplayServerTestFixture, ASurfaceIsNotifiedOfReceivingFocus) |
241 | { |
242 | using namespace ::testing; |
243 | |
244 | @@ -137,7 +137,7 @@ |
245 | |
246 | } |
247 | |
248 | -TEST_F(BespokeDisplayServerTestFixture, two_surfaces_are_notified_of_gaining_and_losing_focus) |
249 | +TEST_F(BespokeDisplayServerTestFixture, TwoSurfacesAreNotifiedOfGainingAndLosingFocus) |
250 | { |
251 | using namespace ::testing; |
252 | |
253 | |
254 | === modified file 'tests/acceptance-tests/test_client_header_version.cpp' |
255 | --- tests/acceptance-tests/test_client_header_version.cpp 2014-11-20 05:43:02 +0000 |
256 | +++ tests/acceptance-tests/test_client_header_version.cpp 2014-11-24 02:31:01 +0000 |
257 | @@ -20,7 +20,7 @@ |
258 | |
259 | #include <gtest/gtest.h> |
260 | |
261 | -TEST(ClientHeaderVersion, mir_client_version_ge_is_sane) |
262 | +TEST(ClientHeaderVersion, MirClientVersionGeIsSane) |
263 | { |
264 | // We have to be greater than 0.0.0 |
265 | EXPECT_TRUE(MIR_CLIENT_VERSION >= MIR_VERSION_NUMBER(0, 0, 0)); |
266 | @@ -42,7 +42,7 @@ |
267 | MIR_CLIENT_MICRO_VERSION + 1)); |
268 | } |
269 | |
270 | -TEST(ClientHeaderVersion, mir_client_version_ge_is_usable_in_preprocessor) |
271 | +TEST(ClientHeaderVersion, MirClientVersionGeIsUsableInPreprocessor) |
272 | { |
273 | #if MIR_CLIENT_VERSION < MIR_VERSION_NUMBER(0, 0, 0) |
274 | FAIL() << "MIR_CLIENT_VERSION < MIR_VERSION_NUMBER(0, 0, 0)"; |
275 | |
276 | === modified file 'tests/acceptance-tests/test_client_input.cpp' |
277 | --- tests/acceptance-tests/test_client_input.cpp 2014-11-12 07:07:06 +0000 |
278 | +++ tests/acceptance-tests/test_client_input.cpp 2014-11-24 02:31:01 +0000 |
279 | @@ -223,7 +223,7 @@ |
280 | |
281 | } |
282 | |
283 | -TEST_F(TestClientInput, clients_receive_key_input) |
284 | +TEST_F(TestClientInput, ClientsReceiveKeyInput) |
285 | { |
286 | using namespace testing; |
287 | |
288 | @@ -243,7 +243,7 @@ |
289 | mis::a_key_down_event().of_scancode(KEY_ENTER)); |
290 | } |
291 | |
292 | -TEST_F(TestClientInput, clients_receive_us_english_mapped_keys) |
293 | +TEST_F(TestClientInput, ClientsReceiveUsEnglishMappedKeys) |
294 | { |
295 | using namespace testing; |
296 | |
297 | @@ -267,7 +267,7 @@ |
298 | mis::a_key_down_event().of_scancode(KEY_4)); |
299 | } |
300 | |
301 | -TEST_F(TestClientInput, clients_receive_motion_inside_window) |
302 | +TEST_F(TestClientInput, ClientsReceiveMotionInsideWindow) |
303 | { |
304 | using namespace testing; |
305 | |
306 | @@ -294,7 +294,7 @@ |
307 | fake_event_hub()->synthesize_event(mis::a_motion_event().with_movement(2,2)); |
308 | } |
309 | |
310 | -TEST_F(TestClientInput, clients_receive_button_events_inside_window) |
311 | +TEST_F(TestClientInput, ClientsReceiveButtonEventsInsideWindow) |
312 | { |
313 | using namespace testing; |
314 | |
315 | @@ -312,7 +312,7 @@ |
316 | .with_action(mis::EventAction::Down)); |
317 | } |
318 | |
319 | -TEST_F(TestClientInput, multiple_clients_receive_motion_inside_windows) |
320 | +TEST_F(TestClientInput, MultipleClientsReceiveMotionInsideWindows) |
321 | { |
322 | using namespace testing; |
323 | |
324 | @@ -359,7 +359,7 @@ |
325 | mis::a_motion_event().with_movement(screen_width / 2, screen_height / 2)); |
326 | } |
327 | |
328 | -TEST_F(TestClientInput, clients_do_not_receive_motion_outside_input_region) |
329 | +TEST_F(TestClientInput, ClientsDoNotReceiveMotionOutsideInputRegion) |
330 | { |
331 | using namespace testing; |
332 | |
333 | @@ -414,7 +414,7 @@ |
334 | fake_event_hub()->synthesize_event(mis::a_button_up_event().of_button(BTN_LEFT)); |
335 | } |
336 | |
337 | -TEST_F(TestClientInput, scene_obscure_motion_events_by_stacking) |
338 | +TEST_F(TestClientInput, SceneObscureMotionEventsByStacking) |
339 | { |
340 | using namespace testing; |
341 | |
342 | @@ -467,7 +467,7 @@ |
343 | fake_event_hub()->synthesize_event(mis::a_button_up_event().of_button(BTN_LEFT)); |
344 | } |
345 | |
346 | -TEST_F(TestClientInput, hidden_clients_do_not_receive_pointer_events) |
347 | +TEST_F(TestClientInput, HiddenClientsDoNotReceivePointerEvents) |
348 | { |
349 | using namespace testing; |
350 | |
351 | @@ -510,7 +510,7 @@ |
352 | fake_event_hub()->synthesize_event(mis::a_motion_event().with_movement(1,1)); |
353 | } |
354 | |
355 | -TEST_F(TestClientInput, clients_receive_motion_within_coordinate_system_of_window) |
356 | +TEST_F(TestClientInput, ClientsReceiveMotionWithinCoordinateSystemOfWindow) |
357 | { |
358 | using namespace testing; |
359 | |
360 | @@ -544,7 +544,7 @@ |
361 | } |
362 | |
363 | // TODO: Consider tests for more input devices with custom mapping (i.e. joysticks...) |
364 | -TEST_F(TestClientInput, usb_direct_input_devices_work) |
365 | +TEST_F(TestClientInput, UsbDirectInputDevicesWork) |
366 | { |
367 | using namespace ::testing; |
368 | |
369 | @@ -595,7 +595,7 @@ |
370 | mis::a_touch_event().at_position({abs_touch_x_2, abs_touch_y_2})); |
371 | } |
372 | |
373 | -TEST_F(TestClientInput, send_mir_input_events_through_surface) |
374 | +TEST_F(TestClientInput, SendMirInputEventsThroughSurface) |
375 | { |
376 | InputClient client1{new_connection(), test_client_name_1}; |
377 | |
378 | |
379 | === modified file 'tests/acceptance-tests/test_client_library.cpp' |
380 | --- tests/acceptance-tests/test_client_library.cpp 2014-11-12 07:07:06 +0000 |
381 | +++ tests/acceptance-tests/test_client_library.cpp 2014-11-24 02:31:01 +0000 |
382 | @@ -150,7 +150,7 @@ |
383 | |
384 | using namespace testing; |
385 | |
386 | -TEST_F(ClientLibrary, client_library_connects_and_disconnects) |
387 | +TEST_F(ClientLibrary, ClientLibraryConnectsAndDisconnects) |
388 | { |
389 | MirWaitHandle* wh = mir_connect(new_connection().c_str(), __PRETTY_FUNCTION__, connection_callback, this); |
390 | EXPECT_THAT(wh, NotNull()); |
391 | @@ -163,7 +163,7 @@ |
392 | mir_connection_release(connection); |
393 | } |
394 | |
395 | -TEST_F(ClientLibrary, synchronous_connection) |
396 | +TEST_F(ClientLibrary, SynchronousConnection) |
397 | { |
398 | connection = mir_connect_sync(new_connection().c_str(), __PRETTY_FUNCTION__); |
399 | |
400 | @@ -174,7 +174,7 @@ |
401 | mir_connection_release(connection); |
402 | } |
403 | |
404 | -TEST_F(ClientLibrary, creates_surface) |
405 | +TEST_F(ClientLibrary, CreatesSurface) |
406 | { |
407 | mir_wait_for(mir_connect(new_connection().c_str(), __PRETTY_FUNCTION__, connection_callback, this)); |
408 | |
409 | @@ -220,7 +220,7 @@ |
410 | mir_connection_release(connection); |
411 | } |
412 | |
413 | -TEST_F(ClientLibrary, can_set_surface_types) |
414 | +TEST_F(ClientLibrary, CanSetSurfaceTypes) |
415 | { |
416 | mir_wait_for(mir_connect(new_connection().c_str(), __PRETTY_FUNCTION__, connection_callback, this)); |
417 | |
418 | @@ -265,7 +265,7 @@ |
419 | mir_connection_release(connection); |
420 | } |
421 | |
422 | -TEST_F(ClientLibrary, can_set_surface_state) |
423 | +TEST_F(ClientLibrary, CanSetSurfaceState) |
424 | { |
425 | connection = mir_connect_sync(new_connection().c_str(), __PRETTY_FUNCTION__); |
426 | |
427 | @@ -307,7 +307,7 @@ |
428 | mir_connection_release(connection); |
429 | } |
430 | |
431 | -TEST_F(ClientLibrary, receives_surface_dpi_value) |
432 | +TEST_F(ClientLibrary, ReceivesSurfaceDpiValue) |
433 | { |
434 | connection = mir_connect_sync(new_connection().c_str(), __PRETTY_FUNCTION__); |
435 | |
436 | @@ -330,7 +330,7 @@ |
437 | } |
438 | |
439 | #ifndef ANDROID |
440 | -TEST_F(ClientLibrary, surface_scanout_flag_toggles) |
441 | +TEST_F(ClientLibrary, SurfaceScanoutFlagToggles) |
442 | { |
443 | connection = mir_connect_sync(new_connection().c_str(), __PRETTY_FUNCTION__); |
444 | |
445 | @@ -388,9 +388,9 @@ |
446 | |
447 | #ifdef ANDROID |
448 | // Mir's Android test infrastructure isn't quite ready for this yet. |
449 | -TEST_F(ClientLibrary, DISABLED_gets_buffer_dimensions) |
450 | +TEST_F(ClientLibrary, DISABLED_GetsBufferDimensions) |
451 | #else |
452 | -TEST_F(ClientLibrary, gets_buffer_dimensions) |
453 | +TEST_F(ClientLibrary, GetsBufferDimensions) |
454 | #endif |
455 | { |
456 | connection = mir_connect_sync(new_connection().c_str(), __PRETTY_FUNCTION__); |
457 | @@ -436,7 +436,7 @@ |
458 | mir_connection_release(connection); |
459 | } |
460 | |
461 | -TEST_F(ClientLibrary, creates_multiple_surfaces) |
462 | +TEST_F(ClientLibrary, CreatesMultipleSurfaces) |
463 | { |
464 | int const n_surfaces = 13; |
465 | size_t old_surface_count = 0; |
466 | @@ -475,7 +475,7 @@ |
467 | mir_connection_release(connection); |
468 | } |
469 | |
470 | -TEST_F(ClientLibrary, client_library_accesses_and_advances_buffers) |
471 | +TEST_F(ClientLibrary, ClientLibraryAccessesAndAdvancesBuffers) |
472 | { |
473 | mir_wait_for(mir_connect(new_connection().c_str(), __PRETTY_FUNCTION__, connection_callback, this)); |
474 | |
475 | @@ -501,7 +501,7 @@ |
476 | mir_connection_release(connection); |
477 | } |
478 | |
479 | -TEST_F(ClientLibrary, fully_synchronous_client) |
480 | +TEST_F(ClientLibrary, FullySynchronousClient) |
481 | { |
482 | connection = mir_connect_sync(new_connection().c_str(), __PRETTY_FUNCTION__); |
483 | |
484 | @@ -527,7 +527,7 @@ |
485 | mir_connection_release(connection); |
486 | } |
487 | |
488 | -TEST_F(ClientLibrary, highly_threaded_client) |
489 | +TEST_F(ClientLibrary, HighlyThreadedClient) |
490 | { |
491 | connection = mir_connect_sync(new_connection().c_str(), __PRETTY_FUNCTION__); |
492 | |
493 | @@ -560,7 +560,7 @@ |
494 | mir_connection_release(connection); |
495 | } |
496 | |
497 | -TEST_F(ClientLibrary, accesses_platform_package) |
498 | +TEST_F(ClientLibrary, AccessesPlatformPackage) |
499 | { |
500 | mir_wait_for(mir_connect(new_connection().c_str(), __PRETTY_FUNCTION__, connection_callback, this)); |
501 | |
502 | @@ -575,7 +575,7 @@ |
503 | mir_connection_release(connection); |
504 | } |
505 | |
506 | -TEST_F(ClientLibrary, accesses_display_info) |
507 | +TEST_F(ClientLibrary, AccessesDisplayInfo) |
508 | { |
509 | mir_wait_for(mir_connect(new_connection().c_str(), __PRETTY_FUNCTION__, connection_callback, this)); |
510 | |
511 | |
512 | === modified file 'tests/acceptance-tests/test_client_library_drm.cpp' |
513 | --- tests/acceptance-tests/test_client_library_drm.cpp 2014-11-21 12:16:36 +0000 |
514 | +++ tests/acceptance-tests/test_client_library_drm.cpp 2014-11-24 02:31:01 +0000 |
515 | @@ -28,7 +28,7 @@ |
516 | |
517 | using MirClientLibraryDrmTest = mtf::ConnectedClientHeadlessServer; |
518 | |
519 | -TEST_F(MirClientLibraryDrmTest, sets_gbm_device_in_platform_data) |
520 | +TEST_F(MirClientLibraryDrmTest, SetsGbmDeviceInPlatformData) |
521 | { |
522 | struct gbm_device* dev = reinterpret_cast<struct gbm_device*>(connection); |
523 | |
524 | |
525 | === modified file 'tests/acceptance-tests/test_client_library_errors.cpp' |
526 | --- tests/acceptance-tests/test_client_library_errors.cpp 2014-11-18 16:44:19 +0000 |
527 | +++ tests/acceptance-tests/test_client_library_errors.cpp 2014-11-24 02:31:01 +0000 |
528 | @@ -135,7 +135,7 @@ |
529 | |
530 | using ClientLibraryErrors = mtf::HeadlessInProcessServer; |
531 | |
532 | -TEST_F(ClientLibraryErrors, exception_in_client_configuration_constructor_generates_error) |
533 | +TEST_F(ClientLibraryErrors, ExceptionInClientConfigurationConstructorGeneratesError) |
534 | { |
535 | mtf::UsingClientPlatform<ConfigurableFailureConfiguration<Method::the_client_platform_factory>> stubby; |
536 | |
537 | @@ -146,7 +146,7 @@ |
538 | mir_connection_release(connection); |
539 | } |
540 | |
541 | -TEST_F(ClientLibraryErrors, exception_in_platform_construction_generates_error) |
542 | +TEST_F(ClientLibraryErrors, ExceptionInPlatformConstructionGeneratesError) |
543 | { |
544 | mtf::UsingClientPlatform<ConfigurableFailureConfiguration<Method::create_client_platform>> stubby; |
545 | |
546 | @@ -157,7 +157,7 @@ |
547 | mir_connection_release(connection); |
548 | } |
549 | |
550 | -TEST_F(ClientLibraryErrors, connecting_to_garbage_socket_returns_appropriate_error) |
551 | +TEST_F(ClientLibraryErrors, ConnectingToGarbageSocketReturnsAppropriateError) |
552 | { |
553 | using namespace testing; |
554 | mtf::UsingStubClientPlatform stubby; |
555 | @@ -176,7 +176,7 @@ |
556 | mir_connection_release(connection); |
557 | } |
558 | |
559 | -TEST_F(ClientLibraryErrors, create_surface_returns_error_object_on_failure) |
560 | +TEST_F(ClientLibraryErrors, CreateSurfaceReturnsErrorObjectOnFailure) |
561 | { |
562 | mtf::UsingClientPlatform<ConfigurableFailureConfiguration<Method::create_buffer_factory>> stubby; |
563 | |
564 | @@ -211,7 +211,7 @@ |
565 | } |
566 | } |
567 | |
568 | -TEST_F(ClientLibraryErrors, surface_release_on_error_object_still_calls_callback) |
569 | +TEST_F(ClientLibraryErrors, SurfaceReleaseOnErrorObjectStillCallsCallback) |
570 | { |
571 | mtf::UsingClientPlatform<ConfigurableFailureConfiguration<Method::create_buffer_factory>> stubby; |
572 | |
573 | @@ -240,7 +240,7 @@ |
574 | } |
575 | |
576 | |
577 | -TEST_F(ClientLibraryErrors, create_surface_returns_error_object_on_failure_in_reply_processing) |
578 | +TEST_F(ClientLibraryErrors, CreateSurfaceReturnsErrorObjectOnFailureInReplyProcessing) |
579 | { |
580 | mtf::UsingClientPlatform<ConfigurableFailureConfiguration<Method::create_egl_native_window>> stubby; |
581 | |
582 | @@ -269,7 +269,7 @@ |
583 | using ClientLibraryErrorsDeathTest = ClientLibraryErrors; |
584 | |
585 | |
586 | -TEST_F(ClientLibraryErrorsDeathTest, createing_surface_on_garbage_connection_is_fatal) |
587 | +TEST_F(ClientLibraryErrorsDeathTest, CreateingSurfaceOnGarbageConnectionIsFatal) |
588 | { |
589 | mtf::UsingStubClientPlatform stubby; |
590 | |
591 | @@ -289,7 +289,7 @@ |
592 | } |
593 | |
594 | |
595 | -TEST_F(ClientLibraryErrorsDeathTest, creating_surface_synchronosly_on_malconstructed_connection_is_fatal) |
596 | +TEST_F(ClientLibraryErrorsDeathTest, CreatingSurfaceSynchronoslyOnMalconstructedConnectionIsFatal) |
597 | { |
598 | MirSurfaceParameters const request_params = |
599 | { |
600 | @@ -308,7 +308,7 @@ |
601 | EXPECT_DEATH(mir_connection_create_surface_sync(connection, &request_params), ""); |
602 | } |
603 | |
604 | -TEST_F(ClientLibraryErrorsDeathTest, creating_surface_synchronosly_on_invalid_connection_is_fatal) |
605 | +TEST_F(ClientLibraryErrorsDeathTest, CreatingSurfaceSynchronoslyOnInvalidConnectionIsFatal) |
606 | { |
607 | MirSurfaceParameters const request_params = |
608 | { |
609 | |
610 | === modified file 'tests/acceptance-tests/test_client_library_old.cpp' |
611 | --- tests/acceptance-tests/test_client_library_old.cpp 2014-11-21 12:16:36 +0000 |
612 | +++ tests/acceptance-tests/test_client_library_old.cpp 2014-11-24 02:31:01 +0000 |
613 | @@ -45,7 +45,7 @@ |
614 | } |
615 | }; |
616 | |
617 | -TEST_F(ClientLibraryThread, handles_no_signals) |
618 | +TEST_F(ClientLibraryThread, HandlesNoSignals) |
619 | { |
620 | run_in_client([&] |
621 | { |
622 | @@ -88,7 +88,7 @@ |
623 | }); |
624 | } |
625 | |
626 | -TEST_F(ClientLibraryThread, does_not_interfere_with_client_signal_handling) |
627 | +TEST_F(ClientLibraryThread, DoesNotInterfereWithClientSignalHandling) |
628 | { |
629 | run_in_client([&] |
630 | { |
631 | |
632 | === modified file 'tests/acceptance-tests/test_client_screencast.cpp' |
633 | --- tests/acceptance-tests/test_client_screencast.cpp 2014-10-29 06:21:10 +0000 |
634 | +++ tests/acceptance-tests/test_client_screencast.cpp 2014-11-24 02:31:01 +0000 |
635 | @@ -93,7 +93,7 @@ |
636 | |
637 | } |
638 | |
639 | -TEST_F(MirScreencastTest, creation_with_invalid_connection_fails) |
640 | +TEST_F(MirScreencastTest, CreationWithInvalidConnectionFails) |
641 | { |
642 | using namespace testing; |
643 | |
644 | @@ -101,7 +101,7 @@ |
645 | ASSERT_EQ(nullptr, screencast); |
646 | } |
647 | |
648 | -TEST_F(MirScreencastTest, contacts_server_screencast_for_create_and_release) |
649 | +TEST_F(MirScreencastTest, ContactsServerScreencastForCreateAndRelease) |
650 | { |
651 | using namespace testing; |
652 | |
653 | @@ -123,7 +123,7 @@ |
654 | mir_screencast_release_sync(screencast); |
655 | } |
656 | |
657 | -TEST_F(MirScreencastTest, contacts_server_screencast_with_provided_params) |
658 | +TEST_F(MirScreencastTest, ContactsServerScreencastWithProvidedParams) |
659 | { |
660 | using namespace testing; |
661 | |
662 | @@ -152,7 +152,7 @@ |
663 | mir_screencast_release_sync(screencast); |
664 | } |
665 | |
666 | -TEST_F(MirScreencastTest, creation_with_invalid_params_fails) |
667 | +TEST_F(MirScreencastTest, CreationWithInvalidParamsFails) |
668 | { |
669 | using namespace testing; |
670 | |
671 | @@ -173,7 +173,7 @@ |
672 | ASSERT_EQ(nullptr, screencast); |
673 | } |
674 | |
675 | -TEST_F(MirScreencastTest, gets_valid_egl_native_window) |
676 | +TEST_F(MirScreencastTest, GetsValidEglNativeWindow) |
677 | { |
678 | using namespace testing; |
679 | |
680 | @@ -195,7 +195,7 @@ |
681 | mir_screencast_release_sync(screencast); |
682 | } |
683 | |
684 | -TEST_F(MirScreencastTest, fails_on_client_when_server_request_fails) |
685 | +TEST_F(MirScreencastTest, FailsOnClientWhenServerRequestFails) |
686 | { |
687 | using namespace testing; |
688 | |
689 | @@ -234,7 +234,7 @@ |
690 | |
691 | } |
692 | |
693 | -TEST_F(UnauthorizedMirScreencastTest, fails_to_create_screencast) |
694 | +TEST_F(UnauthorizedMirScreencastTest, FailsToCreateScreencast) |
695 | { |
696 | using namespace testing; |
697 | |
698 | |
699 | === modified file 'tests/acceptance-tests/test_client_surface_events.cpp' |
700 | --- tests/acceptance-tests/test_client_surface_events.cpp 2014-11-21 12:16:36 +0000 |
701 | +++ tests/acceptance-tests/test_client_surface_events.cpp 2014-11-24 02:31:01 +0000 |
702 | @@ -156,7 +156,7 @@ |
703 | }; |
704 | } |
705 | |
706 | -TEST_F(ClientSurfaceEvents, surface_receives_state_events) |
707 | +TEST_F(ClientSurfaceEvents, SurfaceReceivesStateEvents) |
708 | { |
709 | int surface_id = mir_debug_surface_id(surface); |
710 | |
711 | @@ -217,7 +217,7 @@ |
712 | |
713 | struct OrientationEvents : ClientSurfaceEvents, ::testing::WithParamInterface<MirOrientation> {}; |
714 | |
715 | -TEST_P(OrientationEvents, surface_receives_orientation_events) |
716 | +TEST_P(OrientationEvents, SurfaceReceivesOrientationEvents) |
717 | { |
718 | set_event_filter(mir_event_type_orientation); |
719 | |
720 | @@ -238,7 +238,7 @@ |
721 | OrientationEvents, |
722 | Values(mir_orientation_normal, mir_orientation_left, mir_orientation_inverted, mir_orientation_right)); |
723 | |
724 | -TEST_F(ClientSurfaceEvents, client_can_query_current_orientation) |
725 | +TEST_F(ClientSurfaceEvents, ClientCanQueryCurrentOrientation) |
726 | { |
727 | set_event_filter(mir_event_type_orientation); |
728 | |
729 | |
730 | === modified file 'tests/acceptance-tests/test_client_surface_swap_buffers.cpp' |
731 | --- tests/acceptance-tests/test_client_surface_swap_buffers.cpp 2014-11-18 16:15:00 +0000 |
732 | +++ tests/acceptance-tests/test_client_surface_swap_buffers.cpp 2014-11-24 02:31:01 +0000 |
733 | @@ -52,7 +52,7 @@ |
734 | }; |
735 | } |
736 | |
737 | -TEST_F(SurfaceSwapBuffers, does_not_block_when_surface_is_not_composited) |
738 | +TEST_F(SurfaceSwapBuffers, DoesNotBlockWhenSurfaceIsNotComposited) |
739 | { |
740 | for (int i = 0; i != 10; ++i) |
741 | { |
742 | |
743 | === modified file 'tests/acceptance-tests/test_client_surface_visibility.cpp' |
744 | --- tests/acceptance-tests/test_client_surface_visibility.cpp 2014-10-29 06:21:10 +0000 |
745 | +++ tests/acceptance-tests/test_client_surface_visibility.cpp 2014-11-24 02:31:01 +0000 |
746 | @@ -312,14 +312,14 @@ |
747 | |
748 | } |
749 | |
750 | -TEST_F(MirSurfaceVisibilityEvent, occluded_received_when_surface_goes_off_screen) |
751 | +TEST_F(MirSurfaceVisibilityEvent, OccludedReceivedWhenSurfaceGoesOffScreen) |
752 | { |
753 | expect_surface_visibility_event_after( |
754 | mir_surface_visibility_occluded, |
755 | [this] { move_surface_off_screen(); }); |
756 | } |
757 | |
758 | -TEST_F(MirSurfaceVisibilityEvent, exposed_received_when_surface_reenters_screen) |
759 | +TEST_F(MirSurfaceVisibilityEvent, ExposedReceivedWhenSurfaceReentersScreen) |
760 | { |
761 | expect_surface_visibility_event_after( |
762 | mir_surface_visibility_occluded, |
763 | @@ -330,14 +330,14 @@ |
764 | [this] { move_surface_into_screen(); }); |
765 | } |
766 | |
767 | -TEST_F(MirSurfaceVisibilityEvent, occluded_received_when_surface_occluded_by_other_surface) |
768 | +TEST_F(MirSurfaceVisibilityEvent, OccludedReceivedWhenSurfaceOccludedByOtherSurface) |
769 | { |
770 | expect_surface_visibility_event_after( |
771 | mir_surface_visibility_occluded, |
772 | [this] { create_larger_surface_on_top(); }); |
773 | } |
774 | |
775 | -TEST_F(MirSurfaceVisibilityEvent, exposed_received_when_surface_raised_over_occluding_surface) |
776 | +TEST_F(MirSurfaceVisibilityEvent, ExposedReceivedWhenSurfaceRaisedOverOccludingSurface) |
777 | { |
778 | expect_surface_visibility_event_after( |
779 | mir_surface_visibility_occluded, |
780 | |
781 | === modified file 'tests/acceptance-tests/test_client_surfaces.cpp' |
782 | --- tests/acceptance-tests/test_client_surfaces.cpp 2014-10-29 06:21:10 +0000 |
783 | +++ tests/acceptance-tests/test_client_surfaces.cpp 2014-11-24 02:31:01 +0000 |
784 | @@ -104,7 +104,7 @@ |
785 | } |
786 | } |
787 | |
788 | -TEST_F(ClientSurfaces, are_created_with_correct_size) |
789 | +TEST_F(ClientSurfaces, AreCreatedWithCorrectSize) |
790 | { |
791 | mir_connection_create_surface(connection, &surface_params, create_surface_callback, ssync); |
792 | wait_for_surface_create(ssync); |
793 | @@ -135,7 +135,7 @@ |
794 | wait_for_surface_release(ssync); |
795 | } |
796 | |
797 | -TEST_F(ClientSurfaces, have_distinct_ids) |
798 | +TEST_F(ClientSurfaces, HaveDistinctIds) |
799 | { |
800 | mir_connection_create_surface(connection, &surface_params, create_surface_callback, ssync); |
801 | wait_for_surface_create(ssync); |
802 | @@ -157,7 +157,7 @@ |
803 | wait_for_surface_release(ssync); |
804 | } |
805 | |
806 | -TEST_F(ClientSurfaces, creates_need_not_be_serialized) |
807 | +TEST_F(ClientSurfaces, CreatesNeedNotBeSerialized) |
808 | { |
809 | for (int i = 0; i != max_surface_count; ++i) |
810 | mir_connection_create_surface(connection, &surface_params, create_surface_callback, ssync+i); |
811 | |
812 | === modified file 'tests/acceptance-tests/test_command_line_handling.cpp' |
813 | --- tests/acceptance-tests/test_command_line_handling.cpp 2014-11-21 12:16:36 +0000 |
814 | +++ tests/acceptance-tests/test_command_line_handling.cpp 2014-11-24 02:31:01 +0000 |
815 | @@ -36,7 +36,7 @@ |
816 | }; |
817 | }; |
818 | |
819 | -TEST_F(CommandLineHandling, valid_options_are_accepted_by_default_callback) |
820 | +TEST_F(CommandLineHandling, ValidOptionsAreAcceptedByDefaultCallback) |
821 | { |
822 | char const* argv[] = |
823 | { "dummy-exe-name", "--file", "test", "--enable-input", "off"}; |
824 | @@ -48,7 +48,7 @@ |
825 | server.apply_settings(); |
826 | } |
827 | |
828 | -TEST_F(CommandLineHandling, unrecognised_tokens_cause_default_callback_to_throw) |
829 | +TEST_F(CommandLineHandling, UnrecognisedTokensCauseDefaultCallbackToThrow) |
830 | { |
831 | char const* argv[] = |
832 | { "dummy-exe-name", "--file", "test", "--hello", "world", "--enable-input", "off"}; |
833 | @@ -60,7 +60,7 @@ |
834 | EXPECT_THROW(server.apply_settings(), std::runtime_error); |
835 | } |
836 | |
837 | -TEST_F(CommandLineHandling, valid_options_are_not_passed_to_callback) |
838 | +TEST_F(CommandLineHandling, ValidOptionsAreNotPassedToCallback) |
839 | { |
840 | char const* argv[] = |
841 | { "dummy-exe-name", "--file", "test", "--enable-input", "off"}; |
842 | @@ -75,7 +75,7 @@ |
843 | server.apply_settings(); |
844 | } |
845 | |
846 | -TEST_F(CommandLineHandling, unrecognised_tokens_are_passed_to_callback) |
847 | +TEST_F(CommandLineHandling, UnrecognisedTokensArePassedToCallback) |
848 | { |
849 | char const* argv[] = |
850 | { "dummy-exe-name", "--file", "test", "--hello", "world", "--enable-input", "off"}; |
851 | |
852 | === modified file 'tests/acceptance-tests/test_custom_input_dispatcher.cpp' |
853 | --- tests/acceptance-tests/test_custom_input_dispatcher.cpp 2014-10-29 06:21:10 +0000 |
854 | +++ tests/acceptance-tests/test_custom_input_dispatcher.cpp 2014-11-24 02:31:01 +0000 |
855 | @@ -104,7 +104,7 @@ |
856 | |
857 | using CustomInputDispatcher = BespokeDisplayServerTestFixture; |
858 | |
859 | -TEST_F(CustomInputDispatcher, receives_input) |
860 | +TEST_F(CustomInputDispatcher, ReceivesInput) |
861 | { |
862 | struct ServerConfig : CustomDispatcherServerConfig |
863 | { |
864 | @@ -137,7 +137,7 @@ |
865 | }); |
866 | } |
867 | |
868 | -TEST_F(CustomInputDispatcher, gets_started_and_stopped) |
869 | +TEST_F(CustomInputDispatcher, GetsStartedAndStopped) |
870 | { |
871 | struct ServerConfig : CustomDispatcherServerConfig |
872 | { |
873 | @@ -155,7 +155,7 @@ |
874 | launch_server_process(server_config); |
875 | } |
876 | |
877 | -TEST_F(CustomInputDispatcher, receives_focus_changes) |
878 | +TEST_F(CustomInputDispatcher, ReceivesFocusChanges) |
879 | { |
880 | struct ServerConfig : CustomDispatcherServerConfig |
881 | { |
882 | |
883 | === modified file 'tests/acceptance-tests/test_debug_api.cpp' |
884 | --- tests/acceptance-tests/test_debug_api.cpp 2014-11-20 11:30:38 +0000 |
885 | +++ tests/acceptance-tests/test_debug_api.cpp 2014-11-24 02:31:01 +0000 |
886 | @@ -119,7 +119,7 @@ |
887 | }; |
888 | } |
889 | |
890 | -TEST_F(DebugAPI, translates_surface_coordinates_to_screen_coordinates) |
891 | +TEST_F(DebugAPI, TranslatesSurfaceCoordinatesToScreenCoordinates) |
892 | { |
893 | start_server_with_debug(true); |
894 | |
895 | @@ -153,7 +153,7 @@ |
896 | mir_surface_release_sync(surf); |
897 | } |
898 | |
899 | -TEST_F(DebugAPI, is_unavaliable_when_server_not_started_with_debug) |
900 | +TEST_F(DebugAPI, IsUnavaliableWhenServerNotStartedWithDebug) |
901 | { |
902 | start_server_with_debug(false); |
903 | |
904 | |
905 | === modified file 'tests/acceptance-tests/test_display_configuration.cpp' |
906 | --- tests/acceptance-tests/test_display_configuration.cpp 2014-10-29 06:21:10 +0000 |
907 | +++ tests/acceptance-tests/test_display_configuration.cpp 2014-11-24 02:31:01 +0000 |
908 | @@ -170,7 +170,7 @@ |
909 | |
910 | using DisplayConfigurationTest = BespokeDisplayServerTestFixture; |
911 | |
912 | -TEST_F(DisplayConfigurationTest, display_configuration_reaches_client) |
913 | +TEST_F(DisplayConfigurationTest, DisplayConfigurationReachesClient) |
914 | { |
915 | struct ServerConfig : TestingServerConfiguration |
916 | { |
917 | @@ -204,7 +204,7 @@ |
918 | launch_client_process(client_config); |
919 | } |
920 | |
921 | -TEST_F(DisplayConfigurationTest, hw_display_change_notification_reaches_all_clients) |
922 | +TEST_F(DisplayConfigurationTest, HwDisplayChangeNotificationReachesAllClients) |
923 | { |
924 | mtf::CrossProcessSync client_ready_fence; |
925 | mtf::CrossProcessSync unsubscribed_client_ready_fence; |
926 | @@ -345,7 +345,7 @@ |
927 | }); |
928 | } |
929 | |
930 | -TEST_F(DisplayConfigurationTest, display_change_request_for_unauthorized_client_fails) |
931 | +TEST_F(DisplayConfigurationTest, DisplayChangeRequestForUnauthorizedClientFails) |
932 | { |
933 | struct ServerConfig : TestingServerConfiguration |
934 | { |
935 | @@ -458,7 +458,7 @@ |
936 | |
937 | } |
938 | |
939 | -TEST_F(DisplayConfigurationTest, changing_config_for_focused_client_configures_display) |
940 | +TEST_F(DisplayConfigurationTest, ChangingConfigForFocusedClientConfiguresDisplay) |
941 | { |
942 | mt::CrossProcessAction display_client_connect; |
943 | mt::CrossProcessAction display_client_apply_config; |
944 | @@ -538,7 +538,7 @@ |
945 | }); |
946 | } |
947 | |
948 | -TEST_F(DisplayConfigurationTest, focusing_client_with_display_config_configures_display) |
949 | +TEST_F(DisplayConfigurationTest, FocusingClientWithDisplayConfigConfiguresDisplay) |
950 | { |
951 | mt::CrossProcessAction display_client_connect; |
952 | mt::CrossProcessAction display_client_apply_config; |
953 | @@ -634,7 +634,7 @@ |
954 | }); |
955 | } |
956 | |
957 | -TEST_F(DisplayConfigurationTest, changing_focus_from_client_with_config_to_client_without_config_configures_display) |
958 | +TEST_F(DisplayConfigurationTest, ChangingFocusFromClientWithConfigToClientWithoutConfigConfiguresDisplay) |
959 | { |
960 | mt::CrossProcessAction display_client_connect; |
961 | mt::CrossProcessAction display_client_apply_config; |
962 | @@ -729,7 +729,7 @@ |
963 | }); |
964 | } |
965 | |
966 | -TEST_F(DisplayConfigurationTest, hw_display_change_doesnt_apply_base_config_if_per_session_config_is_active) |
967 | +TEST_F(DisplayConfigurationTest, HwDisplayChangeDoesntApplyBaseConfigIfPerSessionConfigIsActive) |
968 | { |
969 | mt::CrossProcessAction display_client_connect; |
970 | mt::CrossProcessAction display_client_apply_config; |
971 | |
972 | === modified file 'tests/acceptance-tests/test_focus_selection.cpp' |
973 | --- tests/acceptance-tests/test_focus_selection.cpp 2014-10-29 06:21:10 +0000 |
974 | +++ tests/acceptance-tests/test_focus_selection.cpp 2014-11-24 02:31:01 +0000 |
975 | @@ -46,7 +46,7 @@ |
976 | } |
977 | } |
978 | |
979 | -TEST_F(BespokeDisplayServerTestFixture, sessions_creating_surface_receive_focus) |
980 | +TEST_F(BespokeDisplayServerTestFixture, SessionsCreatingSurfaceReceiveFocus) |
981 | { |
982 | struct ServerConfig : TestingServerConfiguration |
983 | { |
984 | @@ -80,7 +80,7 @@ |
985 | launch_client_process(client); |
986 | } |
987 | |
988 | -TEST_F(BespokeDisplayServerTestFixture, surfaces_receive_input_focus_when_created) |
989 | +TEST_F(BespokeDisplayServerTestFixture, SurfacesReceiveInputFocusWhenCreated) |
990 | { |
991 | struct ServerConfig : TestingServerConfiguration |
992 | { |
993 | |
994 | === modified file 'tests/acceptance-tests/test_large_messages.cpp' |
995 | --- tests/acceptance-tests/test_large_messages.cpp 2014-10-29 06:21:10 +0000 |
996 | +++ tests/acceptance-tests/test_large_messages.cpp 2014-11-24 02:31:01 +0000 |
997 | @@ -89,7 +89,7 @@ |
998 | // Regression test for lp:1320187. Without a fix for that bug, connecting |
999 | // to a server with a lot of information in the display configuration hangs |
1000 | // the client, because the server reply message is incomplete/corrupted. |
1001 | -TEST_F(LargeMessages, connection_to_server_with_large_display_configuration_succeeds) |
1002 | +TEST_F(LargeMessages, ConnectionToServerWithLargeDisplayConfigurationSucceeds) |
1003 | { |
1004 | using namespace testing; |
1005 | |
1006 | |
1007 | === modified file 'tests/acceptance-tests/test_nested_mir.cpp' |
1008 | --- tests/acceptance-tests/test_nested_mir.cpp 2014-11-21 12:16:36 +0000 |
1009 | +++ tests/acceptance-tests/test_nested_mir.cpp 2014-11-24 02:31:01 +0000 |
1010 | @@ -296,7 +296,7 @@ |
1011 | }; |
1012 | } |
1013 | |
1014 | -TEST_F(NestedServer, nested_platform_connects_and_disconnects) |
1015 | +TEST_F(NestedServer, NestedPlatformConnectsAndDisconnects) |
1016 | { |
1017 | NestedServerConfiguration nested_config{connection_string, the_graphics_platform()}; |
1018 | |
1019 | @@ -307,7 +307,7 @@ |
1020 | NestedMirRunner nested_mir{nested_config}; |
1021 | } |
1022 | |
1023 | -TEST_F(NestedServer, sees_expected_outputs) |
1024 | +TEST_F(NestedServer, SeesExpectedOutputs) |
1025 | { |
1026 | NestedServerConfiguration nested_config{connection_string, the_graphics_platform()}; |
1027 | NestedMirRunner nested_mir{nested_config}; |
1028 | @@ -331,7 +331,7 @@ |
1029 | ////////////////////////////////////////////////////////////////// |
1030 | // TODO the following test was used in investigating lifetime issues. |
1031 | // TODO it may not have much long term value, but decide that later. |
1032 | -TEST_F(NestedServer, on_exit_display_objects_should_be_destroyed) |
1033 | +TEST_F(NestedServer, OnExitDisplayObjectsShouldBeDestroyed) |
1034 | { |
1035 | struct MyServerConfiguration : NestedServerConfiguration |
1036 | { |
1037 | @@ -354,7 +354,7 @@ |
1038 | EXPECT_FALSE(config.my_display.lock()) << "after run_mir() exits the display should be released"; |
1039 | } |
1040 | |
1041 | -TEST_F(NestedServer, receives_lifecycle_events_from_host) |
1042 | +TEST_F(NestedServer, ReceivesLifecycleEventsFromHost) |
1043 | { |
1044 | struct MyServerConfiguration : NestedServerConfiguration |
1045 | { |
1046 | |
1047 | === modified file 'tests/acceptance-tests/test_prompt_session_client_api.cpp' |
1048 | --- tests/acceptance-tests/test_prompt_session_client_api.cpp 2014-11-03 02:35:50 +0000 |
1049 | +++ tests/acceptance-tests/test_prompt_session_client_api.cpp 2014-11-24 02:31:01 +0000 |
1050 | @@ -309,7 +309,7 @@ |
1051 | } |
1052 | } |
1053 | |
1054 | -TEST_F(PromptSessionClientAPI, can_start_and_stop_a_prompt_session) |
1055 | +TEST_F(PromptSessionClientAPI, CanStartAndStopAPromptSession) |
1056 | { |
1057 | connection = mir_connect_sync(new_connection().c_str(), __PRETTY_FUNCTION__); |
1058 | |
1059 | @@ -328,7 +328,7 @@ |
1060 | mir_prompt_session_release_sync(prompt_session); |
1061 | } |
1062 | |
1063 | -TEST_F(PromptSessionClientAPI, notifies_start_and_stop) |
1064 | +TEST_F(PromptSessionClientAPI, NotifiesStartAndStop) |
1065 | { |
1066 | connection = mir_connect_sync(new_connection().c_str(), __PRETTY_FUNCTION__); |
1067 | |
1068 | @@ -342,7 +342,7 @@ |
1069 | mir_prompt_session_release_sync(prompt_session); |
1070 | } |
1071 | |
1072 | -TEST_F(PromptSessionClientAPI, can_get_fds_for_prompt_providers) |
1073 | +TEST_F(PromptSessionClientAPI, CanGetFdsForPromptProviders) |
1074 | { |
1075 | connection = mir_connect_sync(new_connection().c_str(), __PRETTY_FUNCTION__); |
1076 | |
1077 | @@ -386,7 +386,7 @@ |
1078 | // TODO we need a nice way to run this (and similar tests that require a |
1079 | // TODO separate client process) in CI. Disabled as we can't be sure the |
1080 | // TODO mir_demo_client_basic executable is about. |
1081 | -TEST_F(PromptSessionClientAPI, DISABLED_client_pid_is_associated_with_session) |
1082 | +TEST_F(PromptSessionClientAPI, DISABLED_ClientPidIsAssociatedWithSession) |
1083 | { |
1084 | connection = mir_connect_sync(new_connection().c_str(), __PRETTY_FUNCTION__); |
1085 | |
1086 | @@ -417,7 +417,7 @@ |
1087 | mir_prompt_session_release_sync(prompt_session); |
1088 | } |
1089 | |
1090 | -TEST_F(PromptSessionClientAPI, notifies_when_server_closes_prompt_session) |
1091 | +TEST_F(PromptSessionClientAPI, NotifiesWhenServerClosesPromptSession) |
1092 | { |
1093 | connection = mir_connect_sync(new_connection().c_str(), __PRETTY_FUNCTION__); |
1094 | |
1095 | @@ -438,7 +438,7 @@ |
1096 | mir_prompt_session_release_sync(prompt_session); |
1097 | } |
1098 | |
1099 | -TEST_F(PromptSessionClientAPI, after_server_closes_prompt_session_api_isnt_broken) |
1100 | +TEST_F(PromptSessionClientAPI, AfterServerClosesPromptSessionApiIsntBroken) |
1101 | { |
1102 | connection = mir_connect_sync(new_connection().c_str(), __PRETTY_FUNCTION__); |
1103 | |
1104 | @@ -455,7 +455,7 @@ |
1105 | mir_prompt_session_release_sync(prompt_session); |
1106 | } |
1107 | |
1108 | -TEST_F(PromptSessionClientAPI, server_retrieves_application_session) |
1109 | +TEST_F(PromptSessionClientAPI, ServerRetrievesApplicationSession) |
1110 | { |
1111 | connection = mir_connect_sync(new_connection().c_str(), __PRETTY_FUNCTION__); |
1112 | capture_server_prompt_session(); |
1113 | @@ -469,7 +469,7 @@ |
1114 | mir_prompt_session_release_sync(prompt_session); |
1115 | } |
1116 | |
1117 | -TEST_F(PromptSessionClientAPI, server_retrieves_helper_session) |
1118 | +TEST_F(PromptSessionClientAPI, ServerRetrievesHelperSession) |
1119 | { |
1120 | connection = mir_connect_sync(new_connection().c_str(), __PRETTY_FUNCTION__); |
1121 | |
1122 | @@ -486,7 +486,7 @@ |
1123 | mir_prompt_session_release_sync(prompt_session); |
1124 | } |
1125 | |
1126 | -TEST_F(PromptSessionClientAPI, server_retrieves_child_provider_sessions) |
1127 | +TEST_F(PromptSessionClientAPI, ServerRetrievesChildProviderSessions) |
1128 | { |
1129 | connection = mir_connect_sync(new_connection().c_str(), __PRETTY_FUNCTION__); |
1130 | |
1131 | @@ -507,7 +507,7 @@ |
1132 | mir_prompt_session_release_sync(prompt_session); |
1133 | } |
1134 | |
1135 | -TEST_F(PromptSessionClientAPI, cannot_start_a_prompt_session_without_authorization) |
1136 | +TEST_F(PromptSessionClientAPI, CannotStartAPromptSessionWithoutAuthorization) |
1137 | { |
1138 | EXPECT_CALL(*the_mock_session_authorizer(), prompt_session_is_allowed(_)) |
1139 | .WillOnce(Return(false)); |
1140 | @@ -570,7 +570,7 @@ |
1141 | } |
1142 | |
1143 | // lp:1377968 |
1144 | -TEST_F(PromptSessionClientAPI, when_application_pid_is_invalid_starting_a_prompt_session_fails) |
1145 | +TEST_F(PromptSessionClientAPI, WhenApplicationPidIsInvalidStartingAPromptSessionFails) |
1146 | { |
1147 | connection = mir_connect_sync(new_prompt_connection().c_str(), __PRETTY_FUNCTION__); |
1148 | |
1149 | |
1150 | === modified file 'tests/acceptance-tests/test_server_disconnect.cpp' |
1151 | --- tests/acceptance-tests/test_server_disconnect.cpp 2014-11-21 12:16:36 +0000 |
1152 | +++ tests/acceptance-tests/test_server_disconnect.cpp 2014-11-24 02:31:01 +0000 |
1153 | @@ -57,7 +57,7 @@ |
1154 | } |
1155 | } |
1156 | |
1157 | -TEST_F(ServerDisconnect, is_detected_by_client) |
1158 | +TEST_F(ServerDisconnect, IsDetectedByClient) |
1159 | { |
1160 | mtf::CrossProcessSync sync; |
1161 | |
1162 | @@ -99,7 +99,7 @@ |
1163 | } |
1164 | } |
1165 | |
1166 | -TEST_F(ServerDisconnect, doesnt_stop_client_calling_API_functions) |
1167 | +TEST_F(ServerDisconnect, DoesntStopClientCalling_APIFunctions) |
1168 | { |
1169 | mt::CrossProcessAction connect; |
1170 | mt::CrossProcessAction create_surface; |
1171 | @@ -162,7 +162,7 @@ |
1172 | } |
1173 | } |
1174 | |
1175 | -TEST_F(ServerDisconnect, causes_client_to_terminate_by_default) |
1176 | +TEST_F(ServerDisconnect, CausesClientToTerminateByDefault) |
1177 | { |
1178 | mt::CrossProcessAction connect; |
1179 | mtf::CrossProcessSync create_surface_sync; |
1180 | |
1181 | === modified file 'tests/acceptance-tests/test_server_shutdown.cpp' |
1182 | --- tests/acceptance-tests/test_server_shutdown.cpp 2014-11-21 12:16:36 +0000 |
1183 | +++ tests/acceptance-tests/test_server_shutdown.cpp 2014-11-24 02:31:01 +0000 |
1184 | @@ -36,7 +36,7 @@ |
1185 | } |
1186 | } |
1187 | |
1188 | -TEST_F(ServerShutdown, normal_exit_removes_endpoint) |
1189 | +TEST_F(ServerShutdown, NormalExitRemovesEndpoint) |
1190 | { |
1191 | run_in_server([]{}); |
1192 | |
1193 | @@ -49,7 +49,7 @@ |
1194 | } |
1195 | } |
1196 | |
1197 | -TEST_F(ServerShutdown, abort_removes_endpoint) |
1198 | +TEST_F(ServerShutdown, AbortRemovesEndpoint) |
1199 | { |
1200 | mtf::CrossProcessSync sync; |
1201 | |
1202 | @@ -76,7 +76,7 @@ |
1203 | } |
1204 | } |
1205 | |
1206 | -TEST_F(ServerShutdown, fatal_error_abort_causes_abort_on_fatal_error) |
1207 | +TEST_F(ServerShutdown, FatalErrorAbortCausesAbortOnFatalError) |
1208 | { |
1209 | // Change the fatal error strategy before starting the Mir server |
1210 | mir::FatalErrorStrategy on_error{mir::fatal_error_abort}; |
1211 | @@ -102,7 +102,7 @@ |
1212 | } |
1213 | } |
1214 | |
1215 | -TEST_F(ServerShutdown, fatal_error_abort_removes_endpoint) |
1216 | +TEST_F(ServerShutdown, FatalErrorAbortRemovesEndpoint) |
1217 | { // Even fatal errors sometimes need to be caught for critical cleanup... |
1218 | mir::FatalErrorStrategy on_error{mir::fatal_error_abort}; |
1219 | |
1220 | @@ -126,7 +126,7 @@ |
1221 | }; |
1222 | } |
1223 | |
1224 | -TEST_F(ServerShutdown, on_fatal_error_abort_option_causes_abort_on_fatal_error) |
1225 | +TEST_F(ServerShutdown, OnFatalErrorAbortOptionCausesAbortOnFatalError) |
1226 | { |
1227 | add_to_environment( "MIR_SERVER_ON_FATAL_ERROR_ABORT", ""); |
1228 | |
1229 | @@ -151,7 +151,7 @@ |
1230 | } |
1231 | } |
1232 | |
1233 | -TEST_F(ServerShutdown, mir_fatal_error_during_init_removes_endpoint) |
1234 | +TEST_F(ServerShutdown, MirFatalErrorDuringInitRemovesEndpoint) |
1235 | { // Even fatal errors sometimes need to be caught for critical cleanup... |
1236 | |
1237 | add_to_environment("MIR_SERVER_FILE", mir_test_socket); |
1238 | @@ -180,7 +180,7 @@ |
1239 | |
1240 | struct OnSignal : ServerShutdown, ::testing::WithParamInterface<int> {}; |
1241 | |
1242 | -TEST_P(OnSignal, removes_endpoint) |
1243 | +TEST_P(OnSignal, RemovesEndpoint) |
1244 | { |
1245 | mtf::CrossProcessSync sync; |
1246 | |
1247 | |
1248 | === modified file 'tests/acceptance-tests/test_server_startup.cpp' |
1249 | --- tests/acceptance-tests/test_server_startup.cpp 2014-11-21 12:16:36 +0000 |
1250 | +++ tests/acceptance-tests/test_server_startup.cpp 2014-11-24 02:31:01 +0000 |
1251 | @@ -30,7 +30,7 @@ |
1252 | |
1253 | using ServerStartup = mtf::InterprocessClientServerTest; |
1254 | |
1255 | -TEST_F(ServerStartup, creates_endpoint_on_filesystem) |
1256 | +TEST_F(ServerStartup, CreatesEndpointOnFilesystem) |
1257 | { |
1258 | ASSERT_FALSE(mtf::detect_server(mtf::test_socket_file(), std::chrono::milliseconds(0))); |
1259 | |
1260 | @@ -43,7 +43,7 @@ |
1261 | }); |
1262 | } |
1263 | |
1264 | -TEST_F(ServerStartup, after_server_sigkilled_can_start_new_instance) |
1265 | +TEST_F(ServerStartup, AfterServerSigkilledCanStartNewInstance) |
1266 | { |
1267 | ASSERT_FALSE(mtf::detect_server(mtf::test_socket_file(), std::chrono::milliseconds(0))); |
1268 | |
1269 | |
1270 | === modified file 'tests/acceptance-tests/test_server_without_active_outputs.cpp' |
1271 | --- tests/acceptance-tests/test_server_without_active_outputs.cpp 2014-07-28 13:16:45 +0000 |
1272 | +++ tests/acceptance-tests/test_server_without_active_outputs.cpp 2014-11-24 02:31:01 +0000 |
1273 | @@ -42,7 +42,7 @@ |
1274 | |
1275 | } |
1276 | |
1277 | -TEST_F(ServerWithoutActiveOutputs, creates_valid_client_surface) |
1278 | +TEST_F(ServerWithoutActiveOutputs, CreatesValidClientSurface) |
1279 | { |
1280 | using namespace testing; |
1281 | |
1282 | |
1283 | === modified file 'tests/acceptance-tests/test_shell_control_of_surface_configuration.cpp' |
1284 | --- tests/acceptance-tests/test_shell_control_of_surface_configuration.cpp 2014-10-29 06:21:10 +0000 |
1285 | +++ tests/acceptance-tests/test_shell_control_of_surface_configuration.cpp 2014-11-24 02:31:01 +0000 |
1286 | @@ -70,7 +70,7 @@ |
1287 | |
1288 | } |
1289 | |
1290 | -TEST_F(BespokeDisplayServerTestFixture, the_shell_surface_configurator_is_notified_of_attribute_changes) |
1291 | +TEST_F(BespokeDisplayServerTestFixture, TheShellSurfaceConfiguratorIsNotifiedOfAttributeChanges) |
1292 | { |
1293 | struct ServerConfiguration : TestingServerConfiguration |
1294 | { |
1295 | @@ -111,7 +111,7 @@ |
1296 | launch_client_process(client_config); |
1297 | } |
1298 | |
1299 | -TEST_F(BespokeDisplayServerTestFixture, the_shell_surface_configurator_may_interfere_with_attribute_changes) |
1300 | +TEST_F(BespokeDisplayServerTestFixture, TheShellSurfaceConfiguratorMayInterfereWithAttributeChanges) |
1301 | { |
1302 | struct ServerConfiguration : TestingServerConfiguration |
1303 | { |
1304 | |
1305 | === modified file 'tests/acceptance-tests/test_surfaces_with_output_id.cpp' |
1306 | --- tests/acceptance-tests/test_surfaces_with_output_id.cpp 2014-10-29 06:21:10 +0000 |
1307 | +++ tests/acceptance-tests/test_surfaces_with_output_id.cpp 2014-11-24 02:31:01 +0000 |
1308 | @@ -144,7 +144,7 @@ |
1309 | |
1310 | } |
1311 | |
1312 | -TEST_F(SurfacesWithOutputId, fullscreen_surfaces_are_placed_at_top_left_of_correct_output) |
1313 | +TEST_F(SurfacesWithOutputId, FullscreenSurfacesArePlacedAtTopLeftOfCorrectOutput) |
1314 | { |
1315 | std::vector<std::shared_ptr<MirSurface>> surfaces; |
1316 | |
1317 | @@ -163,7 +163,7 @@ |
1318 | EXPECT_EQ(display_rects, surface_rects); |
1319 | } |
1320 | |
1321 | -TEST_F(SurfacesWithOutputId, non_fullscreen_surfaces_are_not_accepted) |
1322 | +TEST_F(SurfacesWithOutputId, NonFullscreenSurfacesAreNotAccepted) |
1323 | { |
1324 | for (uint32_t n = 0; n < config->num_outputs; ++n) |
1325 | { |
1326 | |
1327 | === modified file 'tests/acceptance-tests/test_symbols_required_by_mesa.cpp' |
1328 | --- tests/acceptance-tests/test_symbols_required_by_mesa.cpp 2014-10-29 06:21:10 +0000 |
1329 | +++ tests/acceptance-tests/test_symbols_required_by_mesa.cpp 2014-11-24 02:31:01 +0000 |
1330 | @@ -23,7 +23,7 @@ |
1331 | |
1332 | using namespace testing; |
1333 | |
1334 | -TEST(SymbolsRequiredByMesa, are_exported_by_libmirclientplatform) |
1335 | +TEST(SymbolsRequiredByMesa, AreExportedByLibmirclientplatform) |
1336 | { |
1337 | auto const handle = dlopen(MIR_CLIENT_DRIVER_BINARY, RTLD_LAZY); |
1338 | ASSERT_THAT(handle, NotNull()); |
1339 | @@ -34,7 +34,7 @@ |
1340 | dlclose(handle); |
1341 | } |
1342 | |
1343 | -TEST(SymbolsRequiredByMesa, are_exported_by_libmirplatformgraphics) |
1344 | +TEST(SymbolsRequiredByMesa, AreExportedByLibmirplatformgraphics) |
1345 | { |
1346 | auto const handle = dlopen(MIR_PLATFORM_DRIVER_BINARY, RTLD_LAZY); |
1347 | ASSERT_THAT(handle, NotNull()); |
1348 | |
1349 | === modified file 'tests/acceptance-tests/test_touchspot_visualization.cpp' |
1350 | --- tests/acceptance-tests/test_touchspot_visualization.cpp 2014-10-29 06:21:10 +0000 |
1351 | +++ tests/acceptance-tests/test_touchspot_visualization.cpp 2014-11-24 02:31:01 +0000 |
1352 | @@ -164,7 +164,7 @@ |
1353 | |
1354 | using namespace ::testing; |
1355 | |
1356 | -TEST_F(TestTouchspotVisualizations, touch_is_given_to_touchspot_visualizer) |
1357 | +TEST_F(TestTouchspotVisualizations, TouchIsGivenToTouchspotVisualizer) |
1358 | { |
1359 | auto minimum_touch = mi::android::FakeEventHub::TouchScreenMinAxisValue; |
1360 | |
1361 | @@ -190,7 +190,7 @@ |
1362 | start_server(); |
1363 | } |
1364 | |
1365 | -TEST_F(TestTouchspotVisualizations, touchspots_follow_gesture) |
1366 | +TEST_F(TestTouchspotVisualizations, TouchspotsFollowGesture) |
1367 | { |
1368 | auto minimum_touch = mi::android::FakeEventHub::TouchScreenMinAxisValue; |
1369 | auto maximum_touch = mi::android::FakeEventHub::TouchScreenMaxAxisValue; |
1370 | |
1371 | === modified file 'tests/acceptance-tests/test_unresponsive_client.cpp' |
1372 | --- tests/acceptance-tests/test_unresponsive_client.cpp 2014-11-03 02:35:50 +0000 |
1373 | +++ tests/acceptance-tests/test_unresponsive_client.cpp 2014-11-24 02:31:01 +0000 |
1374 | @@ -59,7 +59,7 @@ |
1375 | }; |
1376 | } |
1377 | |
1378 | -TEST_F(UnresponsiveClient, does_not_hang_server) |
1379 | +TEST_F(UnresponsiveClient, DoesNotHangServer) |
1380 | { |
1381 | mt::CrossProcessAction server_send_events; |
1382 | mt::CrossProcessAction client_connect; |
1383 | |
1384 | === modified file 'tests/integration-tests/client/test_screencast.cpp' |
1385 | --- tests/integration-tests/client/test_screencast.cpp 2014-10-29 06:21:10 +0000 |
1386 | +++ tests/integration-tests/client/test_screencast.cpp 2014-11-24 02:31:01 +0000 |
1387 | @@ -85,7 +85,7 @@ |
1388 | |
1389 | } |
1390 | |
1391 | -TEST_F(MirScreencastTest, gets_buffer_fd_when_creating_screencast) |
1392 | +TEST_F(MirScreencastTest, GetsBufferFdWhenCreatingScreencast) |
1393 | { |
1394 | std::vector<char> const cookie{'2','3','l','$'}; |
1395 | |
1396 | @@ -123,7 +123,7 @@ |
1397 | close(read_fd); |
1398 | } |
1399 | |
1400 | -TEST_F(MirScreencastTest, gets_buffer_fd_when_getting_screencast_buffer) |
1401 | +TEST_F(MirScreencastTest, GetsBufferFdWhenGettingScreencastBuffer) |
1402 | { |
1403 | std::vector<char> const cookie{'X','%','q','S'}; |
1404 | |
1405 | |
1406 | === modified file 'tests/integration-tests/compositor/test_buffer_stream.cpp' |
1407 | --- tests/integration-tests/compositor/test_buffer_stream.cpp 2014-10-29 06:21:10 +0000 |
1408 | +++ tests/integration-tests/compositor/test_buffer_stream.cpp 2014-11-24 02:31:01 +0000 |
1409 | @@ -122,7 +122,7 @@ |
1410 | |
1411 | } |
1412 | |
1413 | -TEST_F(BufferStreamTest, gives_same_back_buffer_until_more_available) |
1414 | +TEST_F(BufferStreamTest, GivesSameBackBufferUntilMoreAvailable) |
1415 | { |
1416 | mg::Buffer* client1 = buffer_stream.acquire_client_buffer_blocking(); |
1417 | auto client1_id = client1->id(); |
1418 | @@ -153,7 +153,7 @@ |
1419 | EXPECT_EQ(comp3_id, comp4->id()); |
1420 | } |
1421 | |
1422 | -TEST_F(BufferStreamTest, gives_all_monitors_the_same_buffer) |
1423 | +TEST_F(BufferStreamTest, GivesAllMonitorsTheSameBuffer) |
1424 | { |
1425 | mg::Buffer* client_buffer{nullptr}; |
1426 | int const prefill = buffers_free_for_client(); |
1427 | @@ -172,7 +172,7 @@ |
1428 | } |
1429 | } |
1430 | |
1431 | -TEST_F(BufferStreamTest, gives_different_back_buffer_asap) |
1432 | +TEST_F(BufferStreamTest, GivesDifferentBackBufferAsap) |
1433 | { |
1434 | buffer_stream.release_client_buffer(buffer_stream.acquire_client_buffer_blocking()); |
1435 | auto comp1 = buffer_stream.lock_compositor_buffer(nullptr); |
1436 | @@ -186,7 +186,7 @@ |
1437 | comp2.reset(); |
1438 | } |
1439 | |
1440 | -TEST_F(BufferStreamTest, resize_affects_client_buffers_immediately) |
1441 | +TEST_F(BufferStreamTest, ResizeAffectsClientBuffersImmediately) |
1442 | { |
1443 | auto old_size = buffer_stream.stream_size(); |
1444 | |
1445 | @@ -220,7 +220,7 @@ |
1446 | buffer_stream.release_client_buffer(client); |
1447 | } |
1448 | |
1449 | -TEST_F(BufferStreamTest, compositor_gets_resized_buffers) |
1450 | +TEST_F(BufferStreamTest, CompositorGetsResizedBuffers) |
1451 | { |
1452 | auto old_size = buffer_stream.stream_size(); |
1453 | |
1454 | @@ -279,7 +279,7 @@ |
1455 | comp5.reset(); |
1456 | } |
1457 | |
1458 | -TEST_F(BufferStreamTest, can_get_partly_released_back_buffer) |
1459 | +TEST_F(BufferStreamTest, CanGetPartlyReleasedBackBuffer) |
1460 | { |
1461 | mg::Buffer* client = buffer_stream.acquire_client_buffer_blocking(); |
1462 | buffer_stream.release_client_buffer(client); |
1463 | @@ -343,7 +343,7 @@ |
1464 | |
1465 | } |
1466 | |
1467 | -TEST_F(BufferStreamTest, stress_test_distinct_buffers) |
1468 | +TEST_F(BufferStreamTest, StressTestDistinctBuffers) |
1469 | { |
1470 | // More would be good, but armhf takes too long |
1471 | const int num_snapshotters{2}; |
1472 | @@ -381,7 +381,7 @@ |
1473 | s->join(); |
1474 | } |
1475 | |
1476 | -TEST_F(BufferStreamTest, blocked_client_is_released_on_timeout) |
1477 | +TEST_F(BufferStreamTest, BlockedClientIsReleasedOnTimeout) |
1478 | { |
1479 | using namespace testing; |
1480 | |
1481 | |
1482 | === modified file 'tests/integration-tests/compositor/test_swapping_swappers.cpp' |
1483 | --- tests/integration-tests/compositor/test_swapping_swappers.cpp 2014-10-29 06:21:10 +0000 |
1484 | +++ tests/integration-tests/compositor/test_swapping_swappers.cpp 2014-11-24 02:31:01 +0000 |
1485 | @@ -82,7 +82,7 @@ |
1486 | |
1487 | } // namespace |
1488 | |
1489 | -TEST_F(SwapperSwappingStress, swapper) |
1490 | +TEST_F(SwapperSwappingStress, Swapper) |
1491 | { |
1492 | std::atomic_bool done(false); |
1493 | |
1494 | @@ -126,7 +126,7 @@ |
1495 | h.wait(); |
1496 | } |
1497 | |
1498 | -TEST_F(SwapperSwappingStress, different_swapper_types) |
1499 | +TEST_F(SwapperSwappingStress, DifferentSwapperTypes) |
1500 | { |
1501 | std::atomic_bool done(false); |
1502 | |
1503 | |
1504 | === modified file 'tests/integration-tests/compositor/test_synchronizer.cpp' |
1505 | --- tests/integration-tests/compositor/test_synchronizer.cpp 2013-02-05 18:21:20 +0000 |
1506 | +++ tests/integration-tests/compositor/test_synchronizer.cpp 2014-11-24 02:31:01 +0000 |
1507 | @@ -33,7 +33,7 @@ |
1508 | } |
1509 | } |
1510 | |
1511 | -TEST(Synchronizer, thread_stop_start) |
1512 | +TEST(Synchronizer, ThreadStopStart) |
1513 | { |
1514 | int data = 0; |
1515 | |
1516 | @@ -69,7 +69,7 @@ |
1517 | } |
1518 | } |
1519 | |
1520 | -TEST(Synchronizer, thread_pause_req) |
1521 | +TEST(Synchronizer, ThreadPauseReq) |
1522 | { |
1523 | int data = 0, old_data = 0; |
1524 | |
1525 | |
1526 | === modified file 'tests/integration-tests/frontend/test_session_mediator_report.cpp' |
1527 | --- tests/integration-tests/frontend/test_session_mediator_report.cpp 2014-10-29 06:21:10 +0000 |
1528 | +++ tests/integration-tests/frontend/test_session_mediator_report.cpp 2014-11-24 02:31:01 +0000 |
1529 | @@ -55,7 +55,7 @@ |
1530 | typedef BespokeDisplayServerTestFixture SessionMediatorReport; |
1531 | } |
1532 | |
1533 | -TEST_F(SessionMediatorReport, session_connect_called) |
1534 | +TEST_F(SessionMediatorReport, SessionConnectCalled) |
1535 | { |
1536 | struct Server : TestingServerConfiguration |
1537 | { |
1538 | @@ -99,7 +99,7 @@ |
1539 | launch_client_process(client_process); |
1540 | } |
1541 | |
1542 | -TEST_F(SessionMediatorReport, session_create_surface_called) |
1543 | +TEST_F(SessionMediatorReport, SessionCreateSurfaceCalled) |
1544 | { |
1545 | struct Server : TestingServerConfiguration |
1546 | { |
1547 | @@ -154,7 +154,7 @@ |
1548 | launch_client_process(client_process); |
1549 | } |
1550 | |
1551 | -TEST_F(SessionMediatorReport, session_next_buffer_called) |
1552 | +TEST_F(SessionMediatorReport, SessionNextBufferCalled) |
1553 | { |
1554 | struct Server : TestingServerConfiguration |
1555 | { |
1556 | @@ -211,7 +211,7 @@ |
1557 | launch_client_process(client_process); |
1558 | } |
1559 | |
1560 | -TEST_F(SessionMediatorReport, session_exchange_buffer_called) |
1561 | +TEST_F(SessionMediatorReport, SessionExchangeBufferCalled) |
1562 | { |
1563 | struct Server : TestingServerConfiguration |
1564 | { |
1565 | @@ -272,7 +272,7 @@ |
1566 | launch_client_process(client_process); |
1567 | } |
1568 | |
1569 | -TEST_F(SessionMediatorReport, session_release_surface_called) |
1570 | +TEST_F(SessionMediatorReport, SessionReleaseSurfaceCalled) |
1571 | { |
1572 | struct Server : TestingServerConfiguration |
1573 | { |
1574 | @@ -342,7 +342,7 @@ |
1575 | launch_client_process(client_process); |
1576 | } |
1577 | |
1578 | -TEST_F(SessionMediatorReport, session_disconnect_called) |
1579 | +TEST_F(SessionMediatorReport, SessionDisconnectCalled) |
1580 | { |
1581 | struct Server : TestingServerConfiguration |
1582 | { |
1583 | @@ -422,7 +422,7 @@ |
1584 | launch_client_process(client_process); |
1585 | } |
1586 | |
1587 | -TEST_F(SessionMediatorReport, prompt_session_start_called) |
1588 | +TEST_F(SessionMediatorReport, PromptSessionStartCalled) |
1589 | { |
1590 | struct Server : TestingServerConfiguration |
1591 | { |
1592 | @@ -474,7 +474,7 @@ |
1593 | launch_client_process(client_process); |
1594 | } |
1595 | |
1596 | -TEST_F(SessionMediatorReport, prompt_session_stop_called) |
1597 | +TEST_F(SessionMediatorReport, PromptSessionStopCalled) |
1598 | { |
1599 | struct Server : TestingServerConfiguration |
1600 | { |
1601 | |
1602 | === modified file 'tests/integration-tests/graphics/android/test_buffer_integration.cpp' |
1603 | --- tests/integration-tests/graphics/android/test_buffer_integration.cpp 2014-11-21 12:16:36 +0000 |
1604 | +++ tests/integration-tests/graphics/android/test_buffer_integration.cpp 2014-11-24 02:31:01 +0000 |
1605 | @@ -79,7 +79,7 @@ |
1606 | } |
1607 | } |
1608 | |
1609 | -TEST_F(AndroidBufferIntegration, allocator_can_create_sw_buffer) |
1610 | +TEST_F(AndroidBufferIntegration, AllocatorCanCreateSwBuffer) |
1611 | { |
1612 | using namespace testing; |
1613 | |
1614 | @@ -95,7 +95,7 @@ |
1615 | EXPECT_TRUE(red_pattern.check(*region)); |
1616 | } |
1617 | |
1618 | -TEST_F(AndroidBufferIntegration, allocator_can_create_hw_buffer) |
1619 | +TEST_F(AndroidBufferIntegration, AllocatorCanCreateHwBuffer) |
1620 | { |
1621 | using namespace testing; |
1622 | |
1623 | @@ -107,7 +107,7 @@ |
1624 | EXPECT_NE(nullptr, test_buffer); |
1625 | } |
1626 | |
1627 | -TEST_F(AndroidBufferIntegration, swapper_creation_is_sane) |
1628 | +TEST_F(AndroidBufferIntegration, SwapperCreationIsSane) |
1629 | { |
1630 | using namespace testing; |
1631 | |
1632 | |
1633 | === modified file 'tests/integration-tests/graphics/android/test_client_render.cpp' |
1634 | --- tests/integration-tests/graphics/android/test_client_render.cpp 2014-11-21 12:16:36 +0000 |
1635 | +++ tests/integration-tests/graphics/android/test_client_render.cpp 2014-11-24 02:31:01 +0000 |
1636 | @@ -361,7 +361,7 @@ |
1637 | mtf::CrossProcessSync TestClientIPCRender::sync4; |
1638 | std::shared_ptr<mtf::Process> TestClientIPCRender::render_accelerated_process_double; |
1639 | |
1640 | -TEST_F(TestClientIPCRender, test_render_single) |
1641 | +TEST_F(TestClientIPCRender, TestRenderSingle) |
1642 | { |
1643 | sync1.try_signal_ready_for(); |
1644 | |
1645 | @@ -374,7 +374,7 @@ |
1646 | EXPECT_TRUE(draw_pattern0.check(*region)); |
1647 | } |
1648 | |
1649 | -TEST_F(TestClientIPCRender, test_render_double) |
1650 | +TEST_F(TestClientIPCRender, TestRenderDouble) |
1651 | { |
1652 | sync2.try_signal_ready_for(); |
1653 | |
1654 | @@ -390,7 +390,7 @@ |
1655 | EXPECT_TRUE(draw_pattern1.check(*region1)); |
1656 | } |
1657 | |
1658 | -TEST_F(TestClientIPCRender, test_accelerated_render) |
1659 | +TEST_F(TestClientIPCRender, TestAcceleratedRender) |
1660 | { |
1661 | mt::DrawPatternSolid red_pattern(0xFF0000FF); |
1662 | |
1663 | @@ -404,7 +404,7 @@ |
1664 | EXPECT_TRUE(red_pattern.check(*region0)); |
1665 | } |
1666 | |
1667 | -TEST_F(TestClientIPCRender, test_accelerated_render_double) |
1668 | +TEST_F(TestClientIPCRender, TestAcceleratedRenderDouble) |
1669 | { |
1670 | mt::DrawPatternSolid red_pattern(0xFF0000FF); |
1671 | mt::DrawPatternSolid green_pattern(0xFF00FF00); |
1672 | |
1673 | === modified file 'tests/integration-tests/graphics/android/test_display_integration.cpp' |
1674 | --- tests/integration-tests/graphics/android/test_display_integration.cpp 2014-10-29 06:21:10 +0000 |
1675 | +++ tests/integration-tests/graphics/android/test_display_integration.cpp 2014-11-24 02:31:01 +0000 |
1676 | @@ -79,7 +79,7 @@ |
1677 | }; |
1678 | } |
1679 | |
1680 | -TEST_F(AndroidDisplay, display_can_post) |
1681 | +TEST_F(AndroidDisplay, DisplayCanPost) |
1682 | { |
1683 | display->for_each_display_buffer([](mg::DisplayBuffer& buffer) |
1684 | { |
1685 | @@ -95,7 +95,7 @@ |
1686 | }); |
1687 | } |
1688 | |
1689 | -TEST_F(AndroidDisplay, display_can_post_overlay) |
1690 | +TEST_F(AndroidDisplay, DisplayCanPostOverlay) |
1691 | { |
1692 | display->for_each_display_buffer([](mg::DisplayBuffer& db) |
1693 | { |
1694 | |
1695 | === modified file 'tests/integration-tests/graphics/android/test_internal_client.cpp' |
1696 | --- tests/integration-tests/graphics/android/test_internal_client.cpp 2014-10-29 06:21:10 +0000 |
1697 | +++ tests/integration-tests/graphics/android/test_internal_client.cpp 2014-11-24 02:31:01 +0000 |
1698 | @@ -87,7 +87,7 @@ |
1699 | }; |
1700 | } |
1701 | |
1702 | -TEST_F(AndroidInternalClient, internal_client_creation_and_use) |
1703 | +TEST_F(AndroidInternalClient, InternalClientCreationAndUse) |
1704 | { |
1705 | auto size = geom::Size{334, 122}; |
1706 | auto pf = mir_pixel_format_abgr_8888; |
1707 | |
1708 | === modified file 'tests/integration-tests/graphics/mesa/test_buffer_integration.cpp' |
1709 | --- tests/integration-tests/graphics/mesa/test_buffer_integration.cpp 2014-10-29 06:21:10 +0000 |
1710 | +++ tests/integration-tests/graphics/mesa/test_buffer_integration.cpp 2014-11-24 02:31:01 +0000 |
1711 | @@ -193,7 +193,7 @@ |
1712 | bool exception_thrown; |
1713 | }; |
1714 | |
1715 | -TEST_F(MesaBufferIntegration, buffer_creation_from_arbitrary_thread_works) |
1716 | +TEST_F(MesaBufferIntegration, BufferCreationFromArbitraryThreadWorks) |
1717 | { |
1718 | using namespace testing; |
1719 | |
1720 | @@ -205,7 +205,7 @@ |
1721 | }); |
1722 | } |
1723 | |
1724 | -TEST_F(MesaBufferIntegration, buffer_destruction_from_arbitrary_thread_works) |
1725 | +TEST_F(MesaBufferIntegration, BufferDestructionFromArbitraryThreadWorks) |
1726 | { |
1727 | using namespace testing; |
1728 | |
1729 | @@ -220,7 +220,7 @@ |
1730 | }); |
1731 | } |
1732 | |
1733 | -TEST_F(MesaBufferIntegration, buffer_lazy_texture_instantiation_from_arbitrary_thread_fails) |
1734 | +TEST_F(MesaBufferIntegration, BufferLazyTextureInstantiationFromArbitraryThreadFails) |
1735 | { |
1736 | using namespace testing; |
1737 | |
1738 | |
1739 | === modified file 'tests/integration-tests/input/android/test_android_cursor_listener.cpp' |
1740 | --- tests/integration-tests/input/android/test_android_cursor_listener.cpp 2014-10-29 06:21:10 +0000 |
1741 | +++ tests/integration-tests/input/android/test_android_cursor_listener.cpp 2014-11-24 02:31:01 +0000 |
1742 | @@ -95,7 +95,7 @@ |
1743 | |
1744 | } |
1745 | |
1746 | -TEST_F(AndroidCursorListenerIntegrationTest, cursor_listener_receives_motion) |
1747 | +TEST_F(AndroidCursorListenerIntegrationTest, CursorListenerReceivesMotion) |
1748 | { |
1749 | using namespace ::testing; |
1750 | |
1751 | |
1752 | === modified file 'tests/integration-tests/input/android/test_android_input_manager.cpp' |
1753 | --- tests/integration-tests/input/android/test_android_input_manager.cpp 2014-10-29 06:21:10 +0000 |
1754 | +++ tests/integration-tests/input/android/test_android_input_manager.cpp 2014-11-24 02:31:01 +0000 |
1755 | @@ -91,7 +91,7 @@ |
1756 | |
1757 | } |
1758 | |
1759 | -TEST_F(AndroidInputManagerAndEventFilterDispatcherSetup, manager_dispatches_key_events_to_filter) |
1760 | +TEST_F(AndroidInputManagerAndEventFilterDispatcherSetup, ManagerDispatchesKeyEventsToFilter) |
1761 | { |
1762 | using namespace ::testing; |
1763 | |
1764 | @@ -109,7 +109,7 @@ |
1765 | wait_condition.wait_for_at_most_seconds(1); |
1766 | } |
1767 | |
1768 | -TEST_F(AndroidInputManagerAndEventFilterDispatcherSetup, manager_dispatches_button_down_events_to_filter) |
1769 | +TEST_F(AndroidInputManagerAndEventFilterDispatcherSetup, ManagerDispatchesButtonDownEventsToFilter) |
1770 | { |
1771 | using namespace ::testing; |
1772 | |
1773 | @@ -127,7 +127,7 @@ |
1774 | wait_condition.wait_for_at_most_seconds(1); |
1775 | } |
1776 | |
1777 | -TEST_F(AndroidInputManagerAndEventFilterDispatcherSetup, manager_dispatches_button_up_events_to_filter) |
1778 | +TEST_F(AndroidInputManagerAndEventFilterDispatcherSetup, ManagerDispatchesButtonUpEventsToFilter) |
1779 | { |
1780 | using namespace ::testing; |
1781 | |
1782 | @@ -158,7 +158,7 @@ |
1783 | wait_condition.wait_for_at_most_seconds(1); |
1784 | } |
1785 | |
1786 | -TEST_F(AndroidInputManagerAndEventFilterDispatcherSetup, manager_dispatches_motion_events_to_filter) |
1787 | +TEST_F(AndroidInputManagerAndEventFilterDispatcherSetup, ManagerDispatchesMotionEventsToFilter) |
1788 | { |
1789 | using namespace ::testing; |
1790 | |
1791 | @@ -266,7 +266,7 @@ |
1792 | |
1793 | } |
1794 | |
1795 | -TEST_F(AndroidInputManagerDispatcherInterceptSetup, server_input_fd_of_focused_channel_is_sent_unfiltered_key_events) |
1796 | +TEST_F(AndroidInputManagerDispatcherInterceptSetup, ServerInputFdOfFocusedChannelIsSentUnfilteredKeyEvents) |
1797 | { |
1798 | using namespace ::testing; |
1799 | |
1800 | @@ -288,7 +288,7 @@ |
1801 | wait_condition.wait_for_at_most_seconds(1); |
1802 | } |
1803 | |
1804 | -TEST_F(AndroidInputManagerDispatcherInterceptSetup, changing_focus_changes_event_recipient) |
1805 | +TEST_F(AndroidInputManagerDispatcherInterceptSetup, ChangingFocusChangesEventRecipient) |
1806 | { |
1807 | using namespace ::testing; |
1808 | |
1809 | |
1810 | === modified file 'tests/integration-tests/input/test_configuring_input_manager.cpp' |
1811 | --- tests/integration-tests/input/test_configuring_input_manager.cpp 2013-04-24 05:22:20 +0000 |
1812 | +++ tests/integration-tests/input/test_configuring_input_manager.cpp 2014-11-24 02:31:01 +0000 |
1813 | @@ -28,7 +28,7 @@ |
1814 | |
1815 | #include <stdio.h> |
1816 | |
1817 | -TEST_F(BespokeDisplayServerTestFixture, starting_display_server_starts_input_manager) |
1818 | +TEST_F(BespokeDisplayServerTestFixture, StartingDisplayServerStartsInputManager) |
1819 | { |
1820 | struct ServerConfig : TestingServerConfiguration |
1821 | { |
1822 | |
1823 | === modified file 'tests/integration-tests/input/test_nested_input.cpp' |
1824 | --- tests/integration-tests/input/test_nested_input.cpp 2014-10-29 06:21:10 +0000 |
1825 | +++ tests/integration-tests/input/test_nested_input.cpp 2014-11-24 02:31:01 +0000 |
1826 | @@ -42,7 +42,7 @@ |
1827 | namespace mt = mir::test; |
1828 | namespace mtd = mir::test::doubles; |
1829 | |
1830 | -TEST(NestedInputTest, applies_event_filter_on_relayed_event) |
1831 | +TEST(NestedInputTest, AppliesEventFilterOnRelayedEvent) |
1832 | { |
1833 | using namespace testing; |
1834 | |
1835 | |
1836 | === modified file 'tests/integration-tests/session_management.cpp' |
1837 | --- tests/integration-tests/session_management.cpp 2014-10-29 06:21:10 +0000 |
1838 | +++ tests/integration-tests/session_management.cpp 2014-11-24 02:31:01 +0000 |
1839 | @@ -115,7 +115,7 @@ |
1840 | } |
1841 | } |
1842 | |
1843 | -TEST_F(SessionManagement, creating_a_surface_adds_it_to_scene) |
1844 | +TEST_F(SessionManagement, CreatingASurfaceAddsItToScene) |
1845 | { |
1846 | auto const session = session_manager->open_session(0, __PRETTY_FUNCTION__, event_sink); |
1847 | |
1848 | @@ -123,7 +123,7 @@ |
1849 | session->create_surface(params); |
1850 | } |
1851 | |
1852 | -TEST_F(SessionManagement, focus_on_a_session_raises_its_surface) |
1853 | +TEST_F(SessionManagement, FocusOnASessionRaisesItsSurface) |
1854 | { |
1855 | EXPECT_CALL(*test_surface_stack, add_surface(_,_,_)).Times(AnyNumber()); |
1856 | |
1857 | |
1858 | === modified file 'tests/integration-tests/shell/test_session_lifecycle_event.cpp' |
1859 | --- tests/integration-tests/shell/test_session_lifecycle_event.cpp 2014-10-29 06:21:10 +0000 |
1860 | +++ tests/integration-tests/shell/test_session_lifecycle_event.cpp 2014-11-24 02:31:01 +0000 |
1861 | @@ -73,7 +73,7 @@ |
1862 | |
1863 | } |
1864 | |
1865 | -TEST_F(LifecycleEventTest, lifecycle_event_test) |
1866 | +TEST_F(LifecycleEventTest, LifecycleEventTest) |
1867 | { |
1868 | using namespace ::testing; |
1869 | |
1870 | |
1871 | === modified file 'tests/integration-tests/surface_composition.cpp' |
1872 | --- tests/integration-tests/surface_composition.cpp 2014-10-02 11:56:12 +0000 |
1873 | +++ tests/integration-tests/surface_composition.cpp 2014-11-24 02:31:01 +0000 |
1874 | @@ -102,7 +102,7 @@ |
1875 | } |
1876 | |
1877 | // Presumptive cause of lp:1376324 |
1878 | -TEST_F(SurfaceComposition, does_not_send_client_buffers_to_dead_surfaces) |
1879 | +TEST_F(SurfaceComposition, DoesNotSendClientBuffersToDeadSurfaces) |
1880 | { |
1881 | auto surface = create_surface(); |
1882 | |
1883 | |
1884 | === modified file 'tests/integration-tests/test_client_surface_swap_buffers.cpp' |
1885 | --- tests/integration-tests/test_client_surface_swap_buffers.cpp 2014-10-29 06:21:10 +0000 |
1886 | +++ tests/integration-tests/test_client_surface_swap_buffers.cpp 2014-11-24 02:31:01 +0000 |
1887 | @@ -52,7 +52,7 @@ |
1888 | // |
1889 | //} |
1890 | // |
1891 | -//TEST_F(MirSurfaceSwapBuffersTest, swap_buffers_does_not_block_when_surface_is_not_composited) |
1892 | +//TEST_F(MirSurfaceSwapBuffersTest, Swap_buffers_does_not_block_when_surface_is_not_composited) |
1893 | //{ |
1894 | // using namespace testing; |
1895 | // |
1896 | |
1897 | === modified file 'tests/integration-tests/test_display_info.cpp' |
1898 | --- tests/integration-tests/test_display_info.cpp 2014-10-29 06:21:10 +0000 |
1899 | +++ tests/integration-tests/test_display_info.cpp 2014-11-24 02:31:01 +0000 |
1900 | @@ -132,7 +132,7 @@ |
1901 | |
1902 | using AvailableSurfaceFormatsTest = BespokeDisplayServerTestFixture; |
1903 | |
1904 | -TEST_F(AvailableSurfaceFormatsTest, surface_pixel_formats_reach_client) |
1905 | +TEST_F(AvailableSurfaceFormatsTest, SurfacePixelFormatsReachClient) |
1906 | { |
1907 | struct ServerConfig : TestingServerConfiguration |
1908 | { |
1909 | |
1910 | === modified file 'tests/integration-tests/test_display_server_main_loop_events.cpp' |
1911 | --- tests/integration-tests/test_display_server_main_loop_events.cpp 2014-11-05 03:25:04 +0000 |
1912 | +++ tests/integration-tests/test_display_server_main_loop_events.cpp 2014-11-24 02:31:01 +0000 |
1913 | @@ -349,7 +349,7 @@ |
1914 | |
1915 | } |
1916 | |
1917 | -TEST(DisplayServerMainLoopEvents, display_server_shuts_down_properly_on_sigint) |
1918 | +TEST(DisplayServerMainLoopEvents, DisplayServerShutsDownProperlyOnSigint) |
1919 | { |
1920 | ServerConfig server_config; |
1921 | |
1922 | @@ -360,7 +360,7 @@ |
1923 | }); |
1924 | } |
1925 | |
1926 | -TEST(DisplayServerMainLoopEvents, display_server_shuts_down_properly_on_sigterm) |
1927 | +TEST(DisplayServerMainLoopEvents, DisplayServerShutsDownProperlyOnSigterm) |
1928 | { |
1929 | ServerConfig server_config; |
1930 | |
1931 | @@ -371,7 +371,7 @@ |
1932 | }); |
1933 | } |
1934 | |
1935 | -TEST(DisplayServerMainLoopEvents, display_server_components_pause_and_resume) |
1936 | +TEST(DisplayServerMainLoopEvents, DisplayServerComponentsPauseAndResume) |
1937 | { |
1938 | using namespace testing; |
1939 | |
1940 | @@ -427,7 +427,7 @@ |
1941 | }); |
1942 | } |
1943 | |
1944 | -TEST(DisplayServerMainLoopEvents, display_server_quits_when_paused) |
1945 | +TEST(DisplayServerMainLoopEvents, DisplayServerQuitsWhenPaused) |
1946 | { |
1947 | using namespace testing; |
1948 | |
1949 | @@ -475,7 +475,7 @@ |
1950 | }); |
1951 | } |
1952 | |
1953 | -TEST(DisplayServerMainLoopEvents, display_server_attempts_to_continue_on_pause_failure) |
1954 | +TEST(DisplayServerMainLoopEvents, DisplayServerAttemptsToContinueOnPauseFailure) |
1955 | { |
1956 | using namespace testing; |
1957 | |
1958 | @@ -530,7 +530,7 @@ |
1959 | }); |
1960 | } |
1961 | |
1962 | -TEST(DisplayServerMainLoopEvents, display_server_handles_configuration_change) |
1963 | +TEST(DisplayServerMainLoopEvents, DisplayServerHandlesConfigurationChange) |
1964 | { |
1965 | using namespace testing; |
1966 | |
1967 | @@ -577,7 +577,7 @@ |
1968 | }); |
1969 | } |
1970 | |
1971 | -TEST(DisplayServerMainLoopEvents, postpones_configuration_when_paused) |
1972 | +TEST(DisplayServerMainLoopEvents, PostponesConfigurationWhenPaused) |
1973 | { |
1974 | using namespace testing; |
1975 | |
1976 | @@ -641,7 +641,7 @@ |
1977 | }); |
1978 | } |
1979 | |
1980 | -TEST(DisplayServerMainLoopEvents, server_status_listener) |
1981 | +TEST(DisplayServerMainLoopEvents, ServerStatusListener) |
1982 | { |
1983 | using namespace testing; |
1984 | |
1985 | |
1986 | === modified file 'tests/integration-tests/test_drm_auth_magic.cpp' |
1987 | --- tests/integration-tests/test_drm_auth_magic.cpp 2014-11-18 03:21:20 +0000 |
1988 | +++ tests/integration-tests/test_drm_auth_magic.cpp 2014-11-24 02:31:01 +0000 |
1989 | @@ -88,7 +88,7 @@ |
1990 | |
1991 | } |
1992 | |
1993 | -TEST_F(BespokeDisplayServerTestFixture, client_drm_auth_magic_calls_platform) |
1994 | +TEST_F(BespokeDisplayServerTestFixture, ClientDrmAuthMagicCallsPlatform) |
1995 | { |
1996 | unsigned int const magic{0x10111213}; |
1997 | |
1998 | @@ -142,7 +142,7 @@ |
1999 | launch_client_process(client_config); |
2000 | } |
2001 | |
2002 | -TEST_F(BespokeDisplayServerTestFixture, drm_auth_magic_platform_error_reaches_client) |
2003 | +TEST_F(BespokeDisplayServerTestFixture, DrmAuthMagicPlatformErrorReachesClient) |
2004 | { |
2005 | unsigned int const magic{0x10111213}; |
2006 | static int const auth_magic_error{667}; |
2007 | |
2008 | === modified file 'tests/integration-tests/test_error_reporting.cpp' |
2009 | --- tests/integration-tests/test_error_reporting.cpp 2014-11-12 07:07:06 +0000 |
2010 | +++ tests/integration-tests/test_error_reporting.cpp 2014-11-24 02:31:01 +0000 |
2011 | @@ -174,7 +174,7 @@ |
2012 | |
2013 | using ErrorReporting = BespokeDisplayServerTestFixture; |
2014 | |
2015 | -TEST_F(ErrorReporting, c_api_returns_connection_error) |
2016 | +TEST_F(ErrorReporting, CApiReturnsConnectionError) |
2017 | { |
2018 | |
2019 | struct ServerConfig : TestingServerConfiguration |
2020 | @@ -208,7 +208,7 @@ |
2021 | launch_client_process(client_config); |
2022 | } |
2023 | |
2024 | -TEST_F(ErrorReporting, c_api_returns_surface_creation_error) |
2025 | +TEST_F(ErrorReporting, CApiReturnsSurfaceCreationError) |
2026 | { |
2027 | |
2028 | struct ServerConfig : TestingServerConfiguration |
2029 | |
2030 | === modified file 'tests/integration-tests/test_exchange_buffer.cpp' |
2031 | --- tests/integration-tests/test_exchange_buffer.cpp 2014-11-16 07:44:33 +0000 |
2032 | +++ tests/integration-tests/test_exchange_buffer.cpp 2014-11-24 02:31:01 +0000 |
2033 | @@ -242,7 +242,7 @@ |
2034 | }; |
2035 | } |
2036 | |
2037 | -TEST_F(ExchangeBufferTest, exchanges_happen) |
2038 | +TEST_F(ExchangeBufferTest, ExchangesHappen) |
2039 | { |
2040 | auto connection = mir_connect_sync(new_connection().c_str(), __PRETTY_FUNCTION__); |
2041 | MirSurfaceParameters const request_params = |
2042 | @@ -278,7 +278,7 @@ |
2043 | return arg > 0; |
2044 | } |
2045 | } |
2046 | -TEST_F(ExchangeBufferTest, fds_can_be_sent_back) |
2047 | +TEST_F(ExchangeBufferTest, FdsCanBeSentBack) |
2048 | { |
2049 | using namespace testing; |
2050 | std::string test_string{"mir was a space station"}; |
2051 | |
2052 | === modified file 'tests/integration-tests/test_macros.cpp' |
2053 | --- tests/integration-tests/test_macros.cpp 2014-11-18 03:21:20 +0000 |
2054 | +++ tests/integration-tests/test_macros.cpp 2014-11-24 02:31:01 +0000 |
2055 | @@ -19,7 +19,7 @@ |
2056 | #include "cutils/log.h" // Get the final value of LOG_NDEBUG |
2057 | #include <gtest/gtest.h> |
2058 | |
2059 | -TEST(Macros, android_verbose_logging_is_disabled) |
2060 | +TEST(Macros, AndroidVerboseLoggingIsDisabled) |
2061 | { |
2062 | // Ensure verbose logging (ALOGV) is removed. It requires significant |
2063 | // CPU time to constantly format some verbose messages... |
2064 | |
2065 | === modified file 'tests/integration-tests/test_protobuf.cpp' |
2066 | --- tests/integration-tests/test_protobuf.cpp 2014-10-29 06:21:10 +0000 |
2067 | +++ tests/integration-tests/test_protobuf.cpp 2014-11-24 02:31:01 +0000 |
2068 | @@ -183,7 +183,7 @@ |
2069 | char const* const nothing_returned = "Nothing returned"; |
2070 | } |
2071 | |
2072 | -TEST_F(DemoPrivateProtobuf, client_calls_server) |
2073 | +TEST_F(DemoPrivateProtobuf, ClientCallsServer) |
2074 | { |
2075 | using namespace testing; |
2076 | EXPECT_CALL(*demo_connection_creator, create_processor(_, _, _)); |
2077 | @@ -230,7 +230,7 @@ |
2078 | EXPECT_THAT(result.error(), Eq(nothing_returned)); |
2079 | } |
2080 | |
2081 | -TEST_F(DemoPrivateProtobuf, wrapping_message_processor) |
2082 | +TEST_F(DemoPrivateProtobuf, WrappingMessageProcessor) |
2083 | { |
2084 | using namespace testing; |
2085 | EXPECT_CALL(*demo_connection_creator, create_processor(_, _, _)) |
2086 | @@ -242,7 +242,7 @@ |
2087 | mir_connection_release(connection); |
2088 | } |
2089 | |
2090 | -TEST_F(DemoPrivateProtobuf, server_receives_function_call) |
2091 | +TEST_F(DemoPrivateProtobuf, ServerReceivesFunctionCall) |
2092 | { |
2093 | using namespace testing; |
2094 | EXPECT_CALL(*demo_connection_creator, create_processor(_, _, _)) |
2095 | @@ -270,7 +270,7 @@ |
2096 | } |
2097 | |
2098 | |
2099 | -TEST_F(DemoPrivateProtobuf, client_receives_result) |
2100 | +TEST_F(DemoPrivateProtobuf, ClientReceivesResult) |
2101 | { |
2102 | using namespace testing; |
2103 | EXPECT_CALL(*demo_connection_creator, create_processor(_, _, _)) |
2104 | |
2105 | === modified file 'tests/integration-tests/test_server_client_types.cpp' |
2106 | --- tests/integration-tests/test_server_client_types.cpp 2013-09-04 19:01:36 +0000 |
2107 | +++ tests/integration-tests/test_server_client_types.cpp 2014-11-24 02:31:01 +0000 |
2108 | @@ -27,7 +27,7 @@ |
2109 | EXPECT_EQ(static_cast<mg::DisplayConfigurationOutputType>(mir_display_output_type_##TYPE), \ |
2110 | mg::DisplayConfigurationOutputType::TYPE) |
2111 | |
2112 | -TEST(ServerClientTypes, display_output_types_match) |
2113 | +TEST(ServerClientTypes, DisplayOutputTypesMatch) |
2114 | { |
2115 | EXPECT_DISPLAY_OUTPUT_TYPES_MATCH(unknown); |
2116 | EXPECT_DISPLAY_OUTPUT_TYPES_MATCH(vga); |
2117 | |
2118 | === modified file 'tests/integration-tests/test_server_shutdown.cpp' |
2119 | --- tests/integration-tests/test_server_shutdown.cpp 2014-10-29 06:21:10 +0000 |
2120 | +++ tests/integration-tests/test_server_shutdown.cpp 2014-11-24 02:31:01 +0000 |
2121 | @@ -159,7 +159,7 @@ |
2122 | |
2123 | using ServerShutdown = BespokeDisplayServerTestFixture; |
2124 | |
2125 | -TEST_F(ServerShutdown, server_can_shut_down_when_clients_are_blocked) |
2126 | +TEST_F(ServerShutdown, ServerCanShutDownWhenClientsAreBlocked) |
2127 | { |
2128 | Flag next_buffer_done1{"next_buffer_done1_c5d49978.tmp"}; |
2129 | Flag next_buffer_done2{"next_buffer_done2_c5d49978.tmp"}; |
2130 | @@ -285,7 +285,7 @@ |
2131 | EXPECT_EQ(0, input_manager.use_count()); |
2132 | } |
2133 | |
2134 | -TEST_F(ServerShutdown, server_releases_resources_on_shutdown_with_connected_clients) |
2135 | +TEST_F(ServerShutdown, ServerReleasesResourcesOnShutdownWithConnectedClients) |
2136 | { |
2137 | Flag surface_created1{"surface_created1_7e9c69fc.tmp"}; |
2138 | Flag surface_created2{"surface_created2_7e9c69fc.tmp"}; |
2139 | |
2140 | === modified file 'tests/integration-tests/test_session.cpp' |
2141 | --- tests/integration-tests/test_session.cpp 2014-10-29 06:21:10 +0000 |
2142 | +++ tests/integration-tests/test_session.cpp 2014-11-24 02:31:01 +0000 |
2143 | @@ -128,7 +128,7 @@ |
2144 | |
2145 | } |
2146 | |
2147 | -TEST(ApplicationSession, stress_test_take_snapshot) |
2148 | +TEST(ApplicationSession, StressTestTakeSnapshot) |
2149 | { |
2150 | TestServerConfiguration conf; |
2151 | |
2152 | |
2153 | === modified file 'tests/integration-tests/test_session_manager.cpp' |
2154 | --- tests/integration-tests/test_session_manager.cpp 2014-10-29 06:21:10 +0000 |
2155 | +++ tests/integration-tests/test_session_manager.cpp 2014-11-24 02:31:01 +0000 |
2156 | @@ -72,7 +72,7 @@ |
2157 | |
2158 | } |
2159 | |
2160 | -TEST_F(TestSessionManagerAndFocusSelectionStrategy, cycle_focus) |
2161 | +TEST_F(TestSessionManagerAndFocusSelectionStrategy, CycleFocus) |
2162 | { |
2163 | using namespace ::testing; |
2164 | |
2165 | @@ -101,7 +101,7 @@ |
2166 | EXPECT_CALL(focus_setter, set_focus_to(_)).Times(AtLeast(0)); |
2167 | } |
2168 | |
2169 | -TEST_F(TestSessionManagerAndFocusSelectionStrategy, closing_applications_transfers_focus) |
2170 | +TEST_F(TestSessionManagerAndFocusSelectionStrategy, ClosingApplicationsTransfersFocus) |
2171 | { |
2172 | using namespace ::testing; |
2173 | |
2174 | |
2175 | === modified file 'tests/integration-tests/test_stale_frames.cpp' |
2176 | --- tests/integration-tests/test_stale_frames.cpp 2014-11-12 07:07:06 +0000 |
2177 | +++ tests/integration-tests/test_stale_frames.cpp 2014-11-24 02:31:01 +0000 |
2178 | @@ -183,7 +183,7 @@ |
2179 | |
2180 | } |
2181 | |
2182 | -TEST_F(StaleFrames, are_dropped_when_restarting_compositor) |
2183 | +TEST_F(StaleFrames, AreDroppedWhenRestartingCompositor) |
2184 | { |
2185 | using namespace testing; |
2186 | |
2187 | @@ -212,7 +212,7 @@ |
2188 | EXPECT_THAT(stale_buffers, Not(Contains(new_buffers[0]))); |
2189 | } |
2190 | |
2191 | -TEST_F(StaleFrames, only_fresh_frames_are_used_after_restarting_compositor) |
2192 | +TEST_F(StaleFrames, OnlyFreshFramesAreUsedAfterRestartingCompositor) |
2193 | { |
2194 | using namespace testing; |
2195 | |
2196 | |
2197 | === modified file 'tests/integration-tests/test_surface_first_frame_sync.cpp' |
2198 | --- tests/integration-tests/test_surface_first_frame_sync.cpp 2014-10-29 06:21:10 +0000 |
2199 | +++ tests/integration-tests/test_surface_first_frame_sync.cpp 2014-11-24 02:31:01 +0000 |
2200 | @@ -136,7 +136,7 @@ |
2201 | |
2202 | using SurfaceFirstFrameSync = BespokeDisplayServerTestFixture; |
2203 | |
2204 | -TEST_F(SurfaceFirstFrameSync, surface_not_rendered_until_buffer_is_pushed) |
2205 | +TEST_F(SurfaceFirstFrameSync, SurfaceNotRenderedUntilBufferIsPushed) |
2206 | { |
2207 | static std::string const surface_created{"surface_created_0950f3f9.tmp"}; |
2208 | static std::string const do_next_buffer{"do_next_buffer_0950f3f9.tmp"}; |
2209 | |
2210 | === modified file 'tests/integration-tests/test_surface_stack_with_compositor.cpp' |
2211 | --- tests/integration-tests/test_surface_stack_with_compositor.cpp 2014-10-29 06:21:10 +0000 |
2212 | +++ tests/integration-tests/test_surface_stack_with_compositor.cpp 2014-11-24 02:31:01 +0000 |
2213 | @@ -160,7 +160,7 @@ |
2214 | }; |
2215 | } |
2216 | |
2217 | -TEST_F(SurfaceStackCompositor, composes_on_start_if_told_to_in_constructor) |
2218 | +TEST_F(SurfaceStackCompositor, ComposesOnStartIfToldToInConstructor) |
2219 | { |
2220 | mc::MultiThreadedCompositor mt_compositor( |
2221 | mt::fake_shared(stub_display), |
2222 | @@ -173,7 +173,7 @@ |
2223 | EXPECT_TRUE(stub_secondary_db.has_posted_at_least(1, timeout)); |
2224 | } |
2225 | |
2226 | -TEST_F(SurfaceStackCompositor, does_not_composes_on_start_if_told_not_to_in_constructor) |
2227 | +TEST_F(SurfaceStackCompositor, DoesNotComposesOnStartIfToldNotToInConstructor) |
2228 | { |
2229 | mc::MultiThreadedCompositor mt_compositor( |
2230 | mt::fake_shared(stub_display), |
2231 | @@ -186,7 +186,7 @@ |
2232 | EXPECT_TRUE(stub_secondary_db.has_posted_at_least(0, timeout)); |
2233 | } |
2234 | |
2235 | -TEST_F(SurfaceStackCompositor, adding_a_surface_that_has_been_swapped_triggers_a_composition) |
2236 | +TEST_F(SurfaceStackCompositor, AddingASurfaceThatHasBeenSwappedTriggersAComposition) |
2237 | { |
2238 | mc::MultiThreadedCompositor mt_compositor( |
2239 | mt::fake_shared(stub_display), |
2240 | @@ -203,7 +203,7 @@ |
2241 | } |
2242 | |
2243 | //test associated with lp:1290306, 1293896, 1294048, 1294051, 1294053 |
2244 | -TEST_F(SurfaceStackCompositor, compositor_runs_until_all_surfaces_buffers_are_consumed) |
2245 | +TEST_F(SurfaceStackCompositor, CompositorRunsUntilAllSurfacesBuffersAreConsumed) |
2246 | { |
2247 | using namespace testing; |
2248 | ON_CALL(*mock_buffer_stream, buffers_ready_for_compositor()) |
2249 | @@ -223,7 +223,7 @@ |
2250 | EXPECT_TRUE(stub_secondary_db.has_posted_at_least(5, timeout)); |
2251 | } |
2252 | |
2253 | -TEST_F(SurfaceStackCompositor, bypassed_compositor_runs_until_all_surfaces_buffers_are_consumed) |
2254 | +TEST_F(SurfaceStackCompositor, BypassedCompositorRunsUntilAllSurfacesBuffersAreConsumed) |
2255 | { |
2256 | using namespace testing; |
2257 | ON_CALL(*mock_buffer_stream, buffers_ready_for_compositor()) |
2258 | @@ -245,7 +245,7 @@ |
2259 | EXPECT_TRUE(stub_secondary_db.has_posted_at_least(5, timeout)); |
2260 | } |
2261 | |
2262 | -TEST_F(SurfaceStackCompositor, an_empty_scene_retriggers) |
2263 | +TEST_F(SurfaceStackCompositor, AnEmptySceneRetriggers) |
2264 | { |
2265 | using namespace testing; |
2266 | ON_CALL(*mock_buffer_stream, buffers_ready_for_compositor()) |
2267 | @@ -270,7 +270,7 @@ |
2268 | EXPECT_TRUE(stub_secondary_db.has_posted_at_least(2, timeout)); |
2269 | } |
2270 | |
2271 | -TEST_F(SurfaceStackCompositor, moving_a_surface_triggers_composition) |
2272 | +TEST_F(SurfaceStackCompositor, MovingASurfaceTriggersComposition) |
2273 | { |
2274 | stub_surface->swap_buffers(&stubbuf, [](mg::Buffer*){}); |
2275 | stack.add_surface(stub_surface, default_params.depth, default_params.input_mode); |
2276 | @@ -288,7 +288,7 @@ |
2277 | EXPECT_TRUE(stub_secondary_db.has_posted_at_least(1, timeout)); |
2278 | } |
2279 | |
2280 | -TEST_F(SurfaceStackCompositor, removing_a_surface_triggers_composition) |
2281 | +TEST_F(SurfaceStackCompositor, RemovingASurfaceTriggersComposition) |
2282 | { |
2283 | stub_surface->swap_buffers(&stubbuf, [](mg::Buffer*){}); |
2284 | stack.add_surface(stub_surface, default_params.depth, default_params.input_mode); |
2285 | @@ -306,7 +306,7 @@ |
2286 | EXPECT_TRUE(stub_secondary_db.has_posted_at_least(1, timeout)); |
2287 | } |
2288 | |
2289 | -TEST_F(SurfaceStackCompositor, buffer_updates_trigger_composition) |
2290 | +TEST_F(SurfaceStackCompositor, BufferUpdatesTriggerComposition) |
2291 | { |
2292 | ON_CALL(*mock_buffer_stream, buffers_ready_for_compositor()) |
2293 | .WillByDefault(testing::Return(1)); |
2294 | |
2295 | === modified file 'tests/integration-tests/test_surfaceloop.cpp' |
2296 | --- tests/integration-tests/test_surfaceloop.cpp 2014-10-29 06:21:10 +0000 |
2297 | +++ tests/integration-tests/test_surfaceloop.cpp 2014-11-24 02:31:01 +0000 |
2298 | @@ -242,7 +242,7 @@ |
2299 | } |
2300 | }; |
2301 | |
2302 | -TEST_F(SurfaceLoop, all_created_buffers_are_destroyed) |
2303 | +TEST_F(SurfaceLoop, AllCreatedBuffersAreDestroyed) |
2304 | { |
2305 | for (int i = 0; i != max_surface_count; ++i) |
2306 | mir_connection_create_surface(connection, &request_params, create_surface_callback, ssync+i); |
2307 | @@ -257,7 +257,7 @@ |
2308 | wait_for_surface_release(ssync+i); |
2309 | } |
2310 | |
2311 | -TEST_F(SurfaceLoop, all_created_buffers_are_destroyed_if_client_disconnects_without_releasing_surfaces) |
2312 | +TEST_F(SurfaceLoop, AllCreatedBuffersAreDestroyedIfClientDisconnectsWithoutReleasingSurfaces) |
2313 | { |
2314 | for (int i = 0; i != max_surface_count; ++i) |
2315 | mir_connection_create_surface(connection, &request_params, create_surface_callback, ssync+i); |
2316 | |
2317 | === modified file 'tests/integration-tests/test_swapinterval.cpp' |
2318 | --- tests/integration-tests/test_swapinterval.cpp 2014-10-29 06:21:10 +0000 |
2319 | +++ tests/integration-tests/test_swapinterval.cpp 2014-11-24 02:31:01 +0000 |
2320 | @@ -94,7 +94,7 @@ |
2321 | } |
2322 | |
2323 | using SwapIntervalSignalTest = BespokeDisplayServerTestFixture; |
2324 | -TEST_F(SwapIntervalSignalTest, swapinterval_test) |
2325 | +TEST_F(SwapIntervalSignalTest, SwapintervalTest) |
2326 | { |
2327 | static std::string const swapinterval_set{"swapinterval_set_952f3f10.tmp"}; |
2328 | static std::string const do_client_finish{"do_client_finish_952f3f10.tmp"}; |
2329 | |
2330 | === modified file 'tests/integration-tests/test_test_framework.cpp' |
2331 | --- tests/integration-tests/test_test_framework.cpp 2014-11-03 02:35:50 +0000 |
2332 | +++ tests/integration-tests/test_test_framework.cpp 2014-11-24 02:31:01 +0000 |
2333 | @@ -34,7 +34,7 @@ |
2334 | // We need some tests to prove that errors are reported by the |
2335 | // display server test fixture. But don't want them to fail in |
2336 | // normal builds. |
2337 | -TEST_F(BespokeDisplayServerTestFixture, DISABLED_failing_server_side_test) |
2338 | +TEST_F(BespokeDisplayServerTestFixture, DISABLED_FailingServerSideTest) |
2339 | { |
2340 | struct Server : TestingServerConfiguration |
2341 | { |
2342 | @@ -48,11 +48,11 @@ |
2343 | launch_server_process(fail); |
2344 | } |
2345 | |
2346 | -TEST_F(BespokeDisplayServerTestFixture, DISABLED_failing_without_server) |
2347 | +TEST_F(BespokeDisplayServerTestFixture, DISABLED_FailingWithoutServer) |
2348 | { |
2349 | } |
2350 | |
2351 | -TEST_F(DefaultDisplayServerTestFixture, demonstrate_multiple_clients) |
2352 | +TEST_F(DefaultDisplayServerTestFixture, DemonstrateMultipleClients) |
2353 | { |
2354 | struct Client : TestingClientConfiguration |
2355 | { |
2356 | @@ -79,7 +79,7 @@ |
2357 | }; |
2358 | } |
2359 | |
2360 | -TEST_F(DemoInProcessServer, client_can_connect) |
2361 | +TEST_F(DemoInProcessServer, ClientCanConnect) |
2362 | { |
2363 | auto const connection = mir_connect_sync(new_connection().c_str(), __PRETTY_FUNCTION__); |
2364 | EXPECT_TRUE(mir_connection_is_valid(connection)); |
2365 | |
2366 | === modified file 'tests/performance-tests/test_glmark2-es2-mir.cpp' |
2367 | --- tests/performance-tests/test_glmark2-es2-mir.cpp 2014-10-29 06:21:10 +0000 |
2368 | +++ tests/performance-tests/test_glmark2-es2-mir.cpp 2014-11-24 02:31:01 +0000 |
2369 | @@ -71,7 +71,7 @@ |
2370 | mir::DefaultServerConfiguration config; |
2371 | }; |
2372 | |
2373 | -TEST_F(GLMark2Test, benchmark_fullscreen_default) |
2374 | +TEST_F(GLMark2Test, BenchmarkFullscreenDefault) |
2375 | { |
2376 | run_glmark2("/tmp/glmark2_fullscreen_default.results", raw); |
2377 | } |
2378 | |
2379 | === modified file 'tests/unit-tests/android_input/input_reader.cpp' |
2380 | --- tests/unit-tests/android_input/input_reader.cpp 2014-11-21 12:16:36 +0000 |
2381 | +++ tests/unit-tests/android_input/input_reader.cpp 2014-11-24 02:31:01 +0000 |
2382 | @@ -3438,7 +3438,7 @@ |
2383 | } |
2384 | } |
2385 | |
2386 | -TEST_F(MultiTouchInputMapperTest, DISABLED_Process_NormalMultiTouchGesture_WithoutTrackingIds) { |
2387 | +TEST_F(MultiTouchInputMapperTest, DISABLED__Process_NormalMultiTouchGesture_WithoutTrackingIds) { |
2388 | MultiTouchInputMapper* mapper = new MultiTouchInputMapper(mDevice); |
2389 | addConfigurationProperty("touch.deviceType", "touchScreen"); |
2390 | prepareDisplay(DISPLAY_ORIENTATION_0); |
2391 | |
2392 | === modified file 'tests/unit-tests/android_input/int_set.cpp' |
2393 | --- tests/unit-tests/android_input/int_set.cpp 2013-10-25 13:59:31 +0000 |
2394 | +++ tests/unit-tests/android_input/int_set.cpp 2014-11-24 02:31:01 +0000 |
2395 | @@ -44,7 +44,7 @@ |
2396 | }; |
2397 | } |
2398 | |
2399 | -TEST_F(AndroidInputIntSet, difference) |
2400 | +TEST_F(AndroidInputIntSet, Difference) |
2401 | { |
2402 | IntSet a = {1, 2, 3, 6}; |
2403 | IntSet b = { 2, 3, 4, 5}; |
2404 | @@ -54,7 +54,7 @@ |
2405 | EXPECT_EQ(expected_c, c); |
2406 | } |
2407 | |
2408 | -TEST_F(AndroidInputIntSet, intersection) |
2409 | +TEST_F(AndroidInputIntSet, Intersection) |
2410 | { |
2411 | IntSet a = {1, 2, 3}; |
2412 | IntSet b = { 2, 3, 4, 5}; |
2413 | @@ -64,13 +64,13 @@ |
2414 | EXPECT_EQ(expected_c, c); |
2415 | } |
2416 | |
2417 | -TEST_F(AndroidInputIntSet, first) |
2418 | +TEST_F(AndroidInputIntSet, First) |
2419 | { |
2420 | IntSet a = {4, 2, 1, 3}; |
2421 | EXPECT_EQ(1, a.first()); |
2422 | } |
2423 | |
2424 | -TEST_F(AndroidInputIntSet, remove_set) |
2425 | +TEST_F(AndroidInputIntSet, RemoveSet) |
2426 | { |
2427 | IntSet a = {1, 2, 3, 4}; |
2428 | IntSet b = { 2, 3, 5}; |
2429 | @@ -81,7 +81,7 @@ |
2430 | EXPECT_EQ(expected_a, a); |
2431 | } |
2432 | |
2433 | -TEST_F(AndroidInputIntSet, index_of) |
2434 | +TEST_F(AndroidInputIntSet, IndexOf) |
2435 | { |
2436 | IntSet a = {5, 6, 10, 15}; |
2437 | |
2438 | @@ -89,7 +89,7 @@ |
2439 | EXPECT_EQ(2u, a.indexOf(10)); |
2440 | } |
2441 | |
2442 | -TEST_F(AndroidInputIntSet, for_each) |
2443 | +TEST_F(AndroidInputIntSet, ForEach) |
2444 | { |
2445 | IntSet a = {5, 6, 10, 15}; |
2446 | |
2447 | @@ -103,14 +103,14 @@ |
2448 | EXPECT_EQ(expected_values, actual_values); |
2449 | } |
2450 | |
2451 | -TEST_F(AndroidInputIntSet, to_string) |
2452 | +TEST_F(AndroidInputIntSet, ToString) |
2453 | { |
2454 | IntSet a = {1, 2, 3}; |
2455 | string expected_str = "1, 2, 3"; |
2456 | EXPECT_EQ(expected_str, a.toString()); |
2457 | } |
2458 | |
2459 | -TEST_F(AndroidInputIntSet, unnecessary_constructions) |
2460 | +TEST_F(AndroidInputIntSet, UnnecessaryConstructions) |
2461 | { |
2462 | IntSet a = {1, 2, 3, 6}; |
2463 | IntSet b = { 2, 3, 4, 5}; |
2464 | |
2465 | === modified file 'tests/unit-tests/android_input/property_map.cpp' |
2466 | --- tests/unit-tests/android_input/property_map.cpp 2013-05-03 16:38:07 +0000 |
2467 | +++ tests/unit-tests/android_input/property_map.cpp 2014-11-24 02:31:01 +0000 |
2468 | @@ -60,26 +60,26 @@ |
2469 | }; |
2470 | } |
2471 | |
2472 | -TEST_F(AndroidInputPropertyMap, test_map_created) |
2473 | +TEST_F(AndroidInputPropertyMap, TestMapCreated) |
2474 | { |
2475 | EXPECT_TRUE(test_map); |
2476 | } |
2477 | |
2478 | -TEST_F(AndroidInputPropertyMap, test_map_has_a_string) |
2479 | +TEST_F(AndroidInputPropertyMap, TestMapHasAString) |
2480 | { |
2481 | String8 result; |
2482 | EXPECT_TRUE(test_map->tryGetProperty(String8("test.string"), result)); |
2483 | EXPECT_EQ(String8("a_string"), result); |
2484 | } |
2485 | |
2486 | -TEST_F(AndroidInputPropertyMap, test_map_has_an_int32_t) |
2487 | +TEST_F(AndroidInputPropertyMap, TestMapHasAnInt32T) |
2488 | { |
2489 | int32_t result; |
2490 | EXPECT_TRUE(test_map->tryGetProperty(String8("test.int_32"), result)); |
2491 | EXPECT_EQ(123, result); |
2492 | } |
2493 | |
2494 | -TEST_F(AndroidInputPropertyMap, test_map_has_bools_true_and_false) |
2495 | +TEST_F(AndroidInputPropertyMap, TestMapHasBoolsTrueAndFalse) |
2496 | { |
2497 | bool result{}; |
2498 | EXPECT_TRUE(test_map->tryGetProperty(String8("test.bool.true"), result)); |
2499 | @@ -89,38 +89,38 @@ |
2500 | EXPECT_FALSE(result); |
2501 | } |
2502 | |
2503 | -TEST_F(AndroidInputPropertyMap, test_map_has_a_float) |
2504 | +TEST_F(AndroidInputPropertyMap, TestMapHasAFloat) |
2505 | { |
2506 | float result; |
2507 | EXPECT_TRUE(test_map->tryGetProperty(String8("test.float"), result)); |
2508 | EXPECT_EQ(0.5, result); |
2509 | } |
2510 | |
2511 | -TEST_F(AndroidInputPropertyMap, test_map_fails_to_get_unknown_string) |
2512 | +TEST_F(AndroidInputPropertyMap, TestMapFailsToGetUnknownString) |
2513 | { |
2514 | String8 result; |
2515 | EXPECT_FALSE(test_map->tryGetProperty(String8("unknown"), result)); |
2516 | } |
2517 | |
2518 | -TEST_F(AndroidInputPropertyMap, test_map_fails_to_get_unknown_bool) |
2519 | +TEST_F(AndroidInputPropertyMap, TestMapFailsToGetUnknownBool) |
2520 | { |
2521 | bool result{}; |
2522 | EXPECT_FALSE(test_map->tryGetProperty(String8("unknown"), result)); |
2523 | } |
2524 | |
2525 | -TEST_F(AndroidInputPropertyMap, test_map_fails_to_get_unknown_int32_t) |
2526 | +TEST_F(AndroidInputPropertyMap, TestMapFailsToGetUnknownInt32T) |
2527 | { |
2528 | int32_t result; |
2529 | EXPECT_FALSE(test_map->tryGetProperty(String8("unknown"), result)); |
2530 | } |
2531 | |
2532 | -TEST_F(AndroidInputPropertyMap, test_map_fails_to_get_unknown_float) |
2533 | +TEST_F(AndroidInputPropertyMap, TestMapFailsToGetUnknownFloat) |
2534 | { |
2535 | float result; |
2536 | EXPECT_FALSE(test_map->tryGetProperty(String8("unknown"), result)); |
2537 | } |
2538 | |
2539 | -TEST_F(AndroidInputPropertyMap, test_map_ignores_comment) |
2540 | +TEST_F(AndroidInputPropertyMap, TestMapIgnoresComment) |
2541 | { |
2542 | int32_t result; |
2543 | EXPECT_FALSE(test_map->tryGetProperty(String8("test.int.ignored"), result)); |
2544 | |
2545 | === modified file 'tests/unit-tests/android_input/sha1.cpp' |
2546 | --- tests/unit-tests/android_input/sha1.cpp 2013-02-07 15:31:17 +0000 |
2547 | +++ tests/unit-tests/android_input/sha1.cpp 2014-11-24 02:31:01 +0000 |
2548 | @@ -39,7 +39,7 @@ |
2549 | et malesuada fames ac turpis egestas.)"; |
2550 | } |
2551 | |
2552 | -TEST(AndroidSha1, test) |
2553 | +TEST(AndroidSha1, Test) |
2554 | { |
2555 | EXPECT_STREQ("aa74e4cdc9b384c5e30df0d3ea3cd1121a854ef7", |
2556 | c_str(detail::sha1(String8(test_text)))); |
2557 | |
2558 | === modified file 'tests/unit-tests/android_input/sorted_vector.cpp' |
2559 | --- tests/unit-tests/android_input/sorted_vector.cpp 2013-05-03 16:38:07 +0000 |
2560 | +++ tests/unit-tests/android_input/sorted_vector.cpp 2014-11-24 02:31:01 +0000 |
2561 | @@ -35,18 +35,18 @@ |
2562 | }; |
2563 | } |
2564 | |
2565 | -TEST_F(AndroidInputSortedVector, empty_vector_isEmpty) |
2566 | +TEST_F(AndroidInputSortedVector, EmptyVectorIsEmpty) |
2567 | { |
2568 | EXPECT_TRUE(test_vector.isEmpty()); |
2569 | } |
2570 | |
2571 | -TEST_F(AndroidInputSortedVector, non_empty_vector_not_isEmpty) |
2572 | +TEST_F(AndroidInputSortedVector, NonEmptyVectorNotIsEmpty) |
2573 | { |
2574 | test_vector.add(1); |
2575 | EXPECT_FALSE(test_vector.isEmpty()); |
2576 | } |
2577 | |
2578 | -TEST_F(AndroidInputSortedVector, items_found_at_expected_indexes) |
2579 | +TEST_F(AndroidInputSortedVector, ItemsFoundAtExpectedIndexes) |
2580 | { |
2581 | test_vector.add(3); |
2582 | test_vector.add(1); |
2583 | @@ -61,7 +61,7 @@ |
2584 | EXPECT_EQ(android::NAME_NOT_FOUND, test_vector.indexOf(4)); |
2585 | } |
2586 | |
2587 | -TEST_F(AndroidInputSortedVector, duplicate_adds_create_single_entry) |
2588 | +TEST_F(AndroidInputSortedVector, DuplicateAddsCreateSingleEntry) |
2589 | { |
2590 | test_vector.add(3); |
2591 | test_vector.add(1); |
2592 | @@ -83,7 +83,7 @@ |
2593 | EXPECT_EQ(android::NAME_NOT_FOUND, test_vector.indexOf(4)); |
2594 | } |
2595 | |
2596 | -TEST_F(AndroidInputSortedVector, adds_returns_correct_index) |
2597 | +TEST_F(AndroidInputSortedVector, AddsReturnsCorrectIndex) |
2598 | { |
2599 | EXPECT_EQ(0, test_vector.add(3)); |
2600 | EXPECT_EQ(0, test_vector.add(1)); |
2601 | @@ -96,7 +96,7 @@ |
2602 | EXPECT_EQ(0, test_vector.add(0)); |
2603 | } |
2604 | |
2605 | -TEST_F(AndroidInputSortedVector, missing_items_are_not_found) |
2606 | +TEST_F(AndroidInputSortedVector, MissingItemsAreNotFound) |
2607 | { |
2608 | test_vector.add(3); |
2609 | test_vector.add(1); |
2610 | @@ -106,7 +106,7 @@ |
2611 | EXPECT_EQ(android::NAME_NOT_FOUND, test_vector.indexOf(4)); |
2612 | } |
2613 | |
2614 | -TEST_F(AndroidInputSortedVector, index_gets_expected_items) |
2615 | +TEST_F(AndroidInputSortedVector, IndexGetsExpectedItems) |
2616 | { |
2617 | test_vector.add(30); |
2618 | test_vector.add(10); |
2619 | @@ -119,7 +119,7 @@ |
2620 | EXPECT_EQ(30, test_vector.itemAt(3)); |
2621 | } |
2622 | |
2623 | -TEST_F(AndroidInputSortedVector, edit_changes_item) |
2624 | +TEST_F(AndroidInputSortedVector, EditChangesItem) |
2625 | { |
2626 | test_vector.add(30); |
2627 | test_vector.add(10); |
2628 | @@ -132,7 +132,7 @@ |
2629 | EXPECT_EQ(12, test_vector.itemAt(1)); |
2630 | } |
2631 | |
2632 | -TEST_F(AndroidInputSortedVector, removed_items_are_not_found) |
2633 | +TEST_F(AndroidInputSortedVector, RemovedItemsAreNotFound) |
2634 | { |
2635 | test_vector.add(3); |
2636 | test_vector.add(1); |
2637 | @@ -145,7 +145,7 @@ |
2638 | EXPECT_EQ(android::NAME_NOT_FOUND, test_vector.indexOf(1)); |
2639 | } |
2640 | |
2641 | -TEST_F(AndroidInputSortedVector, remove_unknown_items_is_noop) |
2642 | +TEST_F(AndroidInputSortedVector, RemoveUnknownItemsIsNoop) |
2643 | { |
2644 | test_vector.add(3); |
2645 | test_vector.add(2); |
2646 | @@ -155,7 +155,7 @@ |
2647 | EXPECT_EQ(3u, test_vector.size()); |
2648 | } |
2649 | |
2650 | -TEST_F(AndroidInputSortedVector, item_at_removed_index_are_not_found) |
2651 | +TEST_F(AndroidInputSortedVector, ItemAtRemovedIndexAreNotFound) |
2652 | { |
2653 | test_vector.add(30); |
2654 | test_vector.add(10); |
2655 | @@ -169,7 +169,7 @@ |
2656 | EXPECT_EQ(android::NAME_NOT_FOUND, test_vector.indexOf(10)); |
2657 | } |
2658 | |
2659 | -TEST_F(AndroidInputSortedVector, count_items_at_removed_index_are_not_found) |
2660 | +TEST_F(AndroidInputSortedVector, CountItemsAtRemovedIndexAreNotFound) |
2661 | { |
2662 | test_vector.add(30); |
2663 | test_vector.add(10); |
2664 | @@ -187,7 +187,7 @@ |
2665 | } |
2666 | |
2667 | // Android utils use ALOG_ASSERT - which tends to bomb the program |
2668 | -TEST_F(AndroidInputSortedVector, remove_beyond_end_fails) |
2669 | +TEST_F(AndroidInputSortedVector, RemoveBeyondEndFails) |
2670 | { |
2671 | test_vector.add(30); |
2672 | test_vector.add(10); |
2673 | |
2674 | === modified file 'tests/unit-tests/android_input/string8.cpp' |
2675 | --- tests/unit-tests/android_input/string8.cpp 2013-05-03 16:38:07 +0000 |
2676 | +++ tests/unit-tests/android_input/string8.cpp 2014-11-24 02:31:01 +0000 |
2677 | @@ -24,7 +24,7 @@ |
2678 | |
2679 | using namespace android; |
2680 | |
2681 | -TEST(AndroidString8, appendFormat) |
2682 | +TEST(AndroidString8, AppendFormat) |
2683 | { |
2684 | String8 string; |
2685 | |
2686 | @@ -40,7 +40,7 @@ |
2687 | EXPECT_STREQ("Hello12", c_str(string)); |
2688 | } |
2689 | |
2690 | -TEST(AndroidString8, formatString8) |
2691 | +TEST(AndroidString8, FormatString8) |
2692 | { |
2693 | auto string = formatString8("Hello %s #%02x", "world", 0x42); |
2694 | |
2695 | |
2696 | === modified file 'tests/unit-tests/client/android/test_android_client_platform.cpp' |
2697 | --- tests/unit-tests/client/android/test_android_client_platform.cpp 2014-03-06 06:05:17 +0000 |
2698 | +++ tests/unit-tests/client/android/test_android_client_platform.cpp 2014-11-24 02:31:01 +0000 |
2699 | @@ -29,7 +29,7 @@ |
2700 | namespace mt = mir::test; |
2701 | namespace mtd = mt::doubles; |
2702 | |
2703 | -TEST(AndroidClientPlatformTest, egl_native_display_is_egl_default_display) |
2704 | +TEST(AndroidClientPlatformTest, EglNativeDisplayIsEglDefaultDisplay) |
2705 | { |
2706 | mtd::MockClientContext context; |
2707 | mcl::android::ClientPlatformFactory factory; |
2708 | @@ -40,7 +40,7 @@ |
2709 | EXPECT_EQ(EGL_DEFAULT_DISPLAY, *native_display); |
2710 | } |
2711 | |
2712 | -TEST(AndroidClientPlatformTest, egl_native_window_is_set) |
2713 | +TEST(AndroidClientPlatformTest, EglNativeWindowIsSet) |
2714 | { |
2715 | mtd::MockClientContext context; |
2716 | mcl::android::ClientPlatformFactory factory; |
2717 | |
2718 | === modified file 'tests/unit-tests/client/android/test_android_native_window.cpp' |
2719 | --- tests/unit-tests/client/android/test_android_native_window.cpp 2014-10-29 06:21:10 +0000 |
2720 | +++ tests/unit-tests/client/android/test_android_native_window.cpp 2014-11-24 02:31:01 +0000 |
2721 | @@ -63,7 +63,7 @@ |
2722 | |
2723 | } |
2724 | |
2725 | -TEST_F(AndroidNativeWindowTest, native_window_swapinterval) |
2726 | +TEST_F(AndroidNativeWindowTest, NativeWindowSwapinterval) |
2727 | { |
2728 | using namespace testing; |
2729 | |
2730 | @@ -84,7 +84,7 @@ |
2731 | } |
2732 | |
2733 | /* Query hook tests */ |
2734 | -TEST_F(AndroidNativeWindowTest, native_window_query_hook) |
2735 | +TEST_F(AndroidNativeWindowTest, NativeWindowQueryHook) |
2736 | { |
2737 | using namespace testing; |
2738 | |
2739 | @@ -102,7 +102,7 @@ |
2740 | } |
2741 | |
2742 | /* perform hook tests */ |
2743 | -TEST_F(AndroidNativeWindowTest, native_window_perform_hook_callable) |
2744 | +TEST_F(AndroidNativeWindowTest, NativeWindowPerformHookCallable) |
2745 | { |
2746 | int const format = 4; |
2747 | |
2748 | @@ -114,7 +114,7 @@ |
2749 | } |
2750 | |
2751 | /* setSwapInterval hook tests */ |
2752 | -TEST_F(AndroidNativeWindowTest, native_window_setswapinterval_hook_callable) |
2753 | +TEST_F(AndroidNativeWindowTest, NativeWindowSetswapintervalHookCallable) |
2754 | { |
2755 | int const swap = 2; |
2756 | |
2757 | @@ -123,7 +123,7 @@ |
2758 | } |
2759 | |
2760 | /* dequeue hook tests */ |
2761 | -TEST_F(AndroidNativeWindowTest, native_window_dequeue_hook_callable) |
2762 | +TEST_F(AndroidNativeWindowTest, NativeWindowDequeueHookCallable) |
2763 | { |
2764 | ANativeWindowBuffer* returned_buffer; |
2765 | int fence_fd; |
2766 | @@ -132,7 +132,7 @@ |
2767 | window.dequeueBuffer(&window, &returned_buffer, &fence_fd); |
2768 | } |
2769 | |
2770 | -TEST_F(AndroidNativeWindowTest, native_window_dequeue_returns_right_buffer) |
2771 | +TEST_F(AndroidNativeWindowTest, NativeWindowDequeueReturnsRightBuffer) |
2772 | { |
2773 | using namespace testing; |
2774 | |
2775 | @@ -153,7 +153,7 @@ |
2776 | EXPECT_EQ(fake_fd, fence_fd); |
2777 | } |
2778 | |
2779 | -TEST_F(AndroidNativeWindowTest, native_window_dequeue_returns_previously_cancelled_buffer) |
2780 | +TEST_F(AndroidNativeWindowTest, NativeWindowDequeueReturnsPreviouslyCancelledBuffer) |
2781 | { |
2782 | using namespace testing; |
2783 | ANativeWindowBuffer buffer; |
2784 | @@ -171,7 +171,7 @@ |
2785 | EXPECT_EQ(dequeued_buffer, expected_buffer); |
2786 | } |
2787 | |
2788 | -TEST_F(AndroidNativeWindowTest, native_window_dequeue_deprecated_hook_callable) |
2789 | +TEST_F(AndroidNativeWindowTest, NativeWindowDequeueDeprecatedHookCallable) |
2790 | { |
2791 | ANativeWindowBuffer* tmp; |
2792 | |
2793 | @@ -179,7 +179,7 @@ |
2794 | window.dequeueBuffer_DEPRECATED(&window, &tmp); |
2795 | } |
2796 | |
2797 | -TEST_F(AndroidNativeWindowTest, native_window_dequeue_deprecated_returns_right_buffer) |
2798 | +TEST_F(AndroidNativeWindowTest, NativeWindowDequeueDeprecatedReturnsRightBuffer) |
2799 | { |
2800 | using namespace testing; |
2801 | |
2802 | @@ -198,7 +198,7 @@ |
2803 | EXPECT_EQ(mock_buffer->anwb(), returned_buffer); |
2804 | } |
2805 | |
2806 | -TEST_F(AndroidNativeWindowTest, native_window_dequeue_deprecated_returns_previously_cancelled_buffer) |
2807 | +TEST_F(AndroidNativeWindowTest, NativeWindowDequeueDeprecatedReturnsPreviouslyCancelledBuffer) |
2808 | { |
2809 | using namespace testing; |
2810 | ANativeWindowBuffer buffer; |
2811 | @@ -216,7 +216,7 @@ |
2812 | } |
2813 | |
2814 | /* queue hook tests */ |
2815 | -TEST_F(AndroidNativeWindowTest, native_window_queue_hook_callable) |
2816 | +TEST_F(AndroidNativeWindowTest, NativeWindowQueueHookCallable) |
2817 | { |
2818 | ANativeWindowBuffer* tmp = nullptr; |
2819 | |
2820 | @@ -224,7 +224,7 @@ |
2821 | window.queueBuffer(&window, tmp, -1); |
2822 | } |
2823 | |
2824 | -TEST_F(AndroidNativeWindowTest, native_window_queue_passes_buffer_back) |
2825 | +TEST_F(AndroidNativeWindowTest, NativeWindowQueuePassesBufferBack) |
2826 | { |
2827 | using namespace testing; |
2828 | ANativeWindowBuffer buffer; |
2829 | @@ -236,7 +236,7 @@ |
2830 | window.queueBuffer(&window, &buffer, fence_fd); |
2831 | } |
2832 | |
2833 | -TEST_F(AndroidNativeWindowTest, native_window_queue_deprecated_hook_callable) |
2834 | +TEST_F(AndroidNativeWindowTest, NativeWindowQueueDeprecatedHookCallable) |
2835 | { |
2836 | ANativeWindowBuffer* tmp = nullptr; |
2837 | |
2838 | @@ -244,7 +244,7 @@ |
2839 | window.queueBuffer_DEPRECATED(&window, tmp); |
2840 | } |
2841 | |
2842 | -TEST_F(AndroidNativeWindowTest, native_window_queue_deprecated_passes_buffer_back) |
2843 | +TEST_F(AndroidNativeWindowTest, NativeWindowQueueDeprecatedPassesBufferBack) |
2844 | { |
2845 | using namespace testing; |
2846 | ANativeWindowBuffer buffer; |
2847 | @@ -256,7 +256,7 @@ |
2848 | } |
2849 | |
2850 | /* cancel hook tests */ |
2851 | -TEST_F(AndroidNativeWindowTest, native_window_cancel_hooks_callable) |
2852 | +TEST_F(AndroidNativeWindowTest, NativeWindowCancelHooksCallable) |
2853 | { |
2854 | ANativeWindowBuffer* tmp = nullptr; |
2855 | |
2856 | @@ -267,7 +267,7 @@ |
2857 | } |
2858 | |
2859 | /* lock hook tests */ |
2860 | -TEST_F(AndroidNativeWindowTest, native_window_lock_hook_callable) |
2861 | +TEST_F(AndroidNativeWindowTest, NativeWindowLockHookCallable) |
2862 | { |
2863 | ANativeWindowBuffer* tmp = 0x0; |
2864 | |
2865 | @@ -275,19 +275,19 @@ |
2866 | window.lockBuffer_DEPRECATED(&window, tmp); |
2867 | } |
2868 | |
2869 | -TEST_F(AndroidNativeWindowTest, native_window_incref_hook_callable) |
2870 | +TEST_F(AndroidNativeWindowTest, NativeWindowIncrefHookCallable) |
2871 | { |
2872 | ASSERT_NE(nullptr, window.common.incRef); |
2873 | window.common.incRef(NULL); |
2874 | } |
2875 | |
2876 | -TEST_F(AndroidNativeWindowTest, native_window_decref_hook_callable) |
2877 | +TEST_F(AndroidNativeWindowTest, NativeWindowDecrefHookCallable) |
2878 | { |
2879 | ASSERT_NE(nullptr, window.common.decRef); |
2880 | window.common.decRef(NULL); |
2881 | } |
2882 | |
2883 | -TEST_F(AndroidNativeWindowTest, native_window_dequeue_deprecated_has_proper_rc) |
2884 | +TEST_F(AndroidNativeWindowTest, NativeWindowDequeueDeprecatedHasProperRc) |
2885 | { |
2886 | ANativeWindowBuffer* tmp; |
2887 | |
2888 | @@ -295,7 +295,7 @@ |
2889 | EXPECT_EQ(0, ret); |
2890 | } |
2891 | |
2892 | -TEST_F(AndroidNativeWindowTest, native_window_dequeue_has_proper_rc) |
2893 | +TEST_F(AndroidNativeWindowTest, NativeWindowDequeueHasProperRc) |
2894 | { |
2895 | ANativeWindowBuffer* tmp; |
2896 | int fencefd; |
2897 | @@ -304,7 +304,7 @@ |
2898 | EXPECT_EQ(0, ret); |
2899 | } |
2900 | |
2901 | -TEST_F(AndroidNativeWindowTest, native_window_cancel_hook_does_not_call_driver_interpreter) |
2902 | +TEST_F(AndroidNativeWindowTest, NativeWindowCancelHookDoesNotCallDriverInterpreter) |
2903 | { |
2904 | using namespace testing; |
2905 | ANativeWindowBuffer buffer; |
2906 | @@ -317,7 +317,7 @@ |
2907 | EXPECT_EQ(0, rc); |
2908 | } |
2909 | |
2910 | -TEST_F(AndroidNativeWindowTest, returns_error_on_dequeue_buffer_failure) |
2911 | +TEST_F(AndroidNativeWindowTest, ReturnsErrorOnDequeueBufferFailure) |
2912 | { |
2913 | using namespace testing; |
2914 | |
2915 | @@ -329,7 +329,7 @@ |
2916 | EXPECT_THAT(window.dequeueBuffer_DEPRECATED(&window, nullptr), Eq(failure_code)); |
2917 | } |
2918 | |
2919 | -TEST_F(AndroidNativeWindowTest, returns_error_on_queue_buffer_failure) |
2920 | +TEST_F(AndroidNativeWindowTest, ReturnsErrorOnQueueBufferFailure) |
2921 | { |
2922 | using namespace testing; |
2923 | |
2924 | @@ -341,7 +341,7 @@ |
2925 | EXPECT_THAT(window.queueBuffer_DEPRECATED(&window, nullptr), Eq(failure_code)); |
2926 | } |
2927 | |
2928 | -TEST_F(AndroidNativeWindowTest, returns_error_on_query_failure) |
2929 | +TEST_F(AndroidNativeWindowTest, ReturnsErrorOnQueryFailure) |
2930 | { |
2931 | using namespace testing; |
2932 | |
2933 | @@ -351,7 +351,7 @@ |
2934 | EXPECT_THAT(window.query(&window, 0, nullptr), Eq(failure_code)); |
2935 | } |
2936 | |
2937 | -TEST_F(AndroidNativeWindowTest, returns_error_on_perform_failure) |
2938 | +TEST_F(AndroidNativeWindowTest, ReturnsErrorOnPerformFailure) |
2939 | { |
2940 | using namespace testing; |
2941 | |
2942 | |
2943 | === modified file 'tests/unit-tests/client/android/test_buffer.cpp' |
2944 | --- tests/unit-tests/client/android/test_buffer.cpp 2014-11-03 02:35:50 +0000 |
2945 | +++ tests/unit-tests/client/android/test_buffer.cpp 2014-11-24 02:31:01 +0000 |
2946 | @@ -58,7 +58,7 @@ |
2947 | MirBufferPackage package; |
2948 | }; |
2949 | |
2950 | -TEST_F(AndroidClientBuffer, registers_native_handle_with_correct_size) |
2951 | +TEST_F(AndroidClientBuffer, RegistersNativeHandleWithCorrectSize) |
2952 | { |
2953 | EXPECT_CALL(*mock_registrar, register_buffer(testing::_, testing::_)) |
2954 | .WillOnce(testing::Return(mock_native_buffer)); |
2955 | @@ -69,7 +69,7 @@ |
2956 | EXPECT_EQ(stride, buffer.stride()); |
2957 | } |
2958 | |
2959 | -TEST_F(AndroidClientBuffer, packs_memory_region_correctly) |
2960 | +TEST_F(AndroidClientBuffer, PacksMemoryRegionCorrectly) |
2961 | { |
2962 | using namespace testing; |
2963 | geom::Rectangle rect{{0,0}, size}; |
2964 | @@ -87,7 +87,7 @@ |
2965 | EXPECT_EQ(pf, region->format); |
2966 | } |
2967 | |
2968 | -TEST_F(AndroidClientBuffer, update_from_package_merges_fence_when_present) |
2969 | +TEST_F(AndroidClientBuffer, UpdateFromPackageMergesFenceWhenPresent) |
2970 | { |
2971 | mga::NativeFence fake_fence{213}; |
2972 | EXPECT_CALL(*mock_native_buffer, update_usage(fake_fence, mga::BufferAccess::read)) |
2973 | @@ -104,7 +104,7 @@ |
2974 | buffer.update_from(package); |
2975 | } |
2976 | |
2977 | -TEST_F(AndroidClientBuffer, fills_update_msg) |
2978 | +TEST_F(AndroidClientBuffer, FillsUpdateMsg) |
2979 | { |
2980 | using namespace testing; |
2981 | using mir::graphics::android::BufferFlag; |
2982 | |
2983 | === modified file 'tests/unit-tests/client/android/test_client_surface_interpreter.cpp' |
2984 | --- tests/unit-tests/client/android/test_client_surface_interpreter.cpp 2014-10-29 06:21:10 +0000 |
2985 | +++ tests/unit-tests/client/android/test_client_surface_interpreter.cpp 2014-11-24 02:31:01 +0000 |
2986 | @@ -99,7 +99,7 @@ |
2987 | std::shared_ptr<MockClientBuffer> mock_client_buffer; |
2988 | }; |
2989 | |
2990 | -TEST_F(AndroidInterpreter, gets_buffer_via_the_surface_on_request) |
2991 | +TEST_F(AndroidInterpreter, GetsBufferViaTheSurfaceOnRequest) |
2992 | { |
2993 | using namespace testing; |
2994 | testing::NiceMock<MockMirSurface> mock_surface{surf_params}; |
2995 | @@ -112,7 +112,7 @@ |
2996 | interpreter.driver_requests_buffer(); |
2997 | } |
2998 | |
2999 | -TEST_F(AndroidInterpreter, gets_native_handle_from_returned_buffer) |
3000 | +TEST_F(AndroidInterpreter, GetsNativeHandleFromReturnedBuffer) |
3001 | { |
3002 | using namespace testing; |
3003 | auto buffer = std::make_shared<mtd::StubAndroidNativeBuffer>(); |
3004 | @@ -131,7 +131,7 @@ |
3005 | EXPECT_EQ(buffer.get(), returned_buffer); |
3006 | } |
3007 | |
3008 | -TEST_F(AndroidInterpreter, advances_surface_on_buffer_return) |
3009 | +TEST_F(AndroidInterpreter, AdvancesSurfaceOnBufferReturn) |
3010 | { |
3011 | using namespace testing; |
3012 | ANativeWindowBuffer buffer; |
3013 | @@ -146,7 +146,7 @@ |
3014 | } |
3015 | |
3016 | /* format is an int that is set by the driver. these are not the HAL_PIXEL_FORMATS in android */ |
3017 | -TEST_F(AndroidInterpreter, remembers_format) |
3018 | +TEST_F(AndroidInterpreter, RemembersFormat) |
3019 | { |
3020 | int format = 945; |
3021 | testing::NiceMock<MockMirSurface> mock_surface{surf_params}; |
3022 | @@ -158,7 +158,7 @@ |
3023 | EXPECT_EQ(format, tmp_format); |
3024 | } |
3025 | |
3026 | -TEST_F(AndroidInterpreter, returns_no_transform_for_transform_hint_query) |
3027 | +TEST_F(AndroidInterpreter, ReturnsNoTransformForTransformHintQuery) |
3028 | { |
3029 | testing::NiceMock<MockMirSurface> mock_surface{surf_params}; |
3030 | mcla::ClientSurfaceInterpreter interpreter(mock_surface); |
3031 | @@ -170,7 +170,7 @@ |
3032 | EXPECT_EQ(transform_hint_zero, transform); |
3033 | } |
3034 | |
3035 | -TEST_F(AndroidInterpreter, returns_width_as_default_width) |
3036 | +TEST_F(AndroidInterpreter, ReturnsWidthAsDefaultWidth) |
3037 | { |
3038 | testing::NiceMock<MockMirSurface> mock_surface{surf_params}; |
3039 | mcla::ClientSurfaceInterpreter interpreter(mock_surface); |
3040 | @@ -180,7 +180,7 @@ |
3041 | EXPECT_EQ(surf_params.width, default_width); |
3042 | } |
3043 | |
3044 | -TEST_F(AndroidInterpreter, returns_height_as_default_height) |
3045 | +TEST_F(AndroidInterpreter, ReturnsHeightAsDefaultHeight) |
3046 | { |
3047 | testing::NiceMock<MockMirSurface> mock_surface{surf_params}; |
3048 | mcla::ClientSurfaceInterpreter interpreter(mock_surface); |
3049 | @@ -190,7 +190,7 @@ |
3050 | EXPECT_EQ(surf_params.height, default_height); |
3051 | } |
3052 | |
3053 | -TEST_F(AndroidInterpreter, returns_surface_as_concrete_type) |
3054 | +TEST_F(AndroidInterpreter, ReturnsSurfaceAsConcreteType) |
3055 | { |
3056 | testing::NiceMock<MockMirSurface> mock_surface{surf_params}; |
3057 | mcla::ClientSurfaceInterpreter interpreter(mock_surface); |
3058 | @@ -199,7 +199,7 @@ |
3059 | EXPECT_EQ(NATIVE_WINDOW_SURFACE, concrete_type); |
3060 | } |
3061 | |
3062 | -TEST_F(AndroidInterpreter, returns_width) |
3063 | +TEST_F(AndroidInterpreter, ReturnsWidth) |
3064 | { |
3065 | testing::NiceMock<MockMirSurface> mock_surface{surf_params}; |
3066 | mcla::ClientSurfaceInterpreter interpreter(mock_surface); |
3067 | @@ -209,7 +209,7 @@ |
3068 | EXPECT_EQ(surf_params.width, width); |
3069 | } |
3070 | |
3071 | -TEST_F(AndroidInterpreter, returns_height) |
3072 | +TEST_F(AndroidInterpreter, ReturnsHeight) |
3073 | { |
3074 | testing::NiceMock<MockMirSurface> mock_surface{surf_params}; |
3075 | mcla::ClientSurfaceInterpreter interpreter(mock_surface); |
3076 | @@ -226,7 +226,7 @@ |
3077 | to keep 2 buffers on hand at all time, the driver might dequeue 5 buffers, then cancel those 5 buffers. |
3078 | After the first call to queueBuffer however, the client may never own more than the number it has |
3079 | reserved (in this case, 3 buffers) */ |
3080 | -TEST_F(AndroidInterpreter, returns_2_for_min_undequeued_query) |
3081 | +TEST_F(AndroidInterpreter, Returns_2ForMinUndequeuedQuery) |
3082 | { |
3083 | testing::NiceMock<MockMirSurface> mock_surface{surf_params}; |
3084 | mcla::ClientSurfaceInterpreter interpreter(mock_surface); |
3085 | @@ -235,7 +235,7 @@ |
3086 | EXPECT_EQ(2, num_buffers); |
3087 | } |
3088 | |
3089 | -TEST_F(AndroidInterpreter, requests_swapinterval_change) |
3090 | +TEST_F(AndroidInterpreter, RequestsSwapintervalChange) |
3091 | { |
3092 | testing::NiceMock<MockMirSurface> mock_surface{surf_params}; |
3093 | testing::InSequence seq; |
3094 | |
3095 | === modified file 'tests/unit-tests/client/android/test_gralloc_registrar.cpp' |
3096 | --- tests/unit-tests/client/android/test_gralloc_registrar.cpp 2014-11-03 02:35:50 +0000 |
3097 | +++ tests/unit-tests/client/android/test_gralloc_registrar.cpp 2014-11-24 02:31:01 +0000 |
3098 | @@ -111,7 +111,7 @@ |
3099 | std::shared_ptr<mtd::MockAndroidNativeBuffer> const mock_native_buffer; |
3100 | }; |
3101 | |
3102 | -TEST_F(GrallocRegistrar, client_buffer_converts_stub_package) |
3103 | +TEST_F(GrallocRegistrar, ClientBufferConvertsStubPackage) |
3104 | { |
3105 | int const flag_offset{1}; |
3106 | mcla::GrallocRegistrar registrar(mock_module); |
3107 | @@ -127,14 +127,14 @@ |
3108 | EXPECT_EQ(stub_package.data[i + flag_offset], handle->data[i + stub_package.fd_items]); |
3109 | } |
3110 | |
3111 | -TEST_F(GrallocRegistrar, client_sets_correct_version) |
3112 | +TEST_F(GrallocRegistrar, ClientSetsCorrectVersion) |
3113 | { |
3114 | mcla::GrallocRegistrar registrar(mock_module); |
3115 | auto buffer = registrar.register_buffer(stub_package, pf); |
3116 | EXPECT_EQ(buffer->handle()->version, static_cast<int>(sizeof(native_handle_t))); |
3117 | } |
3118 | |
3119 | -TEST_F(GrallocRegistrar, registrar_registers_using_module) |
3120 | +TEST_F(GrallocRegistrar, RegistrarRegistersUsingModule) |
3121 | { |
3122 | using namespace testing; |
3123 | native_handle_t const* handle1 = nullptr; |
3124 | @@ -155,7 +155,7 @@ |
3125 | EXPECT_EQ(handle1, handle2); |
3126 | } |
3127 | |
3128 | -TEST_F(GrallocRegistrar, registrar_frees_fds) |
3129 | +TEST_F(GrallocRegistrar, RegistrarFreesFds) |
3130 | { |
3131 | using namespace testing; |
3132 | MirBufferPackage stub_package; |
3133 | @@ -174,7 +174,7 @@ |
3134 | } |
3135 | |
3136 | |
3137 | -TEST_F(GrallocRegistrar, register_failure) |
3138 | +TEST_F(GrallocRegistrar, RegisterFailure) |
3139 | { |
3140 | using namespace testing; |
3141 | EXPECT_CALL(*mock_module, registerBuffer_interface(_, _)) |
3142 | @@ -189,7 +189,7 @@ |
3143 | }, std::runtime_error); |
3144 | } |
3145 | |
3146 | -TEST_F(GrallocRegistrar, region_is_cleaned_up_correctly) |
3147 | +TEST_F(GrallocRegistrar, RegionIsCleanedUpCorrectly) |
3148 | { |
3149 | using namespace testing; |
3150 | mcla::GrallocRegistrar registrar(mock_module); |
3151 | @@ -219,7 +219,7 @@ |
3152 | EXPECT_EQ(handle_alloc, handle_freed); |
3153 | } |
3154 | |
3155 | -TEST_F(GrallocRegistrar, maps_buffer_for_cpu_correctly) |
3156 | +TEST_F(GrallocRegistrar, MapsBufferForCpuCorrectly) |
3157 | { |
3158 | EXPECT_CALL(*mock_module, lock_interface( |
3159 | mock_module.get(), |
3160 | @@ -236,7 +236,7 @@ |
3161 | registrar.secure_for_cpu(mock_native_buffer, rect); |
3162 | } |
3163 | |
3164 | -TEST_F(GrallocRegistrar, lock_failure_throws) |
3165 | +TEST_F(GrallocRegistrar, LockFailureThrows) |
3166 | { |
3167 | using namespace testing; |
3168 | EXPECT_CALL(*mock_module, lock_interface(_,_,_,_,_,_,_,_)) |
3169 | @@ -251,7 +251,7 @@ |
3170 | } |
3171 | |
3172 | /* unlock is called in destructor. should not throw */ |
3173 | -TEST_F(GrallocRegistrar, unlock_failure_doesnt_throw) |
3174 | +TEST_F(GrallocRegistrar, UnlockFailureDoesntThrow) |
3175 | { |
3176 | using namespace testing; |
3177 | EXPECT_CALL(*mock_module, unlock_interface(_,_)) |
3178 | @@ -265,7 +265,7 @@ |
3179 | }); |
3180 | } |
3181 | |
3182 | -TEST_F(GrallocRegistrar, produces_valid_anwb) |
3183 | +TEST_F(GrallocRegistrar, ProducesValidAnwb) |
3184 | { |
3185 | using namespace testing; |
3186 | mcla::GrallocRegistrar registrar(mock_module); |
3187 | |
3188 | === modified file 'tests/unit-tests/client/input/test_android_input_receiver.cpp' |
3189 | --- tests/unit-tests/client/input/test_android_input_receiver.cpp 2014-10-29 06:21:10 +0000 |
3190 | +++ tests/unit-tests/client/input/test_android_input_receiver.cpp 2014-11-24 02:31:01 +0000 |
3191 | @@ -146,14 +146,14 @@ |
3192 | |
3193 | } |
3194 | |
3195 | -TEST_F(AndroidInputReceiverSetup, receiever_takes_channel_fd) |
3196 | +TEST_F(AndroidInputReceiverSetup, ReceieverTakesChannelFd) |
3197 | { |
3198 | mircva::InputReceiver receiver(client_fd, std::make_shared<mircv::NullInputReceiverReport>()); |
3199 | |
3200 | EXPECT_EQ(client_fd, receiver.fd()); |
3201 | } |
3202 | |
3203 | -TEST_F(AndroidInputReceiverSetup, receiver_receives_key_events) |
3204 | +TEST_F(AndroidInputReceiverSetup, ReceiverReceivesKeyEvents) |
3205 | { |
3206 | mircva::InputReceiver receiver(client_fd, std::make_shared<mircv::NullInputReceiverReport>()); |
3207 | TestingInputProducer producer(server_fd); |
3208 | @@ -169,7 +169,7 @@ |
3209 | EXPECT_EQ(producer.testing_key_event_scan_code, ev.key.scan_code); |
3210 | } |
3211 | |
3212 | -TEST_F(AndroidInputReceiverSetup, receiver_handles_events) |
3213 | +TEST_F(AndroidInputReceiverSetup, ReceiverHandlesEvents) |
3214 | { |
3215 | mircva::InputReceiver receiver(client_fd, std::make_shared<mircv::NullInputReceiverReport>()); |
3216 | TestingInputProducer producer(server_fd); |
3217 | @@ -185,7 +185,7 @@ |
3218 | EXPECT_TRUE (producer.must_receive_handled_signal()); |
3219 | } |
3220 | |
3221 | -TEST_F(AndroidInputReceiverSetup, receiver_consumes_batched_motion_events) |
3222 | +TEST_F(AndroidInputReceiverSetup, ReceiverConsumesBatchedMotionEvents) |
3223 | { |
3224 | mircva::InputReceiver receiver(client_fd, std::make_shared<mircv::NullInputReceiverReport>()); |
3225 | TestingInputProducer producer(server_fd); |
3226 | @@ -204,7 +204,7 @@ |
3227 | EXPECT_FALSE(receiver.next_event(std::chrono::milliseconds(1), ev)); // Minimal timeout needed for valgrind |
3228 | } |
3229 | |
3230 | -TEST_F(AndroidInputReceiverSetup, slow_raw_input_doesnt_cause_frameskipping) |
3231 | +TEST_F(AndroidInputReceiverSetup, SlowRawInputDoesntCauseFrameskipping) |
3232 | { // Regression test for LP: #1372300 |
3233 | using namespace testing; |
3234 | using namespace std::chrono; |
3235 | @@ -252,7 +252,7 @@ |
3236 | ASSERT_EQ(mir_event_type_motion, ev.type); |
3237 | } |
3238 | |
3239 | -TEST_F(AndroidInputReceiverSetup, rendering_does_not_lag_behind_input) |
3240 | +TEST_F(AndroidInputReceiverSetup, RenderingDoesNotLagBehindInput) |
3241 | { |
3242 | using namespace testing; |
3243 | |
3244 | @@ -300,7 +300,7 @@ |
3245 | EXPECT_THAT(average_lag_milliseconds, Le(1)); |
3246 | } |
3247 | |
3248 | -TEST_F(AndroidInputReceiverSetup, input_comes_in_phase_with_rendering) |
3249 | +TEST_F(AndroidInputReceiverSetup, InputComesInPhaseWithRendering) |
3250 | { |
3251 | using namespace testing; |
3252 | |
3253 | |
3254 | === modified file 'tests/unit-tests/client/input/test_android_input_receiver_thread.cpp' |
3255 | --- tests/unit-tests/client/input/test_android_input_receiver_thread.cpp 2014-10-29 06:21:10 +0000 |
3256 | +++ tests/unit-tests/client/input/test_android_input_receiver_thread.cpp 2014-11-24 02:31:01 +0000 |
3257 | @@ -76,7 +76,7 @@ |
3258 | |
3259 | } |
3260 | |
3261 | -TEST_F(AndroidInputReceiverThreadSetup, reads_events_until_stopped) |
3262 | +TEST_F(AndroidInputReceiverThreadSetup, ReadsEventsUntilStopped) |
3263 | { |
3264 | using namespace ::testing; |
3265 | |
3266 | @@ -92,7 +92,7 @@ |
3267 | input_thread.join(); |
3268 | } |
3269 | |
3270 | -TEST_F(AndroidInputReceiverThreadSetup, receives_and_dispatches_available_events_when_ready) |
3271 | +TEST_F(AndroidInputReceiverThreadSetup, ReceivesAndDispatchesAvailableEventsWhenReady) |
3272 | { |
3273 | using namespace ::testing; |
3274 | MockEventHandler mock_handler; |
3275 | @@ -122,7 +122,7 @@ |
3276 | input_thread.join(); |
3277 | } |
3278 | |
3279 | -TEST_F(AndroidInputReceiverThreadSetup, input_callback_invoked_from_thread) |
3280 | +TEST_F(AndroidInputReceiverThreadSetup, InputCallbackInvokedFromThread) |
3281 | { |
3282 | using namespace ::testing; |
3283 | MockEventHandler mock_handler; |
3284 | |
3285 | === modified file 'tests/unit-tests/client/input/test_xkb_mapper.cpp' |
3286 | --- tests/unit-tests/client/input/test_xkb_mapper.cpp 2014-03-06 06:05:17 +0000 |
3287 | +++ tests/unit-tests/client/input/test_xkb_mapper.cpp 2014-11-24 02:31:01 +0000 |
3288 | @@ -54,7 +54,7 @@ |
3289 | |
3290 | } |
3291 | |
3292 | -TEST(XKBMapper, maps_generic_us_english_keys) |
3293 | +TEST(XKBMapper, MapsGenericUsEnglishKeys) |
3294 | { |
3295 | mircv::XKBMapper mapper; |
3296 | |
3297 | @@ -66,7 +66,7 @@ |
3298 | EXPECT_EQ(XKB_KEY_4, map_key(mapper, mir_key_action_down, KEY_4)); |
3299 | } |
3300 | |
3301 | -TEST(XKBMapper, key_action_multiple_does_not_update_modifier_state) |
3302 | +TEST(XKBMapper, KeyActionMultipleDoesNotUpdateModifierState) |
3303 | { |
3304 | mircv::XKBMapper mapper; |
3305 | |
3306 | @@ -74,7 +74,7 @@ |
3307 | EXPECT_EQ(XKB_KEY_7, map_key(mapper, mir_key_action_down, KEY_7)); |
3308 | } |
3309 | |
3310 | -TEST(XKBMapper, key_repeats_do_not_recurse_modifier_state) |
3311 | +TEST(XKBMapper, KeyRepeatsDoNotRecurseModifierState) |
3312 | { |
3313 | mircv::XKBMapper mapper; |
3314 | |
3315 | |
3316 | === modified file 'tests/unit-tests/client/mesa/test_client_buffer.cpp' |
3317 | --- tests/unit-tests/client/mesa/test_client_buffer.cpp 2014-10-21 19:10:52 +0000 |
3318 | +++ tests/unit-tests/client/mesa/test_client_buffer.cpp 2014-11-24 02:31:01 +0000 |
3319 | @@ -75,7 +75,7 @@ |
3320 | |
3321 | } |
3322 | |
3323 | -TEST_F(MesaClientBufferTest, width_and_height) |
3324 | +TEST_F(MesaClientBufferTest, WidthAndHeight) |
3325 | { |
3326 | using namespace testing; |
3327 | |
3328 | @@ -86,7 +86,7 @@ |
3329 | EXPECT_EQ(buffer.pixel_format(), pf); |
3330 | } |
3331 | |
3332 | -TEST_F(MesaClientBufferTest, buffer_returns_correct_stride) |
3333 | +TEST_F(MesaClientBufferTest, BufferReturnsCorrectStride) |
3334 | { |
3335 | using namespace testing; |
3336 | |
3337 | @@ -95,7 +95,7 @@ |
3338 | EXPECT_EQ(buffer.stride(), stride); |
3339 | } |
3340 | |
3341 | -TEST_F(MesaClientBufferTest, buffer_returns_set_package) |
3342 | +TEST_F(MesaClientBufferTest, BufferReturnsSetPackage) |
3343 | { |
3344 | using namespace testing; |
3345 | |
3346 | @@ -111,7 +111,7 @@ |
3347 | EXPECT_EQ(package_return->fd[i], package_copy->fd[i]); |
3348 | } |
3349 | |
3350 | -TEST_F(MesaClientBufferTest, secure_for_cpu_write_maps_buffer_fd) |
3351 | +TEST_F(MesaClientBufferTest, SecureForCpuWriteMapsBufferFd) |
3352 | { |
3353 | using namespace testing; |
3354 | void *map_addr{reinterpret_cast<void*>(0xabcdef)}; |
3355 | @@ -133,7 +133,7 @@ |
3356 | ASSERT_EQ(pf, mem_region->format); |
3357 | } |
3358 | |
3359 | -TEST_F(MesaClientBufferTest, secure_for_cpu_write_throws_on_map_failure) |
3360 | +TEST_F(MesaClientBufferTest, SecureForCpuWriteThrowsOnMapFailure) |
3361 | { |
3362 | using namespace testing; |
3363 | |
3364 | @@ -151,7 +151,7 @@ |
3365 | }, std::runtime_error); |
3366 | } |
3367 | |
3368 | -TEST_F(MesaClientBufferTest, buffer_fd_closed_on_buffer_destruction) |
3369 | +TEST_F(MesaClientBufferTest, BufferFdClosedOnBufferDestruction) |
3370 | { |
3371 | using namespace testing; |
3372 | |
3373 | @@ -161,7 +161,7 @@ |
3374 | mclg::ClientBuffer buffer(buffer_file_ops, package, size, pf); |
3375 | } |
3376 | |
3377 | -TEST_F(MesaClientBufferTest, factory_gets_size_from_package) |
3378 | +TEST_F(MesaClientBufferTest, FactoryGetsSizeFromPackage) |
3379 | { |
3380 | using namespace testing; |
3381 | |
3382 | @@ -177,7 +177,7 @@ |
3383 | EXPECT_NE(unused_size, buf_size); |
3384 | } |
3385 | |
3386 | -TEST_F(MesaClientBufferTest, creation_with_invalid_buffer_package_throws) |
3387 | +TEST_F(MesaClientBufferTest, CreationWithInvalidBufferPackageThrows) |
3388 | { |
3389 | using namespace testing; |
3390 | |
3391 | @@ -191,7 +191,7 @@ |
3392 | }, std::runtime_error); |
3393 | } |
3394 | |
3395 | -TEST_F(MesaClientBufferTest, packs_empty_update_msg) |
3396 | +TEST_F(MesaClientBufferTest, PacksEmptyUpdateMsg) |
3397 | { |
3398 | using namespace testing; |
3399 | mclg::ClientBuffer buffer(buffer_file_ops, package, size, pf); |
3400 | |
3401 | === modified file 'tests/unit-tests/client/mesa/test_client_platform.cpp' |
3402 | --- tests/unit-tests/client/mesa/test_client_platform.cpp 2014-03-06 06:05:17 +0000 |
3403 | +++ tests/unit-tests/client/mesa/test_client_platform.cpp 2014-11-24 02:31:01 +0000 |
3404 | @@ -31,7 +31,7 @@ |
3405 | namespace mt = mir::test; |
3406 | namespace mtd = mir::test::doubles; |
3407 | |
3408 | -TEST(MesaClientPlatformTest, egl_native_display_is_valid_until_released) |
3409 | +TEST(MesaClientPlatformTest, EglNativeDisplayIsValidUntilReleased) |
3410 | { |
3411 | mtd::MockClientContext context; |
3412 | mclm::ClientPlatformFactory factory; |
3413 | |
3414 | === modified file 'tests/unit-tests/client/mesa/test_mesa_native_display_container.cpp' |
3415 | --- tests/unit-tests/client/mesa/test_mesa_native_display_container.cpp 2014-03-06 06:05:17 +0000 |
3416 | +++ tests/unit-tests/client/mesa/test_mesa_native_display_container.cpp 2014-11-24 02:31:01 +0000 |
3417 | @@ -45,7 +45,7 @@ |
3418 | |
3419 | } |
3420 | |
3421 | -TEST_F(MesaNativeDisplayContainerSetup, valid_displays_come_from_factory) |
3422 | +TEST_F(MesaNativeDisplayContainerSetup, ValidDisplaysComeFromFactory) |
3423 | { |
3424 | using namespace ::testing; |
3425 | |
3426 | @@ -56,7 +56,7 @@ |
3427 | EXPECT_FALSE(container->validate(&invalid_native_display)); |
3428 | } |
3429 | |
3430 | -TEST_F(MesaNativeDisplayContainerSetup, releasing_displays_invalidates_address) |
3431 | +TEST_F(MesaNativeDisplayContainerSetup, ReleasingDisplaysInvalidatesAddress) |
3432 | { |
3433 | using namespace ::testing; |
3434 | |
3435 | |
3436 | === modified file 'tests/unit-tests/client/mesa/test_native_surface.cpp' |
3437 | --- tests/unit-tests/client/mesa/test_native_surface.cpp 2014-10-29 06:21:10 +0000 |
3438 | +++ tests/unit-tests/client/mesa/test_native_surface.cpp 2014-11-24 02:31:01 +0000 |
3439 | @@ -78,7 +78,7 @@ |
3440 | mclg::NativeSurface native_surface{mock_surface}; |
3441 | }; |
3442 | |
3443 | -TEST_F(MesaClientNativeSurfaceTest, basic_parameters) |
3444 | +TEST_F(MesaClientNativeSurfaceTest, BasicParameters) |
3445 | { |
3446 | MirSurfaceParameters params; |
3447 | native_surface.surface_get_parameters(&native_surface, ¶ms); |
3448 | @@ -87,7 +87,7 @@ |
3449 | EXPECT_EQ(surf_params.pixel_format, params.pixel_format); |
3450 | } |
3451 | |
3452 | -TEST_F(MesaClientNativeSurfaceTest, first_advance_skips_request) |
3453 | +TEST_F(MesaClientNativeSurfaceTest, FirstAdvanceSkipsRequest) |
3454 | { // Verify the workaround for LP: #1281938 is functioning, until it's |
3455 | // fixed in Mesa and we can remove it from Mir. |
3456 | |
3457 | @@ -101,7 +101,7 @@ |
3458 | native_surface.surface_advance_buffer(&native_surface, &buffer_package); |
3459 | } |
3460 | |
3461 | -TEST_F(MesaClientNativeSurfaceTest, basic_advance) |
3462 | +TEST_F(MesaClientNativeSurfaceTest, BasicAdvance) |
3463 | { |
3464 | using namespace testing; |
3465 | MirBufferPackage buffer_package; |
3466 | @@ -118,7 +118,7 @@ |
3467 | native_surface.surface_advance_buffer(&native_surface, &buffer_package); |
3468 | } |
3469 | |
3470 | -TEST_F(MesaClientNativeSurfaceTest, swapinterval_request) |
3471 | +TEST_F(MesaClientNativeSurfaceTest, SwapintervalRequest) |
3472 | { |
3473 | using namespace testing; |
3474 | |
3475 | @@ -132,7 +132,7 @@ |
3476 | native_surface.set_swapinterval(1); |
3477 | } |
3478 | |
3479 | -TEST_F(MesaClientNativeSurfaceTest, swapinterval_unsupported_request) |
3480 | +TEST_F(MesaClientNativeSurfaceTest, SwapintervalUnsupportedRequest) |
3481 | { |
3482 | EXPECT_EQ(MIR_MESA_FALSE, native_surface.set_swapinterval(-1)); |
3483 | EXPECT_EQ(MIR_MESA_TRUE, native_surface.set_swapinterval(0)); |
3484 | @@ -140,7 +140,7 @@ |
3485 | EXPECT_EQ(MIR_MESA_FALSE, native_surface.set_swapinterval(2)); |
3486 | } |
3487 | |
3488 | -TEST_F(MesaClientNativeSurfaceTest, returns_error_on_advance_buffer_failure) |
3489 | +TEST_F(MesaClientNativeSurfaceTest, ReturnsErrorOnAdvanceBufferFailure) |
3490 | { |
3491 | using namespace testing; |
3492 | |
3493 | @@ -151,7 +151,7 @@ |
3494 | EXPECT_THAT(native_surface.advance_buffer(&buffer_package), Eq(MIR_MESA_FALSE)); |
3495 | } |
3496 | |
3497 | -TEST_F(MesaClientNativeSurfaceTest, returns_error_on_get_parameters_failure) |
3498 | +TEST_F(MesaClientNativeSurfaceTest, ReturnsErrorOnGetParametersFailure) |
3499 | { |
3500 | using namespace testing; |
3501 | |
3502 | @@ -162,7 +162,7 @@ |
3503 | EXPECT_THAT(native_surface.get_parameters(&surface_params), Eq(MIR_MESA_FALSE)); |
3504 | } |
3505 | |
3506 | -TEST_F(MesaClientNativeSurfaceTest, returns_error_on_set_swap_interval_failure) |
3507 | +TEST_F(MesaClientNativeSurfaceTest, ReturnsErrorOnSetSwapIntervalFailure) |
3508 | { |
3509 | using namespace testing; |
3510 | |
3511 | |
3512 | === modified file 'tests/unit-tests/client/test_aging_buffer.cpp' |
3513 | --- tests/unit-tests/client/test_aging_buffer.cpp 2014-11-05 03:25:04 +0000 |
3514 | +++ tests/unit-tests/client/test_aging_buffer.cpp 2014-11-24 02:31:01 +0000 |
3515 | @@ -65,7 +65,7 @@ |
3516 | } |
3517 | }; |
3518 | |
3519 | -TEST(MirClientAgingBufferTest, buffer_age_starts_at_zero) |
3520 | +TEST(MirClientAgingBufferTest, BufferAgeStartsAtZero) |
3521 | { |
3522 | using namespace testing; |
3523 | |
3524 | @@ -74,7 +74,7 @@ |
3525 | EXPECT_EQ(0u, buffer.age()); |
3526 | } |
3527 | |
3528 | -TEST(MirClientAgingBufferTest, buffer_age_set_to_one_on_submit) |
3529 | +TEST(MirClientAgingBufferTest, BufferAgeSetToOneOnSubmit) |
3530 | { |
3531 | using namespace testing; |
3532 | |
3533 | @@ -84,7 +84,7 @@ |
3534 | EXPECT_EQ(1u, buffer.age()); |
3535 | } |
3536 | |
3537 | -TEST(MirClientAgingBufferTest, buffer_age_increases_on_increment) |
3538 | +TEST(MirClientAgingBufferTest, BufferAgeIncreasesOnIncrement) |
3539 | { |
3540 | using namespace testing; |
3541 | |
3542 | @@ -98,7 +98,7 @@ |
3543 | } |
3544 | } |
3545 | |
3546 | -TEST(MirClientAgingBufferTest, incrementing_age_has_no_effect_for_unsubmitted_buffer) |
3547 | +TEST(MirClientAgingBufferTest, IncrementingAgeHasNoEffectForUnsubmittedBuffer) |
3548 | { |
3549 | using namespace testing; |
3550 | |
3551 | |
3552 | === modified file 'tests/unit-tests/client/test_android_client_buffer_factory.cpp' |
3553 | --- tests/unit-tests/client/test_android_client_buffer_factory.cpp 2014-03-06 06:05:17 +0000 |
3554 | +++ tests/unit-tests/client/test_android_client_buffer_factory.cpp 2014-11-24 02:31:01 +0000 |
3555 | @@ -55,7 +55,7 @@ |
3556 | |
3557 | }; |
3558 | |
3559 | -TEST_F(MirBufferFactoryTest, factory_sets_width_and_height) |
3560 | +TEST_F(MirBufferFactoryTest, FactorySetsWidthAndHeight) |
3561 | { |
3562 | using namespace testing; |
3563 | |
3564 | |
3565 | === modified file 'tests/unit-tests/client/test_client.cpp' |
3566 | --- tests/unit-tests/client/test_client.cpp 2014-10-29 06:21:10 +0000 |
3567 | +++ tests/unit-tests/client/test_client.cpp 2014-11-24 02:31:01 +0000 |
3568 | @@ -22,7 +22,7 @@ |
3569 | #include <gtest/gtest.h> |
3570 | #include <gmock/gmock.h> |
3571 | |
3572 | -TEST(MirClientTest, mir_connection_is_valid_handles_invalid_pointers) |
3573 | +TEST(MirClientTest, MirConnectionIsValidHandlesInvalidPointers) |
3574 | { |
3575 | using namespace testing; |
3576 | |
3577 | @@ -37,7 +37,7 @@ |
3578 | ASSERT_FALSE(mir_connection_is_valid(not_a_mir_connection_on_the_heap)); |
3579 | } |
3580 | |
3581 | -TEST(MirClientTest, mir_surface_is_valid_handles_invalid_pointers) |
3582 | +TEST(MirClientTest, MirSurfaceIsValidHandlesInvalidPointers) |
3583 | { |
3584 | MirSurface* null_pointer = NULL; |
3585 | double stack_variable; |
3586 | |
3587 | === modified file 'tests/unit-tests/client/test_client_buffer_depository.cpp' |
3588 | --- tests/unit-tests/client/test_client_buffer_depository.cpp 2014-10-29 06:21:10 +0000 |
3589 | +++ tests/unit-tests/client/test_client_buffer_depository.cpp 2014-11-24 02:31:01 +0000 |
3590 | @@ -120,7 +120,7 @@ |
3591 | return value == arg; |
3592 | } |
3593 | |
3594 | -TEST_F(MirBufferDepositoryTest, depository_sets_width_and_height) |
3595 | +TEST_F(MirBufferDepositoryTest, DepositorySetsWidthAndHeight) |
3596 | { |
3597 | using namespace testing; |
3598 | |
3599 | @@ -131,7 +131,7 @@ |
3600 | depository.deposit_package(package, 8, size, pf); |
3601 | } |
3602 | |
3603 | -TEST_F(MirBufferDepositoryTest, depository_new_deposit_changes_current_buffer) |
3604 | +TEST_F(MirBufferDepositoryTest, DepositoryNewDepositChangesCurrentBuffer) |
3605 | { |
3606 | using namespace testing; |
3607 | |
3608 | @@ -147,7 +147,7 @@ |
3609 | EXPECT_NE(buffer1, buffer2); |
3610 | } |
3611 | |
3612 | -TEST_F(MirBufferDepositoryTest, depository_sets_buffer_age_to_zero_for_new_buffer) |
3613 | +TEST_F(MirBufferDepositoryTest, DepositorySetsBufferAgeToZeroForNewBuffer) |
3614 | { |
3615 | using namespace testing; |
3616 | |
3617 | @@ -159,7 +159,7 @@ |
3618 | EXPECT_EQ(0u, buffer1->age()); |
3619 | } |
3620 | |
3621 | -TEST_F(MirBufferDepositoryTest, just_sumbitted_buffer_has_age_1) |
3622 | +TEST_F(MirBufferDepositoryTest, JustSumbittedBufferHasAge_1) |
3623 | { |
3624 | using namespace testing; |
3625 | |
3626 | @@ -177,7 +177,7 @@ |
3627 | EXPECT_EQ(1u, buffer1->age()); |
3628 | } |
3629 | |
3630 | -TEST_F(MirBufferDepositoryTest, submitting_buffer_ages_other_buffers) |
3631 | +TEST_F(MirBufferDepositoryTest, SubmittingBufferAgesOtherBuffers) |
3632 | { |
3633 | using namespace testing; |
3634 | |
3635 | @@ -204,7 +204,7 @@ |
3636 | EXPECT_EQ(0u, buffer3->age()); |
3637 | } |
3638 | |
3639 | -TEST_F(MirBufferDepositoryTest, double_buffering_reaches_steady_state_age) |
3640 | +TEST_F(MirBufferDepositoryTest, DoubleBufferingReachesSteadyStateAge) |
3641 | { |
3642 | using namespace testing; |
3643 | |
3644 | @@ -233,7 +233,7 @@ |
3645 | EXPECT_EQ(2u, buffer2->age()); |
3646 | } |
3647 | |
3648 | -TEST_F(MirBufferDepositoryTest, triple_buffering_reaches_steady_state_age) |
3649 | +TEST_F(MirBufferDepositoryTest, TripleBufferingReachesSteadyStateAge) |
3650 | { |
3651 | using namespace testing; |
3652 | |
3653 | @@ -273,7 +273,7 @@ |
3654 | EXPECT_EQ(3u, buffer3->age()); |
3655 | } |
3656 | |
3657 | -TEST_F(MirBufferDepositoryTest, depository_destroys_old_buffers) |
3658 | +TEST_F(MirBufferDepositoryTest, DepositoryDestroysOldBuffers) |
3659 | { |
3660 | using namespace testing; |
3661 | const int num_buffers = 3; |
3662 | @@ -295,7 +295,7 @@ |
3663 | EXPECT_TRUE(mock_factory->first_buffer_allocated_and_then_freed()); |
3664 | } |
3665 | |
3666 | -TEST_F(MirBufferDepositoryTest, depositing_packages_implicitly_submits_current_buffer) |
3667 | +TEST_F(MirBufferDepositoryTest, DepositingPackagesImplicitlySubmitsCurrentBuffer) |
3668 | { |
3669 | using namespace testing; |
3670 | const int num_buffers = 3; |
3671 | @@ -310,7 +310,7 @@ |
3672 | depository.deposit_package(package2, 2, size, pf); |
3673 | } |
3674 | |
3675 | -TEST_F(MirBufferDepositoryTest, depository_frees_buffers_after_reaching_capacity) |
3676 | +TEST_F(MirBufferDepositoryTest, DepositoryFreesBuffersAfterReachingCapacity) |
3677 | { |
3678 | using namespace testing; |
3679 | std::shared_ptr<mcl::ClientBufferDepository> depository; |
3680 | @@ -334,7 +334,7 @@ |
3681 | } |
3682 | } |
3683 | |
3684 | -TEST_F(MirBufferDepositoryTest, depository_caches_recently_seen_buffer) |
3685 | +TEST_F(MirBufferDepositoryTest, DepositoryCachesRecentlySeenBuffer) |
3686 | { |
3687 | using namespace testing; |
3688 | |
3689 | @@ -358,7 +358,7 @@ |
3690 | depository.deposit_package(package3, 8, size, pf); |
3691 | } |
3692 | |
3693 | -TEST_F(MirBufferDepositoryTest, depository_creates_new_buffer_for_different_id) |
3694 | +TEST_F(MirBufferDepositoryTest, DepositoryCreatesNewBufferForDifferentId) |
3695 | { |
3696 | using namespace testing; |
3697 | |
3698 | @@ -374,7 +374,7 @@ |
3699 | depository.deposit_package(package2, 9, size, pf); |
3700 | } |
3701 | |
3702 | -TEST_F(MirBufferDepositoryTest, depository_keeps_last_2_buffers_regardless_of_age) |
3703 | +TEST_F(MirBufferDepositoryTest, DepositoryKeepsLast_2BuffersRegardlessOfAge) |
3704 | { |
3705 | using namespace testing; |
3706 | |
3707 | @@ -389,7 +389,7 @@ |
3708 | depository.deposit_package(package, 8, size, pf); |
3709 | } |
3710 | |
3711 | -TEST_F(MirBufferDepositoryTest, depository_keeps_last_3_buffers_regardless_of_age) |
3712 | +TEST_F(MirBufferDepositoryTest, DepositoryKeepsLast_3BuffersRegardlessOfAge) |
3713 | { |
3714 | using namespace testing; |
3715 | |
3716 | |
3717 | === modified file 'tests/unit-tests/client/test_client_display_conf.cpp' |
3718 | --- tests/unit-tests/client/test_client_display_conf.cpp 2014-03-06 06:05:17 +0000 |
3719 | +++ tests/unit-tests/client/test_client_display_conf.cpp 2014-11-24 02:31:01 +0000 |
3720 | @@ -54,7 +54,7 @@ |
3721 | } |
3722 | } |
3723 | |
3724 | -TEST(TestDisplayConfiguration, configuration_storage) |
3725 | +TEST(TestDisplayConfiguration, ConfigurationStorage) |
3726 | { |
3727 | mp::DisplayConfiguration protobuf_config; |
3728 | fill(protobuf_config.add_display_output()); |
3729 | |
3730 | === modified file 'tests/unit-tests/client/test_client_mir_surface.cpp' |
3731 | --- tests/unit-tests/client/test_client_mir_surface.cpp 2014-10-29 06:21:10 +0000 |
3732 | +++ tests/unit-tests/client/test_client_mir_surface.cpp 2014-11-24 02:31:01 +0000 |
3733 | @@ -496,7 +496,7 @@ |
3734 | |
3735 | } |
3736 | |
3737 | -TEST_F(MirClientSurfaceTest, client_buffer_created_on_surface_creation) |
3738 | +TEST_F(MirClientSurfaceTest, ClientBufferCreatedOnSurfaceCreation) |
3739 | { |
3740 | using namespace testing; |
3741 | |
3742 | @@ -506,7 +506,7 @@ |
3743 | create_and_wait_for_surface_with(*client_comm_channel, mock_buffer_factory); |
3744 | } |
3745 | |
3746 | -TEST_F(MirClientSurfaceTest, attributes_set_on_surface_creation) |
3747 | +TEST_F(MirClientSurfaceTest, AttributesSetOnSurfaceCreation) |
3748 | { |
3749 | using namespace testing; |
3750 | |
3751 | @@ -518,7 +518,7 @@ |
3752 | } |
3753 | } |
3754 | |
3755 | -TEST_F(MirClientSurfaceTest, create_wait_handle_really_blocks) |
3756 | +TEST_F(MirClientSurfaceTest, CreateWaitHandleReallyBlocks) |
3757 | { |
3758 | using namespace testing; |
3759 | |
3760 | @@ -534,7 +534,7 @@ |
3761 | EXPECT_GE(std::chrono::steady_clock::now(), expected_end); |
3762 | } |
3763 | |
3764 | -TEST_F(MirClientSurfaceTest, next_buffer_wait_handle_really_blocks) |
3765 | +TEST_F(MirClientSurfaceTest, NextBufferWaitHandleReallyBlocks) |
3766 | { |
3767 | using namespace testing; |
3768 | |
3769 | @@ -551,7 +551,7 @@ |
3770 | EXPECT_GE(std::chrono::steady_clock::now(), expected_end); |
3771 | } |
3772 | |
3773 | -TEST_F(MirClientSurfaceTest, client_buffer_created_on_next_buffer) |
3774 | +TEST_F(MirClientSurfaceTest, ClientBufferCreatedOnNextBuffer) |
3775 | { |
3776 | using namespace testing; |
3777 | |
3778 | @@ -568,7 +568,7 @@ |
3779 | buffer_wait_handle->wait_for_all(); |
3780 | } |
3781 | |
3782 | -TEST_F(MirClientSurfaceTest, client_buffer_uses_ipc_message_from_server_on_create) |
3783 | +TEST_F(MirClientSurfaceTest, ClientBufferUsesIpcMessageFromServerOnCreate) |
3784 | { |
3785 | using namespace testing; |
3786 | |
3787 | @@ -578,7 +578,7 @@ |
3788 | BufferPackageMatches(mock_server_tool->server_package)); |
3789 | } |
3790 | |
3791 | -TEST_F(MirClientSurfaceTest, message_width_height_used_in_buffer_creation) |
3792 | +TEST_F(MirClientSurfaceTest, MessageWidthHeightUsedInBufferCreation) |
3793 | { |
3794 | using namespace testing; |
3795 | |
3796 | @@ -588,7 +588,7 @@ |
3797 | Eq(geom::Size(mock_server_tool->width_sent, mock_server_tool->height_sent))); |
3798 | } |
3799 | |
3800 | -TEST_F(MirClientSurfaceTest, message_pf_used_in_buffer_creation) |
3801 | +TEST_F(MirClientSurfaceTest, MessagePfUsedInBufferCreation) |
3802 | { |
3803 | using namespace testing; |
3804 | |
3805 | @@ -599,7 +599,7 @@ |
3806 | } |
3807 | |
3808 | // TODO: input fd is not checked in the test |
3809 | -TEST_F(MirClientSurfaceTest, creates_input_thread_with_input_fd_when_delegate_specified) |
3810 | +TEST_F(MirClientSurfaceTest, CreatesInputThreadWithInputFdWhenDelegateSpecified) |
3811 | { |
3812 | using namespace ::testing; |
3813 | |
3814 | @@ -619,7 +619,7 @@ |
3815 | surface.set_event_handler(&delegate); |
3816 | } |
3817 | |
3818 | -TEST_F(MirClientSurfaceTest, does_not_create_input_thread_when_no_delegate_specified) |
3819 | +TEST_F(MirClientSurfaceTest, DoesNotCreateInputThreadWhenNoDelegateSpecified) |
3820 | { |
3821 | using namespace ::testing; |
3822 | |
3823 | @@ -636,7 +636,7 @@ |
3824 | wait_handle->wait_for_all(); |
3825 | } |
3826 | |
3827 | -TEST_F(MirClientSurfaceTest, returns_current_buffer) |
3828 | +TEST_F(MirClientSurfaceTest, ReturnsCurrentBuffer) |
3829 | { |
3830 | using namespace testing; |
3831 | |
3832 | @@ -655,7 +655,7 @@ |
3833 | EXPECT_THAT(next_buffer, Ne(creation_buffer)); |
3834 | } |
3835 | |
3836 | -TEST_F(MirClientSurfaceTest, surface_resizes_with_latest_buffer) |
3837 | +TEST_F(MirClientSurfaceTest, SurfaceResizesWithLatestBuffer) |
3838 | { |
3839 | using namespace testing; |
3840 | |
3841 | @@ -679,7 +679,7 @@ |
3842 | EXPECT_THAT(after.height, Eq(new_height)); |
3843 | } |
3844 | |
3845 | -TEST_F(MirClientSurfaceTest, get_cpu_region_returns_correct_data) |
3846 | +TEST_F(MirClientSurfaceTest, GetCpuRegionReturnsCorrectData) |
3847 | { |
3848 | using namespace testing; |
3849 | |
3850 | @@ -716,14 +716,14 @@ |
3851 | } |
3852 | } |
3853 | |
3854 | -TEST_F(MirClientSurfaceTest, valid_surface_is_valid) |
3855 | +TEST_F(MirClientSurfaceTest, ValidSurfaceIsValid) |
3856 | { |
3857 | auto const surface = create_and_wait_for_surface_with(*client_comm_channel, stub_buffer_factory); |
3858 | |
3859 | EXPECT_TRUE(MirSurface::is_valid(surface.get())); |
3860 | } |
3861 | |
3862 | -TEST_F(MirClientSurfaceTest, configure_cursor_wait_handle_really_blocks) |
3863 | +TEST_F(MirClientSurfaceTest, ConfigureCursorWaitHandleReallyBlocks) |
3864 | { |
3865 | using namespace testing; |
3866 | |
3867 | @@ -743,7 +743,7 @@ |
3868 | mir_cursor_configuration_destroy(cursor_config); |
3869 | } |
3870 | |
3871 | -TEST_F(MirClientSurfaceTest, configure_wait_handle_really_blocks) |
3872 | +TEST_F(MirClientSurfaceTest, ConfigureWaitHandleReallyBlocks) |
3873 | { |
3874 | using namespace testing; |
3875 | |
3876 | |
3877 | === modified file 'tests/unit-tests/client/test_client_platform.cpp' |
3878 | --- tests/unit-tests/client/test_client_platform.cpp 2014-03-06 06:05:17 +0000 |
3879 | +++ tests/unit-tests/client/test_client_platform.cpp 2014-11-24 02:31:01 +0000 |
3880 | @@ -45,7 +45,7 @@ |
3881 | #endif |
3882 | }; |
3883 | |
3884 | -TEST_F(ClientPlatformTest, platform_name) |
3885 | +TEST_F(ClientPlatformTest, PlatformName) |
3886 | { |
3887 | auto platform = factory.create_client_platform(&context); |
3888 | #ifdef ANDROID |
3889 | @@ -56,14 +56,14 @@ |
3890 | EXPECT_EQ(type, platform->platform_type()); |
3891 | } |
3892 | |
3893 | -TEST_F(ClientPlatformTest, platform_creates) |
3894 | +TEST_F(ClientPlatformTest, PlatformCreates) |
3895 | { |
3896 | auto platform = factory.create_client_platform(&context); |
3897 | auto buffer_factory = platform->create_buffer_factory(); |
3898 | EXPECT_NE(buffer_factory.get(), (mcl::ClientBufferFactory*) NULL); |
3899 | } |
3900 | |
3901 | -TEST_F(ClientPlatformTest, platform_creates_native_window) |
3902 | +TEST_F(ClientPlatformTest, PlatformCreatesNativeWindow) |
3903 | { |
3904 | auto platform = factory.create_client_platform(&context); |
3905 | auto mock_client_surface = std::make_shared<mtd::MockClientSurface>(); |
3906 | @@ -71,7 +71,7 @@ |
3907 | EXPECT_NE(*native_window, (EGLNativeWindowType) NULL); |
3908 | } |
3909 | |
3910 | -TEST_F(ClientPlatformTest, platform_creates_egl_native_display) |
3911 | +TEST_F(ClientPlatformTest, PlatformCreatesEglNativeDisplay) |
3912 | { |
3913 | auto platform = factory.create_client_platform(&context); |
3914 | auto native_display = platform->create_egl_native_display(); |
3915 | |
3916 | === modified file 'tests/unit-tests/client/test_event_distributor.cpp' |
3917 | --- tests/unit-tests/client/test_event_distributor.cpp 2014-10-29 06:21:10 +0000 |
3918 | +++ tests/unit-tests/client/test_event_distributor.cpp 2014-11-24 02:31:01 +0000 |
3919 | @@ -46,7 +46,7 @@ |
3920 | |
3921 | } |
3922 | |
3923 | -TEST_F(EventDistributorTest, calls_back_when_registered) |
3924 | +TEST_F(EventDistributorTest, CallsBackWhenRegistered) |
3925 | { |
3926 | using namespace testing; |
3927 | |
3928 | @@ -61,7 +61,7 @@ |
3929 | event_distributor.handle_event(e); |
3930 | } |
3931 | |
3932 | -TEST_F(EventDistributorTest, no_calls_back_after_unregistered) |
3933 | +TEST_F(EventDistributorTest, NoCallsBackAfterUnregistered) |
3934 | { |
3935 | using namespace testing; |
3936 | |
3937 | @@ -77,7 +77,7 @@ |
3938 | event_distributor.handle_event(e); |
3939 | } |
3940 | |
3941 | -TEST_F(EventDistributorTest, no_callback_on_callback_deregistration) |
3942 | +TEST_F(EventDistributorTest, NoCallbackOnCallbackDeregistration) |
3943 | { |
3944 | using namespace testing; |
3945 | int reg_id2; |
3946 | @@ -98,7 +98,7 @@ |
3947 | event_distributor.handle_event(e); |
3948 | } |
3949 | |
3950 | -TEST_F(EventDistributorTest, succeeds_with_thread_delete_unregister) |
3951 | +TEST_F(EventDistributorTest, SucceedsWithThreadDeleteUnregister) |
3952 | { |
3953 | using namespace testing; |
3954 | |
3955 | |
3956 | === modified file 'tests/unit-tests/client/test_mir_connection.cpp' |
3957 | --- tests/unit-tests/client/test_mir_connection.cpp 2014-03-27 06:27:59 +0000 |
3958 | +++ tests/unit-tests/client/test_mir_connection.cpp 2014-11-24 02:31:01 +0000 |
3959 | @@ -185,7 +185,7 @@ |
3960 | std::shared_ptr<MirConnection> const connection; |
3961 | }; |
3962 | |
3963 | -TEST_F(MirConnectionTest, returns_correct_egl_native_display) |
3964 | +TEST_F(MirConnectionTest, ReturnsCorrectEglNativeDisplay) |
3965 | { |
3966 | using namespace testing; |
3967 | |
3968 | @@ -210,7 +210,7 @@ |
3969 | return arg->magic() == magic; |
3970 | } |
3971 | |
3972 | -TEST_F(MirConnectionTest, client_drm_auth_magic_calls_server_drm_auth_magic) |
3973 | +TEST_F(MirConnectionTest, ClientDrmAuthMagicCallsServerDrmAuthMagic) |
3974 | { |
3975 | using namespace testing; |
3976 | |
3977 | @@ -280,7 +280,7 @@ |
3978 | |
3979 | } |
3980 | |
3981 | -TEST_F(MirConnectionTest, populates_display_output_correctly_on_startup) |
3982 | +TEST_F(MirConnectionTest, PopulatesDisplayOutputCorrectlyOnStartup) |
3983 | { |
3984 | using namespace testing; |
3985 | |
3986 | @@ -319,7 +319,7 @@ |
3987 | mcl::delete_config_storage(configuration); |
3988 | } |
3989 | |
3990 | -TEST_F(MirConnectionTest, user_tries_to_configure_incorrectly) |
3991 | +TEST_F(MirConnectionTest, UserTriesToConfigureIncorrectly) |
3992 | { |
3993 | using namespace testing; |
3994 | |
3995 | @@ -364,7 +364,7 @@ |
3996 | mcl::delete_config_storage(configuration); |
3997 | } |
3998 | |
3999 | -TEST_F(MirConnectionTest, display_configuration_validation_succeeds_for_invalid_mode_in_disconnected_output) |
4000 | +TEST_F(MirConnectionTest, DisplayConfigurationValidationSucceedsForInvalidModeInDisconnectedOutput) |
4001 | { |
4002 | using namespace testing; |
4003 | |
4004 | @@ -385,7 +385,7 @@ |
4005 | mcl::delete_config_storage(configuration); |
4006 | } |
4007 | |
4008 | -TEST_F(MirConnectionTest, display_configuration_validation_uses_updated_configuration) |
4009 | +TEST_F(MirConnectionTest, DisplayConfigurationValidationUsesUpdatedConfiguration) |
4010 | { |
4011 | using namespace testing; |
4012 | |
4013 | @@ -422,7 +422,7 @@ |
4014 | mcl::delete_config_storage(configuration); |
4015 | } |
4016 | |
4017 | -TEST_F(MirConnectionTest, populates_pfs_correctly) |
4018 | +TEST_F(MirConnectionTest, PopulatesPfsCorrectly) |
4019 | { |
4020 | using namespace testing; |
4021 | |
4022 | @@ -445,7 +445,7 @@ |
4023 | } |
4024 | } |
4025 | |
4026 | -TEST_F(MirConnectionTest, valid_display_configure_sent) |
4027 | +TEST_F(MirConnectionTest, ValidDisplayConfigureSent) |
4028 | { |
4029 | using namespace testing; |
4030 | |
4031 | @@ -508,7 +508,7 @@ |
4032 | |
4033 | } |
4034 | |
4035 | -TEST_F(MirConnectionTest, focused_window_synthesises_unfocus_event_on_release) |
4036 | +TEST_F(MirConnectionTest, FocusedWindowSynthesisesUnfocusEventOnRelease) |
4037 | { |
4038 | using namespace testing; |
4039 | |
4040 | @@ -546,7 +546,7 @@ |
4041 | EXPECT_TRUE(unfocused_received); |
4042 | } |
4043 | |
4044 | -TEST_F(MirConnectionTest, unfocused_window_does_not_synthesise_unfocus_event_on_release) |
4045 | +TEST_F(MirConnectionTest, UnfocusedWindowDoesNotSynthesiseUnfocusEventOnRelease) |
4046 | { |
4047 | using namespace testing; |
4048 | |
4049 | @@ -595,7 +595,7 @@ |
4050 | |
4051 | } |
4052 | |
4053 | -TEST_F(MirConnectionTest, sets_extra_platform_data) |
4054 | +TEST_F(MirConnectionTest, SetsExtraPlatformData) |
4055 | { |
4056 | using namespace testing; |
4057 | std::vector<int> const initial_data{0x66, 0x67, 0x68}; |
4058 | |
4059 | === modified file 'tests/unit-tests/client/test_mir_prompt_session.cpp' |
4060 | --- tests/unit-tests/client/test_mir_prompt_session.cpp 2014-10-29 06:21:10 +0000 |
4061 | +++ tests/unit-tests/client/test_mir_prompt_session.cpp 2014-11-24 02:31:01 +0000 |
4062 | @@ -139,7 +139,7 @@ |
4063 | |
4064 | } |
4065 | |
4066 | -TEST_F(MirPromptSessionTest, start_prompt_session) |
4067 | +TEST_F(MirPromptSessionTest, StartPromptSession) |
4068 | { |
4069 | using namespace testing; |
4070 | |
4071 | @@ -153,7 +153,7 @@ |
4072 | prompt_session.start(__LINE__, null_callback_func, nullptr); |
4073 | } |
4074 | |
4075 | -TEST_F(MirPromptSessionTest, stop_prompt_session) |
4076 | +TEST_F(MirPromptSessionTest, StopPromptSession) |
4077 | { |
4078 | using namespace testing; |
4079 | |
4080 | @@ -167,7 +167,7 @@ |
4081 | prompt_session.stop(null_callback_func, nullptr); |
4082 | } |
4083 | |
4084 | -TEST_F(MirPromptSessionTest, executes_callback_on_start) |
4085 | +TEST_F(MirPromptSessionTest, ExecutesCallbackOnStart) |
4086 | { |
4087 | using namespace testing; |
4088 | |
4089 | @@ -180,7 +180,7 @@ |
4090 | prompt_session.start(__LINE__, mock_callback_func, &mock_cb)->wait_for_all(); |
4091 | } |
4092 | |
4093 | -TEST_F(MirPromptSessionTest, executes_callback_on_stop) |
4094 | +TEST_F(MirPromptSessionTest, ExecutesCallbackOnStop) |
4095 | { |
4096 | using namespace testing; |
4097 | |
4098 | @@ -193,7 +193,7 @@ |
4099 | prompt_session.stop(mock_callback_func, &mock_cb)->wait_for_all(); |
4100 | } |
4101 | |
4102 | -TEST_F(MirPromptSessionTest, notifies_event_callback) |
4103 | +TEST_F(MirPromptSessionTest, NotifiesEventCallback) |
4104 | { |
4105 | using namespace testing; |
4106 | |
4107 | |
4108 | === modified file 'tests/unit-tests/client/test_mir_screencast.cpp' |
4109 | --- tests/unit-tests/client/test_mir_screencast.cpp 2014-03-11 16:19:27 +0000 |
4110 | +++ tests/unit-tests/client/test_mir_screencast.cpp 2014-11-24 02:31:01 +0000 |
4111 | @@ -261,7 +261,7 @@ |
4112 | |
4113 | } |
4114 | |
4115 | -TEST_F(MirScreencastTest, creates_screencast_on_construction) |
4116 | +TEST_F(MirScreencastTest, CreatesScreencastOnConstruction) |
4117 | { |
4118 | using namespace testing; |
4119 | |
4120 | @@ -278,7 +278,7 @@ |
4121 | null_callback_func, nullptr}; |
4122 | } |
4123 | |
4124 | -TEST_F(MirScreencastTest, releases_screencast_on_release) |
4125 | +TEST_F(MirScreencastTest, ReleasesScreencastOnRelease) |
4126 | { |
4127 | using namespace testing; |
4128 | |
4129 | @@ -305,7 +305,7 @@ |
4130 | screencast.release(null_callback_func, nullptr); |
4131 | } |
4132 | |
4133 | -TEST_F(MirScreencastTest, requests_screencast_buffer_on_next_buffer) |
4134 | +TEST_F(MirScreencastTest, RequestsScreencastBufferOnNextBuffer) |
4135 | { |
4136 | using namespace testing; |
4137 | uint32_t const screencast_id{77}; |
4138 | @@ -331,7 +331,7 @@ |
4139 | screencast.next_buffer(null_callback_func, nullptr); |
4140 | } |
4141 | |
4142 | -TEST_F(MirScreencastTest, executes_callback_on_creation) |
4143 | +TEST_F(MirScreencastTest, ExecutesCallbackOnCreation) |
4144 | { |
4145 | using namespace testing; |
4146 | |
4147 | @@ -349,7 +349,7 @@ |
4148 | screencast.creation_wait_handle()->wait_for_all(); |
4149 | } |
4150 | |
4151 | -TEST_F(MirScreencastTest, executes_callback_on_release) |
4152 | +TEST_F(MirScreencastTest, ExecutesCallbackOnRelease) |
4153 | { |
4154 | using namespace testing; |
4155 | |
4156 | @@ -370,7 +370,7 @@ |
4157 | wh->wait_for_all(); |
4158 | } |
4159 | |
4160 | -TEST_F(MirScreencastTest, executes_callback_on_next_buffer) |
4161 | +TEST_F(MirScreencastTest, ExecutesCallbackOnNextBuffer) |
4162 | { |
4163 | using namespace testing; |
4164 | |
4165 | @@ -391,7 +391,7 @@ |
4166 | wh->wait_for_all(); |
4167 | } |
4168 | |
4169 | -TEST_F(MirScreencastTest, construction_throws_on_invalid_params) |
4170 | +TEST_F(MirScreencastTest, ConstructionThrowsOnInvalidParams) |
4171 | { |
4172 | mir::geometry::Size const invalid_size{0, 0}; |
4173 | mir::geometry::Rectangle const invalid_region{{0, 0}, {0, 0}}; |
4174 | @@ -427,7 +427,7 @@ |
4175 | }, std::runtime_error); |
4176 | } |
4177 | |
4178 | -TEST_F(MirScreencastTest, returns_correct_surface_parameters) |
4179 | +TEST_F(MirScreencastTest, ReturnsCorrectSurfaceParameters) |
4180 | { |
4181 | MirScreencast screencast{ |
4182 | default_region, |
4183 | @@ -449,7 +449,7 @@ |
4184 | EXPECT_EQ(mir_display_output_id_invalid, params.output_id); |
4185 | } |
4186 | |
4187 | -TEST_F(MirScreencastTest, uses_buffer_message_from_server) |
4188 | +TEST_F(MirScreencastTest, UsesBufferMessageFromServer) |
4189 | { |
4190 | using namespace testing; |
4191 | |
4192 | @@ -481,7 +481,7 @@ |
4193 | screencast.creation_wait_handle()->wait_for_all(); |
4194 | } |
4195 | |
4196 | -TEST_F(MirScreencastTest, returns_current_client_buffer) |
4197 | +TEST_F(MirScreencastTest, ReturnsCurrentClientBuffer) |
4198 | { |
4199 | using namespace testing; |
4200 | |
4201 | @@ -523,7 +523,7 @@ |
4202 | EXPECT_EQ(client_buffer2, screencast.get_current_buffer()); |
4203 | } |
4204 | |
4205 | -TEST_F(MirScreencastTest, gets_egl_native_window) |
4206 | +TEST_F(MirScreencastTest, GetsEglNativeWindow) |
4207 | { |
4208 | using namespace testing; |
4209 | |
4210 | @@ -542,7 +542,7 @@ |
4211 | EXPECT_EQ(StubEGLNativeWindowFactory::egl_native_window, egl_native_window); |
4212 | } |
4213 | |
4214 | -TEST_F(MirScreencastTest, is_invalid_if_server_create_screencast_fails) |
4215 | +TEST_F(MirScreencastTest, IsInvalidIfServerCreateScreencastFails) |
4216 | { |
4217 | using namespace testing; |
4218 | |
4219 | @@ -562,7 +562,7 @@ |
4220 | EXPECT_FALSE(screencast.valid()); |
4221 | } |
4222 | |
4223 | -TEST_F(MirScreencastTest, calls_callback_on_creation_failure) |
4224 | +TEST_F(MirScreencastTest, CallsCallbackOnCreationFailure) |
4225 | { |
4226 | using namespace testing; |
4227 | |
4228 | |
4229 | === modified file 'tests/unit-tests/client/test_periodic_perf_report.cpp' |
4230 | --- tests/unit-tests/client/test_periodic_perf_report.cpp 2014-11-03 11:07:02 +0000 |
4231 | +++ tests/unit-tests/client/test_periodic_perf_report.cpp 2014-11-24 02:31:01 +0000 |
4232 | @@ -51,7 +51,7 @@ |
4233 | |
4234 | } // namespace |
4235 | |
4236 | -TEST_F(PeriodicPerfReport, reports_the_right_numbers_at_full_speed) |
4237 | +TEST_F(PeriodicPerfReport, ReportsTheRightNumbersAtFullSpeed) |
4238 | { |
4239 | int const fps = 50; |
4240 | int const nbuffers = 3; |
4241 | @@ -93,7 +93,7 @@ |
4242 | } |
4243 | } |
4244 | |
4245 | -TEST_F(PeriodicPerfReport, reports_the_right_numbers_at_low_speed) |
4246 | +TEST_F(PeriodicPerfReport, ReportsTheRightNumbersAtLowSpeed) |
4247 | { |
4248 | int const nbuffers = 3; |
4249 | std::chrono::microseconds const render_time = std::chrono::milliseconds(3); |
4250 | @@ -123,7 +123,7 @@ |
4251 | } |
4252 | } |
4253 | |
4254 | -TEST_F(PeriodicPerfReport, reports_nothing_on_idle) |
4255 | +TEST_F(PeriodicPerfReport, ReportsNothingOnIdle) |
4256 | { |
4257 | using namespace testing; |
4258 | EXPECT_CALL(report, display(_,_,_,_,_)).Times(0); |
4259 | |
4260 | === modified file 'tests/unit-tests/client/test_wait_handle.cpp' |
4261 | --- tests/unit-tests/client/test_wait_handle.cpp 2014-10-29 06:21:10 +0000 |
4262 | +++ tests/unit-tests/client/test_wait_handle.cpp 2014-11-24 02:31:01 +0000 |
4263 | @@ -25,7 +25,7 @@ |
4264 | int const arbitrary_number_of_events = 100; |
4265 | } |
4266 | |
4267 | -TEST(WaitHandle, symmetric_synchronous) |
4268 | +TEST(WaitHandle, SymmetricSynchronous) |
4269 | { |
4270 | MirWaitHandle w; |
4271 | for (int i = 0; i != arbitrary_number_of_events; ++i) |
4272 | @@ -41,7 +41,7 @@ |
4273 | EXPECT_TRUE(true); // Failure would be hanging in the above loop |
4274 | } |
4275 | |
4276 | -TEST(WaitHandle, asymmetric_synchronous) |
4277 | +TEST(WaitHandle, AsymmetricSynchronous) |
4278 | { |
4279 | MirWaitHandle w; |
4280 | |
4281 | @@ -75,7 +75,7 @@ |
4282 | } |
4283 | } |
4284 | |
4285 | -TEST(WaitHandle, symmetric_asynchronous) |
4286 | +TEST(WaitHandle, SymmetricAsynchronous) |
4287 | { |
4288 | const int max = 100; |
4289 | MirWaitHandle in, out; |
4290 | @@ -108,7 +108,7 @@ |
4291 | } |
4292 | } |
4293 | |
4294 | -TEST(WaitHandle, asymmetric_asynchronous) |
4295 | +TEST(WaitHandle, AsymmetricAsynchronous) |
4296 | { |
4297 | const int max = 100; |
4298 | MirWaitHandle in, out; |
4299 | @@ -144,7 +144,7 @@ |
4300 | } |
4301 | } |
4302 | |
4303 | -TEST(WaitHandle, many_waiters) |
4304 | +TEST(WaitHandle, ManyWaiters) |
4305 | { |
4306 | const int max = 100; |
4307 | MirWaitHandle w; |
4308 | |
4309 | === modified file 'tests/unit-tests/compositor/test_buffer_queue.cpp' |
4310 | --- tests/unit-tests/compositor/test_buffer_queue.cpp 2014-10-29 06:21:10 +0000 |
4311 | +++ tests/unit-tests/compositor/test_buffer_queue.cpp 2014-11-24 02:31:01 +0000 |
4312 | @@ -194,7 +194,7 @@ |
4313 | } |
4314 | } |
4315 | |
4316 | -TEST_F(BufferQueueTest, buffer_queue_of_one_is_supported) |
4317 | +TEST_F(BufferQueueTest, BufferQueueOfOneIsSupported) |
4318 | { |
4319 | std::unique_ptr<mc::BufferQueue> q; |
4320 | ASSERT_NO_THROW(q = std::move( |
4321 | @@ -232,7 +232,7 @@ |
4322 | EXPECT_NO_THROW(next_request->release_buffer()); |
4323 | } |
4324 | |
4325 | -TEST_F(BufferQueueTest, buffer_queue_of_one_supports_resizing) |
4326 | +TEST_F(BufferQueueTest, BufferQueueOfOneSupportsResizing) |
4327 | { |
4328 | mc::BufferQueue q(1, allocator, basic_properties, policy_factory); |
4329 | |
4330 | @@ -257,20 +257,20 @@ |
4331 | EXPECT_NO_THROW(q.compositor_release(q.compositor_acquire(this))); |
4332 | } |
4333 | |
4334 | -TEST_F(BufferQueueTest, framedropping_is_disabled_by_default) |
4335 | +TEST_F(BufferQueueTest, FramedroppingIsDisabledByDefault) |
4336 | { |
4337 | mc::BufferQueue bundle(2, allocator, basic_properties, policy_factory); |
4338 | EXPECT_THAT(bundle.framedropping_allowed(), Eq(false)); |
4339 | } |
4340 | |
4341 | -TEST_F(BufferQueueTest, throws_when_creating_with_invalid_num_buffers) |
4342 | +TEST_F(BufferQueueTest, ThrowsWhenCreatingWithInvalidNumBuffers) |
4343 | { |
4344 | EXPECT_THROW(mc::BufferQueue a(0, allocator, basic_properties, policy_factory), std::logic_error); |
4345 | EXPECT_THROW(mc::BufferQueue a(-1, allocator, basic_properties, policy_factory), std::logic_error); |
4346 | EXPECT_THROW(mc::BufferQueue a(-10, allocator, basic_properties, policy_factory), std::logic_error); |
4347 | } |
4348 | |
4349 | -TEST_F(BufferQueueTest, client_can_acquire_and_release_buffer) |
4350 | +TEST_F(BufferQueueTest, ClientCanAcquireAndReleaseBuffer) |
4351 | { |
4352 | for (int nbuffers = 1; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4353 | { |
4354 | @@ -282,7 +282,7 @@ |
4355 | } |
4356 | } |
4357 | |
4358 | -TEST_F(BufferQueueTest, client_can_acquire_buffers) |
4359 | +TEST_F(BufferQueueTest, ClientCanAcquireBuffers) |
4360 | { |
4361 | for (int nbuffers = 2; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4362 | { |
4363 | @@ -299,7 +299,7 @@ |
4364 | } |
4365 | |
4366 | /* Regression test for LP: #1315302 */ |
4367 | -TEST_F(BufferQueueTest, clients_can_have_multiple_pending_completions) |
4368 | +TEST_F(BufferQueueTest, ClientsCanHaveMultiplePendingCompletions) |
4369 | { |
4370 | int const nbuffers = 3; |
4371 | mc::BufferQueue q(nbuffers, allocator, basic_properties, policy_factory); |
4372 | @@ -330,7 +330,7 @@ |
4373 | handle2->release_buffer(); |
4374 | } |
4375 | |
4376 | -TEST_F(BufferQueueTest, compositor_acquires_frames_in_order_for_synchronous_client) |
4377 | +TEST_F(BufferQueueTest, CompositorAcquiresFramesInOrderForSynchronousClient) |
4378 | { |
4379 | for (int nbuffers = 2; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4380 | { |
4381 | @@ -359,7 +359,7 @@ |
4382 | } |
4383 | } |
4384 | |
4385 | -TEST_F(BufferQueueTest, framedropping_clients_never_block) |
4386 | +TEST_F(BufferQueueTest, FramedroppingClientsNeverBlock) |
4387 | { |
4388 | for (int nbuffers = 2; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4389 | { |
4390 | @@ -376,7 +376,7 @@ |
4391 | } |
4392 | |
4393 | /* Regression test for LP: #1210042 */ |
4394 | -TEST_F(BufferQueueTest, clients_dont_recycle_startup_buffer) |
4395 | +TEST_F(BufferQueueTest, ClientsDontRecycleStartupBuffer) |
4396 | { |
4397 | mc::BufferQueue q(3, allocator, basic_properties, policy_factory); |
4398 | |
4399 | @@ -394,7 +394,7 @@ |
4400 | q.compositor_release(comp_buffer); |
4401 | } |
4402 | |
4403 | -TEST_F(BufferQueueTest, throws_on_out_of_order_client_release) |
4404 | +TEST_F(BufferQueueTest, ThrowsOnOutOfOrderClientRelease) |
4405 | { |
4406 | for (int nbuffers = 3; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4407 | { |
4408 | @@ -414,7 +414,7 @@ |
4409 | } |
4410 | } |
4411 | |
4412 | -TEST_F(BufferQueueTest, async_client_cycles_through_all_buffers) |
4413 | +TEST_F(BufferQueueTest, AsyncClientCyclesThroughAllBuffers) |
4414 | { |
4415 | for (int nbuffers = 2; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4416 | { |
4417 | @@ -449,7 +449,7 @@ |
4418 | } |
4419 | } |
4420 | |
4421 | -TEST_F(BufferQueueTest, compositor_can_acquire_and_release) |
4422 | +TEST_F(BufferQueueTest, CompositorCanAcquireAndRelease) |
4423 | { |
4424 | for (int nbuffers = 1; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4425 | { |
4426 | @@ -467,7 +467,7 @@ |
4427 | } |
4428 | } |
4429 | |
4430 | -TEST_F(BufferQueueTest, multiple_compositors_are_in_sync) |
4431 | +TEST_F(BufferQueueTest, MultipleCompositorsAreInSync) |
4432 | { |
4433 | for (int nbuffers = 1; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4434 | { |
4435 | @@ -489,7 +489,7 @@ |
4436 | } |
4437 | } |
4438 | |
4439 | -TEST_F(BufferQueueTest, compositor_acquires_frames_in_order) |
4440 | +TEST_F(BufferQueueTest, CompositorAcquiresFramesInOrder) |
4441 | { |
4442 | for (int nbuffers = 2; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4443 | { |
4444 | @@ -523,7 +523,7 @@ |
4445 | } |
4446 | } |
4447 | |
4448 | -TEST_F(BufferQueueTest, compositor_acquire_never_blocks_when_there_are_no_ready_buffers) |
4449 | +TEST_F(BufferQueueTest, CompositorAcquireNeverBlocksWhenThereAreNoReadyBuffers) |
4450 | { |
4451 | for (int nbuffers = 1; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4452 | { |
4453 | @@ -537,7 +537,7 @@ |
4454 | } |
4455 | } |
4456 | |
4457 | -TEST_F(BufferQueueTest, compositor_can_always_acquire_buffer) |
4458 | +TEST_F(BufferQueueTest, CompositorCanAlwaysAcquireBuffer) |
4459 | { |
4460 | for (int nbuffers = 2; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4461 | { |
4462 | @@ -575,7 +575,7 @@ |
4463 | } |
4464 | } |
4465 | |
4466 | -TEST_F(BufferQueueTest, compositor_acquire_recycles_latest_ready_buffer) |
4467 | +TEST_F(BufferQueueTest, CompositorAcquireRecyclesLatestReadyBuffer) |
4468 | { |
4469 | for (int nbuffers = 1; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4470 | { |
4471 | @@ -604,7 +604,7 @@ |
4472 | } |
4473 | } |
4474 | |
4475 | -TEST_F(BufferQueueTest, compositor_release_verifies_parameter) |
4476 | +TEST_F(BufferQueueTest, CompositorReleaseVerifiesParameter) |
4477 | { |
4478 | for (int nbuffers = 1; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4479 | { |
4480 | @@ -621,7 +621,7 @@ |
4481 | } |
4482 | |
4483 | /* Regression test for LP#1270964 */ |
4484 | -TEST_F(BufferQueueTest, compositor_client_interleaved) |
4485 | +TEST_F(BufferQueueTest, CompositorClientInterleaved) |
4486 | { |
4487 | mc::BufferQueue q(3, allocator, basic_properties, policy_factory); |
4488 | |
4489 | @@ -643,7 +643,7 @@ |
4490 | q.compositor_release(compositor_buffer); |
4491 | } |
4492 | |
4493 | -TEST_F(BufferQueueTest, overlapping_compositors_get_different_frames) |
4494 | +TEST_F(BufferQueueTest, OverlappingCompositorsGetDifferentFrames) |
4495 | { |
4496 | // This test simulates bypass behaviour |
4497 | for (int nbuffers = 2; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4498 | @@ -681,7 +681,7 @@ |
4499 | } |
4500 | } |
4501 | |
4502 | -TEST_F(BufferQueueTest, snapshot_acquire_basic) |
4503 | +TEST_F(BufferQueueTest, SnapshotAcquireBasic) |
4504 | { |
4505 | for (int nbuffers = 1; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4506 | { |
4507 | @@ -695,7 +695,7 @@ |
4508 | } |
4509 | } |
4510 | |
4511 | -TEST_F(BufferQueueTest, callbacks_cant_happen_after_shutdown) |
4512 | +TEST_F(BufferQueueTest, CallbacksCantHappenAfterShutdown) |
4513 | { |
4514 | mc::BufferQueue q(1, allocator, basic_properties, policy_factory); |
4515 | |
4516 | @@ -704,7 +704,7 @@ |
4517 | ASSERT_FALSE(client->has_acquired_buffer()); |
4518 | } |
4519 | |
4520 | -TEST_F(BufferQueueTest, callbacks_cant_happen_after_shutdown_with_snapshots) |
4521 | +TEST_F(BufferQueueTest, CallbacksCantHappenAfterShutdownWithSnapshots) |
4522 | { |
4523 | mc::BufferQueue q(1, allocator, basic_properties, policy_factory); |
4524 | |
4525 | @@ -716,7 +716,7 @@ |
4526 | ASSERT_FALSE(client->has_acquired_buffer()); |
4527 | } |
4528 | |
4529 | -TEST_F(BufferQueueTest, snapshot_acquire_never_blocks) |
4530 | +TEST_F(BufferQueueTest, SnapshotAcquireNeverBlocks) |
4531 | { |
4532 | for (int nbuffers = 1; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4533 | { |
4534 | @@ -732,7 +732,7 @@ |
4535 | } |
4536 | } |
4537 | |
4538 | -TEST_F(BufferQueueTest, snapshot_release_verifies_parameter) |
4539 | +TEST_F(BufferQueueTest, SnapshotReleaseVerifiesParameter) |
4540 | { |
4541 | for (int nbuffers = 2; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4542 | { |
4543 | @@ -756,7 +756,7 @@ |
4544 | } |
4545 | } |
4546 | |
4547 | -TEST_F(BufferQueueTest, stress) |
4548 | +TEST_F(BufferQueueTest, Stress) |
4549 | { |
4550 | for (int nbuffers = 2; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4551 | { |
4552 | @@ -789,7 +789,7 @@ |
4553 | } |
4554 | } |
4555 | |
4556 | -TEST_F(BufferQueueTest, framedropping_clients_get_all_buffers) |
4557 | +TEST_F(BufferQueueTest, FramedroppingClientsGetAllBuffers) |
4558 | { |
4559 | for (int nbuffers = 2; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4560 | { |
4561 | @@ -810,7 +810,7 @@ |
4562 | } |
4563 | } |
4564 | |
4565 | -TEST_F(BufferQueueTest, waiting_clients_unblock_on_shutdown) |
4566 | +TEST_F(BufferQueueTest, WaitingClientsUnblockOnShutdown) |
4567 | { |
4568 | for (int nbuffers = 2; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4569 | { |
4570 | @@ -836,7 +836,7 @@ |
4571 | } |
4572 | } |
4573 | |
4574 | -TEST_F(BufferQueueTest, client_framerate_matches_compositor) |
4575 | +TEST_F(BufferQueueTest, ClientFramerateMatchesCompositor) |
4576 | { |
4577 | for (int nbuffers = 2; nbuffers <= 3; nbuffers++) |
4578 | { |
4579 | @@ -889,7 +889,7 @@ |
4580 | } |
4581 | |
4582 | /* Regression test LP: #1241369 / LP: #1241371 */ |
4583 | -TEST_F(BufferQueueTest, slow_client_framerate_matches_compositor) |
4584 | +TEST_F(BufferQueueTest, SlowClientFramerateMatchesCompositor) |
4585 | { |
4586 | /* BufferQueue can only satify this for nbuffers >= 3 |
4587 | * since a client can only own up to nbuffers - 1 at any one time |
4588 | @@ -950,7 +950,7 @@ |
4589 | } |
4590 | } |
4591 | |
4592 | -TEST_F(BufferQueueTest, resize_affects_client_acquires_immediately) |
4593 | +TEST_F(BufferQueueTest, ResizeAffectsClientAcquiresImmediately) |
4594 | { |
4595 | for (int nbuffers = 1; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4596 | { |
4597 | @@ -985,7 +985,7 @@ |
4598 | } |
4599 | } |
4600 | |
4601 | -TEST_F(BufferQueueTest, compositor_acquires_resized_frames) |
4602 | +TEST_F(BufferQueueTest, CompositorAcquiresResizedFrames) |
4603 | { |
4604 | for (int nbuffers = 1; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4605 | { |
4606 | @@ -1050,7 +1050,7 @@ |
4607 | } |
4608 | } |
4609 | |
4610 | -TEST_F(BufferQueueTest, uncomposited_client_swaps_when_policy_triggered) |
4611 | +TEST_F(BufferQueueTest, UncompositedClientSwapsWhenPolicyTriggered) |
4612 | { |
4613 | for (int nbuffers = 2; |
4614 | nbuffers <= max_nbuffers_to_test; |
4615 | @@ -1077,7 +1077,7 @@ |
4616 | } |
4617 | } |
4618 | |
4619 | -TEST_F(BufferQueueTest, partially_composited_client_swaps_when_policy_triggered) |
4620 | +TEST_F(BufferQueueTest, PartiallyCompositedClientSwapsWhenPolicyTriggered) |
4621 | { |
4622 | for (int nbuffers = 2; |
4623 | nbuffers <= max_nbuffers_to_test; |
4624 | @@ -1117,7 +1117,7 @@ |
4625 | } |
4626 | } |
4627 | |
4628 | -TEST_F(BufferQueueTest, with_single_buffer_compositor_acquires_resized_frames_eventually) |
4629 | +TEST_F(BufferQueueTest, WithSingleBufferCompositorAcquiresResizedFramesEventually) |
4630 | { |
4631 | int const nbuffers{1}; |
4632 | geom::Size const new_size{123,456}; |
4633 | @@ -1138,7 +1138,7 @@ |
4634 | q.compositor_release(buf); |
4635 | } |
4636 | |
4637 | -TEST_F(BufferQueueTest, double_buffered_client_is_not_blocked_prematurely) |
4638 | +TEST_F(BufferQueueTest, DoubleBufferedClientIsNotBlockedPrematurely) |
4639 | { // Regression test for LP: #1319765 |
4640 | using namespace testing; |
4641 | |
4642 | @@ -1161,7 +1161,7 @@ |
4643 | handle->release_buffer(); |
4644 | } |
4645 | |
4646 | -TEST_F(BufferQueueTest, composite_on_demand_never_deadlocks_with_2_buffers) |
4647 | +TEST_F(BufferQueueTest, CompositeOnDemandNeverDeadlocksWith_2Buffers) |
4648 | { // Extended regression test for LP: #1319765 |
4649 | using namespace testing; |
4650 | |
4651 | @@ -1201,7 +1201,7 @@ |
4652 | } |
4653 | |
4654 | /* Regression test for LP: #1306464 */ |
4655 | -TEST_F(BufferQueueTest, framedropping_client_acquire_does_not_block_when_no_available_buffers) |
4656 | +TEST_F(BufferQueueTest, FramedroppingClientAcquireDoesNotBlockWhenNoAvailableBuffers) |
4657 | { |
4658 | using namespace testing; |
4659 | |
4660 | @@ -1249,7 +1249,7 @@ |
4661 | EXPECT_THAT(handle->has_acquired_buffer(), Eq(true)); |
4662 | } |
4663 | |
4664 | -TEST_F(BufferQueueTest, compositor_never_owns_client_buffers) |
4665 | +TEST_F(BufferQueueTest, CompositorNeverOwnsClientBuffers) |
4666 | { |
4667 | static std::chrono::nanoseconds const time_for_client_to_acquire{1}; |
4668 | |
4669 | @@ -1307,7 +1307,7 @@ |
4670 | } |
4671 | } |
4672 | |
4673 | -TEST_F(BufferQueueTest, client_never_owns_compositor_buffers) |
4674 | +TEST_F(BufferQueueTest, ClientNeverOwnsCompositorBuffers) |
4675 | { |
4676 | for (int nbuffers = 2; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4677 | { |
4678 | @@ -1343,7 +1343,7 @@ |
4679 | * http://code.launchpad.net/~albaguirre/mir/ |
4680 | * alternative-switching-bundle-implementation/+merge/216606/comments/517048 |
4681 | */ |
4682 | -TEST_F(BufferQueueTest, buffers_are_not_lost) |
4683 | +TEST_F(BufferQueueTest, BuffersAreNotLost) |
4684 | { |
4685 | for (int nbuffers = 3; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4686 | { |
4687 | @@ -1404,7 +1404,7 @@ |
4688 | } |
4689 | |
4690 | /* FIXME (enabling this optimization breaks timing tests) */ |
4691 | -TEST_F(BufferQueueTest, DISABLED_synchronous_clients_only_get_two_real_buffers) |
4692 | +TEST_F(BufferQueueTest, DISABLED_SynchronousClientsOnlyGetTwoRealBuffers) |
4693 | { |
4694 | for (int nbuffers = 2; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4695 | { |
4696 | @@ -1446,7 +1446,7 @@ |
4697 | * just before returning the acquired_buffer at the end of |
4698 | * BufferQueue::compositor_acquire(). |
4699 | */ |
4700 | -TEST_F(BufferQueueTest, DISABLED_lp_1317801_regression_test) |
4701 | +TEST_F(BufferQueueTest, DISABLED_Lp_1317801RegressionTest) |
4702 | { |
4703 | int const nbuffers = 3; |
4704 | mc::BufferQueue q(nbuffers, allocator, basic_properties, policy_factory); |
4705 | @@ -1467,7 +1467,7 @@ |
4706 | q.compositor_release(b); |
4707 | } |
4708 | |
4709 | -TEST_F(BufferQueueTest, first_user_is_recorded) |
4710 | +TEST_F(BufferQueueTest, FirstUserIsRecorded) |
4711 | { |
4712 | for (int nbuffers = 1; nbuffers <= max_nbuffers_to_test; ++nbuffers) |
4713 | { |
4714 | @@ -1479,7 +1479,7 @@ |
4715 | } |
4716 | } |
4717 | |
4718 | -TEST_F(BufferQueueTest, gives_compositor_a_valid_buffer_after_dropping_old_buffers_without_clients) |
4719 | +TEST_F(BufferQueueTest, GivesCompositorAValidBufferAfterDroppingOldBuffersWithoutClients) |
4720 | { |
4721 | int const nbuffers = 3; |
4722 | mc::BufferQueue q(nbuffers, allocator, basic_properties, policy_factory); |
4723 | @@ -1490,7 +1490,7 @@ |
4724 | ASSERT_THAT(comp, Ne(nullptr)); |
4725 | } |
4726 | |
4727 | -TEST_F(BufferQueueTest, gives_compositor_the_newest_buffer_after_dropping_old_buffers) |
4728 | +TEST_F(BufferQueueTest, GivesCompositorTheNewestBufferAfterDroppingOldBuffers) |
4729 | { |
4730 | int const nbuffers = 3; |
4731 | mc::BufferQueue q(nbuffers, allocator, basic_properties, policy_factory); |
4732 | @@ -1513,7 +1513,7 @@ |
4733 | ASSERT_THAT(comp->id(), Eq(handle2->id())); |
4734 | } |
4735 | |
4736 | -TEST_F(BufferQueueTest, gives_new_compositor_the_newest_buffer_after_dropping_old_buffers) |
4737 | +TEST_F(BufferQueueTest, GivesNewCompositorTheNewestBufferAfterDroppingOldBuffers) |
4738 | { |
4739 | int const nbuffers = 3; |
4740 | void const* const new_compositor_id{&nbuffers}; |
4741 | |
4742 | === modified file 'tests/unit-tests/compositor/test_buffer_stream.cpp' |
4743 | --- tests/unit-tests/compositor/test_buffer_stream.cpp 2014-10-29 06:21:10 +0000 |
4744 | +++ tests/unit-tests/compositor/test_buffer_stream.cpp 2014-11-24 02:31:01 +0000 |
4745 | @@ -49,7 +49,7 @@ |
4746 | std::shared_ptr<mtd::MockBufferBundle> mock_bundle; |
4747 | }; |
4748 | |
4749 | -TEST_F(BufferStreamTest, size_query) |
4750 | +TEST_F(BufferStreamTest, SizeQuery) |
4751 | { |
4752 | geom::Size size{4, 5}; |
4753 | mg::BufferProperties properties {size, mir_pixel_format_abgr_8888, mg::BufferUsage::hardware}; |
4754 | @@ -62,7 +62,7 @@ |
4755 | EXPECT_EQ(size, returned_size); |
4756 | } |
4757 | |
4758 | -TEST_F(BufferStreamTest, pixel_format_query) |
4759 | +TEST_F(BufferStreamTest, PixelFormatQuery) |
4760 | { |
4761 | MirPixelFormat format{mir_pixel_format_abgr_8888}; |
4762 | mg::BufferProperties properties {geom::Size{4, 5}, format, mg::BufferUsage::hardware}; |
4763 | @@ -75,7 +75,7 @@ |
4764 | EXPECT_EQ(format, returned_pf); |
4765 | } |
4766 | |
4767 | -TEST_F(BufferStreamTest, force_requests_to_complete) |
4768 | +TEST_F(BufferStreamTest, ForceRequestsToComplete) |
4769 | { |
4770 | EXPECT_CALL(*mock_bundle, force_requests_to_complete()) |
4771 | .Times(2); // Once explcit, once on destruction |
4772 | @@ -84,7 +84,7 @@ |
4773 | buffer_stream.force_requests_to_complete(); |
4774 | } |
4775 | |
4776 | -TEST_F(BufferStreamTest, requests_are_completed_before_destruction) |
4777 | +TEST_F(BufferStreamTest, RequestsAreCompletedBeforeDestruction) |
4778 | { |
4779 | EXPECT_CALL(*mock_bundle, force_requests_to_complete()) |
4780 | .Times(1); |
4781 | @@ -92,37 +92,37 @@ |
4782 | mc::BufferStreamSurfaces buffer_stream(mock_bundle); |
4783 | } |
4784 | |
4785 | -TEST_F(BufferStreamTest, get_buffer_for_compositor_handles_resources) |
4786 | -{ |
4787 | - using namespace testing; |
4788 | - |
4789 | - EXPECT_CALL(*mock_bundle, compositor_acquire(_)) |
4790 | - .Times(1) |
4791 | - .WillOnce(Return(mock_buffer)); |
4792 | - EXPECT_CALL(*mock_bundle, compositor_release(_)) |
4793 | - .Times(1); |
4794 | - |
4795 | - mc::BufferStreamSurfaces buffer_stream(mock_bundle); |
4796 | - |
4797 | - buffer_stream.lock_compositor_buffer(0); |
4798 | -} |
4799 | - |
4800 | -TEST_F(BufferStreamTest, get_buffer_for_compositor_can_lock) |
4801 | -{ |
4802 | - using namespace testing; |
4803 | - |
4804 | - EXPECT_CALL(*mock_bundle, compositor_acquire(_)) |
4805 | - .Times(1) |
4806 | - .WillOnce(Return(mock_buffer)); |
4807 | - EXPECT_CALL(*mock_bundle, compositor_release(_)) |
4808 | - .Times(1); |
4809 | - |
4810 | - mc::BufferStreamSurfaces buffer_stream(mock_bundle); |
4811 | - |
4812 | - buffer_stream.lock_compositor_buffer(0); |
4813 | -} |
4814 | - |
4815 | -TEST_F(BufferStreamTest, get_buffer_for_client_releases_resources) |
4816 | +TEST_F(BufferStreamTest, GetBufferForCompositorHandlesResources) |
4817 | +{ |
4818 | + using namespace testing; |
4819 | + |
4820 | + EXPECT_CALL(*mock_bundle, compositor_acquire(_)) |
4821 | + .Times(1) |
4822 | + .WillOnce(Return(mock_buffer)); |
4823 | + EXPECT_CALL(*mock_bundle, compositor_release(_)) |
4824 | + .Times(1); |
4825 | + |
4826 | + mc::BufferStreamSurfaces buffer_stream(mock_bundle); |
4827 | + |
4828 | + buffer_stream.lock_compositor_buffer(0); |
4829 | +} |
4830 | + |
4831 | +TEST_F(BufferStreamTest, GetBufferForCompositorCanLock) |
4832 | +{ |
4833 | + using namespace testing; |
4834 | + |
4835 | + EXPECT_CALL(*mock_bundle, compositor_acquire(_)) |
4836 | + .Times(1) |
4837 | + .WillOnce(Return(mock_buffer)); |
4838 | + EXPECT_CALL(*mock_bundle, compositor_release(_)) |
4839 | + .Times(1); |
4840 | + |
4841 | + mc::BufferStreamSurfaces buffer_stream(mock_bundle); |
4842 | + |
4843 | + buffer_stream.lock_compositor_buffer(0); |
4844 | +} |
4845 | + |
4846 | +TEST_F(BufferStreamTest, GetBufferForClientReleasesResources) |
4847 | { |
4848 | std::mutex mutex; |
4849 | std::condition_variable cv; |
4850 | @@ -172,7 +172,7 @@ |
4851 | } |
4852 | } |
4853 | |
4854 | -TEST_F(BufferStreamTest, allow_framedropping_device) |
4855 | +TEST_F(BufferStreamTest, AllowFramedroppingDevice) |
4856 | { |
4857 | EXPECT_CALL(*mock_bundle, allow_framedropping(true)) |
4858 | .Times(1); |
4859 | @@ -181,7 +181,7 @@ |
4860 | buffer_stream.allow_framedropping(true); |
4861 | } |
4862 | |
4863 | -TEST_F(BufferStreamTest, resizes_bundle) |
4864 | +TEST_F(BufferStreamTest, ResizesBundle) |
4865 | { |
4866 | geom::Size const new_size{66, 77}; |
4867 | |
4868 | |
4869 | === modified file 'tests/unit-tests/compositor/test_compositing_screencast.cpp' |
4870 | --- tests/unit-tests/compositor/test_compositing_screencast.cpp 2014-10-29 06:21:10 +0000 |
4871 | +++ tests/unit-tests/compositor/test_compositing_screencast.cpp 2014-11-24 02:31:01 +0000 |
4872 | @@ -194,7 +194,7 @@ |
4873 | |
4874 | } |
4875 | |
4876 | -TEST_F(CompositingScreencastTest, produces_different_session_ids) |
4877 | +TEST_F(CompositingScreencastTest, ProducesDifferentSessionIds) |
4878 | { |
4879 | std::unordered_set<mf::ScreencastSessionId> session_ids; |
4880 | |
4881 | @@ -207,7 +207,7 @@ |
4882 | } |
4883 | } |
4884 | |
4885 | -TEST_F(CompositingScreencastTest, throws_on_creation_with_invalid_params) |
4886 | +TEST_F(CompositingScreencastTest, ThrowsOnCreationWithInvalidParams) |
4887 | { |
4888 | std::unordered_set<mf::ScreencastSessionId> session_ids; |
4889 | geom::Size invalid_size{0, 0}; |
4890 | @@ -218,20 +218,20 @@ |
4891 | EXPECT_THROW(screencast.create_session(default_region, default_size, mir_pixel_format_invalid), std::runtime_error); |
4892 | } |
4893 | |
4894 | -TEST_F(CompositingScreencastTest, throws_on_capture_with_invalid_session_id) |
4895 | +TEST_F(CompositingScreencastTest, ThrowsOnCaptureWithInvalidSessionId) |
4896 | { |
4897 | mf::ScreencastSessionId const invalid_session_id{10}; |
4898 | EXPECT_THROW(screencast.capture(invalid_session_id), std::logic_error); |
4899 | } |
4900 | |
4901 | -TEST_F(CompositingScreencastTest, throws_on_capture_with_destroyed_session_id) |
4902 | +TEST_F(CompositingScreencastTest, ThrowsOnCaptureWithDestroyedSessionId) |
4903 | { |
4904 | auto session_id = screencast.create_session(default_region, default_size, default_pixel_format); |
4905 | screencast.destroy_session(session_id); |
4906 | EXPECT_THROW(screencast.capture(session_id), std::logic_error); |
4907 | } |
4908 | |
4909 | -TEST_F(CompositingScreencastTest, captures_by_compositing_with_provided_region) |
4910 | +TEST_F(CompositingScreencastTest, CapturesByCompositingWithProvidedRegion) |
4911 | { |
4912 | using namespace testing; |
4913 | |
4914 | @@ -259,7 +259,7 @@ |
4915 | screencast_local.capture(session_id); |
4916 | } |
4917 | |
4918 | -TEST_F(CompositingScreencastTest, allocates_and_uses_buffer_with_provided_size) |
4919 | +TEST_F(CompositingScreencastTest, AllocatesAndUsesBufferWithProvidedSize) |
4920 | { |
4921 | using namespace testing; |
4922 | |
4923 | @@ -283,7 +283,7 @@ |
4924 | ASSERT_EQ(&stub_buffer, buffer.get()); |
4925 | } |
4926 | |
4927 | -TEST_F(CompositingScreencastTest, uses_one_buffer_per_session) |
4928 | +TEST_F(CompositingScreencastTest, UsesOneBufferPerSession) |
4929 | { |
4930 | using namespace testing; |
4931 | |
4932 | @@ -314,7 +314,7 @@ |
4933 | ASSERT_EQ(&stub_buffer2, buffer2.get()); |
4934 | } |
4935 | |
4936 | -TEST_F(CompositingScreencastTest, registers_and_unregisters_from_scene) |
4937 | +TEST_F(CompositingScreencastTest, RegistersAndUnregistersFromScene) |
4938 | { |
4939 | using namespace testing; |
4940 | NiceMock<mtd::MockScene> mock_scene; |
4941 | |
4942 | === modified file 'tests/unit-tests/compositor/test_default_display_buffer_compositor.cpp' |
4943 | --- tests/unit-tests/compositor/test_default_display_buffer_compositor.cpp 2014-11-16 09:50:19 +0000 |
4944 | +++ tests/unit-tests/compositor/test_default_display_buffer_compositor.cpp 2014-11-24 02:31:01 +0000 |
4945 | @@ -113,7 +113,7 @@ |
4946 | }; |
4947 | } |
4948 | |
4949 | -TEST_F(DefaultDisplayBufferCompositor, render) |
4950 | +TEST_F(DefaultDisplayBufferCompositor, Render) |
4951 | { |
4952 | using namespace testing; |
4953 | EXPECT_CALL(mock_renderer, render(IsEmpty())) |
4954 | @@ -132,7 +132,7 @@ |
4955 | compositor.composite(make_scene_elements({})); |
4956 | } |
4957 | |
4958 | -TEST_F(DefaultDisplayBufferCompositor, skips_scene_that_should_not_be_rendered) |
4959 | +TEST_F(DefaultDisplayBufferCompositor, SkipsSceneThatShouldNotBeRendered) |
4960 | { |
4961 | using namespace testing; |
4962 | |
4963 | @@ -188,7 +188,7 @@ |
4964 | })); |
4965 | } |
4966 | |
4967 | -TEST_F(DefaultDisplayBufferCompositor, optimization_skips_composition) |
4968 | +TEST_F(DefaultDisplayBufferCompositor, OptimizationSkipsComposition) |
4969 | { |
4970 | using namespace testing; |
4971 | auto report = std::make_shared<mtd::MockCompositorReport>(); |
4972 | @@ -214,7 +214,7 @@ |
4973 | compositor.composite(make_scene_elements({})); |
4974 | } |
4975 | |
4976 | -TEST_F(DefaultDisplayBufferCompositor, calls_renderer_in_sequence) |
4977 | +TEST_F(DefaultDisplayBufferCompositor, CallsRendererInSequence) |
4978 | { |
4979 | using namespace testing; |
4980 | Sequence render_seq; |
4981 | @@ -243,7 +243,7 @@ |
4982 | })); |
4983 | } |
4984 | |
4985 | -TEST_F(DefaultDisplayBufferCompositor, optimization_toggles_seamlessly) |
4986 | +TEST_F(DefaultDisplayBufferCompositor, OptimizationTogglesSeamlessly) |
4987 | { |
4988 | using namespace testing; |
4989 | ON_CALL(display_buffer, view_area()) |
4990 | @@ -298,7 +298,7 @@ |
4991 | fullscreen->set_buffer({}); // Avoid GMock complaining about false leaks |
4992 | } |
4993 | |
4994 | -TEST_F(DefaultDisplayBufferCompositor, occluded_surfaces_are_not_rendered) |
4995 | +TEST_F(DefaultDisplayBufferCompositor, OccludedSurfacesAreNotRendered) |
4996 | { |
4997 | using namespace testing; |
4998 | EXPECT_CALL(display_buffer, view_area()) |
4999 | @@ -356,7 +356,7 @@ |
5000 | }; |
FAILED: Continuous integration, rev:2085 jenkins. qa.ubuntu. com/job/ mir-ci/ 2218/ jenkins. qa.ubuntu. com/job/ mir-android- vivid-i386- build/294/ console jenkins. qa.ubuntu. com/job/ mir-clang- vivid-amd64- build/294/ console jenkins. qa.ubuntu. com/job/ mir-mediumtests -vivid- touch/268/ console jenkins. qa.ubuntu. com/job/ mir-vivid- amd64-ci/ 207/console jenkins. qa.ubuntu. com/job/ mir-mediumtests -builder- vivid-armhf/ 268/console
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/mir- ci/2218/ rebuild
http://