lp:~raof/mir/i-hate-using-explicitly-forbidden-names
Created by
Chris Halse Rogers
and last modified
- Get this branch:
- bzr branch lp:~raof/mir/i-hate-using-explicitly-forbidden-names
Only
Chris Halse Rogers
can upload to this branch. If you are
Chris Halse Rogers
please log in for upload directions.
Branch merges
Propose for merging
No branches
dependent on this one.
- Cemil Azizoglu (community): Abstain
- Alan Griffiths: Disapprove
- Alexandros Frantzis (community): Disapprove
- Daniel van Vugt: Needs Fixing
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 14680 lines (+1598/-1598)254 files modifiedtests/acceptance-tests/server_configuration_options.cpp (+7/-7)
tests/acceptance-tests/server_configuration_wrapping.cpp (+6/-6)
tests/acceptance-tests/server_signal_handling.cpp (+4/-4)
tests/acceptance-tests/test_client_authorization.cpp (+2/-2)
tests/acceptance-tests/test_client_cursor_api.cpp (+5/-5)
tests/acceptance-tests/test_client_focus_notification.cpp (+2/-2)
tests/acceptance-tests/test_client_header_version.cpp (+2/-2)
tests/acceptance-tests/test_client_input.cpp (+11/-11)
tests/acceptance-tests/test_client_library.cpp (+15/-15)
tests/acceptance-tests/test_client_library_drm.cpp (+1/-1)
tests/acceptance-tests/test_client_library_errors.cpp (+9/-9)
tests/acceptance-tests/test_client_library_old.cpp (+2/-2)
tests/acceptance-tests/test_client_screencast.cpp (+7/-7)
tests/acceptance-tests/test_client_surface_events.cpp (+3/-3)
tests/acceptance-tests/test_client_surface_swap_buffers.cpp (+1/-1)
tests/acceptance-tests/test_client_surface_visibility.cpp (+4/-4)
tests/acceptance-tests/test_client_surfaces.cpp (+3/-3)
tests/acceptance-tests/test_command_line_handling.cpp (+4/-4)
tests/acceptance-tests/test_custom_input_dispatcher.cpp (+3/-3)
tests/acceptance-tests/test_debug_api.cpp (+2/-2)
tests/acceptance-tests/test_display_configuration.cpp (+7/-7)
tests/acceptance-tests/test_focus_selection.cpp (+2/-2)
tests/acceptance-tests/test_large_messages.cpp (+1/-1)
tests/acceptance-tests/test_nested_mir.cpp (+4/-4)
tests/acceptance-tests/test_prompt_session_client_api.cpp (+11/-11)
tests/acceptance-tests/test_server_disconnect.cpp (+3/-3)
tests/acceptance-tests/test_server_shutdown.cpp (+7/-7)
tests/acceptance-tests/test_server_startup.cpp (+2/-2)
tests/acceptance-tests/test_server_without_active_outputs.cpp (+1/-1)
tests/acceptance-tests/test_shell_control_of_surface_configuration.cpp (+2/-2)
tests/acceptance-tests/test_surfaces_with_output_id.cpp (+2/-2)
tests/acceptance-tests/test_symbols_required_by_mesa.cpp (+2/-2)
tests/acceptance-tests/test_touchspot_visualization.cpp (+2/-2)
tests/acceptance-tests/test_unresponsive_client.cpp (+1/-1)
tests/integration-tests/client/test_screencast.cpp (+2/-2)
tests/integration-tests/compositor/test_buffer_stream.cpp (+8/-8)
tests/integration-tests/compositor/test_swapping_swappers.cpp (+2/-2)
tests/integration-tests/compositor/test_synchronizer.cpp (+2/-2)
tests/integration-tests/frontend/test_session_mediator_report.cpp (+8/-8)
tests/integration-tests/graphics/android/test_buffer_integration.cpp (+3/-3)
tests/integration-tests/graphics/android/test_client_render.cpp (+4/-4)
tests/integration-tests/graphics/android/test_display_integration.cpp (+2/-2)
tests/integration-tests/graphics/android/test_internal_client.cpp (+1/-1)
tests/integration-tests/graphics/mesa/test_buffer_integration.cpp (+3/-3)
tests/integration-tests/input/android/test_android_cursor_listener.cpp (+1/-1)
tests/integration-tests/input/android/test_android_input_manager.cpp (+6/-6)
tests/integration-tests/input/test_configuring_input_manager.cpp (+1/-1)
tests/integration-tests/input/test_nested_input.cpp (+1/-1)
tests/integration-tests/session_management.cpp (+2/-2)
tests/integration-tests/shell/test_session_lifecycle_event.cpp (+1/-1)
tests/integration-tests/surface_composition.cpp (+1/-1)
tests/integration-tests/test_client_surface_swap_buffers.cpp (+1/-1)
tests/integration-tests/test_display_info.cpp (+1/-1)
tests/integration-tests/test_display_server_main_loop_events.cpp (+8/-8)
tests/integration-tests/test_drm_auth_magic.cpp (+2/-2)
tests/integration-tests/test_error_reporting.cpp (+2/-2)
tests/integration-tests/test_exchange_buffer.cpp (+2/-2)
tests/integration-tests/test_macros.cpp (+1/-1)
tests/integration-tests/test_protobuf.cpp (+4/-4)
tests/integration-tests/test_server_client_types.cpp (+1/-1)
tests/integration-tests/test_server_shutdown.cpp (+2/-2)
tests/integration-tests/test_session.cpp (+1/-1)
tests/integration-tests/test_session_manager.cpp (+2/-2)
tests/integration-tests/test_stale_frames.cpp (+2/-2)
tests/integration-tests/test_surface_first_frame_sync.cpp (+1/-1)
tests/integration-tests/test_surface_stack_with_compositor.cpp (+9/-9)
tests/integration-tests/test_surfaceloop.cpp (+2/-2)
tests/integration-tests/test_swapinterval.cpp (+1/-1)
tests/integration-tests/test_test_framework.cpp (+4/-4)
tests/performance-tests/test_glmark2-es2-mir.cpp (+1/-1)
tests/unit-tests/android_input/input_reader.cpp (+1/-1)
tests/unit-tests/android_input/int_set.cpp (+8/-8)
tests/unit-tests/android_input/property_map.cpp (+10/-10)
tests/unit-tests/android_input/sha1.cpp (+1/-1)
tests/unit-tests/android_input/sorted_vector.cpp (+13/-13)
tests/unit-tests/android_input/string8.cpp (+2/-2)
tests/unit-tests/client/android/test_android_client_platform.cpp (+2/-2)
tests/unit-tests/client/android/test_android_native_window.cpp (+25/-25)
tests/unit-tests/client/android/test_buffer.cpp (+4/-4)
tests/unit-tests/client/android/test_client_surface_interpreter.cpp (+12/-12)
tests/unit-tests/client/android/test_gralloc_registrar.cpp (+10/-10)
tests/unit-tests/client/input/test_android_input_receiver.cpp (+7/-7)
tests/unit-tests/client/input/test_android_input_receiver_thread.cpp (+3/-3)
tests/unit-tests/client/input/test_xkb_mapper.cpp (+3/-3)
tests/unit-tests/client/mesa/test_client_buffer.cpp (+9/-9)
tests/unit-tests/client/mesa/test_client_platform.cpp (+1/-1)
tests/unit-tests/client/mesa/test_mesa_native_display_container.cpp (+2/-2)
tests/unit-tests/client/mesa/test_native_surface.cpp (+8/-8)
tests/unit-tests/client/test_aging_buffer.cpp (+4/-4)
tests/unit-tests/client/test_android_client_buffer_factory.cpp (+1/-1)
tests/unit-tests/client/test_client.cpp (+2/-2)
tests/unit-tests/client/test_client_buffer_depository.cpp (+14/-14)
tests/unit-tests/client/test_client_display_conf.cpp (+1/-1)
tests/unit-tests/client/test_client_mir_surface.cpp (+16/-16)
tests/unit-tests/client/test_client_platform.cpp (+4/-4)
tests/unit-tests/client/test_event_distributor.cpp (+4/-4)
tests/unit-tests/client/test_mir_connection.cpp (+11/-11)
tests/unit-tests/client/test_mir_prompt_session.cpp (+5/-5)
tests/unit-tests/client/test_mir_screencast.cpp (+13/-13)
tests/unit-tests/client/test_periodic_perf_report.cpp (+3/-3)
tests/unit-tests/client/test_wait_handle.cpp (+5/-5)
tests/unit-tests/compositor/test_buffer_queue.cpp (+48/-48)
tests/unit-tests/compositor/test_buffer_stream.cpp (+37/-37)
tests/unit-tests/compositor/test_compositing_screencast.cpp (+8/-8)
tests/unit-tests/compositor/test_default_display_buffer_compositor.cpp (+9/-9)
tests/unit-tests/compositor/test_gl_renderer.cpp (+5/-5)
tests/unit-tests/compositor/test_gl_texture_cache.cpp (+3/-3)
tests/unit-tests/compositor/test_multi_threaded_compositor.cpp (+11/-11)
tests/unit-tests/compositor/test_occlusion.cpp (+11/-11)
tests/unit-tests/compositor/test_screencast_display_buffer.cpp (+7/-7)
tests/unit-tests/compositor/test_temporary_buffers.cpp (+8/-8)
tests/unit-tests/compositor/test_timeout_frame_dropping_policy.cpp (+7/-7)
tests/unit-tests/examples/test_demo_compositor.cpp (+1/-1)
tests/unit-tests/examples/test_demo_renderer.cpp (+1/-1)
tests/unit-tests/frontend/stress_protobuf_communicator.cpp (+1/-1)
tests/unit-tests/frontend/test_basic_connector.cpp (+1/-1)
tests/unit-tests/frontend/test_client_buffer_tracker.cpp (+34/-34)
tests/unit-tests/frontend/test_event_sender.cpp (+3/-3)
tests/unit-tests/frontend/test_protobuf_buffer_packer.cpp (+3/-3)
tests/unit-tests/frontend/test_protobuf_message_processor.cpp (+1/-1)
tests/unit-tests/frontend/test_protobuf_reports_errors.cpp (+2/-2)
tests/unit-tests/frontend/test_protobuf_surface_apis.cpp (+2/-2)
tests/unit-tests/frontend/test_published_socket_connector.cpp (+9/-9)
tests/unit-tests/frontend/test_resource_cache.cpp (+3/-3)
tests/unit-tests/frontend/test_session_mediator.cpp (+24/-24)
tests/unit-tests/frontend/test_socket_connection.cpp (+6/-6)
tests/unit-tests/frontend/test_unauthorized_display_changer.cpp (+2/-2)
tests/unit-tests/geometry/test-dimensions.cpp (+6/-6)
tests/unit-tests/geometry/test-displacement.cpp (+3/-3)
tests/unit-tests/geometry/test-length.cpp (+6/-6)
tests/unit-tests/geometry/test-point.cpp (+2/-2)
tests/unit-tests/geometry/test-rectangle.cpp (+8/-8)
tests/unit-tests/geometry/test-rectangles.cpp (+7/-7)
tests/unit-tests/geometry/test-size.cpp (+1/-1)
tests/unit-tests/graphics/android/test_android_alloc_adaptor.cpp (+18/-18)
tests/unit-tests/graphics/android/test_android_buffer_allocator.cpp (+4/-4)
tests/unit-tests/graphics/android/test_buffer.cpp (+4/-4)
tests/unit-tests/graphics/android/test_buffer_tex_bind.cpp (+41/-41)
tests/unit-tests/graphics/android/test_device_detection.cpp (+4/-4)
tests/unit-tests/graphics/android/test_display.cpp (+8/-8)
tests/unit-tests/graphics/android/test_display_buffer.cpp (+19/-19)
tests/unit-tests/graphics/android/test_fb_device.cpp (+6/-6)
tests/unit-tests/graphics/android/test_fb_simple_swapper.cpp (+10/-10)
tests/unit-tests/graphics/android/test_hwc_common_device.cpp (+11/-11)
tests/unit-tests/graphics/android/test_hwc_device.cpp (+18/-18)
tests/unit-tests/graphics/android/test_hwc_fallback_gl_renderer.cpp (+6/-6)
tests/unit-tests/graphics/android/test_hwc_fb_device.cpp (+3/-3)
tests/unit-tests/graphics/android/test_hwc_layerlist.cpp (+3/-3)
tests/unit-tests/graphics/android/test_hwc_layers.cpp (+8/-8)
tests/unit-tests/graphics/android/test_hwc_logger.cpp (+8/-8)
tests/unit-tests/graphics/android/test_hwc_wrapper.cpp (+9/-9)
tests/unit-tests/graphics/android/test_internal_client.cpp (+2/-2)
tests/unit-tests/graphics/android/test_internal_client_interpreter.cpp (+4/-4)
tests/unit-tests/graphics/android/test_interpreter_buffer_cache.cpp (+5/-5)
tests/unit-tests/graphics/android/test_ipc_operations.cpp (+1/-1)
tests/unit-tests/graphics/android/test_native_buffer.cpp (+8/-8)
tests/unit-tests/graphics/android/test_output_builder.cpp (+6/-6)
tests/unit-tests/graphics/android/test_pixel_format.cpp (+2/-2)
tests/unit-tests/graphics/android/test_platform.cpp (+6/-6)
tests/unit-tests/graphics/android/test_resource_factory.cpp (+4/-4)
tests/unit-tests/graphics/android/test_server_interpreter.cpp (+9/-9)
tests/unit-tests/graphics/android/test_sync_fence.cpp (+4/-4)
tests/unit-tests/graphics/egl_mock/egl_mock_test.cpp (+2/-2)
tests/unit-tests/graphics/mesa/test_anonymous_shm_file.cpp (+3/-3)
tests/unit-tests/graphics/mesa/test_buffer_allocator.cpp (+16/-16)
tests/unit-tests/graphics/mesa/test_bypass.cpp (+20/-20)
tests/unit-tests/graphics/mesa/test_cursor.cpp (+17/-17)
tests/unit-tests/graphics/mesa/test_display.cpp (+22/-22)
tests/unit-tests/graphics/mesa/test_display_buffer.cpp (+13/-13)
tests/unit-tests/graphics/mesa/test_display_configuration.cpp (+5/-5)
tests/unit-tests/graphics/mesa/test_display_multi_monitor.cpp (+6/-6)
tests/unit-tests/graphics/mesa/test_drm_helper.cpp (+1/-1)
tests/unit-tests/graphics/mesa/test_gbm_buffer.cpp (+8/-8)
tests/unit-tests/graphics/mesa/test_internal_client.cpp (+2/-2)
tests/unit-tests/graphics/mesa/test_internal_native_display.cpp (+1/-1)
tests/unit-tests/graphics/mesa/test_internal_native_surface.cpp (+2/-2)
tests/unit-tests/graphics/mesa/test_kms_page_flipper.cpp (+9/-9)
tests/unit-tests/graphics/mesa/test_linux_virtual_terminal.cpp (+15/-15)
tests/unit-tests/graphics/mesa/test_native_platform.cpp (+2/-2)
tests/unit-tests/graphics/mesa/test_platform.cpp (+11/-11)
tests/unit-tests/graphics/mesa/test_real_kms_output.cpp (+7/-7)
tests/unit-tests/graphics/mesa/test_shm_buffer.cpp (+4/-4)
tests/unit-tests/graphics/nested/test_nested_display.cpp (+3/-3)
tests/unit-tests/graphics/nested/test_nested_display_buffer.cpp (+2/-2)
tests/unit-tests/graphics/nested/test_nested_display_configuration.cpp (+7/-7)
tests/unit-tests/graphics/nested/test_nested_platform.cpp (+1/-1)
tests/unit-tests/graphics/offscreen/test_offscreen_display.cpp (+4/-4)
tests/unit-tests/graphics/test_buffer_id.cpp (+1/-1)
tests/unit-tests/graphics/test_buffer_properties.cpp (+4/-4)
tests/unit-tests/graphics/test_default_display_configuration_policy.cpp (+7/-7)
tests/unit-tests/graphics/test_display.cpp (+4/-4)
tests/unit-tests/graphics/test_display_configuration.cpp (+19/-19)
tests/unit-tests/graphics/test_egl_extensions.cpp (+3/-3)
tests/unit-tests/graphics/test_graphics_platform.cpp (+3/-3)
tests/unit-tests/graphics/test_overlapping_output_grouping.cpp (+9/-9)
tests/unit-tests/graphics/test_pixel_format_utils.cpp (+6/-6)
tests/unit-tests/graphics/test_program_factory.cpp (+4/-4)
tests/unit-tests/input/android/test_android_communication_package.cpp (+1/-1)
tests/unit-tests/input/android/test_android_input_application_handle.cpp (+1/-1)
tests/unit-tests/input/android/test_android_input_dispatcher.cpp (+4/-4)
tests/unit-tests/input/android/test_android_input_lexicon.cpp (+3/-3)
tests/unit-tests/input/android/test_android_input_manager.cpp (+3/-3)
tests/unit-tests/input/android/test_android_input_reader_policy.cpp (+1/-1)
tests/unit-tests/input/android/test_android_input_registrar.cpp (+3/-3)
tests/unit-tests/input/android/test_android_input_sender.cpp (+16/-16)
tests/unit-tests/input/android/test_android_input_target_enumerator.cpp (+1/-1)
tests/unit-tests/input/android/test_android_input_targeter.cpp (+3/-3)
tests/unit-tests/input/android/test_android_input_window_handle.cpp (+1/-1)
tests/unit-tests/input/android/test_android_pointer_controller.cpp (+4/-4)
tests/unit-tests/input/android/test_event_filter_input_dispatcher_policy.cpp (+2/-2)
tests/unit-tests/input/android/test_input_translator.cpp (+13/-13)
tests/unit-tests/input/test_cursor_controller.cpp (+8/-8)
tests/unit-tests/input/test_display_input_region.cpp (+2/-2)
tests/unit-tests/input/test_event_filter_chain.cpp (+4/-4)
tests/unit-tests/input/test_touchspot_controller.cpp (+7/-7)
tests/unit-tests/input/test_xcursor_loader.cpp (+4/-4)
tests/unit-tests/logging/message_processor_report.cpp (+8/-8)
tests/unit-tests/logging/test_compositor_report.cpp (+3/-3)
tests/unit-tests/logging/test_display_report.cpp (+1/-1)
tests/unit-tests/logging/test_legacy_input_report.cpp (+6/-6)
tests/unit-tests/options/test_program_option.cpp (+10/-10)
tests/unit-tests/scene/test_application_session.cpp (+14/-14)
tests/unit-tests/scene/test_basic_surface.cpp (+28/-28)
tests/unit-tests/scene/test_broadcasting_session_event_sink.cpp (+3/-3)
tests/unit-tests/scene/test_gl_pixel_buffer.cpp (+3/-3)
tests/unit-tests/scene/test_global_event_sender.cpp (+1/-1)
tests/unit-tests/scene/test_legacy_scene_change_notification.cpp (+6/-6)
tests/unit-tests/scene/test_mediating_display_changer.cpp (+14/-14)
tests/unit-tests/scene/test_prompt_session_container.cpp (+7/-7)
tests/unit-tests/scene/test_prompt_session_manager.cpp (+10/-10)
tests/unit-tests/scene/test_rendering_tracker.cpp (+7/-7)
tests/unit-tests/scene/test_session_manager.cpp (+5/-5)
tests/unit-tests/scene/test_surface.cpp (+22/-22)
tests/unit-tests/scene/test_surface_controller.cpp (+4/-4)
tests/unit-tests/scene/test_surface_impl.cpp (+11/-11)
tests/unit-tests/scene/test_surface_stack.cpp (+27/-27)
tests/unit-tests/scene/test_the_session_container_implementation.cpp (+3/-3)
tests/unit-tests/scene/test_threaded_snapshot_strategy.cpp (+2/-2)
tests/unit-tests/shared_library_test.cpp (+8/-8)
tests/unit-tests/shell/test_default_focus_mechanism.cpp (+3/-3)
tests/unit-tests/shell/test_default_placement_strategy.cpp (+1/-1)
tests/unit-tests/shell/test_graphics_display_layout.cpp (+4/-4)
tests/unit-tests/test_asio_main_loop.cpp (+25/-25)
tests/unit-tests/test_default_emergency_cleanup.cpp (+3/-3)
tests/unit-tests/test_fatal.cpp (+3/-3)
tests/unit-tests/test_fd.cpp (+3/-3)
tests/unit-tests/test_glib_main_loop.cpp (+34/-34)
tests/unit-tests/test_gmock_fixes.cpp (+1/-1)
tests/unit-tests/test_raii.cpp (+10/-10)
tests/unit-tests/test_recursive_read_write_mutex.cpp (+17/-17)
tests/unit-tests/test_thread_name.cpp (+2/-2)
tests/unit-tests/test_thread_safe_list.cpp (+4/-4)
tests/unit-tests/test_variable_length_array.cpp (+6/-6)
tests/unit-tests/thread/test_basic_thread_pool.cpp (+5/-5)
Related source package recipes
Related bugs
Related blueprints
Branch information
Recent revisions
- 2095. By Chris Halse Rogers
-
The great un-should-
not-ening. The Google Test docs explicitly say that you should not name_tests_
like_this.
Which, for some reason unknown to me, is our style.For some reason this annoys me everytime I propose a new test.
Change all the snake_case_named tests to CamelCaseNamed tests
- 2094. By Alan Griffiths
-
1. "privatized" headers no longer be available throughout Mir codebase. (Especially not examples and acceptance tests.)
2. Some headers re-published as they are required by features in the acceptance tests and examples.Approved by PS Jenkins bot, Alexandros Frantzis, Kevin DuBois.
- 2093. By Alan Griffiths
-
tests: default to no logging with an option to enable it. Fixes: https:/
/bugs.launchpad .net/bugs/ 1394221. Approved by PS Jenkins bot, Cemil Azizoglu.
- 2092. By Kevin DuBois
-
doc: update the build docs for ARM.
Approved by PS Jenkins bot, Alexandros Frantzis, Alberto Aguirre.
- 2091. By Kevin DuBois
-
mesa: designate an interface that the mesa ipc operations can use.
mgm::helpers::DRMHelper is the implementation for the host server, and NestedAuthentic ation (a new implementation cobbled together from existing code) is the implementation for the nested server to get drm. Approved by Alberto Aguirre, Alan Griffiths, PS Jenkins bot, Alexandros Frantzis.
- 2090. By Alan Griffiths
-
tests: fix commandline handling in tests.
Approved by Cemil Azizoglu, Alberto Aguirre, PS Jenkins bot.
- 2089. By Daniel van Vugt
-
Automatically insert a useful component string into every log message.
The default is the library name, but you can customize it by adding
this to the top of your source file:
#define MIR_LOGGING_COMPONENT "foo"
.Approved by PS Jenkins bot, Robert Carr, Alberto Aguirre.
- 2087. By Daniel van Vugt
-
(Re)introduce desktop zoom support to the demo shell.
Just use Super+mousewheel to zoom.Approved by Kevin DuBois, Cemil Azizoglu, PS Jenkins bot.
- 2086. By Alexandros Frantzis
-
server: Fix race in BasicThreadPool
Ensure a task is removed from the task queue before notifying that the task is
done. Otherwise, scheduling new tasks based on these notifications may cause
unnecessary threads to be created.
. Fixes: https://bugs.launchpad .net/bugs/ 1391488. Approved by PS Jenkins bot, Robert Carr, Alberto Aguirre, Alan Griffiths.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:mir
