Mir

Code review comment for lp:~raof/mir/hide-internal-symbols

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> >> The plugin could inspect each function definition as it compiles, and if
> the source location of
> >> the declaration is in <root>/include/ mark it public. (I.e. write it to a
> symbols file?)
>
> Then we would strip the symbol after build?

Well, after compiling: during the link part of the build.

> Seems cool I guess...I think it's
> kind of a pain to write MIR_INTERNAL everywhere

The sad thing is that the compiler plugin [https://fedorahosted.org/gcc-python-plugin/] isn't part of the Ubuntu archive - and as it is "alpha" code we probably shouldn't make it an integral part of our build process.

« Back to merge proposal