Mir

Code review comment for lp:~raof/mir/hide-internal-symbols

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

I *think* we can do better than this. I'm not sure how yet but have started thinking about it.

My idea solution wouldn't use macros but would use the location of the include files to control visibility.

Maybe we can use the GCC python plugin. There's an example:
http://blog.cuviper.com/2014/01/23/add-new-warnings-to-gcc-with-python/

The plugin could inspect each function definition as it compiles, and if the source location of the declaration is in <root>/include/ mark it public. (I.e. write it to a symbols file?)

Or something similar based on libclang?

Anyway, not for this week.

review: Abstain

« Back to merge proposal