Code review comment for lp:~raof/mir/hate-hate-hate-on-the-cmake
Revision history for this message
| Chris Halse Rogers (raof) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Specifically: test-memcheck is a test to test that valgrind *fails with an error* when run against a program that generates a known-bad memory access. So, for the test to pass, valgrind needs to return 1; which it does, but this normally indicates that a test has *failed*, so we need to invert the test success condition.
Which fail_on_success.sh does. Is it's name confusing?