Mir

Code review comment for lp:~raof/mir/factor-out-gbm-output-surface

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Sounds like a sane plan on the surface of it.

I would point out that you've deleted some test cases, but assuming that rotation happens only on construction is an outdated idea. Plus I'm about to change that logic even more soon...

review: Approve

« Back to merge proposal