Mir

Code review comment for lp:~raof/mir/dont-kill-the-poor-clients

Revision history for this message
Chris Halse Rogers (raof) wrote :

Hm. Expanding on that - it tries, but fails, to stub out the client platform. It's got at configuration() override, but this is never called.

The DefaultConnectionAPI is constructed in mir_connection_api.cpp, and that uses DefaultMirConnectionAPI's configuration().

Then UsingStubClientPlatform comes along, and interposes StubMirConnectionAPI's connect() method before the default, but then calls the default API's connect(), which calls DefaultConfigurationAPI's configuration().

Since UsingStubClientPlatform wasn't actually doing anything, I removed it.

« Back to merge proposal