Code review comment for lp:~raof/mir/client-side-buffer-age

246 void deposit_package(std::shared_ptr<mir_toolkit::MirBufferPackage> && package, int, geometry::Size size, geometry::PixelFormat pf);

I guess this MP didn't create this (so I wouldn't block on it). But WHY a rvalue-reference to a shared pointer?! A const ref would be idiomatic and work better. It would be nice to clean this up while changing this code.
~~~~~~

Every time I look at that code I'm tempted to make deposit_package take a mir::protobuf::Buffer. The MirSurface does nothing with the m::p::Buffer but copy the values to a MirBufferPackage which it promptly hands off to the depository and forgets.

That's probably more controversial, though.