Mir

Code review comment for lp:~raof/mir/check-for-surfaceless

Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

I think

16 + khr_surfaceless_context(strstr(eglQueryString(egl_display, EGL_EXTENSIONS), "EGL_KHR_surfaceless_context") != nullptr)
 wants to be a utility function for querying egl extension existance

You could also turn
20 + egl_surface( .... )

 into
  egl_surface( EGLSurfaceStore::create_dummy_surface(egl_display, egl_config, khr_surfaceless_context) )

and evade control flow in the initializer list.

-> yay and that would be my first launchpad review.

review: Needs Fixing

« Back to merge proposal