Code review comment for lp:~raof/mir/1hz-rendering-always
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | # |
review:
Abstain
(manual testing)
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
Verified both bugs are fixed.
I'm not a big fan of the new design. Particularly:
(1) framedrop_policy is an object that you modify? Making policy an object is one thing I don't like but can kind of understand. However, modifying a policy object on the fly doesn't sound like the design is quite right.
On the other hand, I am a big fan of fixing bug 1308843 and bug 1308844. And the minimal intrusion to the BufferQueue class is also nice.