Mir

Code review comment for lp:~raof/mir/1hz-rendering-always

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

CI says:

[ 63%] /mir/tests/mir_test_doubles/mock_frame_dropping_policy_factory.cpp:19:65: fatal error: mir_test_doubles/mock_frame_dropping_policy_factory.h: No such file or directory
 #include "mir_test_doubles/mock_frame_dropping_policy_factory.h"

~~~~

315 +#endif // MIR_TEST_SEMAPHORE_H_

We're calling it Signal in this revision.

~~~~

2549 + MOCK_METHOD1(create_alarm, std::unique_ptr<mir::time::Alarm>(std::function<void(void)>));

Why create a mock method when we don't set expectations or behavior?

review: Needs Fixing

« Back to merge proposal