Mir

Code review comment for lp:~raof/mir/1hz-rendering-always

  1. 1hz-rendering-always
  2. Merge into development-branch
Revision history for this message
Alberto Aguirre (albaguirre) wrote :

46 +class Semaphore

Perhaps BinarySemaphore?

The framedrop on timeout looks pretty straightforward to me. However I still maintain that the timeout should
only be enabled for the 2 conditions where we actually need it: when a surface is not visible on any display (due to a display off condition) and when a surface is occluded. But that's the FrameDroppingPolicy discussion, which I am okay coming in a separate MP.

~~~
TEST_F(SwitchingBundleTest, compositor_swapping_at_min_rate_gets_oldest_buffer)
~~~

Is this an implicit policy? oldest with respect to what? client-release?

review: Approve

« Back to merge proposal