Code review comment for lp:~ralsina/ubuntuone-windows-installer/ui-come-back-to-installer

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

* Can you please unify these two imports into one?

from ubuntuone.platform.credentials import (
    APP_NAME,
    TC_URL,
)
from ubuntuone.platform.credentials import CredentialsManagementTool

* We need a blank line between these two:

import sys
from PyQt4 import QtGui

* The code inside the try-except in currentuser.py should not be this:

+ print e, type(e), repr(e)

but a call to logger.exception.

* Four double quotes instead of 3:

""""Fake the wizard() method of QWizardPage.""

* The faked credentialsmanagementtool should return a fired deferred with an empty dict, to simulate the absence of credentials.

review: Needs Fixing

« Back to merge proposal