Merge lp:~ralsina/ubuntuone-windows-installer/start-with-overlay into lp:ubuntuone-windows-installer
Proposed by
Roberto Alsina
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Roberto Alsina | ||||
Approved revision: | 36 | ||||
Merged at revision: | 31 | ||||
Proposed branch: | lp:~ralsina/ubuntuone-windows-installer/start-with-overlay | ||||
Merge into: | lp:ubuntuone-windows-installer | ||||
Diff against target: |
172 lines (+67/-9) 4 files modified
setup.py (+2/-1) ubuntuone_installer/gui/qt/gui.py (+14/-5) ubuntuone_installer/gui/qt/local_folders.py (+4/-1) ubuntuone_installer/gui/qt/tests/test_gui.py (+47/-2) |
||||
To merge this branch: | bzr merge lp:~ralsina/ubuntuone-windows-installer/start-with-overlay | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Diego Sarmentero (community) | Approve | ||
Natalia Bidart (community) | Approve | ||
Review via email:
|
Commit message
* Change the default "Next Page" for the license page to not-None
* Block the UI (using the overlay) until the find_credentials call is done
Description of the change
* Change the default "Next Page" for the license page to not-None
* Block the UI (using the overlay) until the find_credentials call is done
To post a comment you must log in.
As we discussed in IRC, some tests will be added for the fixes proposed in this branch.