Merge lp:~ralsina/ubuntuone-windows-installer/not-compressed into lp:ubuntuone-windows-installer

Proposed by Roberto Alsina
Status: Merged
Approved by: Roberto Alsina
Approved revision: 31
Merged at revision: 30
Proposed branch: lp:~ralsina/ubuntuone-windows-installer/not-compressed
Merge into: lp:ubuntuone-windows-installer
Diff against target: 33 lines (+2/-3)
2 files modified
setup.py (+1/-1)
ubuntuone_installer/gui/qt/main/windows.py (+1/-2)
To merge this branch: bzr merge lp:~ralsina/ubuntuone-windows-installer/not-compressed
Reviewer Review Type Date Requested Status
Diego Sarmentero (community) Approve
Manuel de la Peña (community) Approve
Review via email: mp+71296@code.launchpad.net

Commit message

QSS are not compressed files, no need to call qUncompress.

Description of the change

QSS are not compressed files, no need to call qUncompress.

To post a comment you must log in.
Revision history for this message
Manuel de la Peña (mandel) wrote :

trivial! But can you put a little longer comment in the commit so that we know the reason. Or even better make a blog post!

review: Approve
Revision history for this message
Manuel de la Peña (mandel) wrote :

trivial! But can you put a little longer comment in the commit so that we know the reason. Or even better make a blog post!

review: Approve
Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

Not working for me, when i changed to qUncompressed, it was because this was not working.

review: Needs Fixing
31. By Roberto Alsina

generate uncompressed resource file

Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'setup.py'
--- setup.py 2011-07-19 00:42:30 +0000
+++ setup.py 2011-08-12 13:12:40 +0000
@@ -114,7 +114,7 @@
114 path = os.getenv('PATH')114 path = os.getenv('PATH')
115 os.putenv('PATH', path + os.path.pathsep + os.path.join(115 os.putenv('PATH', path + os.path.pathsep + os.path.join(
116 os.path.dirname(PyQt4.__file__), 'bin'))116 os.path.dirname(PyQt4.__file__), 'bin'))
117 if os.system('pyrcc4 "%s" -o "%s"' % (qrc_file, py_file)) > 0:117 if os.system('pyrcc4 -no-compress "%s" -o "%s"' % (qrc_file, py_file)) > 0:
118 self.warn('Unable to generate python module {py_file}'118 self.warn('Unable to generate python module {py_file}'
119 ' for resource file {qrc_file}'.format(119 ' for resource file {qrc_file}'.format(
120 py_file=py_file, qrc_file=qrc_file))120 py_file=py_file, qrc_file=qrc_file))
121121
=== modified file 'ubuntuone_installer/gui/qt/main/windows.py'
--- ubuntuone_installer/gui/qt/main/windows.py 2011-08-05 18:45:19 +0000
+++ ubuntuone_installer/gui/qt/main/windows.py 2011-08-12 13:12:40 +0000
@@ -23,7 +23,6 @@
2323
24from PyQt4 import QtGui24from PyQt4 import QtGui
25from PyQt4 import QtCore25from PyQt4 import QtCore
26from PyQt4.Qt import qUncompress
2726
28# Module used to include the resources into this file27# Module used to include the resources into this file
29# pylint: disable=W061128# pylint: disable=W0611
@@ -51,7 +50,7 @@
51 # Set Application Style Sheet50 # Set Application Style Sheet
52 app = QtGui.QApplication.instance()51 app = QtGui.QApplication.instance()
53 qss = QtCore.QResource(":/ubuntuone.qss")52 qss = QtCore.QResource(":/ubuntuone.qss")
54 app.setStyleSheet(QtCore.QString(qUncompress(qss.data())))53 app.setStyleSheet(QtCore.QString(qss.data()))
55 # Apply font to the entire application54 # Apply font to the entire application
56 QtGui.QFontDatabase.addApplicationFont(':/Ubuntu-R.ttf')55 QtGui.QFontDatabase.addApplicationFont(':/Ubuntu-R.ttf')
57 QtGui.QFontDatabase.addApplicationFont(':/Ubuntu-B.ttf')56 QtGui.QFontDatabase.addApplicationFont(':/Ubuntu-B.ttf')

Subscribers

People subscribed via source and target branches