Code review comment for lp:~ralsina/ubuntuone-windows-installer/fix_803929

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

The branch looks great. Some lint issues:

C0111: 85:SetupAccountPage.name_assistance: Missing docstring
C0111: 93:SetupAccountPage.email_assistance: Missing docstring
C0111:101:SetupAccountPage.confirm_email_assistance: Missing docstring
C0111:110:SetupAccountPage.password_assistance: Missing docstring
C0111:399:MainWindow.on_currentIdChanged: Missing docstring
W0612: 57:CalculateSize.run: Unused variable 'dirnames'
C0103: 84:LocalFoldersPage.initializePage: Invalid name "initializePage" (should match ([a-z_][a-z0-9_]{2,79}$|setUp|tearDown))
C0111: 84:LocalFoldersPage.initializePage: Missing docstring
W0612:149:LocalFoldersPage.stop_threads: Unused variable 'path'
C0103:152:LocalFoldersPage.on_folder_list_itemClicked: Invalid name "on_folder_list_itemClicked" (should match ([a-z_][a-z0-9_]{2,79}$|setUp|tearDown))
C0111: 30:TosPage: Missing docstring
W0201:293:LocalFoldersTestCase.test_size_calculation: Attribute 'queue' defined outside __init__
W0201:294:LocalFoldersTestCase.test_size_calculation: Attribute 'csize' defined outside __init__

nessita@dali:~/canonical/u1/windows-installer/review_fix_803929$ pep8 --repeat --exclude="*_ui.py" .
./build/lib.linux-x86_64-2.7/ubuntuone_installer/gui/qt/gui.py:70:21: E202 whitespace before ')'
./ubuntuone_installer/gui/qt/gui.py:70:21: E202 whitespace before ')'
./ubuntuone_installer/gui/qt/tests/test_gui.py:43:21: E202 whitespace before ')'
./ubuntuone_installer/gui/qt/tests/test_gui.py:396:57: E202 whitespace before ')'
./ubuntuone_installer/gui/qt/tests/test_gui.py:412:57: E202 whitespace before ')'
./ubuntuone_installer/gui/qt/tests/test_gui.py:439:60: E202 whitespace before ')'
./ubuntuone_installer/gui/qt/tests/test_gui.py:480:58: E202 whitespace before ')'

review: Needs Fixing

« Back to merge proposal