The branch looks great. Some lint issues:
C0111: 85:SetupAccountPage.name_assistance: Missing docstring C0111: 93:SetupAccountPage.email_assistance: Missing docstring C0111:101:SetupAccountPage.confirm_email_assistance: Missing docstring C0111:110:SetupAccountPage.password_assistance: Missing docstring C0111:399:MainWindow.on_currentIdChanged: Missing docstring W0612: 57:CalculateSize.run: Unused variable 'dirnames' C0103: 84:LocalFoldersPage.initializePage: Invalid name "initializePage" (should match ([a-z_][a-z0-9_]{2,79}$|setUp|tearDown)) C0111: 84:LocalFoldersPage.initializePage: Missing docstring W0612:149:LocalFoldersPage.stop_threads: Unused variable 'path' C0103:152:LocalFoldersPage.on_folder_list_itemClicked: Invalid name "on_folder_list_itemClicked" (should match ([a-z_][a-z0-9_]{2,79}$|setUp|tearDown)) C0111: 30:TosPage: Missing docstring W0201:293:LocalFoldersTestCase.test_size_calculation: Attribute 'queue' defined outside __init__ W0201:294:LocalFoldersTestCase.test_size_calculation: Attribute 'csize' defined outside __init__
nessita@dali:~/canonical/u1/windows-installer/review_fix_803929$ pep8 --repeat --exclude="*_ui.py" . ./build/lib.linux-x86_64-2.7/ubuntuone_installer/gui/qt/gui.py:70:21: E202 whitespace before ')' ./ubuntuone_installer/gui/qt/gui.py:70:21: E202 whitespace before ')' ./ubuntuone_installer/gui/qt/tests/test_gui.py:43:21: E202 whitespace before ')' ./ubuntuone_installer/gui/qt/tests/test_gui.py:396:57: E202 whitespace before ')' ./ubuntuone_installer/gui/qt/tests/test_gui.py:412:57: E202 whitespace before ')' ./ubuntuone_installer/gui/qt/tests/test_gui.py:439:60: E202 whitespace before ')' ./ubuntuone_installer/gui/qt/tests/test_gui.py:480:58: E202 whitespace before ')'
« Back to merge proposal
The branch looks great. Some lint issues:
C0111: 85:SetupAccount Page.name_ assistance: Missing docstring Page.email_ assistance: Missing docstring SetupAccountPag e.confirm_ email_assistanc e: Missing docstring SetupAccountPag e.password_ assistance: Missing docstring MainWindow. on_currentIdCha nged: Missing docstring e.run: Unused variable 'dirnames' Page.initialize Page: Invalid name "initializePage" (should match ([a-z_] [a-z0-9_ ]{2,79} $|setUp| tearDown) ) Page.initialize Page: Missing docstring LocalFoldersPag e.stop_ threads: Unused variable 'path' LocalFoldersPag e.on_folder_ list_itemClicke d: Invalid name "on_folder_ list_itemClicke d" (should match ([a-z_] [a-z0-9_ ]{2,79} $|setUp| tearDown) ) LocalFoldersTes tCase.test_ size_calculatio n: Attribute 'queue' defined outside __init__ LocalFoldersTes tCase.test_ size_calculatio n: Attribute 'csize' defined outside __init__
C0111: 93:SetupAccount
C0111:101:
C0111:110:
C0111:399:
W0612: 57:CalculateSiz
C0103: 84:LocalFolders
C0111: 84:LocalFolders
W0612:149:
C0103:152:
C0111: 30:TosPage: Missing docstring
W0201:293:
W0201:294:
nessita@ dali:~/ canonical/ u1/windows- installer/ review_ fix_803929$ pep8 --repeat --exclude="*_ui.py" . lib.linux- x86_64- 2.7/ubuntuone_ installer/ gui/qt/ gui.py: 70:21: E202 whitespace before ')' installer/ gui/qt/ gui.py: 70:21: E202 whitespace before ')' installer/ gui/qt/ tests/test_ gui.py: 43:21: E202 whitespace before ')' installer/ gui/qt/ tests/test_ gui.py: 396:57: E202 whitespace before ')' installer/ gui/qt/ tests/test_ gui.py: 412:57: E202 whitespace before ')' installer/ gui/qt/ tests/test_ gui.py: 439:60: E202 whitespace before ')' installer/ gui/qt/ tests/test_ gui.py: 480:58: E202 whitespace before ')'
./build/
./ubuntuone_
./ubuntuone_
./ubuntuone_
./ubuntuone_
./ubuntuone_
./ubuntuone_