Code review comment for lp:~ralsina/ubuntuone-windows-installer/fix_800376

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

A couple of needs fixing:

* always call super() instead of explicitly calling the parent class

* the diff seems to add several (at first) not needed blank lines, can you please remove those, if they are not needed? (we usually do not add empty lines after the docstrings)

* by convention, setUp and tearDown, if defined, should be the first 2 methods after the class declaration

* this docstring:

506 + """After removing all folders, offer_frame should be hidden.
507 +
508 + Push the user over quota, it should be visible"""

should be:

506 + """After removing all folders, offer_frame should be hidden.
507 +
508 + Push the user over quota, it should be visible.

          """

review: Needs Fixing

« Back to merge proposal