Merge lp:~ralsina/ubuntuone-windows-installer/doing-windows into lp:ubuntuone-windows-installer

Proposed by Roberto Alsina
Status: Merged
Approved by: Roberto Alsina
Approved revision: 119
Merged at revision: 107
Proposed branch: lp:~ralsina/ubuntuone-windows-installer/doing-windows
Merge into: lp:ubuntuone-windows-installer
Diff against target: 248 lines (+51/-38)
5 files modified
scripts/README (+3/-2)
scripts/conf.py (+11/-8)
scripts/setup.py (+30/-21)
scripts/ubuntuone.xml (+6/-6)
scripts/ubuntuone_autoupdate.xml (+1/-1)
To merge this branch: bzr merge lp:~ralsina/ubuntuone-windows-installer/doing-windows
Reviewer Review Type Date Requested Status
Diego Sarmentero (community) Approve
Brian Curtin (community) Approve
Review via email: mp+97972@code.launchpad.net

Commit message

Cleanup windows build, get rid of windows-installer, build all required binaries.

Description of the change

Cleanup windows build, get rid of windows-installer, build all required binaries.

To post a comment you must log in.
116. By Roberto Alsina

no manual branches, fixed version number

117. By Roberto Alsina

missing ampersand

118. By Roberto Alsina

missing argument

119. By Roberto Alsina

abandon the idea of release number and version being similar

Revision history for this message
Brian Curtin (brian.curtin) wrote :

+1 - looks fine, worked well IRL when I used it a few minutes ago

review: Approve
Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'scripts/README'
--- scripts/README 2012-01-04 12:43:39 +0000
+++ scripts/README 2012-03-23 18:38:19 +0000
@@ -35,8 +35,9 @@
35-------------------------35-------------------------
3636
37Update the release numbers in setup.py ubuntuone_autoupdate.xml and 37Update the release numbers in setup.py ubuntuone_autoupdate.xml and
38ubuntuone.xml. Remember that you have both a build (ex: 203) 38ubuntuone.xml. Remember that you have both a build (ex: 1000)
39and a release (ex: 2.0.3)39and a release (ex: 2.0.3). The build number in ubuntuone_autoupdate.xml should
40be increased on all releases and is not related to the version number.
4041
41Get the VS2008 runtime "vcredist_x86.exe" and put it in the42Get the VS2008 runtime "vcredist_x86.exe" and put it in the
42scripts folder.43scripts folder.
4344
=== modified file 'scripts/conf.py'
--- scripts/conf.py 2012-03-16 14:19:31 +0000
+++ scripts/conf.py 2012-03-23 18:38:19 +0000
@@ -13,28 +13,31 @@
13#13#
14# You should have received a copy of the GNU General Public License along14# You should have received a copy of the GNU General Public License along
15# with this program. If not, see <http://www.gnu.org/licenses/>.15# with this program. If not, see <http://www.gnu.org/licenses/>.
16
16"""Configure what branches make the release."""17"""Configure what branches make the release."""
1718
19# This is appended to the branches. So, if you set it to
20# "/stable-3-0" you will get lp:ubuntuone-client/stable-3-0
21BRANCH_POSTFIX = ""
22
18# You can add branches that are to be merged into the release by23# You can add branches that are to be merged into the release by
19# adding them to the adequate list.24# adding them to the adequate list.
2025
26
21U1_CLIENT_BRANCHES = (27U1_CLIENT_BRANCHES = (
22 "lp:ubuntuone-client",28 "lp:ubuntuone-client" + BRANCH_POSTFIX,
23)29)
24U1_CONTROL_PANEL_BRANCHES = (30U1_CONTROL_PANEL_BRANCHES = (
25 "lp:ubuntuone-control-panel",31 "lp:ubuntuone-control-panel" + BRANCH_POSTFIX,
26)32)
27UBUNTU_SSO_BRANCHES = (33UBUNTU_SSO_BRANCHES = (
28 "lp:ubuntu-sso-client",34 "lp:ubuntu-sso-client" + BRANCH_POSTFIX,
29)
30U1_WINDOWS_INSTALLER_BRANCHES = (
31 "lp:ubuntuone-windows-installer",
32)35)
33U1_STORAGE_PROTOCOL_BRANCHES = (36U1_STORAGE_PROTOCOL_BRANCHES = (
34 "lp:ubuntuone-storage-protocol",37 "lp:ubuntuone-storage-protocol" + BRANCH_POSTFIX,
35)38)
3639
37# If show_cmd is set to True, then the binaries will have cmd windows where40# If show_cmd is set to True, then the binaries will have cmd windows where
38# you can see stderr.41# you can see stderr.
3942
40SHOW_CMD = False43SHOW_CMD = True
4144
=== modified file 'scripts/setup.py'
--- scripts/setup.py 2012-03-16 14:39:17 +0000
+++ scripts/setup.py 2012-03-23 18:38:19 +0000
@@ -160,7 +160,6 @@
160 branch_and_merge(conf.U1_CLIENT_BRANCHES)160 branch_and_merge(conf.U1_CLIENT_BRANCHES)
161 branch_and_merge(conf.U1_CONTROL_PANEL_BRANCHES)161 branch_and_merge(conf.U1_CONTROL_PANEL_BRANCHES)
162 branch_and_merge(conf.UBUNTU_SSO_BRANCHES)162 branch_and_merge(conf.UBUNTU_SSO_BRANCHES)
163 branch_and_merge(conf.U1_WINDOWS_INSTALLER_BRANCHES)
164 branch_and_merge(conf.U1_STORAGE_PROTOCOL_BRANCHES)163 branch_and_merge(conf.U1_STORAGE_PROTOCOL_BRANCHES)
165# pylint: enable=R0904164# pylint: enable=R0904
166165
@@ -188,16 +187,25 @@
188 shutil.copyfile(os.path.join(187 shutil.copyfile(os.path.join(
189 "sources", "ubuntuone-client", "bin", "u1sdtool"),188 "sources", "ubuntuone-client", "bin", "u1sdtool"),
190 os.path.join("bin", "u1sdtool"))189 os.path.join("bin", "u1sdtool"))
190 shutil.copyfile(os.path.join(
191 "sources", "ubuntuone-client", "bin", "ubuntuone-proxy-tunnel"),
192 os.path.join("bin", "ubuntuone-proxy-tunnel"))
191 shutil.copyfile(os.path.join("sources", "ubuntu-sso-client",193 shutil.copyfile(os.path.join("sources", "ubuntu-sso-client",
192 "bin", "ubuntu-sso-login"),194 "bin", "ubuntu-sso-login"),
193 os.path.join("bin", "ubuntu-sso-login"))195 os.path.join("bin", "ubuntu-sso-login"))
196 shutil.copyfile(os.path.join("sources", "ubuntu-sso-client",
197 "bin", "ubuntu-sso-login-qt"),
198 os.path.join("bin", "ubuntu-sso-login-qt"))
199 shutil.copyfile(os.path.join("sources", "ubuntu-sso-client",
200 "bin", "ubuntu-sso-proxy-creds-qt"),
201 os.path.join("bin", "ubuntu-sso-proxy-creds-qt"))
202 shutil.copyfile(os.path.join("sources", "ubuntu-sso-client",
203 "bin", "ubuntu-sso-ssl-certificate-qt"),
204 os.path.join("bin", "ubuntu-sso-ssl-certificate-qt"))
194 shutil.copyfile(os.path.join("sources",205 shutil.copyfile(os.path.join("sources",
195 "ubuntuone-control-panel", "bin",206 "ubuntuone-control-panel", "bin",
196 "ubuntuone-control-panel-qt"),207 "ubuntuone-control-panel-qt"),
197 os.path.join("bin", "ubuntuone-control-panel-qt"))208 os.path.join("bin", "ubuntuone-control-panel-qt"))
198 shutil.copyfile(os.path.join("sources", "ubuntuone-windows-installer",
199 "bin", "ubuntuone-installer-qt"),
200 os.path.join("bin", "ubuntuone-installer-qt"))
201209
202 # Remove "installed" copy210 # Remove "installed" copy
203 try:211 try:
@@ -241,23 +249,12 @@
241 stdout=subprocess.PIPE).communicate()[0]249 stdout=subprocess.PIPE).communicate()[0]
242 os.chdir(start_dir)250 os.chdir(start_dir)
243251
244 os.chdir(os.path.join("sources", "ubuntuone-windows-installer"))
245 os.system("python setup.py build")
246 # Copying by hand because the install is borked
247 dest_installer = os.path.join(dest_dir, "ubuntuone_installer")
248 shutil.copytree("ubuntuone_installer", dest_installer)
249 u1inst_revno = subprocess.Popen(
250 ["bzr", "revno", "."],
251 stdout=subprocess.PIPE).communicate()[0]
252 os.chdir(start_dir)
253
254 # Create revno file252 # Create revno file
255 with open(os.path.join("data", "revnos.txt"), "w+") as revnos:253 with open(os.path.join("data", "revnos.txt"), "w+") as revnos:
256 revnos.write("ubuntu-sso-client: %s"254 revnos.write("ubuntu-sso-client: %s"
257 "ubuntuone-client: %s"255 "ubuntuone-client: %s"
258 "ubuntuone-control-panel: %s"256 "ubuntuone-control-panel: %s" %
259 "ubuntuonw-windows-installer: %s" %257 (sso_revno, u1client_revno, u1cp_revno))
260 (sso_revno, u1client_revno, u1cp_revno, u1inst_revno))
261258
262 # Copy storage-protocol's pem files259 # Copy storage-protocol's pem files
263 shutil.copyfile(os.path.join("sources",260 shutil.copyfile(os.path.join("sources",
@@ -304,6 +301,10 @@
304 'icon_resources': [(0, 'ubuntu_one.ico')]301 'icon_resources': [(0, 'ubuntu_one.ico')]
305 },302 },
306 {303 {
304 'script': 'bin/ubuntuone-proxy-tunnel',
305 'icon_resources': [(0, 'ubuntu_one.ico')]
306 },
307 {
307 'script': 'bin/ubuntuone-control-panel-qt',308 'script': 'bin/ubuntuone-control-panel-qt',
308 'icon_resources': [(0, 'ubuntu_one.ico')]309 'icon_resources': [(0, 'ubuntu_one.ico')]
309 },310 },
@@ -312,7 +313,15 @@
312 'icon_resources': [(0, 'ubuntu_one.ico')]313 'icon_resources': [(0, 'ubuntu_one.ico')]
313 },314 },
314 {315 {
315 'script': 'bin/ubuntuone-installer-qt',316 'script': 'bin/ubuntu-sso-login-qt',
317 'icon_resources': [(0, 'ubuntu_one.ico')]
318 },
319 {
320 'script': 'bin/ubuntu-sso-proxy-creds-qt',
321 'icon_resources': [(0, 'ubuntu_one.ico')]
322 },
323 {
324 'script': 'bin/ubuntu-sso-ssl-certificate-qt',
316 'icon_resources': [(0, 'ubuntu_one.ico')]325 'icon_resources': [(0, 'ubuntu_one.ico')]
317 },326 },
318 ]327 ]
@@ -324,7 +333,7 @@
324 # Build bundles333 # Build bundles
325 setup(334 setup(
326 name='ubuntuone',335 name='ubuntuone',
327 version='2.0.3',336 version='2.99.91',
328 license='GPL v3',337 license='GPL v3',
329 author='',338 author='',
330 author_email='',339 author_email='',
@@ -342,11 +351,11 @@
342 'includes': ['google.protobuf.descriptor',351 'includes': ['google.protobuf.descriptor',
343 'sip',352 'sip',
344 'twisted.web.resource',353 'twisted.web.resource',
354 'twisted.web.client',
345 'ubuntu_sso.qt',355 'ubuntu_sso.qt',
346 'ubuntu_sso.qt.gui',356 'ubuntu_sso.qt.ui',
347 'PyQt4.QtNetwork',357 'PyQt4.QtNetwork',
348 'oauth',358 'oauth',
349 'ubuntuone_installer',
350 'configglue',359 'configglue',
351 'configglue.app',360 'configglue.app',
352 'configglue.inischema',361 'configglue.inischema',
353362
=== modified file 'scripts/ubuntuone.xml'
--- scripts/ubuntuone.xml 2011-12-28 19:15:16 +0000
+++ scripts/ubuntuone.xml 2012-03-23 18:38:19 +0000
@@ -1,7 +1,7 @@
1<project>1<project>
2 <shortName>ubuntuone</shortName>2 <shortName>ubuntuone</shortName>
3 <fullName>Ubuntu One</fullName>3 <fullName>Ubuntu One</fullName>
4 <version>2.0.3</version>4 <version>2.99.91</version>
5 <componentList>5 <componentList>
6 <component>6 <component>
7 <name>autoupdater</name>7 <name>autoupdater</name>
@@ -46,8 +46,7 @@
46 <platforms>windows</platforms>46 <platforms>windows</platforms>
47 <runAsAdmin>0</runAsAdmin>47 <runAsAdmin>0</runAsAdmin>
48 <runInTerminal>0</runInTerminal>48 <runInTerminal>0</runInTerminal>
49 <windowsExec>${installdir}\dist\ubuntuone-installer-qt.exe</windowsExec>49 <windowsExec>${installdir}\dist\ubuntuone-control-panel-qt.exe</windowsExec>
50 <windowsExecArgs></windowsExecArgs>
51 <windowsIcon>${installdir}/ubuntu_one.ico</windowsIcon>50 <windowsIcon>${installdir}/ubuntu_one.ico</windowsIcon>
52 <windowsPath>${windows_folder_desktopdirectory}</windowsPath>51 <windowsPath>${windows_folder_desktopdirectory}</windowsPath>
53 </shortcut>52 </shortcut>
@@ -136,7 +135,7 @@
136 <name>Ubuntu One</name>135 <name>Ubuntu One</name>
137 <runAsAdmin>0</runAsAdmin>136 <runAsAdmin>0</runAsAdmin>
138 <runInTerminal>0</runInTerminal>137 <runInTerminal>0</runInTerminal>
139 <windowsExec>${installdir}\dist\ubuntuone-installer-qt.exe</windowsExec>138 <windowsExec>${installdir}\dist\ubuntuone-control-panel-qt.exe</windowsExec>
140 <windowsExecArgs></windowsExecArgs>139 <windowsExecArgs></windowsExecArgs>
141 <windowsIcon>${installdir}/ubuntu_one.ico</windowsIcon>140 <windowsIcon>${installdir}/ubuntu_one.ico</windowsIcon>
142 <windowsPath>${windows_folder_desktopdirectory}</windowsPath>141 <windowsPath>${windows_folder_desktopdirectory}</windowsPath>
@@ -228,7 +227,7 @@
228 </registrySet>227 </registrySet>
229 <runProgram>228 <runProgram>
230 <program>${windows_folder_system}\RunDll32.exe</program>229 <program>${windows_folder_system}\RunDll32.exe</program>
231 <programArguments>"${installdir}\dist\VistaLib32.dll" RunNonElevated "${installdir}\dist\ubuntuone-installer-qt.exe" --installer &amp;</programArguments>230 <programArguments>"${installdir}\dist\VistaLib32.dll" RunNonElevated "${installdir}\dist\ubuntuone-control-panel-qt.exe --installer &amp;"</programArguments>
232 <useMSDOSPath>0</useMSDOSPath>231 <useMSDOSPath>0</useMSDOSPath>
233 <ruleList>232 <ruleList>
234 <compareText>233 <compareText>
@@ -243,7 +242,7 @@
243 </runProgram>242 </runProgram>
244 <runProgram>243 <runProgram>
245 <program>${windows_folder_system}\RunDll32.exe</program>244 <program>${windows_folder_system}\RunDll32.exe</program>
246 <programArguments>"${installdir}\dist\VistaLib64.dll" RunNonElevated "${installdir}\dist\ubuntuone-installer-qt.exe" --installer &amp;</programArguments>245 <programArguments>"${installdir}\dist\VistaLib64.dll" RunNonElevated "${installdir}\dist\ubuntuone-control-panel-qt.exe" --installer &amp;</programArguments>
247 <useMSDOSPath>0</useMSDOSPath>246 <useMSDOSPath>0</useMSDOSPath>
248 <ruleList>247 <ruleList>
249 <compareText>248 <compareText>
@@ -256,6 +255,7 @@
256 </platformTest>255 </platformTest>
257 </ruleList>256 </ruleList>
258 </runProgram>257 </runProgram>
258 <!-- TODO: remove this showInfo? -->
259 <showInfo>259 <showInfo>
260 <text>Please reboot to finish upgrade.</text>260 <text>Please reboot to finish upgrade.</text>
261 <ruleList>261 <ruleList>
262262
=== modified file 'scripts/ubuntuone_autoupdate.xml'
--- scripts/ubuntuone_autoupdate.xml 2011-12-14 20:42:38 +0000
+++ scripts/ubuntuone_autoupdate.xml 2012-03-23 18:38:19 +0000
@@ -2,7 +2,7 @@
2 <fullName>Ubuntu One</fullName>2 <fullName>Ubuntu One</fullName>
3 <shortName>ubuntuone</shortName>3 <shortName>ubuntuone</shortName>
4 <vendor>Canonical</vendor>4 <vendor>Canonical</vendor>
5 <version>203</version>5 <version>1000</version>
6 <singleInstanceCheck>1</singleInstanceCheck>6 <singleInstanceCheck>1</singleInstanceCheck>
7 <requireInstallationByRootUser>0</requireInstallationByRootUser>7 <requireInstallationByRootUser>0</requireInstallationByRootUser>
8 <requestedExecutionLevel>asInvoker</requestedExecutionLevel>8 <requestedExecutionLevel>asInvoker</requestedExecutionLevel>

Subscribers

People subscribed via source and target branches