Merge lp:~ralsina/ubuntuone-windows-installer/doing-windows into lp:ubuntuone-windows-installer
- doing-windows
- Merge into trunk
Proposed by
Roberto Alsina
Status: | Merged |
---|---|
Approved by: | Roberto Alsina |
Approved revision: | 119 |
Merged at revision: | 107 |
Proposed branch: | lp:~ralsina/ubuntuone-windows-installer/doing-windows |
Merge into: | lp:ubuntuone-windows-installer |
Diff against target: |
248 lines (+51/-38) 5 files modified
scripts/README (+3/-2) scripts/conf.py (+11/-8) scripts/setup.py (+30/-21) scripts/ubuntuone.xml (+6/-6) scripts/ubuntuone_autoupdate.xml (+1/-1) |
To merge this branch: | bzr merge lp:~ralsina/ubuntuone-windows-installer/doing-windows |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Diego Sarmentero (community) | Approve | ||
Brian Curtin (community) | Approve | ||
Review via email: mp+97972@code.launchpad.net |
Commit message
Cleanup windows build, get rid of windows-installer, build all required binaries.
Description of the change
Cleanup windows build, get rid of windows-installer, build all required binaries.
To post a comment you must log in.
- 116. By Roberto Alsina
-
no manual branches, fixed version number
- 117. By Roberto Alsina
-
missing ampersand
- 118. By Roberto Alsina
-
missing argument
- 119. By Roberto Alsina
-
abandon the idea of release number and version being similar
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1 | === modified file 'scripts/README' | |||
2 | --- scripts/README 2012-01-04 12:43:39 +0000 | |||
3 | +++ scripts/README 2012-03-23 18:38:19 +0000 | |||
4 | @@ -35,8 +35,9 @@ | |||
5 | 35 | ------------------------- | 35 | ------------------------- |
6 | 36 | 36 | ||
7 | 37 | Update the release numbers in setup.py ubuntuone_autoupdate.xml and | 37 | Update the release numbers in setup.py ubuntuone_autoupdate.xml and |
10 | 38 | ubuntuone.xml. Remember that you have both a build (ex: 203) | 38 | ubuntuone.xml. Remember that you have both a build (ex: 1000) |
11 | 39 | and a release (ex: 2.0.3) | 39 | and a release (ex: 2.0.3). The build number in ubuntuone_autoupdate.xml should |
12 | 40 | be increased on all releases and is not related to the version number. | ||
13 | 40 | 41 | ||
14 | 41 | Get the VS2008 runtime "vcredist_x86.exe" and put it in the | 42 | Get the VS2008 runtime "vcredist_x86.exe" and put it in the |
15 | 42 | scripts folder. | 43 | scripts folder. |
16 | 43 | 44 | ||
17 | === modified file 'scripts/conf.py' | |||
18 | --- scripts/conf.py 2012-03-16 14:19:31 +0000 | |||
19 | +++ scripts/conf.py 2012-03-23 18:38:19 +0000 | |||
20 | @@ -13,28 +13,31 @@ | |||
21 | 13 | # | 13 | # |
22 | 14 | # You should have received a copy of the GNU General Public License along | 14 | # You should have received a copy of the GNU General Public License along |
23 | 15 | # with this program. If not, see <http://www.gnu.org/licenses/>. | 15 | # with this program. If not, see <http://www.gnu.org/licenses/>. |
24 | 16 | |||
25 | 16 | """Configure what branches make the release.""" | 17 | """Configure what branches make the release.""" |
26 | 17 | 18 | ||
27 | 19 | # This is appended to the branches. So, if you set it to | ||
28 | 20 | # "/stable-3-0" you will get lp:ubuntuone-client/stable-3-0 | ||
29 | 21 | BRANCH_POSTFIX = "" | ||
30 | 22 | |||
31 | 18 | # You can add branches that are to be merged into the release by | 23 | # You can add branches that are to be merged into the release by |
32 | 19 | # adding them to the adequate list. | 24 | # adding them to the adequate list. |
33 | 20 | 25 | ||
34 | 26 | |||
35 | 21 | U1_CLIENT_BRANCHES = ( | 27 | U1_CLIENT_BRANCHES = ( |
37 | 22 | "lp:ubuntuone-client", | 28 | "lp:ubuntuone-client" + BRANCH_POSTFIX, |
38 | 23 | ) | 29 | ) |
39 | 24 | U1_CONTROL_PANEL_BRANCHES = ( | 30 | U1_CONTROL_PANEL_BRANCHES = ( |
41 | 25 | "lp:ubuntuone-control-panel", | 31 | "lp:ubuntuone-control-panel" + BRANCH_POSTFIX, |
42 | 26 | ) | 32 | ) |
43 | 27 | UBUNTU_SSO_BRANCHES = ( | 33 | UBUNTU_SSO_BRANCHES = ( |
48 | 28 | "lp:ubuntu-sso-client", | 34 | "lp:ubuntu-sso-client" + BRANCH_POSTFIX, |
45 | 29 | ) | ||
46 | 30 | U1_WINDOWS_INSTALLER_BRANCHES = ( | ||
47 | 31 | "lp:ubuntuone-windows-installer", | ||
49 | 32 | ) | 35 | ) |
50 | 33 | U1_STORAGE_PROTOCOL_BRANCHES = ( | 36 | U1_STORAGE_PROTOCOL_BRANCHES = ( |
52 | 34 | "lp:ubuntuone-storage-protocol", | 37 | "lp:ubuntuone-storage-protocol" + BRANCH_POSTFIX, |
53 | 35 | ) | 38 | ) |
54 | 36 | 39 | ||
55 | 37 | # If show_cmd is set to True, then the binaries will have cmd windows where | 40 | # If show_cmd is set to True, then the binaries will have cmd windows where |
56 | 38 | # you can see stderr. | 41 | # you can see stderr. |
57 | 39 | 42 | ||
59 | 40 | SHOW_CMD = False | 43 | SHOW_CMD = True |
60 | 41 | 44 | ||
61 | === modified file 'scripts/setup.py' | |||
62 | --- scripts/setup.py 2012-03-16 14:39:17 +0000 | |||
63 | +++ scripts/setup.py 2012-03-23 18:38:19 +0000 | |||
64 | @@ -160,7 +160,6 @@ | |||
65 | 160 | branch_and_merge(conf.U1_CLIENT_BRANCHES) | 160 | branch_and_merge(conf.U1_CLIENT_BRANCHES) |
66 | 161 | branch_and_merge(conf.U1_CONTROL_PANEL_BRANCHES) | 161 | branch_and_merge(conf.U1_CONTROL_PANEL_BRANCHES) |
67 | 162 | branch_and_merge(conf.UBUNTU_SSO_BRANCHES) | 162 | branch_and_merge(conf.UBUNTU_SSO_BRANCHES) |
68 | 163 | branch_and_merge(conf.U1_WINDOWS_INSTALLER_BRANCHES) | ||
69 | 164 | branch_and_merge(conf.U1_STORAGE_PROTOCOL_BRANCHES) | 163 | branch_and_merge(conf.U1_STORAGE_PROTOCOL_BRANCHES) |
70 | 165 | # pylint: enable=R0904 | 164 | # pylint: enable=R0904 |
71 | 166 | 165 | ||
72 | @@ -188,16 +187,25 @@ | |||
73 | 188 | shutil.copyfile(os.path.join( | 187 | shutil.copyfile(os.path.join( |
74 | 189 | "sources", "ubuntuone-client", "bin", "u1sdtool"), | 188 | "sources", "ubuntuone-client", "bin", "u1sdtool"), |
75 | 190 | os.path.join("bin", "u1sdtool")) | 189 | os.path.join("bin", "u1sdtool")) |
76 | 190 | shutil.copyfile(os.path.join( | ||
77 | 191 | "sources", "ubuntuone-client", "bin", "ubuntuone-proxy-tunnel"), | ||
78 | 192 | os.path.join("bin", "ubuntuone-proxy-tunnel")) | ||
79 | 191 | shutil.copyfile(os.path.join("sources", "ubuntu-sso-client", | 193 | shutil.copyfile(os.path.join("sources", "ubuntu-sso-client", |
80 | 192 | "bin", "ubuntu-sso-login"), | 194 | "bin", "ubuntu-sso-login"), |
81 | 193 | os.path.join("bin", "ubuntu-sso-login")) | 195 | os.path.join("bin", "ubuntu-sso-login")) |
82 | 196 | shutil.copyfile(os.path.join("sources", "ubuntu-sso-client", | ||
83 | 197 | "bin", "ubuntu-sso-login-qt"), | ||
84 | 198 | os.path.join("bin", "ubuntu-sso-login-qt")) | ||
85 | 199 | shutil.copyfile(os.path.join("sources", "ubuntu-sso-client", | ||
86 | 200 | "bin", "ubuntu-sso-proxy-creds-qt"), | ||
87 | 201 | os.path.join("bin", "ubuntu-sso-proxy-creds-qt")) | ||
88 | 202 | shutil.copyfile(os.path.join("sources", "ubuntu-sso-client", | ||
89 | 203 | "bin", "ubuntu-sso-ssl-certificate-qt"), | ||
90 | 204 | os.path.join("bin", "ubuntu-sso-ssl-certificate-qt")) | ||
91 | 194 | shutil.copyfile(os.path.join("sources", | 205 | shutil.copyfile(os.path.join("sources", |
92 | 195 | "ubuntuone-control-panel", "bin", | 206 | "ubuntuone-control-panel", "bin", |
93 | 196 | "ubuntuone-control-panel-qt"), | 207 | "ubuntuone-control-panel-qt"), |
94 | 197 | os.path.join("bin", "ubuntuone-control-panel-qt")) | 208 | os.path.join("bin", "ubuntuone-control-panel-qt")) |
95 | 198 | shutil.copyfile(os.path.join("sources", "ubuntuone-windows-installer", | ||
96 | 199 | "bin", "ubuntuone-installer-qt"), | ||
97 | 200 | os.path.join("bin", "ubuntuone-installer-qt")) | ||
98 | 201 | 209 | ||
99 | 202 | # Remove "installed" copy | 210 | # Remove "installed" copy |
100 | 203 | try: | 211 | try: |
101 | @@ -241,23 +249,12 @@ | |||
102 | 241 | stdout=subprocess.PIPE).communicate()[0] | 249 | stdout=subprocess.PIPE).communicate()[0] |
103 | 242 | os.chdir(start_dir) | 250 | os.chdir(start_dir) |
104 | 243 | 251 | ||
105 | 244 | os.chdir(os.path.join("sources", "ubuntuone-windows-installer")) | ||
106 | 245 | os.system("python setup.py build") | ||
107 | 246 | # Copying by hand because the install is borked | ||
108 | 247 | dest_installer = os.path.join(dest_dir, "ubuntuone_installer") | ||
109 | 248 | shutil.copytree("ubuntuone_installer", dest_installer) | ||
110 | 249 | u1inst_revno = subprocess.Popen( | ||
111 | 250 | ["bzr", "revno", "."], | ||
112 | 251 | stdout=subprocess.PIPE).communicate()[0] | ||
113 | 252 | os.chdir(start_dir) | ||
114 | 253 | |||
115 | 254 | # Create revno file | 252 | # Create revno file |
116 | 255 | with open(os.path.join("data", "revnos.txt"), "w+") as revnos: | 253 | with open(os.path.join("data", "revnos.txt"), "w+") as revnos: |
117 | 256 | revnos.write("ubuntu-sso-client: %s" | 254 | revnos.write("ubuntu-sso-client: %s" |
118 | 257 | "ubuntuone-client: %s" | 255 | "ubuntuone-client: %s" |
122 | 258 | "ubuntuone-control-panel: %s" | 256 | "ubuntuone-control-panel: %s" % |
123 | 259 | "ubuntuonw-windows-installer: %s" % | 257 | (sso_revno, u1client_revno, u1cp_revno)) |
121 | 260 | (sso_revno, u1client_revno, u1cp_revno, u1inst_revno)) | ||
124 | 261 | 258 | ||
125 | 262 | # Copy storage-protocol's pem files | 259 | # Copy storage-protocol's pem files |
126 | 263 | shutil.copyfile(os.path.join("sources", | 260 | shutil.copyfile(os.path.join("sources", |
127 | @@ -304,6 +301,10 @@ | |||
128 | 304 | 'icon_resources': [(0, 'ubuntu_one.ico')] | 301 | 'icon_resources': [(0, 'ubuntu_one.ico')] |
129 | 305 | }, | 302 | }, |
130 | 306 | { | 303 | { |
131 | 304 | 'script': 'bin/ubuntuone-proxy-tunnel', | ||
132 | 305 | 'icon_resources': [(0, 'ubuntu_one.ico')] | ||
133 | 306 | }, | ||
134 | 307 | { | ||
135 | 307 | 'script': 'bin/ubuntuone-control-panel-qt', | 308 | 'script': 'bin/ubuntuone-control-panel-qt', |
136 | 308 | 'icon_resources': [(0, 'ubuntu_one.ico')] | 309 | 'icon_resources': [(0, 'ubuntu_one.ico')] |
137 | 309 | }, | 310 | }, |
138 | @@ -312,7 +313,15 @@ | |||
139 | 312 | 'icon_resources': [(0, 'ubuntu_one.ico')] | 313 | 'icon_resources': [(0, 'ubuntu_one.ico')] |
140 | 313 | }, | 314 | }, |
141 | 314 | { | 315 | { |
143 | 315 | 'script': 'bin/ubuntuone-installer-qt', | 316 | 'script': 'bin/ubuntu-sso-login-qt', |
144 | 317 | 'icon_resources': [(0, 'ubuntu_one.ico')] | ||
145 | 318 | }, | ||
146 | 319 | { | ||
147 | 320 | 'script': 'bin/ubuntu-sso-proxy-creds-qt', | ||
148 | 321 | 'icon_resources': [(0, 'ubuntu_one.ico')] | ||
149 | 322 | }, | ||
150 | 323 | { | ||
151 | 324 | 'script': 'bin/ubuntu-sso-ssl-certificate-qt', | ||
152 | 316 | 'icon_resources': [(0, 'ubuntu_one.ico')] | 325 | 'icon_resources': [(0, 'ubuntu_one.ico')] |
153 | 317 | }, | 326 | }, |
154 | 318 | ] | 327 | ] |
155 | @@ -324,7 +333,7 @@ | |||
156 | 324 | # Build bundles | 333 | # Build bundles |
157 | 325 | setup( | 334 | setup( |
158 | 326 | name='ubuntuone', | 335 | name='ubuntuone', |
160 | 327 | version='2.0.3', | 336 | version='2.99.91', |
161 | 328 | license='GPL v3', | 337 | license='GPL v3', |
162 | 329 | author='', | 338 | author='', |
163 | 330 | author_email='', | 339 | author_email='', |
164 | @@ -342,11 +351,11 @@ | |||
165 | 342 | 'includes': ['google.protobuf.descriptor', | 351 | 'includes': ['google.protobuf.descriptor', |
166 | 343 | 'sip', | 352 | 'sip', |
167 | 344 | 'twisted.web.resource', | 353 | 'twisted.web.resource', |
168 | 354 | 'twisted.web.client', | ||
169 | 345 | 'ubuntu_sso.qt', | 355 | 'ubuntu_sso.qt', |
171 | 346 | 'ubuntu_sso.qt.gui', | 356 | 'ubuntu_sso.qt.ui', |
172 | 347 | 'PyQt4.QtNetwork', | 357 | 'PyQt4.QtNetwork', |
173 | 348 | 'oauth', | 358 | 'oauth', |
174 | 349 | 'ubuntuone_installer', | ||
175 | 350 | 'configglue', | 359 | 'configglue', |
176 | 351 | 'configglue.app', | 360 | 'configglue.app', |
177 | 352 | 'configglue.inischema', | 361 | 'configglue.inischema', |
178 | 353 | 362 | ||
179 | === modified file 'scripts/ubuntuone.xml' | |||
180 | --- scripts/ubuntuone.xml 2011-12-28 19:15:16 +0000 | |||
181 | +++ scripts/ubuntuone.xml 2012-03-23 18:38:19 +0000 | |||
182 | @@ -1,7 +1,7 @@ | |||
183 | 1 | <project> | 1 | <project> |
184 | 2 | <shortName>ubuntuone</shortName> | 2 | <shortName>ubuntuone</shortName> |
185 | 3 | <fullName>Ubuntu One</fullName> | 3 | <fullName>Ubuntu One</fullName> |
187 | 4 | <version>2.0.3</version> | 4 | <version>2.99.91</version> |
188 | 5 | <componentList> | 5 | <componentList> |
189 | 6 | <component> | 6 | <component> |
190 | 7 | <name>autoupdater</name> | 7 | <name>autoupdater</name> |
191 | @@ -46,8 +46,7 @@ | |||
192 | 46 | <platforms>windows</platforms> | 46 | <platforms>windows</platforms> |
193 | 47 | <runAsAdmin>0</runAsAdmin> | 47 | <runAsAdmin>0</runAsAdmin> |
194 | 48 | <runInTerminal>0</runInTerminal> | 48 | <runInTerminal>0</runInTerminal> |
197 | 49 | <windowsExec>${installdir}\dist\ubuntuone-installer-qt.exe</windowsExec> | 49 | <windowsExec>${installdir}\dist\ubuntuone-control-panel-qt.exe</windowsExec> |
196 | 50 | <windowsExecArgs></windowsExecArgs> | ||
198 | 51 | <windowsIcon>${installdir}/ubuntu_one.ico</windowsIcon> | 50 | <windowsIcon>${installdir}/ubuntu_one.ico</windowsIcon> |
199 | 52 | <windowsPath>${windows_folder_desktopdirectory}</windowsPath> | 51 | <windowsPath>${windows_folder_desktopdirectory}</windowsPath> |
200 | 53 | </shortcut> | 52 | </shortcut> |
201 | @@ -136,7 +135,7 @@ | |||
202 | 136 | <name>Ubuntu One</name> | 135 | <name>Ubuntu One</name> |
203 | 137 | <runAsAdmin>0</runAsAdmin> | 136 | <runAsAdmin>0</runAsAdmin> |
204 | 138 | <runInTerminal>0</runInTerminal> | 137 | <runInTerminal>0</runInTerminal> |
206 | 139 | <windowsExec>${installdir}\dist\ubuntuone-installer-qt.exe</windowsExec> | 138 | <windowsExec>${installdir}\dist\ubuntuone-control-panel-qt.exe</windowsExec> |
207 | 140 | <windowsExecArgs></windowsExecArgs> | 139 | <windowsExecArgs></windowsExecArgs> |
208 | 141 | <windowsIcon>${installdir}/ubuntu_one.ico</windowsIcon> | 140 | <windowsIcon>${installdir}/ubuntu_one.ico</windowsIcon> |
209 | 142 | <windowsPath>${windows_folder_desktopdirectory}</windowsPath> | 141 | <windowsPath>${windows_folder_desktopdirectory}</windowsPath> |
210 | @@ -228,7 +227,7 @@ | |||
211 | 228 | </registrySet> | 227 | </registrySet> |
212 | 229 | <runProgram> | 228 | <runProgram> |
213 | 230 | <program>${windows_folder_system}\RunDll32.exe</program> | 229 | <program>${windows_folder_system}\RunDll32.exe</program> |
215 | 231 | <programArguments>"${installdir}\dist\VistaLib32.dll" RunNonElevated "${installdir}\dist\ubuntuone-installer-qt.exe" --installer &</programArguments> | 230 | <programArguments>"${installdir}\dist\VistaLib32.dll" RunNonElevated "${installdir}\dist\ubuntuone-control-panel-qt.exe --installer &"</programArguments> |
216 | 232 | <useMSDOSPath>0</useMSDOSPath> | 231 | <useMSDOSPath>0</useMSDOSPath> |
217 | 233 | <ruleList> | 232 | <ruleList> |
218 | 234 | <compareText> | 233 | <compareText> |
219 | @@ -243,7 +242,7 @@ | |||
220 | 243 | </runProgram> | 242 | </runProgram> |
221 | 244 | <runProgram> | 243 | <runProgram> |
222 | 245 | <program>${windows_folder_system}\RunDll32.exe</program> | 244 | <program>${windows_folder_system}\RunDll32.exe</program> |
224 | 246 | <programArguments>"${installdir}\dist\VistaLib64.dll" RunNonElevated "${installdir}\dist\ubuntuone-installer-qt.exe" --installer &</programArguments> | 245 | <programArguments>"${installdir}\dist\VistaLib64.dll" RunNonElevated "${installdir}\dist\ubuntuone-control-panel-qt.exe" --installer &</programArguments> |
225 | 247 | <useMSDOSPath>0</useMSDOSPath> | 246 | <useMSDOSPath>0</useMSDOSPath> |
226 | 248 | <ruleList> | 247 | <ruleList> |
227 | 249 | <compareText> | 248 | <compareText> |
228 | @@ -256,6 +255,7 @@ | |||
229 | 256 | </platformTest> | 255 | </platformTest> |
230 | 257 | </ruleList> | 256 | </ruleList> |
231 | 258 | </runProgram> | 257 | </runProgram> |
232 | 258 | <!-- TODO: remove this showInfo? --> | ||
233 | 259 | <showInfo> | 259 | <showInfo> |
234 | 260 | <text>Please reboot to finish upgrade.</text> | 260 | <text>Please reboot to finish upgrade.</text> |
235 | 261 | <ruleList> | 261 | <ruleList> |
236 | 262 | 262 | ||
237 | === modified file 'scripts/ubuntuone_autoupdate.xml' | |||
238 | --- scripts/ubuntuone_autoupdate.xml 2011-12-14 20:42:38 +0000 | |||
239 | +++ scripts/ubuntuone_autoupdate.xml 2012-03-23 18:38:19 +0000 | |||
240 | @@ -2,7 +2,7 @@ | |||
241 | 2 | <fullName>Ubuntu One</fullName> | 2 | <fullName>Ubuntu One</fullName> |
242 | 3 | <shortName>ubuntuone</shortName> | 3 | <shortName>ubuntuone</shortName> |
243 | 4 | <vendor>Canonical</vendor> | 4 | <vendor>Canonical</vendor> |
245 | 5 | <version>203</version> | 5 | <version>1000</version> |
246 | 6 | <singleInstanceCheck>1</singleInstanceCheck> | 6 | <singleInstanceCheck>1</singleInstanceCheck> |
247 | 7 | <requireInstallationByRootUser>0</requireInstallationByRootUser> | 7 | <requireInstallationByRootUser>0</requireInstallationByRootUser> |
248 | 8 | <requestedExecutionLevel>asInvoker</requestedExecutionLevel> | 8 | <requestedExecutionLevel>asInvoker</requestedExecutionLevel> |
+1 - looks fine, worked well IRL when I used it a few minutes ago