Code review comment for lp:~ralsina/ubuntuone-windows-installer/cloud-to-cloud

Revision history for this message
Roberto Alsina (ralsina) wrote :

> Question:
>
> when entering the SyncNowOrLaterPage, where its initializePage calls get_info
> and the overlay is shown, where is the overlay hid?

In the wizard's next()

> * Can you please move the self.patch(os.path, 'getsize', lambda *args: 0) to
> the testcase setup?
> I'm getting this for test_status_after_get_info:
>
> test_status_after_get_info ... Exception in thread Thread-19:
> Traceback (most recent call last):
> File "/usr/lib/python2.7/threading.py", line 552, in __bootstrap_inner
> self.run()
> File "/home/nessita/canonical/u1/windows-installer/review_cloud-to-
> cloud/ubuntuone_installer/gui/qt/local_folders.py", line 86, in run
> total_size += os.path.getsize(fp)
> File "/usr/lib/python2.7/genericpath.py", line 49, in getsize
> return os.stat(filename).st_size
> OSError: [Errno 2] No such file or directory: '/tmp/tmp5i98v9/test_file'

Sure. I am not sure if that won't break some other test that actually uses getsize though. Will check it.

>
> * When testing IRL, right after the SSO's "Congratulations" page, I got an
> empty page with a loading overlay. A few seconds later, the overlay went away,
> but the page remained empty (I have a screenshot if you need it).
> I had to click next on the empty page to get the cloud to computer page.

I believe you!

> * And I never for the computer to cloud page :-/.

That one should always be there, even if you get the "cloud to computer" page, it should after that.

« Back to merge proposal