Merge lp:~ralsina/ubuntu-sso-client/fix_805461 into lp:ubuntu-sso-client

Proposed by Roberto Alsina
Status: Merged
Approved by: Roberto Alsina
Approved revision: 734
Merged at revision: 730
Proposed branch: lp:~ralsina/ubuntu-sso-client/fix_805461
Merge into: lp:ubuntu-sso-client
Diff against target: 33 lines (+15/-1)
1 file modified
ubuntu_sso/qt/controllers.py (+15/-1)
To merge this branch: bzr merge lp:~ralsina/ubuntu-sso-client/fix_805461
Reviewer Review Type Date Requested Status
Alejandro J. Cura (community) Approve
Review via email: mp+66820@code.launchpad.net

Commit message

Expand a couple of variables that were left as placeholders in a text.

Description of the change

Expand a couple of variables that were left as placeholders in a text.

To post a comment you must log in.
732. By Roberto Alsina

Call _set_titles *after* the email_address field is set

Revision history for this message
Alejandro J. Cura (alecu) wrote :

Tested on windows, works as expected.

review: Approve
733. By Roberto Alsina

Don't use a private method

734. By Roberto Alsina

Style fix

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ubuntu_sso/qt/controllers.py'
--- ubuntu_sso/qt/controllers.py 2011-06-29 22:19:49 +0000
+++ ubuntu_sso/qt/controllers.py 2011-07-04 19:54:40 +0000
@@ -405,6 +405,9 @@
405 self.backend.register_user(self.view.wizard().app_name, email,405 self.backend.register_user(self.view.wizard().app_name, email,
406 password, name, captcha_id,406 password, name, captcha_id,
407 captcha_solution)407 captcha_solution)
408 # Update validation page's title, which contains the email
409 wizard = self.view.wizard()
410 wizard.page(wizard.email_verification_page_id).controller.set_titles()
408411
409 def is_correct_email(self, email_address):412 def is_correct_email(self, email_address):
410 """Return if the email is correct."""413 """Return if the email is correct."""
@@ -480,7 +483,18 @@
480 """Set the different titles."""483 """Set the different titles."""
481 logger.debug('EmailVerificationController._set_titles')484 logger.debug('EmailVerificationController._set_titles')
482 self.view.setTitle(VERIFY_EMAIL_TITLE)485 self.view.setTitle(VERIFY_EMAIL_TITLE)
483 self.view.setSubTitle(VERIFY_EMAIL_CONTENT)486 self.view.setSubTitle(VERIFY_EMAIL_CONTENT % {
487 "app_name": self.view.wizard().app_name,
488 "email": self.view.wizard().field("email_address").toString(),
489 })
490
491 def set_titles(self):
492 """This class needs to have a public set_titles.
493
494 Since the subtitle contains data that is only known after SetupAccount
495 and _set_titles is only called on initialization.
496 """
497 self._set_titles()
484498
485 #pylint: disable=C0103499 #pylint: disable=C0103
486 @inlineCallbacks500 @inlineCallbacks

Subscribers

People subscribed via source and target branches