Code review comment for lp:~ralsina/ubuntu-sso-client/error_message_key

Revision history for this message
Roberto Alsina (ralsina) wrote :

> The branch looks great!
>
> Only a couple of tests are missing:
> - when both msg1 and msg2 are not None (for two cases: when msg2 is 'message'
> and when is 'error_message').
> - when msg1 is not None (ie __all__ is present)
>
> Can you please add those test cases? Thanks!

Added!

« Back to merge proposal