Merge lp:~ralsina/ubuntu-push-qml/fix-watcher-leak into lp:ubuntu-push-qml

Proposed by Roberto Alsina
Status: Merged
Approved by: MichaƂ Karnicki
Approved revision: 17
Merged at revision: 18
Proposed branch: lp:~ralsina/ubuntu-push-qml/fix-watcher-leak
Merge into: lp:ubuntu-push-qml
Diff against target: 19 lines (+2/-0)
1 file modified
src/Ubuntu/PushNotifications/pushclient.cpp (+2/-0)
To merge this branch: bzr merge lp:~ralsina/ubuntu-push-qml/fix-watcher-leak
Reviewer Review Type Date Requested Status
Roberto Alsina (community) Approve
Review via email: mp+250780@code.launchpad.net

Commit message

Don't leak watchers.

Description of the change

Don't leak watchers.

To post a comment you must log in.
Revision history for this message
Roberto Alsina (ralsina) wrote :

+1 from karni

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Ubuntu/PushNotifications/pushclient.cpp'
--- src/Ubuntu/PushNotifications/pushclient.cpp 2015-01-19 18:42:19 +0000
+++ src/Ubuntu/PushNotifications/pushclient.cpp 2015-02-24 15:37:32 +0000
@@ -77,6 +77,7 @@
77 QTimer::singleShot(200, this, SLOT(getNotifications()));77 QTimer::singleShot(200, this, SLOT(getNotifications()));
78 emit tokenChanged(this->token);78 emit tokenChanged(this->token);
79 }79 }
80 watcher->deleteLater();
80}81}
8182
82QString PushClient::getAppId() {83QString PushClient::getAppId() {
@@ -117,6 +118,7 @@
117 else {118 else {
118 emit notificationsChanged(reply.value());119 emit notificationsChanged(reply.value());
119 }120 }
121 watcher->deleteLater();
120}122}
121123
122QStringList PushClient::getPersistent() {124QStringList PushClient::getPersistent() {

Subscribers

People subscribed via source and target branches