Code review comment for lp:~rainct/zeitgeist/custom-log-handler

Revision history for this message
Michal Hruby (mhr3) wrote :

> 2012/2/17 Michal Hruby <email address hidden>:
> > Only WARNING and higher levels should be logged to stderr.
>
> Currently it's sending anything but debug to stderr. I tried :P.
>

Yes, I wanted INFO and MESSAGE to also go to stdout.

> (But if you want to change that, fine with me).
>
> > Also, one thing I dont like about glib's default log handler is that
> > it doesn't print time, could we do that?
>
> To the file, sure (it's in the commented code).
>
> To std{out,err}, wth would you do that, it's just cluttering stuff up.

It's pretty valuable when you're just reading the log and wondering if something happened in the same millisecond or a couple of hours apart.

« Back to merge proposal