Code review comment for lp:~rainct/libzeitgeist/776651-doc

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

30 +/**
31 + * zeitgeist_subject_get_current_uri:
32 + * @subject: The subject to get the current_uri from
33 + *
34 + * Get the current_uri of a subject.
35 + * This attribute is only significant for subjects for a
36 + * #ZEITGEIST_ZG_MOVE_EVENT.
37 + *
38 + * Returns: The current_uri of @subject.
39 + *
40 + * Since: 0.3.14
41 + */

This is not entirely true is guess?

If a file has been deleted and zg registers it then the current_uri will be NULL, no? And current_uri != uri if at any point in the past Zg has seen a MOVE_EVENT on uri - the ocs make it sounds like it is only relevant when the subject instance is embedded in a MoveEvent instance..?

review: Needs Fixing

« Back to merge proposal