Code review comment for ~raharper/netplan:fix-mtu

On Mon, Mar 6, 2017 at 11:18 AM, Ryan Harper <email address hidden>
wrote:

> On Mon, Mar 6, 2017 at 11:13 AM, Mathieu Trudel-Lapierre <
> <email address hidden>> wrote:
>
> > Review: Needs Fixing
> >
> > I wasn't able to successfully verify that this works on both NM and
> > networkd. Could you add integration tests too?
> >
>
> I tested networkd only; I'll look at the integration tests.
>

I'm struggling with getting the tests to work reliably; If anyone of the
tests fails,
the system ends up in a bad state (modules previously loaded fail to a load
a second time); veth devices stick around, and data is written into /run but
not cleaned up between test-case runs. The tests don't run with via nose;
but
rather calling python directly and only from within the tests directory.
Finally the test invokes 'netplan' which references whatever netplan is
installed
on the system rather than the netplan from the source tree.

I didn't verify NM side as I didn't add any changes for NM side;

>
> > --
> > https://code.launchpad.net/~raharper/netplan/+git/netplan/+merge/318545
> > You are the owner of ~raharper/netplan:fix-mtu.
> >
>
> --
> https://code.launchpad.net/~raharper/netplan/+git/netplan/+merge/318545
> You are the owner of ~raharper/netplan:fix-mtu.
>