Code review comment for lp:~raharper/curtin/trunk.nvme_bcache

Revision history for this message
Scott Moser (smoser) wrote :

Some comments inline.
The unit tests seem really tied to the implementation (mocking os.path.exists which is called by 2 different callers).

I realize this is tricky, but maybe some re-work could make the tests more clear.

A test for get_bcache_sys_path would be good.

« Back to merge proposal