Merge lp:~raharper/curtin/trunk.net-manual into lp:~curtin-dev/curtin/trunk
Proposed by
Ryan Harper
Status: | Merged |
---|---|
Merged at revision: | 374 |
Proposed branch: | lp:~raharper/curtin/trunk.net-manual |
Merge into: | lp:~curtin-dev/curtin/trunk |
Diff against target: |
199 lines (+78/-23) 3 files modified
curtin/commands/apply_net.py (+14/-3) curtin/net/__init__.py (+22/-11) tests/unittests/test_net.py (+42/-9) |
To merge this branch: | bzr merge lp:~raharper/curtin/trunk.net-manual |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Server Team CI bot | continuous-integration | Needs Fixing | |
Scott Moser | Pending | ||
Review via email: mp+288799@code.launchpad.net |
Commit message
net: clean up e/n/i and udev rules for manually configured interfaces
Don't emit auto $iface for manually configured interfaces, except when
enslaved to bridges or bonds.
Don't emit a udev rules for nics without a mac_address
Don't write a udev rules file unless we have at least one interface to map
Add unittest to validate bonding network config which uses iface manual but in the service of a bond
To post a comment you must log in.
It seems maybe arguable that you'd *want* to blank the udev rules if there were no interfaces to map.
ie, if you're fully declaritive we own that file.
thoughts?