Code review comment for lp:~raharper/curtin/trunk.fix-lvm-over-raid

Revision history for this message
Ryan Harper (raharper) wrote :

> I agree with Chad's request for the actual errors.
>
> The only other thing that I would suggest, is that if we can determine in the
> exception block that this failure can be ignored, then we could/should not log
> it at WARN. Ie, if we tried and everything still ends up OK, then the warning
> is just loud noise that looks scary later.

I'll replace the WARN with debug.

« Back to merge proposal