Code review comment for lp:~raharper/curtin/trunk.fix-lvm-over-raid
Revision history for this message
| Scott Moser (smoser) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
I agree with Chad's request for the actual errors.
The only other thing that I would suggest, is that if we can determine in the exception block that this failure can be ignored, then we could/should not log it at WARN. Ie, if we tried and everything still ends up OK, then the warning is just loud noise that looks scary later.