Code review comment for lp:~raharper/curtin/trunk.add-syslog-handler

Revision history for this message
Ryan Harper (raharper) wrote :

On Tue, Nov 28, 2017 at 9:52 AM, Scott Moser <email address hidden>
wrote:

> Review: Approve
>
> Adjust your comment to mention that we are now supporting multiple
> handlers at once (I think).
> And then i approve.
>
> Is there a way to disable the syslog logger? It doesnt look like it. I
> dont have a reason at the moment to suggest that it needs to be.
>

I want to review it in light of the journal_report logger; I thought this
would have replaced it but the journal reporter was needed separately
and the syslog had some interesting side-effects w.r.t the reporting logger.

I'll mark this WIP

Ryan

>
>
> --
> https://code.launchpad.net/~raharper/curtin/trunk.add-
> syslog-handler/+merge/330914
> You are the owner of lp:~raharper/curtin/trunk.add-syslog-handler.
>

« Back to merge proposal