~raharper/curtin:fix/ptable-label-pmbr

Branch merges

Propose for merging

Merged into curtin:master

Chad Smith: Approve on 2019-10-24

Server Team CI bot: Approve (continuous-integration) on 2019-10-24

Dan Watkins (community): Approve on 2019-10-23

Dimitri John Ledkov (community): Needs Fixing on 2019-10-22

Michael Hudson-Doyle: Pending requested 2019-10-17

Diff: 109 lines (+27/-6)

4 files modified

curtin/block/schemas.py (+3/-2)
curtin/commands/block_meta.py (+3/-1)
curtin/storage_config.py (+5/-1)
tests/unittests/test_storage_config.py (+16/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

ca77533... by Ryan Harper on 2019-10-24

Replace use of 'unsupported' with schemas._ptable_unsupported

48fd93a... by Ryan Harper on 2019-10-23

Restore ptable preserve check, except when 'unsupported'

be9e2d3... by Ryan Harper on 2019-10-23

schema: add _ptable_unsupported variable

8981dde... by Ryan Harper on 2019-10-22

schema: Add ptable value 'unsupported' for types curtin does not handle

Mark unsupported table types as 'unsupported'. This allows the existing
table and partitions to be re-used. Modify block_meta disk_handler to
not attempt to validate a preserved partition table as we now accept
'unsupported' ptable types; we won't be able to validate those entries.

e7a9d6a... by Ryan Harper on 2019-10-17

schema: omit 'ptable' entries for values curtin cannot create

Probert output may include values of partition table 'label'
values that curtin does not create. This triggers schema
validation errors for common values, like 'mac' or 'PMBR' and
likely other valid table names but are not something that
curtin will create if wiped. Instead of adding more values
to the list that are valid if the value is not one curtin
uses omit the the 'ptable' entry entirely. Curtin will
default to using 'gpt' when creating new partition tables.

LP: #1848535

0390735... by Ryan Harper on 2019-10-21

Add skip_by_date to eoan ipv6 vlan test

70fa30b... by Michael Hudson-Doyle on 2019-10-15

storage_config: interpret value, not presence, of DM_MULTIPATH_DEVICE_PATH

Curtin assumes any block device that has the DM_MULTIPATH_DEVICE_PATH
key set in udev is a block device, but that's not correct. Since
multipath-tools 0.7.7 (according to
https://www.spinics.net/lists/dm-devel/msg35965.html), _every_ block
device that multipathd looks at gets that key set, but it is set to "1"
for things that are part of a multipathed device and "0" for things that
are not. So fix the checks in curtin to follow that.

4f6e365... by Ryan Harper on 2019-10-11

vmtest: Add skip_by_date for test_ip_output on eoan + vlans

edfdb1d... by Ryan Harper on 2019-10-08

block-schema: update raid schema for preserve and metadata

Curtin can now accept type: raid storage config which sets the
'preserve' boolean to 'true' which informs curtin that it does
not need to create a new raid device.

We also accept a 'metadata' version hint in the schema as curtin
passes this value along as info to users of block-discover.

12b437d... by Ryan Harper on 2019-10-08

dasd: update partition table value to 'vtoc'

DASD devices use a 'vtoc' partition table type. It is similar to DOS
but it is not in MS-DOS format. Adjust this value to 'vtoc' in docs,
block schema and the example config for vmtest.

LP: #1847073