~raharper/curtin:fix/better-fstab-entries

Branch merges

Propose for merging

Merged into curtin:master

Dan Watkins (community): Approve on 2020-01-29

Server Team CI bot: Approve (continuous-integration) on 2020-01-29

Ryan Harper (community): Approve on 2020-01-24

Dimitri John Ledkov (community): Approve on 2020-01-23

Diff: 1148 lines (+571/-185)

11 files modified

curtin/commands/block_meta.py (+56/-4)
curtin/commands/curthooks.py (+4/-1)
curtin/distro.py (+11/-0)
curtin/udev.py (+15/-7)
tests/unittests/test_commands_block_meta.py (+287/-35)
tests/unittests/test_udev.py (+15/-14)
tests/vmtests/__init__.py (+98/-5)
tests/vmtests/test_basic.py (+17/-89)
tests/vmtests/test_iscsi.py (+1/-0)
tests/vmtests/test_lvm.py (+10/-18)
tests/vmtests/test_mdadm_bcache.py (+57/-12)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

ef7a744... by Ryan Harper on 2020-01-29

Add comment on disk/part s390x by-path choice.

d64d65d... by Ryan Harper on 2020-01-29

remove osfamily param for now

161aeb8... by Ryan Harper on 2020-01-29

Update comment to point to unittests which have examples.

93c7b28... by Ryan Harper on 2020-01-24

revert debugging change

882995f... by Ryan Harper on 2020-01-23

fstab: use by-path symlinks on s390x

f8c8a97... by Ryan Harper on 2020-01-23

Add bcache unittest

491bd8f... by Ryan Harper on 2019-12-12

Drop unused imports

80404e8... by Ryan Harper on 2019-12-12

vmtest: refactor verification of fstab

With the changes to the contents of fstab depending on the
storage device type, we need to do some additional work to
determine the expected value from other parts of the system
and compare that to what's present in fstab.

In particular, we use dname or serials to look up device names
which can be used to look up other persistent storage device
symlinks in /dev/disk/by-id which we expect to be in fstab.

For bcache, we now verify that we have /dev/bcache/by-uuid
For lvm, raid, we verify /dev/disk/by/{dm|md}-uuid symlinks

This branch also added a fstab header to match what's present
in Ubiquity/d-i installers.

To enable this, a number of helper functions were added to
the VMBaseClass, including a new method to fetch the expected
fstab entry values at runtime, rather than defined in the class.

2bae971... by Ryan Harper on 2019-12-09

Indicate get_volume_type is private

a9e7899... by Ryan Harper on 2019-12-09

Add unittest for get_volume_spec