Merge ~raharper/curtin:fix/refactor-uefi-duplicate-for-reuse into curtin:master
Proposed by
Ryan Harper
Status: | Merged |
---|---|
Approved by: | Paride Legovini |
Approved revision: | 76199108979409c68c821a0b3044d3ffd5810138 |
Merge reported by: | Server Team CI bot |
Merged at revision: | not available |
Proposed branch: | ~raharper/curtin:fix/refactor-uefi-duplicate-for-reuse |
Merge into: | curtin:master |
Diff against target: |
82 lines (+26/-15) 2 files modified
curtin/commands/curthooks.py (+18/-9) tests/vmtests/test_reuse_uefi_esp.py (+8/-6) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paride Legovini | Approve | ||
Server Team CI bot | continuous-integration | Approve | |
Review via email: mp+390563@code.launchpad.net |
Commit message
Refactor uefi_remove_
Splitting the function into find/remove functions allows reuse in the
vmtest which exercises the code and then verifies the duplicate
removals.
- Remove skip_by_date on Centos7 in test_reuse_uefi_esp
- Use uefi_find_
To post a comment you must log in.
PASSED: Continuous integration, rev:76199108979 409c68c821a0b30 44d3ffd5810138 /jenkins. ubuntu. com/server/ job/curtin- ci/184/ /jenkins. ubuntu. com/server/ job/curtin- ci/nodes= metal-amd64/ 184/ /jenkins. ubuntu. com/server/ job/curtin- ci/nodes= metal-arm64/ 184/ /jenkins. ubuntu. com/server/ job/curtin- ci/nodes= metal-ppc64el/ 184/ /jenkins. ubuntu. com/server/ job/curtin- ci/nodes= metal-s390x/ 184/
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
Click here to trigger a rebuild: /jenkins. ubuntu. com/server/ job/curtin- ci/184/ /rebuild
https:/