Merge ~raharper/curtin:fix/add-btrfs-progs-dep into curtin:master

Proposed by Ryan Harper
Status: Rejected
Rejected by: Joshua Powers
Proposed branch: ~raharper/curtin:fix/add-btrfs-progs-dep
Merge into: curtin:master
Diff against target: 26 lines (+2/-2)
2 files modified
curtin/deps/__init__.py (+1/-1)
debian/control (+1/-1)
Reviewer Review Type Date Requested Status
Dan Watkins (community) Approve
Server Team CI bot continuous-integration Pending
Review via email: mp+370911@code.launchpad.net

Commit message

debian/control: switch btrfs-tools to btrfs-progs

Don't use the transitional package name btrfs-tools, use
btrfs-progs.

LP: #1772618

To post a comment you must log in.
Revision history for this message
Ryan Harper (raharper) wrote :

Note, on the release branches, btrfs-progs starts in bionic, so we'll need to patch this out on Xenial.

Revision history for this message
Dan Watkins (oddbloke) :
review: Approve
Revision history for this message
Chad Smith (chad.smith) wrote :

Think Ryan mentioned tackling the runtime deps logic too.

814c325... by Ryan Harper

Also update the runtime package name

Revision history for this message
Dan Watkins (oddbloke) :
review: Approve
Revision history for this message
Dimitri John Ledkov (xnox) wrote :
Revision history for this message
Joshua Powers (powersj) wrote :

I'm rejecting this one over the merge xnox commented about above.

Unmerged commits

814c325... by Ryan Harper

Also update the runtime package name

4762057... by Ryan Harper

debian/control: switch btrfs-tools to btrfs-progs

Don't use the transitional package name btrfs-tools, use
btrfs-progs.

LP: #1772618

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/curtin/deps/__init__.py b/curtin/deps/__init__.py
2index 37c4469..3eacbc9 100644
3--- a/curtin/deps/__init__.py
4+++ b/curtin/deps/__init__.py
5@@ -25,7 +25,7 @@ REQUIRED_EXECUTABLES = [
6 ('lvcreate', 'lvm2'),
7 ('mdadm', 'mdadm'),
8 ('mkfs.vfat', 'dosfstools'),
9- ('mkfs.btrfs', 'btrfs-tools'),
10+ ('mkfs.btrfs', 'btrfs-progs'),
11 ('mkfs.ext4', 'e2fsprogs'),
12 ('mkfs.xfs', 'xfsprogs'),
13 ('partprobe', 'parted'),
14diff --git a/debian/control b/debian/control
15index c2de623..3cc763e 100644
16--- a/debian/control
17+++ b/debian/control
18@@ -29,7 +29,7 @@ Package: curtin
19 Architecture: all
20 Priority: extra
21 Depends: bcache-tools,
22- btrfs-tools,
23+ btrfs-progs,
24 dosfstools,
25 file,
26 gdisk,

Subscribers

People subscribed via source and target branches