Code review comment for ~raharper/curtin:fix/dname_to_serial_wwn_if_available

On Wed, Nov 28, 2018 at 11:20 AM Scott Moser <email address hidden> wrote:
>
> At this point, I think this is probably fine.
> I put together what I think are some test case cleanups at:
> http://paste.ubuntu.com/p/XkJ2KMW5x7/
>
> I'd like you to pull them, but wont insist on it.

I'll pull

>
> Also, I think we have a bug with multipath disks.
> As it is, I'm pretty sure that ifyou put a name on a disk that was
> a multipath disk, you'll get a symlink from /dev/disk/by-name/my-name -> /dev/diskX
> when what we want would be /dev/mapper/mpathX
>
> For example, on some of our power systems, /dev/sda and /dev/sdg are
> multiple paths to the same disk. If we put a name on one of those, I think
> we'd get either
> /dev/disk/by-name -> /dev/sda or /dev/disk/by-name -> /dev/sdg
> but what we want is
> /dev/disk/by-name -> /dev/mapper/mpath0
>
> I'm fine to leave that as it is for now, but I think ultimately we
> will want to have some fix for that.

https://bugs.launchpad.net/ubuntu/+source/curtin/+bug/1805673

>
>
> --
> https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/358116
> You are the owner of ~raharper/curtin:fix/dname_to_serial_wwn_if_available.