cloud-init

Code review comment for ~raharper/cloud-init:cloud-test-add-pylint-and-fix

  1. Git
  2. lp:~raharper/cloud-init
  3. cloud-test-add-pylint-and-fix
  4. Merge into master
Revision history for this message
Scott Moser (smoser) wrote :

locally i've been through this locally
 tox && ./tools/run-centos 6 --rpm --srpm --unittest &&
   ./tools/run-centos 7 --rpm --srpm --unittest

And c-i is just about to agree
 https://jenkins.ubuntu.com/server/job/cloud-init-ci/599/console

I am making one change though. i'm going to move the '_tricky' bit for assertRaisesRegex back to the bottom of the file. it seems to fit better there with the other bits that are already there. (and i've tested the above).

review: Approve

« Back to merge proposal