Code review comment for ~raharper/cloud-init:cloud-test-add-pylint-and-fix

Revision history for this message
Ryan Harper (raharper) wrote :

Didn't mean to run on tools for now.

w.r.t the meta-data bits, I'll defer to Scott, he did that first bit.

On Wed, Dec 6, 2017 at 5:15 PM, Joshua Powers <email address hidden>
wrote:

> Review: Needs Fixing
>
> Thanks for doing this! Can you add comment to description/commit message
> about meta-data getting added to the integration tests?
>
> Looks like a few tip-pylint errors, one of which is why I asked about
> getting rid of tools/hacking.py.
>
> Otherwise I ran a full lxd and nocloud-kvm test run with no failures:
> lxd: https://paste.ubuntu.com/26128706/
> nocloud-kvm: https://paste.ubuntu.com/26128704/
>
>
> --
> https://code.launchpad.net/~raharper/cloud-init/+git/
> cloud-init/+merge/334868
> You are the owner of ~raharper/cloud-init:cloud-test-add-pylint-and-fix.
>

« Back to merge proposal