Code review comment for ~raharper/cloud-init:logging-gmtime

Revision history for this message
Scott Moser (smoser) wrote :

I think your test case has fence post errors at the end of a minute. I, if we read it now() in the 59th second and the log message happens in the next second the test will fail. Right?

One way to combat this would be to get a before timestamp and an after timestamp. Then parse the log message time stamp and assert that before >= log >= after.

« Back to merge proposal