Merge lp:~raghavendra-prabhu/percona-xtrabackup/2.0-bug1201686 into lp:percona-xtrabackup/2.1

Proposed by Raghavendra D Prabhu
Status: Rejected
Rejected by: Alexey Kopytov
Proposed branch: lp:~raghavendra-prabhu/percona-xtrabackup/2.0-bug1201686
Merge into: lp:percona-xtrabackup/2.1
Diff against target: 120 lines (+39/-4) (has conflicts)
3 files modified
test/t/bug983720_galerainfo.sh (+9/-1)
test/t/xb_galera_info.sh (+7/-1)
test/t/xb_galera_sst.sh (+23/-2)
Text conflict in test/t/xb_galera_sst.sh
To merge this branch: bzr merge lp:~raghavendra-prabhu/percona-xtrabackup/2.0-bug1201686
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Needs Resubmitting
Review via email: mp+176660@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Raghavendra D Prabhu (raghavendra-prabhu) wrote :
Revision history for this message
Raghavendra D Prabhu (raghavendra-prabhu) wrote :
Revision history for this message
Alexey Kopytov (akopytov) wrote :

This should be MPed into 2.0 rather 2.1. Will re-MP.

review: Needs Resubmitting

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'test/t/bug983720_galerainfo.sh'
2--- test/t/bug983720_galerainfo.sh 2012-11-12 05:06:16 +0000
3+++ test/t/bug983720_galerainfo.sh 2013-07-24 11:38:31 +0000
4@@ -4,6 +4,7 @@
5
6 . inc/common.sh
7
8+ADDR=127.0.0.1
9 set +e
10 ${MYSQLD} --basedir=$MYSQL_BASEDIR --user=$USER --help --verbose --wsrep-sst-method=rsync| grep -q wsrep
11 probe_result=$?
12@@ -16,9 +17,16 @@
13 fi
14 set -e
15
16+debug=""
17+pdebug=""
18+if [[ -n ${WSREP_DEBUG:-} ]];then
19+ debug="--wsrep-debug=1"
20+ pdebug=";debug=1"
21+fi
22+
23 galera_port=`get_free_port 2`
24
25-start_server --log-bin=`hostname`-bin --binlog-format=ROW --wsrep-provider=${MYSQL_BASEDIR}/lib/libgalera_smm.so --wsrep_cluster_address=gcomm:// --wsrep_provider_options="base_port=${galera_port}"
26+start_server --log-bin=`hostname`-bin --binlog-format=ROW --wsrep-provider=${MYSQL_BASEDIR}/lib/libgalera_smm.so --wsrep_cluster_address=gcomm:// $debug --wsrep_provider_options="base_port=${galera_port}${pdebug}" --wsrep_node_address=$ADDR
27
28 # take a backup with stream mode
29 mkdir -p $topdir/backup
30
31=== modified file 'test/t/xb_galera_info.sh'
32--- test/t/xb_galera_info.sh 2012-09-21 00:43:03 +0000
33+++ test/t/xb_galera_info.sh 2013-07-24 11:38:31 +0000
34@@ -1,5 +1,6 @@
35 . inc/common.sh
36
37+ADDR=127.0.0.1
38 set +e
39 ${MYSQLD} --basedir=$MYSQL_BASEDIR --user=$USER --help --verbose --wsrep-sst-method=rsync| grep -q wsrep
40 probe_result=$?
41@@ -12,7 +13,12 @@
42 fi
43 set -e
44
45-start_server --log-bin=`hostname`-bin --binlog-format=ROW --wsrep-provider=${MYSQL_BASEDIR}/lib/libgalera_smm.so --wsrep_cluster_address=gcomm://
46+if [[ -n ${WSREP_DEBUG:-} ]];then
47+ start_server --log-bin=`hostname`-bin --binlog-format=ROW --wsrep-provider=${MYSQL_BASEDIR}/lib/libgalera_smm.so --wsrep_cluster_address=gcomm:// --wsrep-debug=1 --wsrep_provider_options="debug=1" --wsrep_node_address=$ADDR
48+else
49+ start_server --log-bin=`hostname`-bin --binlog-format=ROW --wsrep-provider=${MYSQL_BASEDIR}/lib/libgalera_smm.so --wsrep_cluster_address=gcomm:// --wsrep_node_address=$ADDR
50+fi
51+
52
53 innobackupex --no-timestamp --galera-info $topdir/backup
54 backup_dir=$topdir/backup
55
56=== modified file 'test/t/xb_galera_sst.sh'
57--- test/t/xb_galera_sst.sh 2013-07-09 09:49:17 +0000
58+++ test/t/xb_galera_sst.sh 2013-07-24 11:38:31 +0000
59@@ -9,9 +9,11 @@
60 node2=901
61 ADDR=127.0.0.1
62 SSTPASS="password"
63+SUSER="root"
64+SMDSUM="9f6f3edb78f9a5957ecaf8f99953b5af"
65
66 set +e
67-${MYSQLD} --basedir=$MYSQL_BASEDIR --user=$USER --help --verbose --wsrep-sst-method=rsync| grep -q wsrep
68+${MYSQLD} --basedir=$MYSQL_BASEDIR --help --verbose --wsrep-sst-method=rsync| grep -q wsrep
69 probe_result=$?
70 if [[ "$probe_result" == "0" ]]
71 then
72@@ -22,13 +24,20 @@
73 fi
74 set -e
75
76+debug=""
77+pdebug=""
78+if [[ -n ${WSREP_DEBUG:-} ]];then
79+ debug="--wsrep-debug=1"
80+ pdebug=";debug=1"
81+fi
82+
83 recv_addr1="${ADDR}:$(get_free_port 2)"
84 recv_addr2="${ADDR}:$(get_free_port 3)"
85 listen_addr1="${ADDR}:$(get_free_port 4)"
86 listen_addr2="${ADDR}:$(get_free_port 5)"
87
88 vlog "Starting server $node1"
89-start_server_with_id $node1 --innodb_file_per_table --binlog-format=ROW --wsrep-provider=${MYSQL_BASEDIR}/lib/libgalera_smm.so --wsrep_cluster_address=gcomm:// --wsrep_sst_receive_address=$recv_addr1 --wsrep_node_incoming_address=$ADDR --wsrep_provider_options="gmcast.listen_addr=tcp://$listen_addr1" --wsrep_sst_method=xtrabackup --wsrep_sst_auth=$USER:$SSTPASS
90+start_server_with_id $node1 --innodb_file_per_table --binlog-format=ROW --wsrep-provider=${MYSQL_BASEDIR}/lib/libgalera_smm.so --wsrep_cluster_address=gcomm:// --wsrep_sst_receive_address=$recv_addr1 --wsrep_node_incoming_address=$ADDR --wsrep_provider_options="gmcast.listen_addr=tcp://$listen_addr1${pdebug}" --wsrep_sst_method=xtrabackup --wsrep_sst_auth=$SUSER:$SSTPASS --wsrep_node_address=$ADDR $debug
91
92 load_sakila
93
94@@ -38,8 +47,12 @@
95 EOF
96
97 vlog "Starting server $node2"
98+<<<<<<< TREE
99 start_server_with_id $node2 --innodb_file_per_table --binlog-format=ROW --wsrep-provider=${MYSQL_BASEDIR}/lib/libgalera_smm.so --wsrep_cluster_address=gcomm://$listen_addr1 --wsrep_sst_receive_address=$recv_addr2 --wsrep_node_incoming_address=$ADDR --wsrep_provider_options="gmcast.listen_addr=tcp://$listen_addr2" --wsrep_sst_method=xtrabackup --wsrep_sst_auth=$USER:$SSTPASS
100
101+=======
102+start_server_with_id $node2 --innodb_file_per_table --binlog-format=ROW --wsrep-provider=${MYSQL_BASEDIR}/lib/libgalera_smm.so --wsrep_cluster_address=gcomm://$listen_addr1 --wsrep_sst_receive_address=$recv_addr2 --wsrep_node_incoming_address=$ADDR --wsrep_provider_options="gmcast.listen_addr=tcp://$listen_addr2${pdebug}" --wsrep_sst_method=xtrabackup --wsrep_sst_auth=$SUSER:$SSTPASS --wsrep_node_address=$ADDR $debug
103+>>>>>>> MERGE-SOURCE
104 switch_server $node2
105
106 # The password propagates through SST
107@@ -54,6 +67,14 @@
108 exit 1
109 fi
110
111+# Lightweight verification till lp:1199656 is fixed
112+mdsum=$(${MYSQL} ${MYSQL_ARGS} -e 'select * from sakila.actor;' | md5sum | cut -d" " -f1)
113+
114+if [[ $mdsum != $SMDSUM ]];then
115+ vlog "Integrity verification failed: found: $mdsum expected: $SMDSUM"
116+ exit 1
117+fi
118+
119 stop_server_with_id $node2
120 stop_server_with_id $node1
121

Subscribers

People subscribed via source and target branches