Ubuntu
systemd package

Code review comment for ~rafaeldtinoco/ubuntu/+source/systemd:lp1815101-eoan

  1. Git
  2. lp:~rafaeldtinoco/ubuntu/+source/systemd
  3. lp1815101-eoan
  4. Merge into ubuntu/eoan-devel
Revision history for this message
Dan Streetman (ddstreet) wrote :

Overall, the patchset looks mostly good (one comment farther down in the patches), but I'm quite concerned about handling of dhcp addresses on stop, start, and restart. I don't think it's even entirely worked out correctly/fully upstream yet. That's not to say that the dhcp handling behavior in our SRU releases is correct, or that upstream is correct, it's just complex and I feel like the KeepConfiguration param makes it more complex.

Since HA and the other software that need this only uses manually-added static addresses/routes (right?), I'd much prefer something smaller, less complex, that only causes networkd to ignore foreign static addresses/routes.

But I don't currently have any suggestions on how to do that :-)

« Back to merge proposal