Ubuntu
resource-agents package

Code review comment for ~rafaeldtinoco/ubuntu/+source/resource-agents:lp1895348-groovy

  1. Git
  2. lp:~rafaeldtinoco/ubuntu/+source/resource-agents
  3. lp1895348-groovy
  4. Merge into ubuntu/groovy-devel
Revision history for this message
Bryce Harrington (bryce) wrote :

  - [d22700fc] azure-lb: Don't redirect nc listener output to pidfile

LGTM +1, this looks like a cleaner approach for capturing the pid, than from the eval string.

  - [3b0ffc59] build: fix distcheck issue introduced by including
               READMEs in heartbeat directory

LGTM +1, trivial

  - [73551ac0] galera: Fix automatic recovery when a cluster was not
               gracefully stopped

LGTM +1, I had to think the refactoring logic through but it does make sense for the described behavior. I did not reproduce the problem myself, but can see now how it would occur.

review: Approve

« Back to merge proposal