Code review comment for ~rafaeldtinoco/ubuntu/+source/qemu:lp1805256-bionic-refix

Right,

so TARGET_ARM was only defined in some parts of the build and wasn't appropriate for async code (also because it would include armhf and that wasn't needed based in our observations).

Checking how QEMU used predefs for arch recognition, I saw the preferred way was #if defined(__arch__) so I'm using the #if !defined(__arch64__) version here.

Tested the predef in an aarch64 env and it works.

$ ./temp
aarch64

--
int
main(int argc, char *argv)
{
#if !defined(__aarch64__)
    printf("other\n");
#else
    printf("aarch64\n");
#endif
}
--

Submitted package to PPA again.

Thanks for the feedback @dannf