Ubuntu
qemu package

Code review comment for ~rafaeldtinoco/ubuntu/+source/qemu:lp1805256-bionic-refix

  1. Git
  2. lp:~rafaeldtinoco/ubuntu/+source/qemu
  3. lp1805256-bionic-refix
  4. Merge into ubuntu/bionic-devel
Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

Okay, from all ideas I had.. this one is the less intrusive, most easy to manage and one without introducing anything that QEMU has not already have.

#ifndef TARGET_ARM

depends on me removing the gcc poisoning for "TARGET_ARM" definition. QEMU poisons TARGET_ARM just to make sure that there aren't any other pars in machine independent code taking decisions based on the target architecture. Our case was exactly that.. to take a decision based on target architecture inside the mach-independent code (AIO)..

I'm now sending this to the PPA to be tested for build and executions. Dan Frazier provided a good feedback on this change for the original case.

Thanks for reviewing/testing this o/

« Back to merge proposal