Code review comment for ~rafaeldtinoco/ubuntu/+source/qemu:lp1828495-disco-devel-qemu

On Mon, Aug 05, 2019 at 01:12:29AM -0000, Nish Aravamudan wrote:
> On Mon, Jul 1, 2019, 02:46 Christian Ehrhardt  <
> <email address hidden>> wrote:
>
> > Review: Approve
> >
> > @Bryce - yes the position of dep3 is (AFAIK) only style; e.g. I usually
> > add them along the tags upstream has between signoff and the diffstat.
> >
>
> FYI `dep3changelog` while not a policy file may imply that putting headers
> anywhere is not supported by all tools. I'm curious what it does in this
> case.

Looking at its source code, it expects to see Description|Subject and
Origin|Author|From somewhere between the top of the file and the --- cut
line but doesn't seem to care where or in what order.

(Personally, I remain unconvinced that it's better to interleave the
DEP3 headers rather than keep them above and separate from the upstream
patch, however all the patches I've seen so far that have DEP3 headers
are interleaving them, so there's at least a consistency value in doing
similarly.)

Bryce