Code review comment for ~rafaeldtinoco/ubuntu/+source/qemu:lp1828495-disco-devel-qemu

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

@Bryce - yes the position of dep3 is (AFAIK) only style; e.g. I usually add them along the tags upstream has between signoff and the diffstat.

@Rafael - this LGTM it is the long list we had in Bionic reduced to what still applies to Disco.
I found no special case that would affect this being different in 3.1.

Ready to also create cosmic then - OTOH thinking again this one is so huge and testing will surely take a while. Cosmic is EOL in mid July, so maybe we don't even consider cosmic on this - what is your opinion about that?

review: Approve

« Back to merge proposal