Code review comment for ~rafaeldtinoco/ubuntu/+source/pacemaker:lp1864116-focal

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Changelog:
- [√] old content matches pkg/import/2.0.1-5ubuntu5
- [√] changelog entry correct version and targeted codename
- [x] changelog entries correct
  Missing:
  - d/control: Demote fence-agents to Suggests, avoiding main inclusion
  Optional:
  your style on non-active LP references differs e.g. LP: 1828228 vs LP #1862947
- [√] update-maintainer has been run

Actual changes:
- [√] no major upstream changes to consider
- [√] no further upstream version to consider
- [√] debian changes look safe

Old Delta:
- [√] dropped changes are ok to be dropped
- [√] nothing else to drop

New Delta:
- [√] no new patches added

Build/Test:
- [√] build is ok
- [√] verified PPA package installs/uninstalls

Puh plenty of changes in d/control bumping versions and packages.
I think I have read all of them and none needs a breaks/replaces - hope I didn't miss one.
libtransitioner25 had only internal dependencies, so it is ok to go away.

+1, but I've not seen autopkgtests yet, so if you can run them before doing the upload

review: Approve

« Back to merge proposal